Otherwise, post a message to the PR saying that the commits must
be squashed into one.
Updates: golang/go#18517
Change-Id: I800ef7283224cae81bc04ba6d395585c412d3fbd
Reviewed-on: https://go-review.googlesource.com/81116
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also clean up some redundant comments, move trybots from OpenBSD
6.0 to 6.2, and add some missing MaxAtOnce caps.
Updates golang/go#20852
Change-Id: I3d862ca7a7172952ec2254b583e4bf6102b026e6
Reviewed-on: https://go-review.googlesource.com/80876
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Due to maintner’s async nature, there is a period of time where
a Gerrit change may exist for a Pull Request but it is not reflected
in the corpus. Account for this by keeping an in-memory map of PRs
with stale data, and query Gerrit (should that map be incorrect due
to a restart) before creating a new change.
Update: golang/go#18517
Change-Id: Ife142697b15269caca088c3616c4acd4b227bfeb
Reviewed-on: https://go-review.googlesource.com/80840
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We had a bunch running for weeks and months with no "delete-at" field.
I'm not sure why. Perhaps related to gomote instances.
I need to debug that more and dig into git history, but for now clean
them up.
Change-Id: I7bde12357fbe2daa5f75d62e720b94028a0be6b5
Reviewed-on: https://go-review.googlesource.com/80655
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Currently the Dockerfile fails to build because maintner calls
github.Issue.IsPullRequest(), which was only added recently.
I'm not sure if we only want to update one dep (or if there is a way
to) or update all of them but this updates all of them.
Change-Id: I224074770512acfffbe18c8860a6361a5e78b2ff
Reviewed-on: https://go-review.googlesource.com/80475
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Use /boot/loader.conf from the official FreeBSD GCE image.
Add /sbin to the PATH environment variable buildlet is running with,
so that poweroff and shutdown are found.
Fixesgolang/go#22894
Updates golang/go#22895
Change-Id: I2f8b56ff7df4726e4f8ef72357934f2f7abb8e59
Reviewed-on: https://go-review.googlesource.com/80335
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
"go vet" now runs when the tests run, and errors on this test.
Change-Id: I239f23f51477530e4bda19793979e519fa371cdf
Reviewed-on: https://go-review.googlesource.com/80302
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Release on FreeBSD 11.1 now, not 11.0.
Change-Id: Idfa5b51796513a613d4a3a3cafa817cb6b1999a8
Reviewed-on: https://go-review.googlesource.com/80303
Reviewed-by: Andrew Bonventre <andybons@golang.org>
This change will look for PRs that have no associated Gerrit
Change and attempt to import them.
Update golang/go#18517
Change-Id: I612759ca93809ebfb253d7f6c0f8bb47b44d6865
Reviewed-on: https://go-review.googlesource.com/79196
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We want them in our host keys, but GCE doesn't accept them, so
normalize them to dashes.
Fixesgolang/go#22905
Change-Id: I1136eea50483db0adccc289f0f133ab3b0458cb7
Reviewed-on: https://go-review.googlesource.com/80299
Reviewed-by: Andrew Bonventre <andybons@golang.org>
freebsd.org says that the current supported releases are:
> Production: 11.1, 11.0, 10.4, 10.3
Previously we had builders for 9.3, 10.1, and 11.0.
We'll keep FreeBSD 9.3 for now (as it's still supported by the last
two released Go versions), but we'll stop testing FreeBSD 9.3 at tip
shortly here (that will be a separate change).
This CL updates our builders from 11.0 to 11.1 and 10.1 to 10.3,
spanning the range from the old to newest supported release. We'll
stop testing 10.4 and 11.0, as that's a bit overkill.
Another reason we're doing 10.3 instead of 10.4 is because the Go 1.9
release notes (https://golang.org/doc/go1.9#freebsd) said that future
Go releases (Go 1.10) will require FreeBSD 10.3+, so we need to test
FreeBSD 10.3, being the oldest. (Go has historically "supported"
FreeBSD releases a bit longer than they're officially supported by
FreeBSD, partly due to our out-of-sync release cycles.)
Fixesgolang/go#19303Fixesgolang/go#22854
Change-Id: I69589000b1c87aecf054857f514cc48ccedf752f
Reviewed-on: https://go-review.googlesource.com/80297
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The NetBSD 8 builders had a very low RLIMIT_DATA (even as root).
The builders don't run run.bash, which normally increases the ulimit.
So do it ourselves on start-up. Currently this is only on NetBSD.
Deployed and verified it works now.
Fixesgolang/go#22871
Change-Id: I6ecb38b985ce27f0f29b36b55367eb1729be29c9
Reviewed-on: https://go-review.googlesource.com/79955
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Its image has been rebuilt with latest upstream NetBSD changes.
(See CLs 64750, 77475)
Updates golang/go#20852
Change-Id: I8d68313326ec29a97731d2a79198dfdae5b789a6
Reviewed-on: https://go-review.googlesource.com/79436
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The solaris-amd64-smartosbuildlet builders reuse their filesystem per
build, which means they can leak stuff in /tmp ($TMPDIR) when the
tests themselves leak stuff in temp dirs. (which they shouldn't, but
the build system should also get a fresh state per run).
Instead of fixing these builders to use a fresh environment per run
(which is harder), this fixes the immediate problem and runs each
build/test with $TMPDIR set to a subdirectory of /tmp that is then
cleaned by the buildlet after the run.
Fixesgolang/go#22798
Change-Id: Ideb0960af565bad3d3d05499104799163dcfe214
Reviewed-on: https://go-review.googlesource.com/79137
Reviewed-by: Andrew Bonventre <andybons@golang.org>
It's doing no good being red all the time, especially as nobody is
working on it.
Updates golang/go#22689
Updates golang/go#19938
Change-Id: Icb947878d85e920f24ea458eb0f319844ca5bd60
Reviewed-on: https://go-review.googlesource.com/78575
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
As far as I can tell, the data structure inconsistency check that
panic-failed earlier has been fixed by the last few CLs (the
"finishProcessing" ones). The new tests double check.
Also, fix up Footer to not allocate by changing the requirement of its
argument.
And fix a failing test that was crashing due to its *Gerrit not being
initialized in a non-Gerrit test.
Fixesgolang/go#22753 (already fixed, but now tested)
Change-Id: If09cfad6f69d8b3c97410f3e4c3a2e2281c666a5
Reviewed-on: https://go-review.googlesource.com/78155
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We also need to call finishProcessing (added in golang.org/cl/77690) to whenever
we append to the mutation log.
Otherwise we never finish building data structures needed when
maintner is used in mutation-generation & API server mode.
Fixesgolang/go#22763 again.
Change-Id: I55270cd43f03bee0524df188c589ac01ab8fafda
Reviewed-on: https://go-review.googlesource.com/78540
Reviewed-by: Andrew Bonventre <andybons@golang.org>
A recent CL (golang.org/cl/77690) broke how labelChanges was
incremented. It needs to be renamed and tested, but this gets trybots
working again.
Fixesgolang/go#22763
Change-Id: I068fc66bbde283291191f41acdc436876232e88b
Reviewed-on: https://go-review.googlesource.com/78536
Reviewed-by: Andrew Bonventre <andybons@golang.org>
+ Adds a Footer method to maintner.GerritCL that returns the value
of a git footer with the given name.
+ Iterates through whitelisted GitHub repos and Gerrit projects
looking for changes to update. Handles the case where no update
is required.
Update: golang/go#18517
Change-Id: Id133df6956b7213752059a0b0e84dd76ee8ea620
Reviewed-on: https://go-review.googlesource.com/76374
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The currently pinned github.com/google/go-github does not include
the IsPullRequest field on the Issue struct, which is needed by
maintner.
Change-Id: Id742b09d24064e5ba75b68628840546c226c84f3
Reviewed-on: https://go-review.googlesource.com/77156
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Around Oct 20th, we stopped syncing build stats to BigQuery.
Either the client library was updated around Oct 20th, or the server
changed behavior.
In any case, update the deps (to get a newer version of the bigquery
package) and update the code to work with the new SQL syntax.
This also fixes a bogus loop that was harmless but made the sync
slower than it could've been. (The logic was correct in the nearly
identical span sync later in the file.)
Also adds some TODOs for other log spam I see.
Change-Id: I2aa73084aeb19378bf260839555103fb48eac168
Reviewed-on: https://go-review.googlesource.com/78455
Reviewed-by: Andrew Bonventre <andybons@golang.org>
A previous bug in maintner caused Gerrit ref meta updates occuring in
the mutation log before the git meta hash was added to the log. This
CL handles such entries. We add CLs to a dirty set when we see a ref
update and wait until the end of the mutations to parse the fields out
of the meta commits, at which time the git commits will have appeared
in the log.
Also, don't enumerate over private CLs in ForeachOpenCL, which I
thought was the same bug but turned out to be different.
Fixesgolang/go#22653
Change-Id: I79120f06b13c5e74c7761d04494215bf0da2e53d
Reviewed-on: https://go-review.googlesource.com/77690
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Per policy, we only support & test the past two releases (currently Go
1.8 and Go 1.9).
Change-Id: I3d35d47c9053ffc34a0d175815b7227532579aad
Reviewed-on: https://go-review.googlesource.com/77931
Reviewed-by: Andrew Bonventre <andybons@golang.org>
There's more to do here but it's working well enough to be
very helpful. This is a snapshot of the final version used for
Go 1.8.5 and Go 1.9.2. I intend to keep revising it through
the next few point releases and also the main Go 1.10 release.
Change-Id: I4bdbed7ff92735213ff79bb7c4c983074e681ce4
Reviewed-on: https://go-review.googlesource.com/73333
Reviewed-by: Chris Broadfoot <cbro@golang.org>
This only applies if R=close is on the latest patchset.
Updates golang/go#22620
Change-Id: I097aabba2313936f1d399cdca27b510c06bffdc8
Reviewed-on: https://go-review.googlesource.com/76570
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
aedeploy is now bundled into "gcloud app".
Move it into the README now that it's a one liner.
Change-Id: I9bb0d16e94a062c561922c72cd02b0ee03f2c0c5
Reviewed-on: https://go-review.googlesource.com/76730
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
My e-mail address has changed.
Change-Id: I09b1d82dbf2044ab1cd7791a20e24a3e62bf87d0
Reviewed-on: https://go-review.googlesource.com/75030
Reviewed-by: Ian Lance Taylor <iant@golang.org>
In preparation for posting comments to GitHub and querying the
Gerrit API for the proper ref to download for a change, methods
are added to create these clients.
Update golang/go#18517
Change-Id: If885bc859e553e8018d62f5e0103c33d43568881
Reviewed-on: https://go-review.googlesource.com/72971
Reviewed-by: Sarah Adams <shadams@google.com>
Andrew Bonventre
Brad Fitzpatrick
Kevin Burke
Yuval Pavel Zholkover
Joel Sing
Jess Frazelle
Benny Siegert
Russ Cox
Chris Broadfoot
Alberto Donizetti
Sarah Adams
Michael Munday
Tobias Klauser