The current releaselet descriptions are good, as recently discussed,
leaving just one typo in the macOS version name to fix up to reduce
confusion.
Change-Id: I60d12dcc67c2bfa4842b081b0c0e950faa50a067
Reviewed-on: https://go-review.googlesource.com/c/build/+/452856
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Structured buildlet log output would make this easier,
but this works well enough to enable other tooling,
such as automatic flaky test reporting to GitHub.
Change-Id: I9efea12999d55959cd729f94272e27a8ad7a6571
Reviewed-on: https://go-review.googlesource.com/c/build/+/432399
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This change makes it so that all errors are wrapped and put onto the
error chain. That way, instanceDoesNotExist can consistently identify a
"does not exist" error. This change also removes "statusFromError" which
makes the returned error a little bit less friendly.
Change-Id: I179914bc1f29b5d07868e568d448f37f55f8fad4
Reviewed-on: https://go-review.googlesource.com/c/build/+/451299
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
CL 450315 updated gerritbot to a newer GitHub API client package, where
the optional since parameter is specified as a pointer instead of value.
This gives the caller more control over whether the optional parameter
is sent to GitHub. For better or worse, GitHub doesn't like it when we
ask for all comments since January 1, year 1 UTC. So, stop doing that.
Change-Id: I7593e9a7d03d2f3702549c3dd79ce380f07b73cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/451276
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
This change adds support for groups to puttar and modifies the CLI to
accept a single source argument that can accept any valid input (go
revision, URL, local file, etc.).
Fixesgolang/go#53273.
For golang/go#53956.
Change-Id: I5505f262ea1a3240d26abd5db349285f2449c719
Reviewed-on: https://go-review.googlesource.com/c/build/+/418934
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Simplifies some code.
For golang/go#53956.
Change-Id: Ie5606fd87a45c4a978b2c1a6b3fb33df4f7013d9
Reviewed-on: https://go-review.googlesource.com/c/build/+/418784
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
This flag creates a new group for the newly-created instances.
For golang/go#53956.
Change-Id: Ib65a6391a554dbeb1f6f0e44c286ad5b0d221757
Reviewed-on: https://go-review.googlesource.com/c/build/+/418302
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
We got feedback on the previous security release that we should be more
precise about the timing of the release. This reflects our current goal;
we can consider tightening the window as our automation improves.
Change-Id: Ia5db5b880471b107bf97ca225408b296735fef84
Reviewed-on: https://go-review.googlesource.com/c/build/+/452015
Run-TryBot: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds the concept of gomote groups into the CLI, where the
user may manage one or more gomotes with a shorter set of commands.
The gomote command manages the necessary state for each group. This
change adds the group subcommand which allows for creating and
destroying groups, and also adds global group tracking across all
the other subcommands.
For now, this CL does essentially nothing other than add groups to the
CLI. The groups are effectively non-functional as all subcommands fail
when there's an active group specified. Follow-up CLs will
incrementally enable group support across these subcommands.
For golang/go#53956.
Change-Id: I4d4d7c4f8aebfe8640fd68a9c6f8ec1211693efd
Reviewed-on: https://go-review.googlesource.com/c/build/+/418154
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
When uploading a new patch set to Gerrit, set the Gerrit CL WIP bit
to be the same as the GitHub Pull Request draft bit.
Fixesgolang/go#30244.
Change-Id: I29ce3bc51e0ef2ee8012c0ad2547ff2dd0c56912
GitHub-Last-Rev: 512da4985f
GitHub-Pull-Request: golang/build#47
Reviewed-on: https://go-review.googlesource.com/c/build/+/450315
Reviewed-by: Matt Hickford <matt.hickford@gmail.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Matthew Hickford <hickford@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change removed the known issue from the NetBSD 9.3 builders.
It also promotes 9.3 to be the primary version of NetBSD used in the
build infrastructure.
Updates golang/go#54773
Change-Id: If8b8aa89edb9ed8be564149ea728715b4a7b1085
Reviewed-on: https://go-review.googlesource.com/c/build/+/450715
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
This adds the 9.3 builders created by running the make file and
manually uploading and creating the VM images.
Updates golang/go#54773
Change-Id: I0826b1fea1c486ec7cb34abad539672bddc39bb7
Reviewed-on: https://go-review.googlesource.com/c/build/+/450235
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The FreeBSD riscv64 builder passed all tests after CL432756 merged.
We can drop known issue now.
For golang/go#53466
Change-Id: Ia9f63b2eb780fbb39fbaf684045b7f8b46101a93
Reviewed-on: https://go-review.googlesource.com/c/build/+/443496
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Goutnik <dgoutnik@gmail.com>
Run-TryBot: Meng Zhuo <mzh@golangcn.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
The internal go repository uses special branches for changes to the
golang.org/x repositories, this change adds support for testing them.
Fixesgolang/go#56446
Change-Id: I01adb148f0efd8eab9686dac2defb59ec61e0373
Reviewed-on: https://go-review.googlesource.com/c/build/+/447037
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This builder runs the longtest test with the race detector turned on to
identify races in -short=false tests.
Fixesgolang/go#54630.
Change-Id: I6fabaa43522a4294f3a23e98ae0f436d4cc153d8
Reviewed-on: https://go-review.googlesource.com/c/build/+/449196
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Also, update to the latest tag rather than one from 2019. This is in
preparation for changing the host config to use a specific image tag
instead of baking the image tag into every docker image.
This change will allow us to keep a separate 'cloudbuild' tag from the
tag used for the main bulder. This tag can be updated weekly, allowing
us to run a second builder in parallel to determine when we want to
update to a newer image.
For golang/go#56673
Change-Id: I906a95b447949deba0b108b3009c440aa5c31171
Reviewed-on: https://go-review.googlesource.com/c/build/+/449037
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Jenny Rakoczy <jenny@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
This is simpler: rather than manually selecting a host to launch on, AWS
just picks any matching host.
For golang/go#55355.
Change-Id: Iede85ad69530dd31faf8ebed43710328ffaf9c00
Reviewed-on: https://go-review.googlesource.com/c/build/+/449195
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Tagging has now run to completion and I'm comfortable turning it loose.
Remove the approval requirement and send CLs to specified reviewers so
that it can be run as a scheduled workflow.
For golang/go#48523.
Change-Id: I2411a2680b09f877b8f4e5905ed51ae2e9ef2bdd
Reviewed-on: https://go-review.googlesource.com/c/build/+/449038
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
The perf builder is broken on the tools repo. Add a KI for it.
Updates golang/go#53538.
Change-Id: I31873ac336a7fe681a2e1356768fd011ebcfe2b9
Reviewed-on: https://go-review.googlesource.com/c/build/+/449036
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
This avoids needing to execute a subprocess for diff,
and it gives more control over the header, so that the
output can say `diff want have`.
Update the tests using the old internal/diff for the new API.
Ran go get golang.org/x/tools@latest && go mod tidy
to add the x/tools dependency for the test's use of txtar.
Looks like x/tools was already in the indirect dep graph at v0.1.12,
but pruned modules graphs meant that its dependencies
hadn't propagated up, so leaving it at v0.1.12 would have
caused other deps changes too (like moving goldmark up to v1.4.13).
It seemed clearer, if we will get churn either way, to bump
x/tools to its most recent tag.
Change-Id: Iabfb692c7916a6bde316d5caf81de052f147e54e
Reviewed-on: https://go-review.googlesource.com/c/build/+/432398
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
CL 429275 and CL 429536 have hidden partially-written files from the
release test. I think a remaining race was that uploadArtifacts only
waits for the main artifact file, and uploadArtifact copies that one
first. So it was possible for fakeCDNLoad to periodically copy all the
main files but not yet one of the .sha256 files, and the test release
workflow would complete too early, before fakeCDNLoad finished its work.
This race is very unlikely to happen in production since everything
else takes longer. Still, we consider the .sha256 metadata file as
non-optional, so modify uploadArtifacts to wait for all files to be
made available before considering its job as done.
Fixesgolang/go#55178. (Third time's the charm, right?)
Updates golang/go#53972.
Change-Id: Id470da1fb94ba91b292c63a53e34705b30ba8d66
Reviewed-on: https://go-review.googlesource.com/c/build/+/448135
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
Add a new task in addSingleReleaseWorkflow that creates the stdlib regeneration CL for each Go release using func CreateUpdateStdlibIndexCL in VersionTasks.
CreateUpdateStdlibIndexCL fetches the latest go binaries, downloads the latest version of tools repo, and submit a CL whose diff is created by regenerating stdlib with `go generate ./internal/imports`.
For golang/go#54377.
Change-Id: I3d95a88def984dd677d49f38587bed298b3aeaea
Reviewed-on: https://go-review.googlesource.com/c/build/+/442157
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Dylan Le <dungtuanle@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
The packages are taken from the 2022Q2 branch. These are built for
the 9.0 release, as is usual upstream, but all 9.x releases are binary
compatible.
There are a few other refactorings in this CL to make future maintenance
simpler.
Update golang/go#54773
Change-Id: I38a8eab1aabd9985771ac83da2e435e490b7e4b4
Reviewed-on: https://go-review.googlesource.com/c/build/+/428415
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Dmitri Shuralyov
Russ Cox
Michael Anthony Knyszek
Heschi Kreinick
M Hickford
Carlos Amedee
Meng Zhuo
Roland Shoemaker
Alex Rakoczy
Michael Pratt
Dung Le
Benny Siegert