- Use the stdlib log package, to distinguish seeddb logs from pkgsite
logs.
- Log events as they happen, instead of at the end.
Change-Id: Ia3877e821def72d89144ad50d2b6706bb531eb1c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/626857
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Add a paragraph to deal with a condition that I have encountered
on my machine.
Change-Id: Ie03a0e8ab4030973cdec8e84cd5877234830b8de
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/626856
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
- Use single-hyphen flags to conform to Go style.
- Remove unnecessary quotation.
- Minor shell style nits.
- Change the "local" case to run all components, instead of assuming
that some are already running.
The last change makes the "local" case much more useful, and faster
than the "ci" case for local testing.
Change-Id: Id3412fac8bd4a29539563e3cc568a3c7edd06c2e
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/626855
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The screentest binary (golang.org/x/website/cmd/screentest) was
recently updated to use a new version of chromedp, the package that
talks to chrome in order to obtain screenshots. The new version
produces slightly different screenshots. We will eventually deal
with this when the screentest changes are finished, but for now
use an older screentest version.
Change-Id: I197501241a823f7c7ee03fab9c7312f89949af9a
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/627535
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Double the maximum allowed size of rendered documentation.
Increase the maximum file size as well.
Also, add information about the documentation size to logs and error
messages, so we can see the amount by which the limit was exceeded
next time.
For golang/go#40576.
Change-Id: Ia2aa11915d583e8e0c5ca0e273202a57679bd5f7
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/622556
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cody Oss <codyoss@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Remove modules that don't matter from the list of modules used
to seed the database in ci mode.
Also combine two identical tests.
Change-Id: I979ed07ce1f3bdf0fa164e46643cffefcdce45e3
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/626003
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
This will be useful for https://go.dev/cl/620739 --
https://go.dev/cl/413680 (the CL that disabled it) says it was failing
on the CI, maybe we'll have better luck this time?
I'd like to enable it here so cl/620739 can capture the diff.
Change-Id: Id0000000c68af80d5194e955e0df7df59f58f29d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/624475
Run-TryBot: Jonathan Amsterdam <jba@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Add a GET method to the patterns for most frontend routes.
We omitted a few where we're not totally clear on what the client
may be sending.
Change-Id: I3f300b7d3753fd4009a60855c7a15b24c5e27dd6
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/616395
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Current logic for detecting "concluding line comment" is not strict
enough that it may cause false-positive, causing some normal comment
(and code following it) to be discarded in the rendered web page.
Ensure that "concluding line comment" can only be prefixed by spaces.
Also add corresponding test case.
Fixesgolang/go#65450
Change-Id: Ief9ec5326aa94965ca02d3278398cc5663ba395f
GitHub-Last-Rev: 7312ff3dff
GitHub-Pull-Request: golang/pkgsite#93
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/600415
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
This CL takes an alternative approach to generate unique headings.
It builds on the work of https://go.dev/cl/573595,
which was a fix for https://go.dev/issue/64582.
- It takes a more direct approach to constructing a unique string
from an ast.Decl.
- The function that does that is tested separately, reducing
the test cases needed for formatDocHTML.
- It saves the generated headings, so the HTML doesn't have to
be reparsed.
NOTE: This will break all links to headings that are not in the package
comment. Happily, such headings are rare: only 40 of the top thousand
packages have one. It might seem we could avoid any breakage by only
applying a suffix to duplicate headings. But then at any time
in the future, a unique heading could become a duplicate, causing
a break. Better one break now than an unending stream of them.
Change-Id: I379712b54c6bc9c6a9343d0006639085a40e23d9
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/608035
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
This CL addresses the errors found by staticcheck when we upgraded
to Go 1.23. All were deprecation warnings, and they were silenced
by "ignore" directives until we could deal with them.
In all cases, ignore the lint message was the right choice.
The CL adds justifications.
Change-Id: I09d4bb96cb9913f8e35189ed3a4af9deaa092447
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/610801
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
For golang/go#69267.
Change-Id: I050c167e2e3ce36541e0d71469fb3f5778f5a882
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/610517
Reviewed-by: Ian Lance Taylor <iant@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
When inserting the paths of a module into the paths table, we were
inserting all the package paths and the v1 module path (the module path
without "/vN" suffix). That is almost always sufficient. But if a module
has a version suffix and is not itself a package, then we were not
inserting its path. The module path is needed by insertSymbols, so this
was causing that function to fail.
Add the module path, refactor the code to simplify it and allow testing,
and add a test.
(For a vN module the code also adds the v1 package path for every
package. I think this is unnecessary, but it's too risky to remove
it.)
Change-Id: I8caa3dd945692a4ec0a1128199237de6b77aa719
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/609117
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Replace some functions with simpler code that uses
recent functions added to the standard library.
Change-Id: Ifcd570679a897fb165a4307c7ce9f0f53fccea05
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/609116
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
The go.mod major version now matches what we use for Dockerfiles.
The version of staticcheck that works with Go 1.23 revealed several
uses of deprecated functions. Some of these were easy to change,
but other require more care and will be addressed in some later CLs.
Change-Id: I7f8344e419b8be6351d51db90faa64cef04057a0
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/609142
Reviewed-by: Robert Findley <rfindley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
- Fix npm vulns.
- Fix the minimized-css check to look only at the working dir.
Change-Id: Iecf2c5ef35813fef16df22147f795cda814fef2b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/608037
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
This reverts commit a224e846c9.
Reason for revert: breaks the UI (#68538)
Fixes#68538.
Change-Id: I23a6acaf741e7cb863c304363ee9b7a4fdf0bbe2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/608036
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Limit the number of goroutines that are fetching modules at once,
to reduce the chance of transactions timing out. We've been noticing
kokoro failures due to that recently.
I chose a limit of 10 arbitrarily. We'll see if it helps.
I tried testing locally, but I don't get the same behavior as on
kokoro.
Also, use an errgroup with a context to clean up seeddb failures faster.
Also, remove the seeddb flag permanently.
Change-Id: Ib0244c76572c9f9e34064f99a05b26d70cc55aea
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/607755
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Move most of the cases of the formatDocHTML test to txtar files.
They were too hard to read.
The remaining cases have to do with passing an ast.Decl.
We may move them later or we may try a different approach
to generating unique heading IDs, which is the purpose of passing
in the decl.
Change-Id: I99c71ed1f04b469cb540ff72a31a39eb6cbb1050
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/607616
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Also change renderInfo's first return value to template.FuncMap
for clarity.
Change-Id: I2ad2906d260d405225d54723401276e419545ecc
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/607418
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
The existing implementation takes a simple approach of using the heading
text and replacing non-safe characters. This leads to potential duplicate
heading ids, so use a map to keep track of used heading ids and generate
unique ids with various strategies until a unique id is generated.
Fixesgolang/go#64582
Change-Id: I95f823c3782411454cff7353b49d90fab5799a45
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/573595
TryBot-Result: Gopher Robot <gobot@golang.org>
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
The existing implementation rewinds lastOffset when indents are replaced
because lastOffset is calculated against the modified literal. lastOffset
acts as a file pointer against the source so calculate offset against the
source literal before stripping indents.
Fixesgolang/go#56762
Change-Id: I86fcef9eb24742e707b4a723a9767baac5433b9c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/586099
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Commit-Queue: Jonathan Amsterdam <jba@google.com>
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Upgrade to use go 1.23 images in various files that
specify docker containers to run.
Change-Id: I6331a07c4d0f00dc7513a5286d315dd0f64cd362
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/606778
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Currently, links in Readmes are invisible when in the header of
a details element. A similar rule exists for the paragraph symbol, but
is overwritten by the following block.
Remove instructions that make links in summary invisible and remove
inactive rule for h2 elements.
Fixesgolang/go#68132
Change-Id: Ia94563e855850beaa7ca10631a4ee23ef3add955
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/595055
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
The value of the gorepo flag variable was being used before flags were
parsed. Fix that.
Also fix a couple of other issues that came up in golang/go#68533:
First, don't print "searching GOPATH" when we're not searching GOPATH.
Second, print the stderr from the go command in the error when it fails
because it's the stderr that usually provides information about the
failure, not the stdout.
For golang/go#68533
Change-Id: Ic6321d6e071dd82415474f2a2c54146e9eabbef7
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/600917
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Auto-Submit: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Very minor tweaks:
- Remove (c) pseudosymbol.
- Remove "All Rights Reserved."
- Change "Google Inc." (no longer exists) to "Google LLC".
[git-generate]
echo '
,s/\(c\) //
,s/ All rights reserved.//
,s/Google Inc./Google LLC/
w
q
' | sam -d LICENSE
Change-Id: I6bf8e66dd0355bc2c6c03e5031ebdf33d3f8954a
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/598524
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Bypass: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
On vulnerability entry pages, display "custom versions" (and a note
explainining them) if there are any "custom_ranges" published in the OSV.
(Once this is live, we will remove the disclaimer from the OSV details
since this will be redundant.)
Change-Id: I20c3b08ecb3f36ce0334553eef0dacd0fe57480b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/597616
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Instead of displaying a chip for each vulnerability affecting
a module version, display a chip for the first vuln, followed
by a chip with the text "+N more" (if applicable).
Screentests aren't available for the versions and search tabs,
but a screenshot of how this looks is at
https://github.com/golang/go/issues/68347.
For golang/go#68347
Change-Id: Ie19ce8e846b5ef3c3e2dc74a9415a7b908c93194
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/597176
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
When a module is affected by many vulnerabilities, the current
display can become overwhelming because details are listed for
each vuln.
If there are 2 or more vulns, condense the the message to
"Affected by GO-XXXX-YYYY and N other vulnerabilities",
with the option to click a button and see all the vulns.
Change-Id: I5e4e6712aa6038d390ed70b339a982f7684a986f
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/595561
kokoro-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
For UNREVIEWED reports, display the word "Unreviewed" under the title,
and add a blurb to the feedback section explaining its meaning.
Currently, don't display anything special for a REVIEWED report. This is the
default.
Change-Id: I43ad7c324f6712a22a035c4aac725808cd50e7c3
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/586101
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Update the script that pulls in the latest vulns to include
an UNREVIEWED report. Run the script to update the test corpus to
bring in this new vuln, plus the review_status for all vulns.
Update the screentests accordingly.
Change-Id: I45aa815ac9a33d186bac196220cce169b8523dae
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/586100
kokoro-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Add a check that the minified css files correspond to the their sources.
Previously, the all.bash script generated the minified files and left
the modified files in the repo working copy. This may have helped during
development, but during CI it should be a no-op. This CL simply verifies
that. The developer can still run `devtools/cmd/static` manually.
A check like this should be standard procedure for all binary or
incrutable files that appear in CLs.
Change-Id: I47d34e5204637ff38113b91ff46c595b9f42f4ee
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/585476
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Change-Id: I2568aa885085a1820f4cffedecf0d737affd7da9
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/585475
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
The existing h4 selector for function and type sections was including
comment headings breaking layout for the pilcrow link. Narrow down
these h4 selectors since flexbox is only required for "since version"
layout.
Fixesgolang/go#66458
Change-Id: Ibebaebb958c0abd777e52dda252eeddc22794bb6
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/574719
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Ensure main page content is readable at 320 CSS pixels without the need
for horizontal scrolling. This is important for documentation users that
may require zoom functionality in order to read content. WCAG 2.2
defines 320 pixels as the minimum width reasonably achieveable by site
authors.
See https://www.w3.org/WAI/WCAG22/Understanding/reflow.html.
Fixes#66996.
Change-Id: Ic3d02bffac23798bcd86d28560845fa91ce831db
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/581236
Reviewed-by: Jonathan Amsterdam <jba@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Findley <rfindley@google.com>
Fix a bug in which the first two credits of a vuln report
were displayed with no separation.
Change-Id: I1f42268d8d6e03341e8e1b5db09d16beb7188f8f
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/581180
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>