Document field access limitations for type parameters.
Also, remove some superfluous "currently" uses - the
time context is clear from the introductory paragraph
of the respective section.
For golang/go#51576.
For golang/go#47694.
Change-Id: If4c12f95f024894a9efb949dda9341d8ab0dc77e
Reviewed-on: https://go-review.googlesource.com/c/website/+/391279
Reviewed-by: DO NOT USE <iant@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
Added dark mode styles and images.
For golang/go#34601
Change-Id: I1a4d9599cbe8e3b51380be914cfe1abbc3cd79bb
Reviewed-on: https://go-review.googlesource.com/c/website/+/384874
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
Go 1.18 is now expected to be released in March 2022.
For golang/go#44513.
Fixesgolang/go#51505.
Change-Id: I4f744dc96c6ef5150d7475b51759d5fc5b13633b
Reviewed-on: https://go-review.googlesource.com/c/website/+/390374
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: DO NOT USE <iant@google.com>
Based on CL 366955 originally by Timothy Gu.
For golang/go#46001
For golang/go#47694
Change-Id: Ide7711680d651c4cbbb6da13ab33b67cf5e26758
Reviewed-on: https://go-review.googlesource.com/c/website/+/389955
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Trust: DO NOT USE <iant@google.com>
Copied from Go commit 2cb9e116d39176bd8a93609c63b175ac09eacea9 CL 388454.
Deleted there in CL 388515.
Updates golang/go#47694
Change-Id: I5f26ce2fc6ec96c5902dbe5838689fd139bcd0e5
Reviewed-on: https://go-review.googlesource.com/c/website/+/388556
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <amedee@google.com>
One test case added in CL 388016 depends on production resources,
specifically the snippet https://play.golang.org/p/MAohLsrz7JQ.go
served by the production instance of the Go playground.
This would be caught by TryBots where internet access is disabled,
but that didn't happen due to golang/go#51444.
Updates golang/go#51181.
Fixesgolang/go#51439.
Change-Id: I4f1c5ea1a6ccad9ae4e5cbb749e3dee0b26731b5
Reviewed-on: https://go-review.googlesource.com/c/website/+/389394
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
The race detector doc doesn't state cgo,
the content is basically as ALTree suggested in issue 51235.
Fixesgolang/go#51235
Change-Id: I03356c01f4542e69a02c712063afb77ae68cc90f
Reviewed-on: https://go-review.googlesource.com/c/website/+/386454
Reviewed-by: DO NOT USE <iant@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
"Add three rows with values" should be "Add four rows with values".
Change-Id: I82103908292faf95c1b6c62ca57d6f47b0249ccb
GitHub-Last-Rev: 2a02403727
GitHub-Pull-Request: golang/website#126
Reviewed-on: https://go-review.googlesource.com/c/website/+/385594
Reviewed-by: DO NOT USE <iant@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
The screentests for the download and install will
always fail because cmd/golangorg uses different
sources for data to render those pages on app engine.
Change-Id: I2ca67ba1bc0a830baa6fe1be1f1cd8b8f63ac9c5
Reviewed-on: https://go-review.googlesource.com/c/website/+/385915
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
URL fragments are dropped from request targets. Stripping
the fragment from the URL ensures we capture the response
status.
Change-Id: I66ed67a23878315076762e4f99332613a4f67723
Reviewed-on: https://go-review.googlesource.com/c/website/+/385201
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
Requests to URLs are expected to return HTTP Status 200.
To override the expected status code, testcases can use
the status keyword.
Change-Id: Ibe6696fc2fe2a779755ff96dc8c5532c1ce03c66
Reviewed-on: https://go-review.googlesource.com/c/website/+/384840
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Adds a page to the fuzzing docs which contains a technical description
of the fuzzing implementation.
Change-Id: I9415548b91e56ad836932da1e61921cbb8086faf
Reviewed-on: https://go-review.googlesource.com/c/website/+/379594
Reviewed-by: DO NOT USE <katiehockman@google.com>
Trust: DO NOT USE <katiehockman@google.com>
Trust: Roland Shoemaker <bracewell@google.com>
Run-TryBot: Roland Shoemaker <bracewell@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This avoids importing the constraints package, which is no longer in
the standard library.
For golang/go#50792
Change-Id: I0e0f48d414e87418a1fe95e500bb7629127007cc
Reviewed-on: https://go-review.googlesource.com/c/website/+/383254
Reviewed-by: Eli Bendersky <eliben@golang.org>
Reviewed-by: Eli Bendersky <eliben@google.com>
Trust: DO NOT USE <iant@google.com>
Run-TryBot: DO NOT USE <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Updates golang/go#51032
Change-Id: Iec7965f8d2823e7918967e0fae8425e0b1cc615e
Reviewed-on: https://go-review.googlesource.com/c/website/+/383454
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <bracewell@google.com>
Trust: DO NOT USE <katiehockman@google.com>
Run-TryBot: DO NOT USE <katiehockman@google.com>
The original motivation to add hostnames to the files
was to make them easier to identify. Now that the origins
can be dynamically set with template variables, it causes
more trouble than it helps.
After removing the extensions, we can support reusing a
single test script for multiple origins. For example:
compare {{.Origin}}::cache {{.Origin}}
Origin may be set to https://staging-pkg.go.dev or
http://localhost:8080 and share the same set of screenshots.
Change-Id: I2c1811fcb0fa7cca9e3b5feeb362528fd3f07af4
Reviewed-on: https://go-review.googlesource.com/c/website/+/382157
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
Add entries for go.work files and the new go work commands to
golang.org/ref/mod.
For golang/go#45713
Change-Id: I1ad3335f977fad864d75790e31e48ee34e531ff5
Reviewed-on: https://go-review.googlesource.com/c/website/+/379655
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Michael Matloob <michaelmatloob@gmail.com>
Explain that Effective Go is not a living document.
No changes other than one new paragraph in the
introduction.
Fixesgolang/go#49937
Update golang/go#28782
Change-Id: I615e48df56313e3d91e8b88b139159f64900db7e
Reviewed-on: https://go-review.googlesource.com/c/website/+/380634
Reviewed-by: DO NOT USE <iant@google.com>
Trust: Michael Knyszek <mknyszek@google.com>
Scripts can use the block keyword to set URL patterns to block.
Wildcards ('*') are allowed.
While loading a webpage if chrome attempts to load a resource
from a blocked URL the request will fail. This is useful for
blocking things like dynamic badge images from a code coverage
or build indicator service.
Change-Id: Ifbde82d56918928333836b493e993c1ef1054a76
Reviewed-on: https://go-review.googlesource.com/c/website/+/381335
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
Run-TryBot: Jamal Carvalho <jamalcarvalho@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Also some minor text and formatting updates.
Change-Id: I0716d6714e9558ac744d9929adaa0a92b63e36e3
Reviewed-on: https://go-review.googlesource.com/c/website/+/380574
Reviewed-by: Robert Griesemer <gri@google.com>
Trust: DO NOT USE <iant@google.com>
There were a couple of minor things that were slightly wrong due to
changes in the libraries, and the addition of generics makes the meaning
of an interface worth clarifying.
Add an introductory paragraph about generics, and adjust a few
sentences.
No substantive change.
Fixesgolang/go#49939
Change-Id: I67fbd28f1a9876158006202bf03ea693265c5cd5
Reviewed-on: https://go-review.googlesource.com/c/website/+/380276
Reviewed-by: DO NOT USE <iant@google.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Michael Knyszek <mknyszek@google.com>
main.go modified to import unicode/utf8 and errors packages, discard
returned error. Steps added to import packages and make changes in final steps.
Fixesgolang/go#50628
Change-Id: I5dd5fb66256d56eb81bdbb16ba2d5a3fc1ee5dd4
Reviewed-on: https://go-review.googlesource.com/c/website/+/378477
Trust: Julie Qiu <julieqiu@google.com>
Trust: DO NOT USE <katiehockman@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
Reviewed-by: DO NOT USE <katiehockman@google.com>
With no "presentStyle" template defined, the template function with
the same name (defined in the internal/web package) starts to be used
in its place. Unlike the no-op wrapper template, the template function
correctly processes some of the legacy present syntax.
Fixesgolang/go#50664.
Change-Id: I8a673e511b326f5c4f8a3a2666a2d1e65b5995ce
Reviewed-on: https://go-review.googlesource.com/c/website/+/379035
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
When include=all is used, archived versions (old) and unstable versions
(new) are appended to the list of returned versions. This makes the
order of the list rather awkward: current, old, new. This commit makes
the ordering a bit more natural: new, current, old. However, even like
that, releases will be out of order, because, for example, 1.18rc1 is
new, while 1.17.6 is current, but 1.18beta1 is old. So, this commit
takes care to sort the entire list properly to avoid that. This way, the
entire list is sorted by version. Nothing changes semantically, as users
of the API can still filter out unstable releases using the "stable:
true" field.
This commit also adds a test case, to make sure this behavior doesn't
regress.
Fixesgolang/go#50201.
Fixesgolang/go#47367.
Change-Id: Ic136197dcdd47aa149601b75ba5152a2006c790a
Reviewed-on: https://go-review.googlesource.com/c/website/+/371934
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Jason Donenfeld <Jason@zx2c4.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
Added a stylesheet insertion step that reduces
motion on web pages by speeding up animations
and removing animation delays.
Change-Id: If945f764dfafaebfedce87fa462c5824033808e2
Reviewed-on: https://go-review.googlesource.com/c/website/+/379134
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
The screenshot file extensions are updated such that
when the hostname of the origins for a testcase are
equal, for example when comparing cached screenshots
to live screenshots from the same server, the output
filenames do not collide.
Change-Id: I0b82f94d87912923e734fc30ba457a440ede94f4
Reviewed-on: https://go-review.googlesource.com/c/website/+/378476
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
Change-Id: I9c8099270a1215bd5b5c3043d2bcc5d097a3dc95
Reviewed-on: https://go-review.googlesource.com/c/website/+/378598
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: DO NOT USE <iant@google.com>
Trust: DO NOT USE <katiehockman@google.com>
The site is served at both go.dev and golang.google.cn.
In China, only golang.google.cn can serve, so we try to use
relative links to avoid pointing users to the copy they can't access.
Periodically we have to remove prefixes that have crept in.
This commit applies today's round of that.
Change-Id: Iaa169635664d0562a1cccc57c3e02b687b3493e7
Reviewed-on: https://go-review.googlesource.com/c/website/+/378597
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: DO NOT USE <katiehockman@google.com>
Trust: DO NOT USE <katiehockman@google.com>
To have test runs output consistent screenshots across
different systems we allow for the use of a remote
instance of Chrome by providing a url to its debugger
as a flag. For example:
go run ./cmd/screentest -d ws://localhost:9222
This is useful in a CI/CD environment to control the
chrome version and OS in which screenshots are taken.
Change-Id: I09b2e2d8e3056d7229808a57653d641677fc8cc3
Reviewed-on: https://go-review.googlesource.com/c/website/+/378475
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
Jamal Carvalho
Robert Griesemer
Mauricio Alvarado
Dmitri Shuralyov
Sean Liao
able.lv
Ian Lance Taylor
Carlos Amedee
Michael Matloob
Julie Qiu
cuishuang
Meng Zhuo
Chia-Chi Hsu
Cherry Mui
Roland Shoemaker
jiahua wang
Katie Hockman
Andrey
Eli Bendersky
Russ Cox
Rob Pike
Beth Brown
Jason A. Donenfeld