* OT form visible to Chromium and Google users
* Allow Google/Chromium users to request server-side
* conditionally handle redirect
* ot requests available for Chromium/Google users
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* Add `ot_feedback_submission_url` to ot creation
* ot button only shows on ot stage details
* Update chromedash-feature-detail.js
* fix OT button
* cancel button returns to feature detail
* add ot milestone fields
* Update chromedash-feature-detail.js
* Squashed commit of the following:
commit 142f605e74
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 20 15:06:53 2023 -0700
Update chromedash-feature-detail.js
commit 83c98ea8a9
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 20 15:00:01 2023 -0700
add ot milestone fields
commit b50933fcb6
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 09:18:46 2023 -0700
cancel button returns to feature detail
commit 9047830f20
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 09:02:06 2023 -0700
fix OT button
commit b442dfd495
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 08:49:21 2023 -0700
Update chromedash-feature-detail.js
commit e78ed6bab1
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 08:44:07 2023 -0700
ot button only shows on ot stage details
commit a2d8df8047
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Fri Sep 15 16:04:52 2023 -0700
Add `ot_feedback_submission_url` to ot creation
commit cb0b1e621f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Fri Sep 15 14:16:22 2023 -0700
Add basic UI for trial creation request
commit a843707680
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 12:50:19 2023 -0700
remove test line
commit 1b471fad6f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 12:46:44 2023 -0700
`stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
commit cc0308efc7
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 10:53:06 2023 -0700
Add 3 more fields for OT creation
* Add `ot_owner_email` and `ot_display_name` fields
* fix test
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* Add `ot_feedback_submission_url` to ot creation
* ot button only shows on ot stage details
* Update chromedash-feature-detail.js
* fix OT button
* cancel button returns to feature detail
* add ot milestone fields
* Update chromedash-feature-detail.js
* Add action_requested field for creation/extension
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* Add `ot_feedback_submission_url` to ot creation
* ot button only shows on ot stage details
* Update chromedash-feature-detail.js
* fix OT button
* cancel button returns to feature detail
* add ot milestone fields
* Update chromedash-feature-detail.js
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
- Add new query parameter releaseNotesMilestone to the GET /features route
- Ensure all shipping and enterprise features are returned from the milestone specified in releaseNotesMilestone until the latest available feature
- Update front end logic to wait for a channel to be selected before getting the features for the release notes
- Update front end logic to fetch policies each time the target milestone is changed
* Let every review team have a 5-day SLO.
* Update api/converters_test.py
Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
---------
Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
* Add OT API key variable to settings
* fix type hint
* Update settings.py
Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
* fix quotes
* Move api key function to secrets file
* Add key generation command and doc explanation
* remove OT_API_KEY from settings
* update global var
* Save API key in var to remove need to re-obtain
* logging change
* Add endpoint for obtaining origin trials
* Update api/origin_trials_api.py
Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
* Obtain API key from secrets function
* add try/except for list trials request
* remove unneeded if block
* changes suggested by @jrobbins
* Add error handling for malformed OT responses
* remove redundant error logging
* remove unnecessary variable
* Add origin trials client
* changes suggested by @jcscottiii
* update docstring
* Update framework/origin_trials_client.py
Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
* Update framework/origin_trials_client.py
Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
* import logging
* fix test
* capitalization consistency
* docstring fix
---------
Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
* Allow deletion of enterprise features and stages
* Features can now be deleted by their creator
* Enterprise rollout stages can be deleted
* Refactor the edit all page to use the repeat directive so that the right elements are deleted
* Fix archived stages returned and stage not being created when feature has 0 stages in edit all
* Change form fields to use updated names
* use new field name for comments
* keep rename mapping to remove later
* Fix features patch python test
* differentiate stage display name from entity name
* Change form fields to use updated names
* Enable stage edit page to use Features API PATCH
* add new line at EOF
* remove unneeded line
* Add back renamed field mapping
* rename field name property
* Update stale feature links
* Support parse LINK_TYPE_GITHUB_ISSUE
* Support parse LINK_TYPE_GITHUB_MARKDOWN
* Fix mypy complains
* Improve markdown title parse
* Add comments
* Use cloud task to update feature links information
* Delay 10 seconds for second feature links request
* Add TODO
* Fix feature_links edge cases
* Add basic FeatureLinksAPI
* Add feature-link to enhance autolink and normal url in feature detail page
* Add tooltip to enhanceChromeStatusLink, polish styles
* Make featureLinks non blocking request
* Add closedTimestamp in enhanceChromeStatusLink
* Remove placeholder function
* Add back white-space: pre-wrap and fix CSS
* Use gray color badge for closed issue
* Rename fallback and change it to a lit-html object
* Move feature link summary into tooltip
* Support custom text in enhanceUrl
- Modify the "Add stage dialog" to receive a custom submit handler that replaces the default behavior of creating a new stage.
- Modify the edit all page to add a stage on the client only via a custom submit handler that it passes to the "Add stage dialog"
- Modify the form field names of stages added only on the client so that they can be created on submit
- Modify the server so that it creates new stages for the stages that were only created on the client
* Add screenshot links to the enterprise feature creation page
* Make enterprise pages that require sign in use an intermediate component when not signed in and redirect to the initial page when signed in
* Move Rollout steps help text to the edit all page
* Rename "Start feature rollout" to "Rollout Step"
* Rename "Rollout stages" to "Rollout steps"
* Fix editors not showing on the feature details page for all features
* Fix enterprise categories only using the first category chosen after creating a new feature
* progress
* Progress
* progress
* Added tests
* Actually add new test file
* Another test
* Update internals/slo.py
Co-authored-by: Kyle Ju <kyleju@google.com>
---------
Co-authored-by: Kyle Ju <kyleju@google.com>
* Create feature only accepts mutable fields
* Docstring and type hints
* Features API POST writes stages and gates
* rename method
* put_multi for new gates
* rearrange unit tests
Daniel Smith
Jason Robbins
Yann Dago
Ping