Граф коммитов

4352 Коммитов

Автор SHA1 Сообщение Дата
Javier Suárez 5276134af5
[iOS] Fix NavBar issues on iOS 13 (#10493)
* Created repro sample

* Fixed #10337 and #10338

* Update Xamarin.Forms.Platform.iOS/Renderers/NavigationRenderer.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>

* Update NavigationRenderer.cs

Co-authored-by: Rui Marinho <me@ruimarinho.net>
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>

fixes #10337
fixes #10338
2020-05-06 17:38:31 -07:00
Shane Neuville 7938a26460
Remove DualScreen projects from Xamarin.Forms.Sln (#10550)
* Move Dual Screen Project out of Gallery

* - fix sln

* - remove excess

* - restore

* - fix up the props a bit more

* - fix build settings
2020-05-06 12:29:41 +01:00
Gerald Versluis bb6ea96310
Revert #8090 Android scrollbar flashes (#10447)
fixes #9591
fixes #9423
fixes #9019
fixes #8986
2020-04-27 14:33:57 -07:00
Javier Suárez dae0fa3e94
Fix Collection selection using SwipeView (#9638)
* Fix Collection selection using SwipeView

* Move SwipeView IsOpen property to ISwipeViewController

* Added comment to added ViewCellContainer constructor

* Minor changes based on PR feedback

* Updated SwipeView GestureRecognizers samples to cover all the cases

* Modified ItemContentView ClickOn method to be internal

fixes #9467
fixes #8774
fixes #8903
fixes #9089
fixes #9466
fixes #9027
fixes #10056
2020-04-27 14:24:42 -07:00
Javier Suárez cf83872fe2
Added repro sample (#10468) fixes #10438 2020-04-27 17:37:26 +01:00
Shane Neuville 351e0e8c54
Setup Xcode provisioning through variables and switch to channels (#10392)
* Xcode provisioning

* - fix

* - provision channels

* - provision channels on mac only

* - install mono if it's not there

* - add jdk install

* - verbose

* - no mo mono

* - fix?

* - add path

* - set path when provisioning

* - androidsdk

* - build tools

* - cake updates

* - android home path

* - path

* - home

* - remove cake sdk

* - install android sdks if they are missing on CI

* - change top use channel

* - move mac check to mac block

* - add latest for xcode

* - fix null check

* [Build] Fix type

* [Build] Install .netcore

* - adds parameters to install custom packages

* - info and windows

* - env

* - env

* - env

Co-authored-by: Rui Marinho <me@ruimarinho.net>
2020-04-24 23:58:04 +01:00
Shane Neuville 5a96f79252
Add Preserve attributes to all Export attributes (#10371) 2020-04-18 12:44:45 -06:00
Shane Neuville 3d0108ce65
[Android] Fix border clipping calculations (#10336) fixes #10269 2020-04-16 10:35:37 +01:00
Shane Neuville 8d47e7dd4b
[Android] Set native properties from element if layout hasn't occurred (#10319)
* [Android] fix so native properties still set before layout

* - fix slow renderer

fixes #10102
fixes #10290
fixes #10197
2020-04-15 09:38:19 -07:00
Shane Neuville ab7f9fb2cc
Set agent os for all pools (#10211)
* - pipelines

* - pipelines

* - cake

* - demands

* - demands

* - demands

* - stages

* - stages

* - stages

* - stages

* - stages

* - stages

* - stages

* - taba-taba-taba

* - taba-taba-taba

* - less config

* - remove nuget code

* - nuget version

* - xcode check

* - release channel check
2020-04-15 15:36:18 +01:00
Rui Marinho bae4e2ccea
[iOS]Fix dispose of all events on CarouselViewRenderer (#10242)
* [Controls] Add repo for issue #10234

* [iOS] Make sure to unsubscribe Scrolled event on CarouselView

* [Controls] Fix UITest ScrollCarouselViewAfterDispose

fixes #10234
2020-04-08 17:09:24 -07:00
Rui Marinho e76003d8f2
[iOS] Fix CollectionView disposing of Delegator (#10259)
* [Controls] Add repo for issue #10222

* [iOS] Dispose delegator

* [Controls] Fix UITest

fixes #10222
2020-04-08 17:09:04 -07:00
Javier Suárez fb9b768270 Fixed exception in iOS NavigationRenderer getting the parent ViewController (#10255) fixes #10250 2020-04-08 13:21:28 -07:00
Javier Suárez e5496de45a
[iOS] Fix issue in NavBar setting a custom BackgroundImage (#10199)
* Fixed NavBar BackgroundImage issue on iOS 13

* Fixed NavBar TintColor issue updating it from a CustomRenderer ViewWillAppear in iOS13

* Code refactoring

* Verify background image in iOS 13 with background changes

* Merge branch '4.5.0' into fix-9767-II

* - xcode11 check

Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
Co-authored-by: shane <shneuvil@microsoft.com>
fixes #9767
2020-04-06 19:58:54 -07:00
Rui Marinho 9148ae3584
[UITests] Fix Entry scroll test (#10218) 2020-04-06 23:05:02 +01:00
Shane Neuville a4f2ca0e67
Slider value updates with talks back and volume buttons correctly (#10204) 2020-04-04 10:32:23 -06:00
Yuriy Holembyovskyy e4e3939b05
Fix 9939 [iOS][UWP] Dispose method not called when adding control inside the NavigationPage.TitleView (#10152)
* Add call for TitleView Cleanup() method when popping for UWP

* Add TitleView  Dispose() call for iOS

Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com>

fixes #9939
2020-04-03 16:05:42 -07:00
Tim Miller da998ca75b Inverse Parent/Child fields for VisualDiagnostics.SendVisualTreeChanged (#10072)
* Inverse Parent/Child fields for VisualDiagnostics.SendVisualTreeChanged

The Parent/Child relationship for what's being sent for SendVisualTreeChanged needs to be flipped. With `VisualDiagnostics.SendVisualTreeChanged(this, value);` you end up with, say, a Button being a parent of a StackPanel, even though the button is _inside_ the StackPanel.

* Inverse Parent/Child fields for VisualDiagnostics.SendVisualTreeChanged

The Parent/Child relationship for what's being sent for SendVisualTreeChanged needs to be flipped. In the case of `XamlLoader`, the root XAML page is the "ultimate" parent of all the elements below it, so it should be sent as the "Parent" rather than as a "Child."

* Revert SendVisualTreeChanged for XamlLoader

* Remove VisualTreeChanged event call from XamlLoader

* Revert "Remove VisualTreeChanged event call from XamlLoader"

This reverts commit 2cbeda2d11393ee1f4b57676d2d7929b04c83e49.

* Revert Whitespace
2020-04-03 15:50:06 +02:00
Javier Suárez 407f698902
Fixed not applied BarTintColor in iOS NavBar using iOS 13 (#10144)
fixes #9765
2020-04-02 09:38:17 -07:00
Shane Neuville e5b02c20b4
Remove controller from UINavigationController stack when page is removed (#10140)
* Remove controller from UINavigationController stack  when page is removed

* - add uitest

* - remove extra code
2020-04-02 10:21:40 -06:00
Yuriy Holembyovskyy 08a7853ee2
Add Dispose method to properly remove Shadow view and avoid memory leak (#10017) fixes #9997
Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com>
2020-04-02 11:58:35 +01:00
Shane Neuville a94368d298
Add preview channel args and fixup provisionator (#10174)
* Add preview channel args and fix mac osx variables

* - remove xcode

* - mono

* - xcode 11.3

* - fix android

* - fix tabs
2020-04-01 19:59:54 -06:00
Rui Marinho 197fb75860
[iOS,Android] Fix CurrentItem position when adding a item (#10103) fixes #8964
* [UWP,iOS,Android] Fix CurrentItem position when adding a item

* [Controls] Add #8964 repo

* [Controls] Fix Issue8964 test

* [iOS] Fix initial position and update position after item inserted

* [Android] Small cleanup

* [UWP] Fix double call to IntialPosition

* [Tests] Fix category  

* Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Shane Neuville <shneuvil@microsoft.com>

* Update CarouselViewRenderer.cs

* [UITests] Try fix test

* [UITests] Try fix test

* [UITests] Try another fix to 8964

Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
2020-04-01 11:40:51 +01:00
Shane Neuville a8bc75dcbf
Add equivalent androidx proguard rules (#10138) 2020-03-30 17:16:33 -07:00
Shane Neuville efc4a40873
Copy build to buildTransitive (#10125)
* Copy build to buildTransitive

* - be less clever
2020-03-30 10:01:34 -06:00
Shane Neuville 741be75211
Fix hot reload when modifying AppShell file (#10064) 2020-03-27 13:58:42 -06:00
Javier Suárez fbae244b35
Fix Label TextDecorations issue on iOS (#10066) fixes #8272 2020-03-26 11:06:38 +00:00
James Clancey e70bc55df7
Embedded fonts fix (#9194)
* Android should use the new FontStuff

* iOS font loading is now more resilant. It returns the loaded font name from the embedded resource!

* iOS now loads any font!

* Font Aliases now work on iOS, Android

* Optimized for Alias, making all the lookups faster

* UWP now works with Font Aliases
2020-03-25 16:07:08 -07:00
Javier Suárez 95140943a3
Fixed SwipeView regression issue on iOS (#9464) fixes #9417 2020-03-24 17:29:31 +00:00
Rui Marinho bf58798e67
[UWP] Fix PeekAreaInsets usage on CarouselViewRenderer (#10068) fixes #10019
* [Controls] Some tweaks on sample CarouselCodeGallery

* [UWP] Fix PeekAreaInsets on CarouselView

* [UWP] Fix item width
2020-03-24 17:27:31 +00:00
Javier Suárez 67f462fff2
[UITests] Fixed SwipeView UITests on Android (Api Level 19) (#10058) 2020-03-24 11:07:32 +00:00
Rui Marinho 7a18459c86
[Build] Rollback to mojave 2020-03-24 10:25:36 +00:00
Yuriy Holembyovskyy 40812f2926
Add MaskToBounds property to clip a layer’s contents (#10023) fixes #9265, #9774
Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com>
2020-03-20 23:38:43 +00:00
Rui Marinho b230acd6f7
[Build] Fixes to build on Catalina (#10036)
* Update build.cake

Revert "Update build.cake"

This reverts commit 7a85766a6889e93b01b5a7c245aad7176fbc7b7a.

Update build.cake

Update build.cake

* Update MtouchArch

Fix arch on iPhone

* Update azure-pipelines.yml
2020-03-20 23:36:31 +00:00
Rui Marinho a33e4c157f
[UWP] Make sure to call UpdateInitialPosition on CarouselView (#10041)
* [UWP] Make sure to call UpdateIntialPosition on CarouselView

* [UWP] Only go to position if we need too
2020-03-20 23:35:32 +00:00
Javier Suárez 37b8112abb
Fixed Issue9306 UITest (#10042) 2020-03-20 22:37:26 +00:00
Javier Suárez Ruiz 7b0b8999bf
[Android/iOS] Swipe to close in SwipeView (#9664)
* Added repro sample

* Fixed swipe errors in SwipeView (swipe from one open SwipeItem to other swipe to close, etc)

* Removed unrelated repro sample

* Fixed swipe threshold calc issue

* Completed repro issue to allow more test validations

* Fixed duplicated ProcessTouchSwipeItems issue on iOS

* Fixed build error

* Added repro sample for the issue 9734

* Added repro sample for Issue 8767

* Changes to improve the touch responsiveness in SwipeView

* Added Issue 8778 and 9088 repro sample

* Fixed touch conflict between shell Flyout and SwipeView

* Added extra validation to invoke SwipeItem Command (only execute if SwipeView is fully open)

* Added new SwipeView in Core Gallery to validate the SwipeItems dispose

* Fixed SwipeView Core Gallery sample mistake

* Added more samples and UITests

* Recover deleted line in Controls android csproj

* Removed wrong space in csproj

* Removed commented line in SwipeView UITest

* Updated SwipeView sample to indicate the swipe direction
2020-03-20 09:25:47 +01:00
Shane Neuville 1b40a3633a
[iOS] Check if Current Item on Shell Section is set before proceeding (#9940)
* Visible ui test

* - make sure there's an active current item
2020-03-19 19:51:58 -06:00
E.Z. Hart a16f764831
Fix for Issue 2829 test, fast renderers, API 19 2020-03-19 10:39:04 -06:00
Javier Suárez Ruiz 36db4fcc25
[Android] Fix SwipeItems dispose when closing SwipeView (#9725)
* Added repro sample

* First possible fix

* Much better fix to dispose the SwipeView secondary view

* Added repro sample instructions

* Added repro sample to test and validate Issue 9735

* Fixed merge error

Co-authored-by: Rui Marinho <me@ruimarinho.net>
2020-03-19 12:21:33 +00:00
Rui Marinho c4bde89d88
[iOS,Android, UWP] Set Position and CurrentItem when ItemsSource items change (#9854) fixes #9322 fixes #9401 fixes #9432 fixes #9771
* [Android] Update CurrentItem on CarouselView when the ItemSource changed

* Fix sample

* [iOS] Update CurrentItem when ItemSource changess

* [Controls] Fix sample

* [iOS] Fix setting initial CurrentItem

* [UITests] Add UITest for CurrentItem change

* [UItests] Fix iOS test

* [Core] If we keep in the same item we still might need to update the position

* [Controls] Add repo for issue #9322

* [Controls] Fix tests

* [iOS,Android] Use NotifyCollectionChangedEventHandler

* [iOS,Android,Controls] Fix rebase

* [Controls] Fix tests

* [iOS] Fix scrolling to initial position

* [Android] Fix set Currentitem

* [Android] Don't try set a current item if we cleared the collection

* [Controls] Updata sample for issue #9401

* [Android] Reset the ItemDecorations when adding/removing the last index

* [Android] UpdateVisualStates when updating CurrentItem

* [Core] If the position of CurrentItem is the same no need to scroll

* [Controls] Update sample

* [Android] Set new currentitem e position from renderer

* [iOS] Update position from renderer

* [iOS] Add hack for position

* [Tests] Comment test for position, this is done on the platform now

* Set correct content offset when removing previous Carousel slides (#9828)

Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>

* [Controls] Fix sample

* [iOS] Update CurrentItem

* [UWP] Set Item/position from renderer

* [UWP] Fix NRE when disposing IndicatorView

* [UWP] Fix CurrentItem on collection changes

* Update App.cs

* [Android] Move to internal the NotifyCollectionChangedEventHandler

* [iOS] Fix rebase

* [Android] Don't try set position if no items

* [Controls] Add sample for #9771

* [iOS] Fix issue when collection is empty

* [Controls] Update sample to fix uitests on API19

* [Tests] Remove old unit tests

* [Android] Recycler extension method for center item

* [UWP] Fix extra padding on items

* [UWP] Refactor validate position

{UWP] Don't set position if there's no items

* [Controls] Update samples for CarouselView

* [Android] Fix set position on collection reset

* [iOS] Fix set position on collection reset

* [Android] Fix visual states on android

* [UITests] Wait for gallery button

* [UWP] Handle Scrolled event on CarouselViewRenderer

* [Android] Validate set position out of bounds

[Android] Reset _goToPostio flag when reset source

* [Android] Reset snap when item count changes

* [Android] If we request ScrollTo we should reset the CurrentTargetPosition

* [Android] Small refactor, reset _goToPosition when ItemsSource changes

* [Android] Better fix for issue with SingleSnapHelper

* [Core] Add AnimatePositionChanges and AnimateCurrentItemChanges to CarouselView

* [Android] Add AnimateChanges usage to CarouselViewRenderer

* [UWP] Add AnimateChanges usage to CarouselViewRenderer

* [iOS] Add AnimateChanges to CarouselViewController

Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>
2020-03-19 10:44:47 +00:00
Jonathan Goldberger 431aec9fc3
[Android] Visual Material Underline color should match placeholder color (#8530) fixes #6187
* Fixes Issue #6187
- Replaces TextColor with Placeholdercolor for setting the underline color in the relavant Material renderers (or base classes if appropriate)

* Added label to describe expected behavior
Removed UITest code

* label text edits

Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
2020-03-18 16:12:45 +00:00
Yuriy Holembyovskyy 2f23f01a1a
fixes #9952 On<iOS>().SetHideNavigationBarSeparator(true) does not work on Xamarin.Forms latest stable version (4.5.0.356) (#9972)
* Add ios13 specific case to UpdateHideNavigationBarSeparator() method

* Cleanup

* Add ELSE case to restore Separator default color on ios13

* Replace variable _defaultSeparatorColor with iOS 13 default shadow color

Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com>
2020-03-18 12:18:48 +00:00
Stephane Delcroix 6831ff1b10
[X] register asm in sourceinfo for xamlc (#10001)
see #9294
2020-03-18 10:35:40 +01:00
Samantha Houts 805913fa03 Merge branch '4.4.0' into 4.5.0 2020-03-17 21:20:07 -07:00
E.Z. Hart fdc1395971
Fix label test for fast renderer 2020-03-17 09:34:44 -06:00
Javier Suárez Ruiz 633718b742
Fix SwipeItem cast issue on SwipeView (#9907)
* Fixed SwipeItem parent casting issue

* Recover unnecessary removed line in ControlGallery project

* Added missing onproperty changed
2020-03-16 23:20:07 +00:00
Rui Marinho c6fa35592f
Merge branch '4.4.0' into 4.5.0 2020-03-16 17:28:09 +00:00
E.Z. Hart 2ad17b782e
Apply fix from #9195 to Style.cs (#9921) Fixes #9656
Fixes #9656
2020-03-16 17:22:15 +00:00
Rui Marinho 8e6dae2209
[Build] Update pool and pipelines (#9978)
* Update pool name

* Update azure-pipelines.yml

* Update build-android.yml

* Update build.cake

* Update azure-pipelines.yml
2020-03-16 17:19:26 +00:00