63479c77c3
iOS Cell default bgcolor to transparent ( #7903 ) fixes #7680 fixes #7850
...
* Update CellRenderer.cs
* Update CellRenderer.cs
* Update CellRenderer.cs
2019-10-25 15:07:07 +01:00
9e6db927e5
use support libs for DrawableWrapper ( #8106 ) fixes #6291
2019-10-25 12:37:46 +01:00
9102f4ac54
Set correct MinWidth for CheckBox style ( #7978 )
...
Fixes #7048
# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
2019-10-24 11:50:46 +02:00
d93ce2154e
[Android] Null checks ( #7941 ) fixes #7939
2019-10-24 10:43:27 +01:00
397e53c37c
Don't force the Master page closed on disappear if it's set to always visible ( #8164 )
...
* Don't force master closed when on split
* - fix UI tests to correctly test for tablet
* - remove extra code
* - fix issue with rotation from Modal
2019-10-23 11:37:02 +01:00
3d92bbd4e8
In Android : Reverse layout only when default layout direction is the… ( #7809 )
...
* In Android : Reverse layout only when default layout direction is the opposite of the user settings (#7393 )
* - remove ReverseLayout and just rely on LayoutDirection
* - fix formatting
2019-10-22 10:50:36 -06:00
95961eea54
Fix random test failures ( #8083 )
...
* [UITEsts] Ignore vertical test
* [UITests] Ignore 5766 uitest
* [UITests] Ignore UITest 1342
2019-10-22 10:54:50 +01:00
a96afaebb6
Merge branch '4.2.0' into 4.3.0
2019-10-21 10:40:15 +02:00
74d4caa05a
Always use current dispatcher to invoke wpf timer ( #7958 ) fixes #6957
2019-10-18 15:07:40 +01:00
3623e993b7
[MacOS] FIx agains NRE on disposing Entry renderer ( #8019 )
2019-10-18 13:03:53 +01:00
42e7cdfc3b
[MacOS] Fixed NRE with modal navigation ( #7900 )
...
* Added repro and fix
* Added UITest
2019-10-18 13:03:43 +01:00
cb4fd78f6f
Fixes #4941 (and 1722 for UWP). Adding a test in UWP NavigationPageRenderer.SetElement, to check if the supplied NavigationPage Eelement has a CurrentPage. If not, an InvalidOperationException is thrown. (Otherwise a NullReferenceException would be thrown at a later point.) ( #8034 )
2019-10-18 11:25:56 +01:00
f9114b1306
Make the Refresh View Respect Command CanExecute and add Refreshing event ( #7866 )
...
* Make Refresh View respect Command CanExecute
* - force isrefreshing false when isenabled fasle
- Add IsRefreshing Event
* - shift command execution up to xplat code
* - fix ui test
* - cleanup
* - add additional check
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7803.xaml.cs
* - fix flag
2019-10-17 00:44:25 -06:00
10b3d774c7
[iOS] Prevent crash when adding item to source of CollectionView in tab ( #7940 )
...
* Prevent crash when adding item to source of CollectionView that's never been displayed;
fixes #7700
* Fix renaming error in UI test
* Add test and fix for adding groups offscreen
* Fix rebase error
* Remove flags
* Add instructions
* Better instructions
2019-10-16 14:54:16 -06:00
eb1c563aa7
Cleanup material controls character spacing interactions ( #7880 )
...
* Cleanup material controls and spacing
* - remove left over code
* - remove virtual
* - pr comments
2019-10-16 17:11:51 +01:00
98d9245eb4
Remove requirement for CollectionView Experimental flag ( #7907 )
...
* CollectionView_Experimental is dead; long live CarouselView_Experimental!
* Change CollectionView enabling button labels to CarouselView for CarouselView tests
* Fix UI tests for Carousel
* Honor the CollectionView_Experimental flag for CarouselView
* Update Issue6963.cs
* Update Issue7817.xaml.cs
* Remove collection view flag settings
2019-10-16 09:44:47 -06:00
2d6a218803
[Android] Fix recyclerview offsets ( #8018 ) fixes #7993
2019-10-16 11:29:33 +01:00
c440dda110
remove duplicate statement ( #8014 )
2019-10-16 12:16:00 +02:00
d9ad8f3150
Fix Material Editor so TextChange delegate isn't removed ( #8011 )
...
* Fix Material Editor so delegate isn't removed
* - fix ui test
2019-10-15 16:10:36 -06:00
61eb23f6fe
Fix bug 5868 "VisualElement.Unfocus does not work on WPF" ( #7883 )
...
* Add repro
* fix bug
2019-10-15 21:24:34 +02:00
7f93346a3d
Fix shell to correctly pick visible item ( #8009 )
...
- when items are removed
2019-10-15 20:44:22 +02:00
ba83b5846a
Fix iOS crash when group type is not an IList ( #7955 )
2019-10-15 20:19:36 +02:00
8da3ccf8e8
Fixed issue setting Position in CarouselView ( #7901 ) fixes #7865
...
* Added sample file
* Updated sample
* Fixed the issue on Android and iOS
* Updated IsScrolling property from UWP CarouselView renderer
* Added repro sample instructions
* Update Issue7865.xaml.cs
* [iOS] Update IsScrolling from renderer
2019-10-15 15:37:40 +01:00
ded907b00e
Fixed build error (merge) ( #8024 )
2019-10-15 14:18:03 +01:00
8b356f6607
Merge branch '4.2.0' into 4.3.0
2019-10-15 14:12:49 +02:00
57e3dc6e1c
Label size doesn't change when text changed ( #7942 )
...
- fixes #7888
2019-10-15 12:53:31 +02:00
9280549d37
Added sample ( #7650 )
2019-10-15 09:37:57 +01:00
6388a3e75c
[iOS] Various fixes with ItemsViewController ( #7618 )
...
* various fixes
* remove comment
* move delegator setting to ViewDidLoad
* fix delegator
* fix accessibility issue
2019-10-15 09:32:26 +01:00
773232214c
[Android] speed up development builds ( #7834 )
...
* speed up development builds android
* - remove extra property group
* - add cake descriptions
* - fix
* - remove shared runtime
* - add check for TF_Build
2019-10-14 23:10:00 -06:00
4658494caa
Fixed ItemSpacing, NumberOfSideItems, PeekAreaInsets and Snap in UWP CarouselView. ( #7930 )
2019-10-14 18:07:11 -06:00
a47892feac
[Android] Fixed a crash on CollectionView changing ItemsSource ( #7945 )
...
* Added repro sample
* Fixed the crash
2019-10-14 15:24:53 -06:00
27879f653c
Validate on Date part only ( #7766 ) fixes #5784
...
* Validate on Date part only
Fixes #5784
* Add unittest
* Both sides should be Date only validated
2019-10-14 16:56:57 +01:00
6746593020
[Android] Fixed CarouselView string EmptyView not displayed ( #7822 ) fixes #7792
...
* Added sample
* Updated sample
* Fixed CarouselView issue not displaying string EmptyView
* Fixed wrong controls shared projitems paths
2019-10-14 16:48:33 +01:00
135020e182
Fix [macOS] navigation page doesn't hide previous page ( #7921 )
...
* fix
* test added
* more transparency added to test
* test simplified
* test title fix
2019-10-14 13:57:44 +02:00
3f4afda657
Merge branch '4.1.0' into 4.2.0
2019-10-14 09:03:32 +02:00
333d3a015e
Move CollectionView UWP implementation to generics ( #7911 )
...
* Clean up implementation with generics and get rid of awkward casts
* Save some unnecessary casts and switching on CarouselView
2019-10-11 17:11:42 -06:00
3680f95786
Fixed crash on UWP Switch (UpdateThumbColor) ( #7932 )
2019-10-11 13:43:08 +02:00
f7bd539917
[Tizen] Fix RenderWith attributes for Forwarders ( #7854 )
2019-10-10 17:46:57 -07:00
f79080bcd1
Generics for CollectionView iOS implementation ( #7918 )
...
* Make the ItemsView type generic
* Make controller type generic
* Generic all the things, and split up the delegators
Fix rebase error
2019-10-10 16:21:22 -07:00
cd75d99d04
Revert "Fixed crash on UWP Switch (UpdateThumbColor)"
...
This reverts commit 10a0f4e0b3
2019-10-10 18:09:50 +02:00
10a0f4e0b3
Fixed crash on UWP Switch (UpdateThumbColor)
2019-10-10 18:08:43 +02:00
76b4b96695
[Android/iOS] Fixed ItemsUpdatingScrollMode on CarouselView ( #7872 )
...
* Added repro sample
* Updated sample
* Fixed issue on Android
* Fixed issue on iOS
* Updated sample
* Updated instructions
* Fixed property changed propagation from CarouselViewRenderer to ItemsViewRenderer
2019-10-10 09:31:05 -06:00
88dfa6c2ed
[UWP] [iOS] Verify selected items exist when updating native selections ( #7902 )
...
* Add selection synchronization tests
* Resync native selection after ItemsSource is updated
* Update native selection on iOS when changing ItemsSource; prevent crash when
selection contains items not in source; fixes #6963
* Automated test
2019-10-10 09:16:38 -06:00
c137d02ed0
[X] binding find the right indexer ( #7896 )
...
supports having multiple indexers on a bound source, try to invoke the right one
- fixes #7837
2019-10-10 10:19:04 +02:00
2e531d726e
Fixed SnapPointsType discrepancy between CarouselView and LinearItemsLayout ( #7893 )
2019-10-09 20:14:38 +02:00
fd9644f3f2
Implement grouping for UWP CollectionView ( #7697 )
...
* Implement grouping for UWP CollectionView
* Clean up CollectionViewSource on teardown
2019-10-09 11:56:18 -06:00
724185eac8
[iOS] Fixed crash displaying strings in CarouselView ( #7858 )
...
* Added repro sample
* Fixed the crash on DequeueReusableCell registering the correct cell types
* Added instructions to the test
* Fixed wrong paths on Controls Issues projitems
2019-10-09 09:52:27 +02:00
2aeeece793
Shell android dispose ( #7768 )
...
* Better dispose of Android shell renderers
* - fixup a few dispose paths
* - set page to null
* - header container
2019-10-08 12:16:03 -06:00
7863614ec0
[iOS] Fix issue changing the ItemTemplate on CollectionView dynamically ( #7743 )
...
* Fixed Issue 7742: Change CollectionView ItemTemplate programmatically
* Fixed typo
* Removed invalid test
2019-10-08 20:06:07 +02:00
51fb38f30b
[iOS] Alternative proposal for PR 7794 ( #7811 )
...
* emptyview fix
* fix
* added collectionview flag
* added using for List
* fix formatting
* fix formatting 2
* fix formatting 3
* fixes
* fix test
2019-10-08 17:44:49 +02:00
Gerald Versluis
Alan Grgic
Glenn Versweyveld
Shane Neuville
Elashi
Rui Marinho
Stephane Delcroix
Konrad Müller
Jon Robinson Levy
E.Z. Hart
adrianknight89
Javier Suárez Ruiz
bill2004158
melimion
Kangho Hur