* rename Azure AD to Microsoft Entra Workforce ID
* update Azure Active Directory to Microsoft Entra Workforce ID
* replace
* update version
* change stale version
* update from stale
* update version
* update readme
* Microsoft Entra Workforce ID -> Microsoft Entra ID
* AAD -> Microsoft Entra ID
* Delete .devcontainer/devcontainer.json
* Revert "Delete .devcontainer/devcontainer.json"
This reverts commit 5dd6d5c265.
* revert code changes
* remove double names
* update version
* go back version
* api update version
* revert for linting
* revert test linting
* fix linting
* roll back linting
* increase line length
* fix linting
* fix formatting
* fix lintin 3
* update urls
* update aad urls
---------
Co-authored-by: Tim Allen <tim.allen@cloudkubed.com>
* Initial Commit
* Update SQL SKU variables
* add in sql_sku to template
* "updateable": true
* ignore zone
* update to azurerm_mysql_flexible_database
* add password
* update sku list
* update user login details for mysql
* update changelog
* doc updates and version updates
* resolving comments
* add ohdsi workspace service (before adjustments to the OSS)
* add execute permission to scripts
* Fix Postgres timeouts when install OHDSI (#3559)
[ohdsi] fix postgres timeouts
* Add OHDSI workspace service (#3552)
* remove todos
* link core vnet to postgres private dns zone when deploying core
* remove synapse references, and add other data sources to the options
* remove postgres_core_dns_link references
* revert synapse reference deletions
* remove non supported dialects
* add execute permission to scripts
* make some of the daimons required
* add required zone field to postgres:
https://github.com/hashicorp/terraform-provider-azurerm/issues/16888
* add fw rule to allow open id authentication in atlas
* fix firewall step
* add README
* update README
* fix linting errors
* fix linting errors
* update changelog
* Update CHANGELOG.md
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
* add ohdsi ws service to the CI
* clarified README
* added name, description and overview to the template_schema
* move README content to docs
* change default display name
* add diagram to and instructions about setting up the CDM data source
* add link to ohdsi-on-azure
* move ohdsi-on-azure to the top
* link to OHDSIonAzure for deploying synapse
* Update docs/tre-templates/workspace-services/ohdsi.md
Co-authored-by: Marcus Robinson <marrobi@microsoft.com>
* add Using a sample CDM data source section
---------
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Co-authored-by: Marcus Robinson <marrobi@microsoft.com>
* Databricks workspace service fails to deploy to East US with DNS error
Fixes#3515
* Update changelog
* remove en-us
* Databricks workspace service fails to deploy with DNS error
Fixes#3515
* fix typo
---------
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
* Azure Databricks TRE workspace service
Co-authored-by: Guy Bertental <guybartal@gmail.com>
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Co-authored-by: Ross Smith <ross-p-smith@users.noreply.github.com>
Co-authored-by: Marcus Robinson <marrobi@microsoft.com>
* Missing Api Id returns 500
* Make app_id mandatory
* Moving authInformation into workspace properties
* Create AAD when the private endpoint is finished
* tflint
* Adding outputs back in
* Default outputs
* Pass auth variables into TF
* TF Lint
* Fix Unit Tests
* app_id => client_id
* Linting
* E2E working locally
* Put tests around truthy method
* Bump the API Version
* Activate the DB migration
* Change return type and hope porter deals with it!
Co-authored-by: David Moore <35696285+damoodamoo@users.noreply.github.com>
* #1290-CodeEnhancements
* #1290-AddMLflowWorkspaceServiceAndDockerImage
* #1290-AddMLflowPostgresqlDB
* #1290-ReducePostgresqlSKUAndStorage
* #1290-FixFilePathsInDockerfile
* Update local reference
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
* Update terraform porter mixin version
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
* Update terraform version
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
* Remove redundant code
* ParameteriseWebExternalExposure
* SetMLflowVersionAndRemoveRedundantCode
* AddPostgreSQLVirtualNetworkRule
* ResolveFileShareConflictDuringDeployment
* #1290-CodeEnhancements
* #1290-AddMLflowWorkspaceServiceAndDockerImage
* #1290-AddMLflowPostgresqlDB
* #1290-ReducePostgresqlSKUAndStorage
* #1290-FixFilePathsInDockerfile
* Update local reference
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
* Update terraform porter mixin version
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
* Update terraform version
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
* Remove redundant code
* ParameteriseWebExternalExposure
* SetMLflowVersionAndRemoveRedundantCode
* AddPostgreSQLVirtualNetworkRule
* ResolveFileShareConflictDuringDeployment
* Squashed commit of the following:
commit 4ff39cec96
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Wed Mar 2 15:31:28 2022 +0000
remove duplicated step (#1419)
commit 06c1e4cc8e
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Wed Mar 2 14:10:51 2022 +0000
Update debugging for comment triggered workflow (#1415)
* Fix up user permissions debugging
* Add logging to PR details
commit e2d12c8dba
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Wed Mar 2 11:07:33 2022 +0000
Add more debug info to help test permission checks (#1412)
commit fc091c740e
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Wed Mar 2 10:09:47 2022 +0000
Comment bot fixes (#1411)
* Fix up tests for running build for main
* Add Dev environment for az credentials for cleanup command
commit f6b25d1550
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Wed Mar 2 09:39:24 2022 +0200
Add header to RP prune script (#1400)
* add script header
* debug steps on destroy script
* change query in the destroy script
commit 8022b7c2b1
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Tue Mar 1 21:15:15 2022 +0000
Add test-destroy-env command (#1410)
commit 7db9fca03b
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Tue Mar 1 20:09:41 2022 +0000
Add explicit checks update for comment-triggered builds (#1408)
commit 607abdea06
Author: James Griffin <me@JamesGriff.in>
Date: Tue Mar 1 17:10:13 2022 +0000
Implement custom actions (#1385)
* Added action route
* Handle custom actions in resource proc
* Added catch for unsupported operation state changes
* Added launch.json for resource proc debug
* Updated res proc docs to make debugging easier
* Added env sample
* Consistency of custom_actions naming
* Use invoke in runner
* custom_actions camelcasing
* Added template validation
* Moved start stop to correct place
* Fixed ubuntu default
* Bumped version
* Validate against template
* Added workspace service name get
* Added action routes to workspace and workspace services
* Bump versions
* Amended API permissions
* Added action field to operation
* PR amendments
* Amended outputs and fixed sb tests
* Fixed set()
* Added pythonpath and pip install
* Modified rp deploy to use new var names
* Removed unused blocks and shortened debug setup for RP
* reverted sb 503 -> 500
* SB auth warning
* Added use local creds flag
commit df8117ccef
Author: Oliver Atkinson <oliver.a@live.co.uk>
Date: Tue Mar 1 16:28:17 2022 +0000
Shared workspace storage (#1339)
* Added Shared Storage Access to Linux VM
* Added vm shared storage to basic SA deployment
* Changed hard coded value to data reference
* Shared Storage access added
* Windows Shared Storage Fixed
* Changed incorrect default image
* fixed typo
* Windows Shared Storage fix
* Added initial storage mount
* removed trailing \ from command
* Link to shared folder created
* Corrected version number
* Added back incorrectly removed char
* Set drive to be added globally
* Ammended paths used
* set cmdkey to add to admin users account
* Set cmdkey add as start-up script
* Fixed shared storage access
* Moved shared storage to workspace level
* Merged shared storage changes
* Ommited shared storage name from template
* Ommiting shared storage access from schema
* granted rw on fileshare to any linux vm user
* Iterate workspace build number
* Fixed lint issues
Co-authored-by: Ross Smith <ross-p-smith@users.noreply.github.com>
commit 9dc4ccb9e0
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Tue Mar 1 14:54:56 2022 +0000
fixup typo (#1404)
* fixup typo
* Update condition on pr details step
* Update command name (test-force-approve)
commit 9d29ba52c5
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Tue Mar 1 12:29:04 2022 +0000
Update to use PR head sha for md-only checks (#1402)
* Add debug output
* Use PR head sha for checks
commit 8c6bc851cd
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Tue Mar 1 08:34:21 2022 +0200
Make uses destroy script (#1392)
* make uses destroy script
* bug fix
* fix field typo
commit 35e04819dc
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Mon Feb 28 15:09:56 2022 +0200
tre-start called before deploy-core (#1391)
commit 858f013a7f
Author: Oliver Atkinson <oliver.a@live.co.uk>
Date: Mon Feb 28 09:55:26 2022 +0000
Guacamole Service properties documentation (#1380)
* Documented Guacamole Service exposed properties
* Reworded based on suggestions
Co-authored-by: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
* Split properties into required and optional
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Co-authored-by: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
commit d066b94a77
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Mon Feb 28 10:03:31 2022 +0200
Diagnostic settings support only sync deletion (#1388)
* fix bug
* delete diagnostics in parallel
commit 15868ad682
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Sun Feb 27 19:20:22 2022 +0200
Fix firewall check in control script (#1387)
* fix control script checking firewall
* adding echo
commit 2831d5c36a
Author: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
Date: Sun Feb 27 15:21:47 2022 +0200
Adding ID token (hybrid flow) to the app registration script (#1353)
* Adding ID token (hybrid flow) to the app registration script
* adding missing optional claims + api permissions
* Adding vars to scope ids
commit a83c33b21c
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Sun Feb 27 10:58:02 2022 +0200
checkout without persisting credentials (#1374)
commit 18b9e8fbcb
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Sat Feb 26 15:38:59 2022 +0000
Add link to workflow run (#1384)
* Explicitly set SHA for checks status
* Add link to workflow run in PR comment
commit 561b482a36
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Fri Feb 25 15:12:52 2022 +0000
Fix ordering. Update to use PR merge ref (#1383)
commit ce3ddb91af
Author: David Moore <35696285+damoodamoo@users.noreply.github.com>
Date: Fri Feb 25 13:46:14 2022 +0000
Split out Firewall / Nexus / Gitea (#1365)
* WIP: doesn't work yet
* Make temporary changes to the makefile
* Fixes to firewall submodule
* Update Makefile
* move firewall name to locals
* Init porter bundles for Gitea and Nexus
* Add parameters to the new porter bundles
* Revert "Convert data inputs into variable inputs for modules in Terraform (#1154)"
This reverts commit c3e2cb7f0a.
* WIP: moving variables around for Gitea
* Update Gitea module to consume variables from data
* Fix several problems in firewall module
* Changes to Gitea terraform (fix state container, add az login for local-exec)
* Initial Nexus porter configuration
* Add Sonatype-Nexus bundle
* Uncomment firewall lock, fix local-exec command
* Fix comments
* fmt
* Gitea, Nexus: Move variable inputs to data and locals
* change path to nexus.properties
* temporarily remove arm_client_id
* fmt
* remove unused arguments
* fmt
* Use key_vault_reference_identity_id in Terraform
* Remove unused variables
* Deploy Firewall, Gitea and Nexus as part of the main build
* Add deploying of shared services to tre-deploy command
* Add uninstall back
* WIP: working transfer of state for Firewall
* WIP: fiddling with more states
* WIP: fix removal of terraform state
* Add import script for Gitea
* fixup tre-start/stop make target naming
* strip '-' from string in storage account name
* removed state_remove for gitea + nexus
* removed state_remove for gitea + nexus
* local modifications of import/remove state scripts
* fw / gitea / nexus deploy from local via tf functional
* gitignore
* bumped gitea version
* tf linting
* PR updates
* vars for ci
* added check_dependencies to login in CI
* check for non-existing RG and skipping import state if we're in a fresh CI
* removed lock from remove/import scripts
* remove/import state for gitea
* gitea and nexus state moved
* nexus + gitea state moved, apart from storage share
* fixed storage import
* PR snags
* override
* kv uri
* new secret import style
* secret
* secret
* state list
* state list
* remove state fix
* remove state special chars
* importing random_password to prevent KV updating
* moved make target out of default path
* supress risky log output
* unwound gitea/nexus state moving debacle
Co-authored-by: Tanya Borisova <tborisova@microsoft.com>
Co-authored-by: Ross Smith <ross-p-smith@users.noreply.github.com>
Co-authored-by: Stuart Leeks <stuartle@microsoft.com>
commit c2742f6feb
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Fri Feb 25 11:34:03 2022 +0000
Fixes for pr_comment_bot (#1382)
* Fixup checkout steps across jobs
* Add persist-credentials=false
* Set repo/ref on checkout for filter
commit 0be8fe0c13
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Fri Feb 25 08:26:11 2022 +0000
Revert to author_association checks (#1379)
commit b238e28278
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Thu Feb 24 19:30:36 2022 +0200
delete env in script (#1372)
commit 3a2a64eaea
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Thu Feb 24 16:31:25 2022 +0000
Add error to output (#1378)
commit 79174398c1
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Thu Feb 24 15:49:48 2022 +0000
Add output to diagnose permissions + start force-approve command (#1377)
* Make message more informative
* Add extra details to log messages
* Add force-approve command
commit 39a3a9ce1d
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Thu Feb 24 14:59:49 2022 +0000
Move user check inside workflow step (#1375)
commit 2495fdfe25
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Thu Feb 24 11:32:50 2022 +0000
Add temp debug step (#1373)
commit df61a4db1e
Author: Martin Peck <mpeck@microsoft.com>
Date: Thu Feb 24 10:29:57 2022 +0000
allow all fw rules to be dropped (#1369)
commit 44522a3c77
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Thu Feb 24 09:44:23 2022 +0000
Fix output reference (#1371)
commit d34bf0c168
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Thu Feb 24 08:24:04 2022 +0000
Add pr_comment_bot workflow (#1356)
* Add pr_comment_bot workflow
Allow running tests by commenting "/test" on a PR as OWNER/COLLABORATOR
* Revert TRE_ID to git ref
Based on discussion with @tamirkamara, changing this ID would require changes in numerous places in the scripts etc
* Switch to standard checkout action for PR code
* Add filter to skip full build on MD-only changes
* Update references to CI github ref
* fix quotes
* Update comment/name
* Update job name to align with manual check status
commit 4df245fdab
Author: Martin Peck <mpeck@microsoft.com>
Date: Wed Feb 23 14:08:06 2022 +0000
set exit codes to 1 (#1364)
commit ca7bb00136
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Tue Feb 22 22:04:13 2022 +0200
ci checks core image version update (#1360)
commit 78815fcea4
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Tue Feb 22 21:22:41 2022 +0200
update rp to free disk space (#1358)
commit 31ca745536
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Tue Feb 22 11:21:23 2022 +0200
Fix debug reference in docs (#1357)
* fix debug reference in docs
* docs published only if needed
commit 383c7f8a1e
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Mon Feb 21 18:38:49 2022 +0200
Skip deploy when only md files are updated (#1351)
* run workflow steps when needed
* update comment
commit a9ec4d3c24
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Mon Feb 21 17:46:34 2022 +0200
Upgrade azurerm to 2.97 (#1354)
* upgrade azurerm to 2.97
* format fix
commit 8602c57341
Author: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
Date: Mon Feb 21 10:27:50 2022 +0200
Fix broken doc link (#1350)
commit 36c5f37c57
Author: Jamie D <daltskin@hotmail.com>
Date: Sun Feb 20 17:03:33 2022 +0000
Reminder to update docs when making changes (#1341)
Co-authored-by: Jamie D <jamie.dalton@microsoft.com>
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
commit 0cbf3d24a4
Author: Stuart Leeks <stuartle@microsoft.com>
Date: Sun Feb 20 15:51:18 2022 +0000
Add firewall dependency for gitea/nexus (#1334)
Co-authored-by: Ross Smith <ross-p-smith@users.noreply.github.com>
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
commit abc6e6a0c9
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Sun Feb 20 17:25:03 2022 +0200
Fix CI ACR Cache Parameter (#1347)
* fix CI_CACHE_ACR_NAME
* Install az extensions as needed
Co-authored-by: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
commit 9315964b1e
Author: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
Date: Sun Feb 20 16:53:36 2022 +0200
add print (#1348)
commit 06d6f95577
Author: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
Date: Sun Feb 20 14:50:05 2022 +0200
Fix extended tests results publishing (#1345)
commit 5375ba5a46
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Sun Feb 20 12:13:11 2022 +0200
Fix cleanup script/workflows with no locks (#1328)
* fix cleanup with no locks
* typo
* fix control-tre script
* keyvault issue
* Revert "keyvault issue"
This reverts commit 123f05c86c.
commit 9ecf86e8df
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Sun Feb 20 11:53:07 2022 +0200
Stop inactive CI environments (#1318)
* enable tre stop/start
* tiny update
* ci to stop envs after inactivity
* keyvault issue
* Revert "keyvault issue"
This reverts commit 710fe475a3.
commit df67ec46aa
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Sun Feb 20 09:13:48 2022 +0200
load core env for tre-destroy (#1329)
commit c6ab21cfdb
Author: Ross Smith <ross-p-smith@users.noreply.github.com>
Date: Fri Feb 18 13:38:34 2022 +0000
Removed .vscode files (#1331)
* Removed .vscode files
* Format document
Co-authored-by: Jamie D <daltskin@hotmail.com>
commit 85bb666f1b
Author: Ross Smith <ross-p-smith@users.noreply.github.com>
Date: Fri Feb 18 13:28:23 2022 +0000
typo (#1337)
Co-authored-by: Jamie D <daltskin@hotmail.com>
commit 4f5bab9a6f
Author: vjmanda <44143177+vjmanda@users.noreply.github.com>
Date: Fri Feb 18 12:54:03 2022 +0000
#1309-Fix-DocumentationCorrectionsAndFormatting (#1312)
Co-authored-by: Vijay Manda <vijay.manda@trustmarque.com>
Co-authored-by: Ross Smith <ross-p-smith@users.noreply.github.com>
commit 2f462c4b43
Author: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
Date: Fri Feb 18 13:16:44 2022 +0200
Adding a job to run extended tests (only on main) (#1322)
* Adding a job to run extended tests (only on main)
* add missing devcontainer tag
Co-authored-by: Ross Smith <ross-p-smith@users.noreply.github.com>
commit c22a6f6866
Author: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Date: Fri Feb 18 12:57:30 2022 +0200
Add secondary docker cache (#1323)
* add secondary docker cache
* change acr name
Co-authored-by: Ross Smith <ross-p-smith@users.noreply.github.com>
commit 79260e0ba3
Author: Jamie D <daltskin@hotmail.com>
Date: Fri Feb 18 10:02:36 2022 +0000
#1326 (#1327)
Co-authored-by: Jamie D <jamie.dalton@microsoft.com>
* #1290-SharedStorageAndDocker
* Fix connectivity and issues
* Postgres Private DNS zone
* webapp use vnet_route_all_enabled
* Resolving comments and issues
* Add newline to dockerignore
* add mlflow to gh actions workflow
* Fixing artifact tracking issue
* Add documentation and tidy-up
Co-authored-by: Vijay Manda <vijay.manda@trustmarque.com>
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Co-authored-by: Martin Peck <mpeck@microsoft.com>
* Added files.pythonhosted whitelist
* Added pypi nexus source
* Added pip source set up in VM cloudinit
* Fixed proxy conf naming
* Pip install working for linux
wojciechcloudkubed
Tim Allen
Yuval Yaron
Marcus Robinson
Guy Bertental
Anuj Parashar
Elad Iwanir
Liza Shakury
Tamir Kamara
Martin Peck
Ross Smith
Oliver Atkinson
vjmanda
Jamie D
James Griffin
Denis Cepun
Tess Ferrandez