Граф коммитов

2962 Коммитов

Автор SHA1 Сообщение Дата
Rido ffc00bd09e
Remove NGrok. Configure Tunnel URL (#2461)
* Rido/ngrok removal (#1)

* update fileMenu

* add tunnelUrl

* get serviceUrl from settings

* showPort

* rm ngrok settings

* showPort

* rm ngrokdebugger

* rm ngroddebug from editor

* rm ngrokService

* rm nGrokTab

* rm ngrok sagas, actions, styles

* rm ngrok settings

* upd version, and deps

* get server port

* update changelog

* fix lint issues

* PR feedback

* Update packages/app/client/src/ui/editor/appSettingsEditor/appSettingsEditor.tsx

Co-authored-by: Eugene <EOlonov@gmail.com>

* Update tsconfig.json

Co-authored-by: Eugene <EOlonov@gmail.com>

* rm ngroc from tests

---------

Co-authored-by: Eugene <EOlonov@gmail.com>
2024-09-16 13:02:49 -07:00
Cecilia Avila e554dc4231
fix: [#2398] Support Bots that use Single Tenant AAD Applications (#2457)
* include Single Tenant apps support

* change tenantId variable name

* fix unit tests

---------

Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
2024-05-23 02:15:41 +00:00
Eugene 012a664107
Security: address TLS/FS issues (#2456)
* Security: address TLS/FS issues

* Fix tests

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2024-03-22 12:17:54 -05:00
Eugene 61414edfe0
Update contributing guide (#2454)
* Update contributing guide

* Fix typo

* Cleanup notices

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2024-03-20 14:49:59 -05:00
Eugene f8ae0a1220
chore: upgrade electron to v26 (#2439)
* chore: upgrade electron to v26

* fix remote usage and bump node-abi

* pin electron

* move @electron/remote to deps

* update restify

* rip off electron devtools installer

* fix remote usage

* restify migration

* fix remaining remote calls

* remove unused

* fix preload and remote usage

* add mock for @electron/remote

* apply for all packages

* fix remaining tests

* revert debug

* mock more cases for remote mock

* fix failing test

* fix CI test failures

* fix nodejs unhandled promise rejection errors 2/n

* fix nodejs unhandled promise rejection errors 3/n

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-10-06 13:19:49 -07:00
Eugene 515fc6275b
a11y: accessibility overhaul (#2426)
* a11y: links to have underline

* a11y: json editor contast to meet aria

* a11y: revisit colors

* Revert "Fixed the focus when opening the Emulator Settings tab (#2310)"

This reverts commit b09b668a49.

* a11y: focus first interactive element upon editor activation

* a11y: add optional aria for optional fields

* a11y: add section to checkbox labels

* a11y: add selected only when selected

* a11y: aplit button to have aria-owns and size

* a11y: force button caption reading for reveal secret control

* a11y: make selected aria only appear if selected

* a11y: better aria for activity region

* fix typo

* a11y: menu to restore focus on task completion if it is lost

* a11y: turn off color adjust for high contrast theme

* fix: app updater can stuck due to unresolved promise

* fix: failing tests

* Revert "a11y: add optional aria for optional fields"

Conflicts with other AT besides JAWS

This reverts commit 9317e80714.

* revert: conditional aria-selected

* a11y: alternative fix for split-button

* fix build

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-07-10 11:02:01 -07:00
Eugene b6c7dcc611
chore: fix nightly release failures (#2432)
* wip on fix nightly release

* fix rebasePackageLock

* reflect lerna update

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-06-22 13:24:22 -07:00
Eugene 3fefda5578
chore: ngrok 3 (#2430)
* Update ngrok.ts and ngrokService.ts for Ngrok 3 support

Remove path and region from Ngrok Options as it is not supported in the config for Ngrok 3.

Pass the path to the ctr when creating the Ngrok instance.

Update ngrok.ts to use the path passed in to the ctr instead of Ngrok Options.

* fix failing tests

* fix ngrokService tests

---------

Co-authored-by: Anish Prasad <v-aniprasad@microsoft.com>
Co-authored-by: Anish Prasad <anishnp01@outlook.com>
Co-authored-by: Anish Prasad <33945547+anishprasad01@users.noreply.github.com>
Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-06-20 17:09:02 -07:00
Eugene d144dd2207
fix: jsonwebtoken usage (#2421)
Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-04-11 12:43:13 -07:00
Eugene 0f67533462
a11y: fix accessibility insights pass issues (#2420)
* fix: log entry buttons have same aria name

* a11y: add titles to html documents

* a11y: tabs with the same name should be possible to identify

* a11y: do not include list control localized name into aria label

* a11y: add log entries index for scan mode

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-04-03 13:53:13 -07:00
Eugene 68c7bd9f25
fix: auth flow issues (#2417)
* fix: auth flow issue

* fix tests

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-03-22 09:07:10 -07:00
Eugene 1e5f36fc4b
chore: add TSA configuration for emulator (#2413)
Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-03-21 17:01:16 -07:00
Eugene 75ebe96a0b
fix: update dev scripts and add missing deps for development (#2419)
* fix: update dev scripts and add missing deps

* rollback package

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-03-14 09:06:46 -07:00
Eugene fa8607a0a1
Bump electron to the latest minor version and cleanup deps (#2412)
* Bump electron for the latest minor version and clenup deps

* Remove deprecated css types loader

* update more deps

* Update webchat and jsonwebtoken

* update tests

---------

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-02-09 17:14:12 -08:00
Eugene 3a6bc48719
chore: update dependencies (#2406)
* chore: update dependencies

* More deps updates

* WIP

* Pin PostCSS

* Run audit on lock file

* Tune lockfile more

* Kick CI

* Fix lint

* Fix tests and allign deps

* Fix babel targets

* Fix coverage reporting

* kick CI

Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2023-01-21 13:47:32 -08:00
Eugene 196b347244
Fix lint issues (#2402)
Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2022-12-13 14:32:09 -08:00
Eugene 99a7ccdb75
chore: update webchat to 4.15.3 (#2395)
Co-authored-by: Eugene Olonov <v-eolonov@microsoft.com>
2022-08-11 13:42:37 -07:00
Eugene 5f27988730
chore: fix build (#2388)
Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-06-21 11:41:56 -07:00
Eugene ae80b16a35
a11y: do not announce chevron as play button (#2384)
* a11y: do not announce chevron as play button

Narrator announces chevron in a JSON tree as a play button.
Hide chevron from AT as it already announces expanded state.

* fix nit

* update lock file

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-06-09 13:40:00 -07:00
Eugene 0ac4a1c47f
a11y: platform fixes for mac (#2381)
* a11y: 63767 - fix VoiceOver reading whole list content

In Electron/Chrome it reads the whole list content when the list root focused. Add a label to fix the issue.

* a11y: 64009 - improve left pane contrast

Fixes secondary text contrast and improves contrast ratio for primary text for the Left pane.
The bug mentioned some menu contrast issues, I believe the're not existent.
The bug also mentioned JSON contrast. It is already fixed.

* a11y: 64005 - make consistent full-screen handling between all platforms

Includes the following changes:
- Move the popup logic into the command
- Use the command for the native menu

* a11y: switch theme: announce on all platforms

Adds announcement for macOS as well. And makes message to start with visible content.

* Revert "a11y: 64005 - make consistent full-screen handling between all platforms"

This reverts commit 850cd46f32d718efe6cc5a5ec4db9e37f56f033d.

* Revert "a11y: switch theme: announce on all platforms"

This reverts commit 14aea00b857b63ce0eb60cdd35a13dfb7000b9f8.

* a11y: 63887 - make ngrok status accessible

Not able to reproduce the original issue, but found that the ngrok status is not being announced, so added the tunnel status and tunnel errors announcement.

* a11y: 63914 -  rework collapsable content announcement

Prevent lists from being announced when a new entry gets added.

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
2022-04-27 08:51:23 -07:00
Eugene 72e46fe262
a11y: announce theme switching and fullscreen commands (#2380)
* a11y: 64005 -  announce theme and fullscreen commands

* Add announcement for macOS as well.
* And makes message to start with visible content.
* Move fullscreen to the UI commands and add announcement
* Fix tests

* Fix main tests

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-04-26 16:05:57 -07:00
Eugene b3b5cc15ec
a11y: fix platform-specific issues (#2378)
* a11y: use region role for WebChat

VSTS-63988 The default `"complementary"` role cannot be included into another landmark. Use `"region"` role for the chat instead.

* a11y: add menu item role description

VSTS-64729 On linux, when using orca, it doesn't announce an actual role for menu items. Fixed by adding the "menu item" to the `aria-description` property only on linux

* a11y: fix sidebar sections aria

VSTS-64703 Sidebar section toggle buttons had a toolbar role which is not descriptive. Fixed by changing the role to button and adding toolbar around the section action buttons.

* a11y: refactor selected tab indication for orca

VSTS-64523 The selected tab announcement doesn't happen to me when using orca. Changed the approach by using `aria-description` property on linux.

* Fix tests

* fix: better way to get current platform

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
2022-04-25 11:00:44 -07:00
Eugene e8a6d72935
fix: keyboard shortcuts don't work when telemetry and updates dialogs appear together (#2379)
* fix: keyboard shortcuts don't work when telemetry and updates dialogs appear together
Normally, there is no way for a user to open a dialog when another dialog has been opened. However, this occurs when the "Updates available" dialog is opened as a result of the 'update-available' event.

Added a method for waiting for the currently displayed dialog to be hidden, and used it for the "Updates available" dialog.

* Add tests

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-04-18 14:30:02 -07:00
Eugene b7bbdc6ea7
chore: update botframework-webchat to v4.15.1 (#2376)
* chore: update botframework-webchat to v4.15.1

* Run CI

* Kick CI

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-03-30 12:16:21 -07:00
Eugene 135c3a8e09
chore: update critical dependencies (#2373)
* chore: update critical dependencies

* update packages lock

* Fix lint issues

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-03-24 16:23:51 -07:00
Tony Anziano acde0c689d
Added CredScan paths for Windows agents (#2372) 2022-03-11 20:42:29 -08:00
Tony Anziano 56e05ed3d9
Added ADO CredScan support. (#2371)
* Added .tsv file for ADO Cred Scan task to use.

* Changed credScanTargetFolders to .tsv extension

* Removed build agent env variables from tsv

* Changed paths in .tsv to try and match the build agent structure

* Adjusted path to not be relative

* Altered tsv paths again

* Added CredScan suppressions.

* Fixed suppressions

* Adjusted CredScan folders.

* Altered tsv paths

* Trying another path format

* Trying another path format

* Removed quotes from path

* Added all the desired paths

* Changed delimiter from tab to newline

* Added missing newline

* Fixed tests.
2022-03-10 13:17:46 -08:00
Chris Whitten 4ee10ee7a8
Adds eslint-plugin-security (#2368) 2022-02-03 08:48:31 -08:00
Tony Anziano 0d686b447a
Added script to redirect upstream npm dependency source to internal Azure Artifacts feed (#2363) 2022-01-11 13:16:40 -08:00
Matias Lera ddfe0537b3
[Accessibility] [Screen Reader] Fix the focus on the Get Started with Channel page (#2361)
* Fix focus on Get Started with Channel page

* Added a prop to use as the fist focusable element

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-29 14:03:03 -08:00
Matias Lera f604f3899d
[Accessibility] [Screen Reader] Add a visual message when using the full screen option (#2359)
* Added a visual message when using the toggle full screen menu option

* Updated the messageBox's title
2021-12-29 13:58:08 -08:00
Matias Lera b87d393a81
Added a visual message when clicking the copy button (#2360) 2021-12-28 13:51:53 -08:00
Matias Lera 9094929621
Added a div with the tabIndex attribute to announce the dialog content (#2358) 2021-12-28 11:30:12 -08:00
Matias Lera 0d2775a127
Set tab role on Json button (#2357)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-28 11:28:57 -08:00
Matias Lera a70d259c0c
Added an ariaLabel prop to change the screen reader announcement for Linux (#2356) 2021-12-28 11:22:10 -08:00
Matias Lera 3310e57c55
Set role conditionally for the resource and bot explorer panels (#2353)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-14 14:33:34 -08:00
Matias Lera 2830477961
Fix screen reader announcement when no chat files are available (#2354)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-14 14:24:05 -08:00
Matias Lera 25cc041b95
Added a screen reader announcement for menu shortcut (#2355)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-14 14:17:58 -08:00
Matias Lera c95dbd1183
Added screen reader announcement for active tab in Linux (#2350) 2021-12-06 10:35:29 -08:00
Matias Lera 1853dab788
Fix large text to be displayed properly (#2349)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-06 10:31:57 -08:00
Matias Lera 023d6c262b
Added a notification announcement by using an aria-live region (#2348) 2021-12-06 10:30:13 -08:00
Matias Lera 694023cc1f
[Accessibility] [Keyboard Navigation] Fix the focus on the Retry and Restart conversation buttons (#2342)
* Set the activity Id to fix the focus problem

* Added a prefix to the activityId for debugging purposes
2021-11-30 14:15:07 -08:00
Matias Lera 815456264f
[Accessibility] [Supporting Platforms] Add a tooltip for keyboard navigation to the left panel (#2341)
* Added a tooltip for keyboard navigation

* Updated tooltip styles for each theme
2021-11-30 14:13:47 -08:00
Matias Lera 34e9bf77fc
[Accessibility] [Screen Reader] Fix the screen reader announcement when an invalid URL is entered (#2344)
* Fix invalid url announce

* Updated test case

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-29 17:07:14 -08:00
Matias Lera 863e829d12
Added the shouldUsehighContrastColors property for Linux (#2343) 2021-11-29 17:05:51 -08:00
Matias Lera d7e5ce78d9
Added CSS styling to remove disabled buttons from DOM (#2339) 2021-11-29 16:29:40 -08:00
Matias Lera ffbdf716a1
[Accessibility] [Keyboard Navigation] Enable left panels to focus on the first interactive element (#2334)
* Fixed focus on the first element when opening the Resources and Bot explorer panels

* Renamed prop with a more descriptive name

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-29 10:53:06 -08:00
Matias Lera 544e913c19
[Accessibility] [Keyboard Navigation] Fix luminosity ratio in Bot Explorer list items (#2340)
* Fixed luminosity ratio in bot explorer list items

* Removed duplicated style

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-29 10:30:59 -08:00
Matias Lera 89658341ea
[Accessibility] [Screen Reader] Add a screen reader announcement when the toggle full-screen option is enable or disable (#2338)
* Fix full screen announce

* Fixed linter error

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-29 09:56:47 -08:00
Matias Lera c790ca1d33
Fix add button announce (#2336)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-19 14:58:56 -08:00