Граф коммитов

2943 Коммитов

Автор SHA1 Сообщение Дата
Eugene 0ac4a1c47f
a11y: platform fixes for mac (#2381)
* a11y: 63767 - fix VoiceOver reading whole list content

In Electron/Chrome it reads the whole list content when the list root focused. Add a label to fix the issue.

* a11y: 64009 - improve left pane contrast

Fixes secondary text contrast and improves contrast ratio for primary text for the Left pane.
The bug mentioned some menu contrast issues, I believe the're not existent.
The bug also mentioned JSON contrast. It is already fixed.

* a11y: 64005 - make consistent full-screen handling between all platforms

Includes the following changes:
- Move the popup logic into the command
- Use the command for the native menu

* a11y: switch theme: announce on all platforms

Adds announcement for macOS as well. And makes message to start with visible content.

* Revert "a11y: 64005 - make consistent full-screen handling between all platforms"

This reverts commit 850cd46f32d718efe6cc5a5ec4db9e37f56f033d.

* Revert "a11y: switch theme: announce on all platforms"

This reverts commit 14aea00b857b63ce0eb60cdd35a13dfb7000b9f8.

* a11y: 63887 - make ngrok status accessible

Not able to reproduce the original issue, but found that the ngrok status is not being announced, so added the tunnel status and tunnel errors announcement.

* a11y: 63914 -  rework collapsable content announcement

Prevent lists from being announced when a new entry gets added.

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
2022-04-27 08:51:23 -07:00
Eugene 72e46fe262
a11y: announce theme switching and fullscreen commands (#2380)
* a11y: 64005 -  announce theme and fullscreen commands

* Add announcement for macOS as well.
* And makes message to start with visible content.
* Move fullscreen to the UI commands and add announcement
* Fix tests

* Fix main tests

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-04-26 16:05:57 -07:00
Eugene b3b5cc15ec
a11y: fix platform-specific issues (#2378)
* a11y: use region role for WebChat

VSTS-63988 The default `"complementary"` role cannot be included into another landmark. Use `"region"` role for the chat instead.

* a11y: add menu item role description

VSTS-64729 On linux, when using orca, it doesn't announce an actual role for menu items. Fixed by adding the "menu item" to the `aria-description` property only on linux

* a11y: fix sidebar sections aria

VSTS-64703 Sidebar section toggle buttons had a toolbar role which is not descriptive. Fixed by changing the role to button and adding toolbar around the section action buttons.

* a11y: refactor selected tab indication for orca

VSTS-64523 The selected tab announcement doesn't happen to me when using orca. Changed the approach by using `aria-description` property on linux.

* Fix tests

* fix: better way to get current platform

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
2022-04-25 11:00:44 -07:00
Eugene e8a6d72935
fix: keyboard shortcuts don't work when telemetry and updates dialogs appear together (#2379)
* fix: keyboard shortcuts don't work when telemetry and updates dialogs appear together
Normally, there is no way for a user to open a dialog when another dialog has been opened. However, this occurs when the "Updates available" dialog is opened as a result of the 'update-available' event.

Added a method for waiting for the currently displayed dialog to be hidden, and used it for the "Updates available" dialog.

* Add tests

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-04-18 14:30:02 -07:00
Eugene b7bbdc6ea7
chore: update botframework-webchat to v4.15.1 (#2376)
* chore: update botframework-webchat to v4.15.1

* Run CI

* Kick CI

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-03-30 12:16:21 -07:00
Eugene 135c3a8e09
chore: update critical dependencies (#2373)
* chore: update critical dependencies

* update packages lock

* Fix lint issues

Co-authored-by: Eugene Olonov <v-evolo@microsoft.com>
2022-03-24 16:23:51 -07:00
Tony Anziano acde0c689d
Added CredScan paths for Windows agents (#2372) 2022-03-11 20:42:29 -08:00
Tony Anziano 56e05ed3d9
Added ADO CredScan support. (#2371)
* Added .tsv file for ADO Cred Scan task to use.

* Changed credScanTargetFolders to .tsv extension

* Removed build agent env variables from tsv

* Changed paths in .tsv to try and match the build agent structure

* Adjusted path to not be relative

* Altered tsv paths again

* Added CredScan suppressions.

* Fixed suppressions

* Adjusted CredScan folders.

* Altered tsv paths

* Trying another path format

* Trying another path format

* Removed quotes from path

* Added all the desired paths

* Changed delimiter from tab to newline

* Added missing newline

* Fixed tests.
2022-03-10 13:17:46 -08:00
Chris Whitten 4ee10ee7a8
Adds eslint-plugin-security (#2368) 2022-02-03 08:48:31 -08:00
Tony Anziano 0d686b447a
Added script to redirect upstream npm dependency source to internal Azure Artifacts feed (#2363) 2022-01-11 13:16:40 -08:00
Matias Lera ddfe0537b3
[Accessibility] [Screen Reader] Fix the focus on the Get Started with Channel page (#2361)
* Fix focus on Get Started with Channel page

* Added a prop to use as the fist focusable element

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-29 14:03:03 -08:00
Matias Lera f604f3899d
[Accessibility] [Screen Reader] Add a visual message when using the full screen option (#2359)
* Added a visual message when using the toggle full screen menu option

* Updated the messageBox's title
2021-12-29 13:58:08 -08:00
Matias Lera b87d393a81
Added a visual message when clicking the copy button (#2360) 2021-12-28 13:51:53 -08:00
Matias Lera 9094929621
Added a div with the tabIndex attribute to announce the dialog content (#2358) 2021-12-28 11:30:12 -08:00
Matias Lera 0d2775a127
Set tab role on Json button (#2357)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-28 11:28:57 -08:00
Matias Lera a70d259c0c
Added an ariaLabel prop to change the screen reader announcement for Linux (#2356) 2021-12-28 11:22:10 -08:00
Matias Lera 3310e57c55
Set role conditionally for the resource and bot explorer panels (#2353)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-14 14:33:34 -08:00
Matias Lera 2830477961
Fix screen reader announcement when no chat files are available (#2354)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-14 14:24:05 -08:00
Matias Lera 25cc041b95
Added a screen reader announcement for menu shortcut (#2355)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-14 14:17:58 -08:00
Matias Lera c95dbd1183
Added screen reader announcement for active tab in Linux (#2350) 2021-12-06 10:35:29 -08:00
Matias Lera 1853dab788
Fix large text to be displayed properly (#2349)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-12-06 10:31:57 -08:00
Matias Lera 023d6c262b
Added a notification announcement by using an aria-live region (#2348) 2021-12-06 10:30:13 -08:00
Matias Lera 694023cc1f
[Accessibility] [Keyboard Navigation] Fix the focus on the Retry and Restart conversation buttons (#2342)
* Set the activity Id to fix the focus problem

* Added a prefix to the activityId for debugging purposes
2021-11-30 14:15:07 -08:00
Matias Lera 815456264f
[Accessibility] [Supporting Platforms] Add a tooltip for keyboard navigation to the left panel (#2341)
* Added a tooltip for keyboard navigation

* Updated tooltip styles for each theme
2021-11-30 14:13:47 -08:00
Matias Lera 34e9bf77fc
[Accessibility] [Screen Reader] Fix the screen reader announcement when an invalid URL is entered (#2344)
* Fix invalid url announce

* Updated test case

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-29 17:07:14 -08:00
Matias Lera 863e829d12
Added the shouldUsehighContrastColors property for Linux (#2343) 2021-11-29 17:05:51 -08:00
Matias Lera d7e5ce78d9
Added CSS styling to remove disabled buttons from DOM (#2339) 2021-11-29 16:29:40 -08:00
Matias Lera ffbdf716a1
[Accessibility] [Keyboard Navigation] Enable left panels to focus on the first interactive element (#2334)
* Fixed focus on the first element when opening the Resources and Bot explorer panels

* Renamed prop with a more descriptive name

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-29 10:53:06 -08:00
Matias Lera 544e913c19
[Accessibility] [Keyboard Navigation] Fix luminosity ratio in Bot Explorer list items (#2340)
* Fixed luminosity ratio in bot explorer list items

* Removed duplicated style

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-29 10:30:59 -08:00
Matias Lera 89658341ea
[Accessibility] [Screen Reader] Add a screen reader announcement when the toggle full-screen option is enable or disable (#2338)
* Fix full screen announce

* Fixed linter error

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-29 09:56:47 -08:00
Matias Lera c790ca1d33
Fix add button announce (#2336)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-19 14:58:56 -08:00
Matias Lera d928289b12
Removed the default button from the message box (#2335) 2021-11-19 14:58:00 -08:00
Matias Lera 2f57d69b21
Added a message box after copying the JSON (#2333)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-19 14:38:38 -08:00
Matias Lera a8f3254afa
Added support for screen reader announcement when the panel is collapsed/expanded (#2332) 2021-11-19 14:22:47 -08:00
Matias Lera a09833d1b0
[Accessibility] [Screen Reader] Show message after saving the transcripts in the Live Chat panel (#2331)
* Added message display to save transcript button

* Updated test case for save transcript feature
2021-11-18 09:50:03 -08:00
Matias Lera e8c17cb591
External/southworks/fix/settings/fix split screen (#2330)
* Fix split screen view on settings tab

* Replace legend tags and use span instead

* Added legend constant

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-16 14:43:18 -08:00
Matias Lera 9cde6af82c
[Accessibility] [Keyboard Navigation] Fix focus on the Live Chat tab (#2329)
* Added ref and focus features to tab component

* Removed focus from caret icon on first load

* Removed focus from the restart conversation button

* Removed unused test case

* Fixed linter error
2021-11-16 10:57:18 -08:00
Matias Lera 5cf0ad2093
Set focus to the first focusable element in the screen (#2328) 2021-11-15 12:11:55 -08:00
Matias Lera 3abfc6ae48
Rollback aria-required and modify required property on textField class (#2327)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-15 12:08:54 -08:00
Matias Lera 373e8b0e2e
Fix hide control announce (#2326)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-15 12:05:46 -08:00
Matias Lera e015430bc7
Fix focus indicator (#2325)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-15 12:04:16 -08:00
Matias Lera 114ca4fa91
Added region role to avoid announcing the element as a list (#2324) 2021-11-15 10:30:05 -08:00
Matias Lera 1a7522945e
Remove region role (#2323)
Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-11-15 10:01:23 -08:00
Tony Anziano 499cbe271b
V4.14.1 (#2322)
* Prepped v4.14.1 release

* Modified change log for clarity

* Adjust changelog to reflect date
2021-11-15 10:00:55 -08:00
Tony Anziano 608f7c23a3
Fixed blank inspectors due to new contextIsolation default value (#2321)
* Fixed blank inspectors due to new contextIsolation default value in Electron 13

* Added changelog entry
2021-11-11 13:37:13 -08:00
Tony Anziano 0a756998ad
Moved next() in handler to fix early HTTP response termination. (#2320)
* Moved next() in handler to fix early HTTP response termination.

* Added changelog entry

* Omit unnecessary next call from route handler

* Fixed tests
2021-11-11 12:37:29 -08:00
Tony Anziano 3226464f8e
Bumped electron to 13.6.1 (#2318)
* Bumped electron to 13.6.1

* Added changelog entry

* Fixed broken test.

* Updated electron-builder, electron-rebuild, and keytar

* Added missing npmlog dependency

* Bumped electron-builder to 22.11.4

* Downgraded electron-builder back to 22.9.1

* Downgraded electron-rebuild and keytar to previous versions

* Updated package-lock

* WIP of new electron download script

* Fixed download script

* Pulled electron-builder config out into a function that generates plat-specific config
2021-11-11 09:07:08 -08:00
Matias Lera ed0b611033
[Accessibility] [Screen Reader] Enable the screen reader to announce when nodes are expanded and collapsed in the JSON tree view (#2299)
* Added screen reader announcements when nodes are expanded and collapsed.

* Added a new line at the end of the file

* Added a comment
2021-10-27 14:01:25 -07:00
Matias Lera 15c552c853
[Accessibility] [Screen Reader] Fix the Ngrok status viewer heading (#2301)
* Fixed Ngrok status viewer heading

* Removed extra space

Co-authored-by: Federico Bernal <64086728+FedericoBernal@users.noreply.github.com>
2021-10-25 10:02:42 -07:00
Matias Lera 3e6695b730
[Accessibility] [Screen Reader] Fix keyboard navigation using the screen reader in the 'Open a bot' dialog (#2302)
* Fix bot URL role

* Fixed keyboard navigation on empty edit boxes
2021-10-25 10:01:27 -07:00