- Legalization is required to propagate the correct type of the OpLoad even when
the resource variables are not being passed or assigned
- This fixes a validation error in simple shaders using image_format, where legalization
would not be needed otherwise
Co-authored-by: Atte Seppälä <atte.seppala@ul.com>
The existing DXC cannot a flatten descriptor array when an instruction
accesses it using a variable index, because spirv-opt
--descriptor-scalar-replacement pass did not support it. spirv-opt
recently added --replace-desc-array-access-using-var-index that replaces
accesses to descriptor arrays using variable indices with accesses to
constant elements using switch statements. This commit uses the newly
added pass to support flattening all descriptor arrays.
* Conditionalize dxilconv pass inclusion in opt
DXC can be built without dxilconv, so we need to handle the case
where dxilconv is not included but we still want opt for lit tests.
We will also need to surface dxilconv as a lit feature, but that can
come later when I get the lit tests running.
* Fixing dependencies for IR and DXIL libs
IR doesn't actually need dxil, and dxil doesn't actually need IPA.
* Enable building LLVM testing tools
This gets a bunch of the LLVM testing tools building, which allows us
to run the LIT tests (which have a lot of failures)
* Fixing broken Linux and Windows builds
* Removing a change that snuck in.
* Adding line ending settings to .gitattributes
This should make it so that cmd and bat files are always crlf and sh and
config.guess are always lf.
* Kicking this file...
* Undoing the last change
* Changes to get LLVM unit tests building
This change gets the LLVM unit tests building again and running through
LIT via the `check-llvm-unit` target.
This change does not have the tests passing! Subsequent changes will
get the unit tests passing. This change also disables some tests where
the LLVM code is no longer used and making those tests work will
require substantial effort.
* Changes to get Clang unit tests building
This change gets the Clang unit tests building again and running
through LIT via the `check-clang-unit` target.
This change does not have the tests passing! Subsequent changes will
get the unit tests passing. This change also disables some tests where
the Clang code is no longer used and making those tests work will
require substantial effort.
* A few extra Windows fixes
This adds some missing APIs to the Windows Filesystem code and adds an
option to hctbuild to enable building the LLVM & Clang unit tests.
* Disable libClangFormat tests
These tests are a bit gnarly to repair... unless we really start using
the format library we probably just want to disable these tests.
* Restore lit and googletest sources from LLVM 3.7.0
This commit just re-adds sources that were removed somewhere along the
way.
* Pull in googletest & googlemock from LLVM 4.0
Googlemock was introduced in LLVM 4.0, and is used by SPIR-V's tests.
This pulls in the LLVM 4.0 version of GoogleTest and GoogleMock to
replace the external submodules.
LLVM's version of GoolgeTest and GoogleMock have some minor extensions
to work better with LIT for error reporting and producing cleaner test
output.
* Remove external googletest
* Fix lit to handle comment in gtest names
This fix came into LLVM with the updated googletest in a977582dead2
* Ignore raw_fd_ostream errors when not closing
There's some odditites with the changes in the filesystem code that
cause this to error sometimes in unit tests. Until we can dedicate time
to looking into the filesystem code, just swallow that error...
* Fix bot failure
Missed an option change.
* Fixing MSVC build failure
* A cleaner build fix
This should address issues with VS 2019 in a cleaner way.
* Fix build
This commit generally only adds those instructions that intersect with
OpenCL.DebugInfo.100, although it does also add generation of
new DebugFunctionDefinition to tie DebugFunction to function.
Co-authored-by: baldurk <baldurk@baldurk.org>
* [templates] Instantiate HLSL Annotations
When instantiating decls, the HLSL annotations should be carried over
for any NamedDecls that have them.
This change resolves#4003
* Add test case covering HLSL annotations
This just adds a test case that covers a wide swath of HLSL annotations
and verifies that they all instantiate correctly.
For the DirectX match we need an exact match otherwise this will match
against the `dxil` arch or `dxbc` as an object format (if we add it).
This will resolve a falure in the triple normalization unit test.
RsourceDescriptorHeap and SamplerDescriptorHeap were predefined in all
shader models, not just 6.6+. By checking the shader model version
before declaring them, we can limit this to relevant shader models.
Added tests for 6.6 and 6.5 behavior when these are redefined
This bug has been latent for a long time, and was exposed by getting
the unit tests running again. When resizing the buffer we were not
copying all the bits. That's bad...
* Enable building llvm-dis
llvm-dis is a lightweight tool for reading IR modules as bitcode and
dumping them as textual IR. It is useful for debugging and verification
of bitcode-related issues.
This patch just re-enables the llvm-dis build and updates the code to
build cleanly on *nix systems.
* Fix broken windows build
I need to cleanup the WinIncludes usage, but that can be a seprate PR.
The reflection calculation involves a multiply by two that was always
float, which caused an internal assert when the variable was not float.
Now the constant uses the type of the other operand
When resolving template argument types if the originating type is a
literal type (i.e. `literal float` or `literal int`), we should instead
substitute the appropriate 32-bit type.
This change is two pieces:
The first translates template arguments from `literal <x>` into the
appropriate 32-bit type after deduction but before generating the
instantiated decl for non-builtin templates.
The second part allows `literal <x>` template parameters to match
against the appropriate instantiated 32-bit types.
This resolves#3973.
* Revert "Fix crash in Sema::CheckDerivedToBaseConversion when Paths is
empty. (#3327)"
This reverts commit 2903170ac5, but keeps
the test case, as the test case is important.
* Generate FlatConversion for buffer member access
ConstantBuffers and TextureBuffers need to behave at the AST level as
if they implicitly convert to the underlying buffer data type.
We do this when generting the AST, but we don't have the proper
overrides in place in `Sema::PerformObjectMemberConversion`.
This is the root cause of issue #3327, so this change should be layered
on a revert of 2903170ac.
This also addresses #3972.
'beanz/beanz/constant-buffer-template-issue-3972'.
../tools/clang/test/HLSLFileCheck/hlsl/template/BufferInExpansion.hlsl
'beanz/beanz/constant-buffer-template-issue-3972'.
../tools/clang/test/HLSLFileCheck/hlsl/template/BufferInExpansion.hlsl
'beanz/beanz/constant-buffer-template-issue-3972'.
../tools/clang/test/HLSLFileCheck/hlsl/template/BufferInExpansion.hlsl
Several instances of handling token strings made the assumption that
the strings were null terminated though they were not necessarily.
By changing the processing to using the full StringRef, the length is
used and the potential for reading invalid characters is eliminated
64-bit linux has 8 byte longs where Windows always uses 4 bytes. As a
result, the strings that exceeded the maximum 32-bit representation on
such platforms were not failing for extreme space/register values as
expected
CMake supports passing in CMake scripts via the `-C` command line
option, which can set CMake cache variables to initialize options
before the first CMakeLists file is processed. This is a portable and
shell-agnostic way of supporting what the
`cmake-predefined-config-params` file is used for.
Clang has added new warnings for possible unintended string
concatenations. When concatonating strings in an array literal warpping
the concatenation in parentesis quiets the warning.
These changes are a result of prototype work in PIX to support shader debugging for DXR,, which was an exercise to figure out how to support libraries in general in PIX. These changes are the result. It's all about iterating over all the library functions, rather than "the" entry point function.
In addition, to have something concrete to submit to a driver, there's the addition of codegen for the shader debugging "prolog", which chooses at runtime whether or not to emit instrumentation data for a given shader invocation based on its (in this case) thread id. This last is not yet ready for production in PIX, in that it is necessary but not sufficient to enable DXR shader debugging.
Before module serialization, constant users of resource globals could themselves have multiple constant users. These could be consolidated through module serialization/deserialization, leading to a difference when only the first constant user was followed. The difference could lead to a validation failure only with external validator (DXIL.dll) since reconstructed RDAT would not match the original RDAT with the missing use. This would happen in cases such as identical constant indexing of resource arrays from multiple entries.
Also, fix groupshared usage detection when setting function compat flags for RDAT.
Enables the associated feature flags when 2021 is selected. Also adds a
feature flag for bitfields.
Add to all feature tests a variant that uses -HV 2021
Made some small changes to a template test that relied on vector
operands with binary logical operators
[SPIRV] Add support of the GL_EXT_spirv_intrinsics
Related to the issue: https://github.com/microsoft/DirectXShaderCompiler/issues/3919
Add these attributes
vk::ext_capability
vk::ext_extension
vk::ext_instruction
vk::ext_reference
vk::ext_literal
Note this commit allows the redeclaration of a HLSL intrinsic function using a function declaration with `vk::ext_instruction`.
Co-authored-by: Jaebaek Seo <jaebaek@google.com>
PIX's mesh shader output instrumentation needs to disambiguate groups of mesh shader invocations, so that PIX can reconstruct the intended mesh after the fact. In the case where an amplification shader is present, the previous code was incomplete: it included only the X value of the mesh shader's group ID relative to the AS DispatchMesh call. The full XYZ value is needed. Unfortunately, this value does not necessarily fit into a single DWORD for returning to PIX via the instrumentation, but various spec constraints mean that the product of the group ID cube's dimensions will fit in a DWORD.
So this change expands the custom data added to the AS->MS payload to include the Y and Z group counts that the AS passed to DispatchMesh. The mesh shader can then multiply its group ID's component values by these counts in order to come up with a single unique group ID value.
Atte Seppälä
JiaoluAMD
Chris B
Jaebaek Seo
Greg Fischer
Xiang Li
Vishal Sharma
Chris B
Helena Kotas
Greg Roth
Adam Yang
Chris B
Jeff Noyle
Grace Jennings
Tex Riddell