VK_KHR_buffer_device_address extension support a Vulkan feature to load data
from an arbitrary raw buffer address. We added
'uint vk::RawBufferLoad(uint64_t address)' before, but it is limited to loading data
with the unsigned integer type.
This commit adds
'T vk::RawBufferLoad<T = uint>(uint64_t address [, uint alignment = 4] )' that
allows us to load data with an arbitrary type.
This mistake was upsetting a certain driver. The UAV being declared is always u0 in space -2. Also changed the name of one struct type to make it more obvious what PIX had added.
authored-by: Jeff Noyle <jeffno@ntdev.microsoft.com>
Enable NRVO when no precise and global coherent to avoid extra memcpy created in clang codeGen.
Also propagate precise from the function to named return value.
* Complete builtin types when used as array params
This is an odd edge case.
C doesn't require array element types to be complete because they decay
to pointers. In HLSL we don't decay to pointers, so we need them to be
complete, otherwise things trip up.
* Fixing code comment
One of these days I'll learn how to write what I mean...
According to the SPIR-V validator this annotation was last usable on
SPIR-V 1.3:
fatal error: generated SPIR-V is invalid: 2nd operand of Decorate: operand BufferBlock(3) requires SPIR-V version 1.3 or earlier
OpDecorate %type_ByteAddressBuffer BufferBlock
note: please file a bug report on https://github.com/Microsoft/DirectXShaderCompiler/issues with source code if possible
The visitor was originally built to remove/omit it on Vulkan 1.2 and
higher only, but since supporting Vulkan 1.1 with SPIR-V 1.4 (in #4364)
- which conveniently sits inbetween SPIR-V 1.3 and Vulkan 1.2 - the
check must be made more stict and apply from SPIR-V 1.4 universal
onwards.
Since we check for the "SPIR-V 1.4 (under Vulkan 1.1 semantics)"
minimum target environment for ray tracing extension use, this change
allows it to be now configured as a target-env via command line options.
Some out of date documentation target environments is also updated,
and improvements are made to version checking to use enums rather
than string comparisons.
Fixes#4313
Currently, DXC assigns new locations for each stage variable. When there
are lots of stage variables, the number of locations we use can exceed the
maximum location limit. This commit uses `Component` decoration to pack
signature and reduce the number of locations DXC uses.
SPIR-V backend finds the source code by reading the source file,
which does not work when we pass the source code via memory
buffer. This commit adds a fallback for the case.
Fixes#4218
Implement first part of support for a passthrough compute shader.
This iteration translates the HLSL resources used in a simple
passthrough compute shader (ByteAddressBuffer and RWByteAddressBuffer)
to the appropriate SPIR-V module variables. Errors are emitted for
unhandled instructions.
Compare the expected and generated error output for whole file check
tests. For existing tests, these should be empty, but upcoming tests
will check expected errors as we iterate towards passthrough compute
shader support.
* Added a DXC_OUT_REMARKS kind that prints to stdout in dxc.
Moving -Vi and -H displayed include process from warnings to DXC_OUT_REMARKS.
* Adding a Compiler Test to check DXC_OUT_REMARKS output text
A couple of minor changes to support PIX shader debugging for hull shaders generated by the 11on12 mapping layer for DXBC originals.
Co-authored-by: Jeff Noyle <jeffno@ntdev.microsoft.com>
When the specific target environment required is exactly
SPV_ENV_VULKAN_1_1_SPIRV_1_4, then make the error message explicitly
note that it is met by Vulkan 1.1 with Spirv 1.4 (rather than simply
requiring Vulkan 1.2).
Fixes#4313
* Add -arm64 to hcttest; exclude one more test with issues on ARM64 & WARP
* DXC arm64 fixes - testing before pushing to GitHub
* Exclude DenormTertiaryFloatOpTest
* ARM64EC fixes, no parallel for ARM64
* Disable crashing test; exclude only denorm preserve tests with issues
- added *.dxo.converted to the list of extensions ignored by git
- renamed 3 test outputs from .fxc to .dxbc (which will make them to be ignored by git)
Add SPIR-V validation after the module is generated, and apply some
fixes required for validation to succeed with a passthrough pixel
shader:
- Add execution mode
- Decorate with SPIR-V Locations
- Refactor some LowerTypeVisitor logic to a util function that is shared with
dxil2spv
- Remove extra pointerness on stage IO vars now that it is handled by
the above pass
{s|u}norm and {row|column}_major modifiers shouldn't have been added to
the block of basic types for parsing init-style cast expressions. When
hitting one of these cases, ParseCXXSimpleTypeSpecifier hits unreachable:
default:
llvm_unreachable("Not a simple-type-specifier token!");
Valid uses of these modifiers are parsed elsewhere. If we hit these
keywords here, they are not a valid expression, so goto tok_default_case
instead, which will produce normal errors instead of the internal error.
While we're at it, update VerifierHelper.py to fix issues, and update tests
to run clean with VerifierHelper.py all *.
DXBC containers from some sources may have signature parts with unaligned sizes, such as from 9on12.
This change pads these signature parts when this is the case to avoid any
problems down the line.
Add support for integer sampling as part of advanced texture ops in
Shader Model 6.7. This includes adding static border colors and allowing
integer resource types to be used by all Sample* operations through
Sema, Dxil generation, and validation when 6.7 is available.
Adds root signature compilation and filecheck testing.
Translate a DXIL entry function to a SPIR-V entry function. This is
currently only supporting the few types and instructions needed to
create the entry function for a simple passthrough pixel shader.
Read DXIL file directly into llvm::MemoryBuffer rather than through an
IDxcBlobEncoding. This also allows support for supplying file by STDIN
(not yet with dedicated CLI).
Also clean up some CMake LLVM dependencies.
* Make external sema source handle type completion
Prior to this change the HLSL built in types are inserted into the AST
during initialization as complete types missing their methods. The
method implementations are then inserted during parsing when handling
declarators and parameter declarations of the built in types.
This method of lazy expansion does not work with HLSL templates because
template declarators in dependent contexts are not handled by the
parser, so they bypass the code path that generates method definitions
(see #4315).
This change alters how we lazy initialize types. Instead of
lazy-initializing in parsing, this change lazy initializes when the
type is required to be complete. This is accomplished by creating the
built in type objects as incomplete decls, and adding an override for
`CompleteType` to the `HLSLExternalSource`.
This change simplifies our code because we can use the type's
`IsCompleteDefinition` flag to track types that have been completed
instead of our own bitmask system.
Fixes#4315
* Nest second isCompleteDefinition check
This will trigger in most but not all cases, so I can nest it under the
condition that triggers it to have a potentially different result.
* Clean up debug preprocessor macros
This change removes the `DBG` macro value in favor of `NDEBUG`, and
also converts many uses of `_DEBUG` with `NDEBUG`.
_DEBUG is set by MSVC when debug information generation is enabled.
NDEBUG is set by CMake debug configurations and by LLVM on all
configurations when `LLVM_ENABLE_ASSERTIONS` is set.
Aligning with LLVM's NDEBUG usage allows a consistent pattern
throughout the codebase.
* Address PR feedback
Without this change, during DxilValueCache::ProcessAndSimplify_PHI,
MayBranchTo will return false for switch. If all but one case or default
block are collapsed into the switch's successor's phi (by simplifycfg), this
causes DxilValueCache to assume the remaining branch is the only predecessor
to the phi. If the corresponding incoming value is constant, DxilValueCache
will assume that's the only possible value, replacing the phi with the
constant.
With the change, MayBranchTo will return false only when a switch with a
constant condition would branch to a different successor.
The test was assigning a pixel shader that didn't exist due to the
conversion of mistaken code that was harmless in the previous form, but
results in an error message in the new.
A mipmapped texture containing the value of LOD at each location in each
level is used to sample at each level using SampleCmpLevel and confirm
that the correct level is used for the comparison.
Additionally, the result of SampleCmpLevelZero is compared to the
SampleCmpLevel equivalent
A texture containing an encoded value representing the X,Y location is
used to retrieve values at various samples using the 8 methods that
newly allow programmable values. Each result is compared to what is
expected based on the given coords and offsets.
Xiang Li
Adam Yang
Natalie Chouinard
Jaebaek Seo
Jeff Noyle
Chris B
Marijn Suijten
Grace Jennings
Helena Kotas
Tex Riddell
Greg Roth
Joshua Batista
Lukas Hermanns