* Modified script to also remove pragma warnings.
This also includes modifying the scope of the pragma removal.
Previously this script only searched inside the ./src/include/LightGMB directory.
This was not inclusive enough to remove the warnings in files shown in the ticket.
* Adds CI test that exits if unknown pragma warnings are present.
* Expanding pragma removal to cpp and hpp files.
* Update .ci/test_r_package.sh
Removing unneeded conditions since this script will only run on Linux and Mac builds anyway.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* Update .ci/test_r_package.sh
Fixes typo
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* replacing double quotes with single quotes
* Using a more portable find syntax so it works on macOS and Linux
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* [R-package] [ci] Make Windows CI fail if R CMD check fails
* restore fix
* catch more errors
* remove testing
* fix processx calls
* try to get status code
* more logs
* trying something
* stuff
* previous changes
* uncomment
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* Initial CUDA work
* redirect log to python console (#3090)
* redir log to python console
* fix pylint
* Apply suggestions from code review
* Update basic.py
* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* Update c_api.h
* Apply suggestions from code review
* Apply suggestions from code review
* super-minor: better wording
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>
* re-order includes (fixes#3132) (#3133)
* Revert "re-order includes (fixes#3132) (#3133)" (#3153)
This reverts commit 656d2676c2.
* Missing change from previous rebase
* Minor cleanup and removal of development scripts.
* Only set gpu_use_dp on by default for CUDA. Other minor change.
* Fix python lint indentation problem.
* More python lint issues.
* Big lint cleanup - more to come.
* Another large lint cleanup - more to come.
* Even more lint cleanup.
* Minor cleanup so less differences in code.
* Revert is_use_subset changes
* Another rebase from master to fix recent conflicts.
* More lint.
* Simple code cleanup - add & remove blank lines, revert unneccessary format changes, remove added dead code.
* Removed parameters added for CUDA and various bug fix.
* Yet more lint and unneccessary changes.
* Revert another change.
* Removal of unneccessary code.
* temporary appveyor.yml for building and testing
* Remove return value in ReSize
* Removal of unused variables.
* Code cleanup from reviewers suggestions.
* Removal of FIXME comments and unused defines.
* More reviewers comments cleanup.
* More reviewers comments cleanup.
* More reviewers comments cleanup.
* Fix config variables.
* Attempt to fix check-docs failure
* Update Paramster.rst for num_gpu
* Removing test appveyor.yml
* Add CUDA_RESOLVE_DEVICE_SYMBOLS to libraries to fix linking issue.
* Fixed handling of data elements less than 2K.
* More reviewers comments cleanup.
* Removal of TODO and fix printing of int64_t
* Add cuda change for CI testing and remove cuda from device_type in python.
* Missed one change form previous check-in
* Removal AdditionConfig and fix settings.
* Limit number of GPUs to one for now in CUDA.
* Update Parameters.rst for previous check-in
* Whitespace removal.
* Cleanup unused code.
* Changed uint/ushort/ulong to unsigned int/short/long to help Windows based CUDA compiler work.
* Lint change from previous check-in.
* Changes based on reviewers comments.
* More reviewer comment changes.
* Adding warning for is_sparse. Revert tmp_subset code. Only return FeatureGroupData if not is_multi_val_
* Fix so that CUDA code will compile even if you enable the SCORE_T_USE_DOUBLE define.
* Reviewer comment cleanup.
* Replace warning with Log message. Removal of some of the USE_CUDA. Fix typo and removal of pragma once.
* Remove PRINT debug for CUDA code.
* Allow to use of multiple GPUs for CUDA.
* More multi-GPUs enablement for CUDA.
* More code cleanup based on reviews comments.
* Update docs with latest config changes.
Co-authored-by: Gordon Fossum <fossum@us.ibm.com>
Co-authored-by: ChipKerchner <ckerchne@linux.vnet.ibm.com>
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* Use Ubuntu Focal image at Travis
* test gcc
* test Bionic and gcc
* test Focal with another Python version for GPU test
* revert testing changes
* install linkchecker via pip
* simplify linkchecker config
* [R-package] make package installable with CRAN toolchain (fixes#2960)
* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* remove GPU stuff
* use wildcard to find objects to build
* use -lomp
* build configure before moving files
* using wildcard for objects
* Update .github/workflows/main.yml
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* add explicit objects back
* reduce allowed R CMD check NOTEs and catch stderr from build-cran-package on Windows
* fixing things
* pin autoconf version
* show diff
* add automake back
* run less checks
* command was in the wrong place
* fix autoconf version
* change strategy for handling configure
* fix Rbuildignore
* fix NOTEs
* fix notes about unrecognized files
* fixing extra files
* remove USE_R35
* add OpenMP check for Mac CRAN build
* run all checks
* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* suggestions from code review
* undo indenting
* remove 03 from Makevars.win.in
* update language about OpenMP in configure script
* checking if configure.ac check works
* add autoconf back
* remove testing code in configure.ac
* more fixes for CI on configure script
* print git diff
* add VERSION.txt when checking configure
* fix relative paths
* remove git diff
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* [ci] [R-package] catch builds that have not updated docs
* drop reliance on .Renviron
* remove docs changes
* Update .ci/test_r_package.sh
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* make all R tasks start with r-package
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* [R-package] replaced gendef.exe with R code to create R.def (fixes#3064)
* fix broken things
* trying to add R4.0 docs
* changed make
* fixing make paths
* update notes on environment variables
* fix linting
* fixes to CI
* fixing build_cmd and other stuff
* fix bad substitution
* fix Azure Linux builds
* I am bad at bash
* simplifying
* only testing R
* getting better logs
* mingw32
* docs
* toolchain
* using msys
* fix visual studio condition
* toolchain test
* full CI
* fix if-elses
* bump allowed NOTEs
* search for Rscript
* updates to docs
* use processx
* fix mismatched arguments
* move CI to GitHub Actions
* minor changes
* fix workflow file
* fix templating
* fix Azure DevOps
* debugging windows builds
* dont shQuote file name
* all GitHub Actions jobs
* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* minor cleanup
* remove objdump printing
* make file.remove() invisible
* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* reduce duplicated paths in docs
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* GitHub Actions
* ok
* fixing on list
* stuff
* directories
* directories
* things
* env variables
* working dir
* running a bunch of tasks
* more builds
* PATH
* actually use R task
* TASK
* be right, often
* doing stuff
* trying stuff
* more paths
* conda activate
* updating PATH
* trying bash
* where the hell is activate
* WHERE IS ACTIVATE
* set up conda
* more conda
* PLEASE WORK
* installing cpplint
* try r-package
* R version
* try windows job
* make windows work
* use powershell
* exe
* use conda
* conda init powershell
* different conda approach
* make it work
* cleaning up
* init powershell
* fixing windows
* more windows
* build directory
* no way right
* maybe it will work
* trying Visual Studio
* do this
* Windows is interesting
* put back check-output
* set compiler
* stuff
* more fixes
* fix the broken things
* updating jobs
* continuing
* poweshell is bad
* ok so maybe not powershell
* cmon now
* ok so
* fixing env variables
* maybe this
* MINGW job
* cleaning up
* conda init powershell
* moving more R stuff into GitHub Actions
* everything else
* use powershell
* cmon now powershell
* ttry to Continue
* override powershell
* peg MiKTeX URL
* what is happening
* try powershell -File
* trying stuff
* path
* more testing of output
* Matches uppercase
* more regex stuff
* this is getting ridiculous
* back to powershell I guess
* more commands
* this might work
* adding more reliable miktex download
* trying to download miktex
* installing httr
* fix error in MiKTeX script
* remove comments
* redirect output
* redirect output
* move linting back to Travis
* change redirection
* switch back to just mac and linux
* put linting exclude back
* renamed R_TRAVIS_LINUX
* revert changes to non-R tasks and update events
* simplify
* Path smoothing
* Try to fix issue with gpu version.
* Fix failing CI for R package.
* Minor fixes.
* Minor refactor.
* Restore old code to get CI working.
* Fix style issues.
* Fix ci for R package.
* Minor fixes for docs and code style.
* Update docs.
* first test of appveyor
* strings are strings
* lil bit of build script
* fixing paths
* removed unnecessary file
* updated CRAN URL
* added a lot more printing
* fixing paths
* more stuff
* fixed paths
* more stuff
* more path guessing
* even more paths
* more stuff
* moar logz
* and now for something totally different
* please work
* ok could be a thing
* changing directories
* we might be in business
* fixed install syntax
* tryinv mingw
* more mingw
* ignore Suggests check
* trying Azure DevOps
* just run bare minimum for Azure DevOps
* fixed build dir thing
* trying to set libPaths
* more testing
* trying R 3.6.3
* R 3.6.3
* this feels right
* still messing around with libraries
* more paths
* removed duplication in Windows testing code
* simpler
* fixed conda stuff
* more conda stuff
* more fixes
* fixed testing script
* moved AppVeyor setup to the top
* commenting
* ch-ch-ch-ch-chaaaanges
* paths
* plz work
* fixed conda stuff in Windows CI
* uncommented stuff to test a full build
* fixed quotes and removed some unnecessary stuff
* added install.libs.R change
* quotes are impoortant
* added commented-out stuff back in
* added Windows script, download retries, and MSVC linking
* minor fixes
* cleaned up debugging code in FindLibR
* cleaned up debugging code and moved R first in CI
* fixed vsts-ci indentation
* cut documentation stuff out of MSVC build
* fix R CMD check for Azure
* misc whitespace changes
* Added echoing of build logs from R CMD check
* cut out more documentation tests
* fixed NOTE about imports from Matrix
* moved some changes out of this PR and into #2963
* fixed whitespace stuff
* added check on number of NOTES
* adding better checks
* fixing check on NOTEs
* removing unnecessary variable
* Update .ci/test_r_package_windows.ps1
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>
* some changes
* fix quoting
* trying MINGW on Azure DevOps
* fixing paths
* more paths
* fixing paths
* testing paths
* fixing slashes
* pinned CTAN mirror
* get better logs
* made sure Azure finds MinGW, fixed search for LIBR_CORE_LIBRARY, stopped building R docs on Azure
* Apply suggestions from code review
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>
* added CXX, CC for Windows builds and changed back to building docs on all MINGW builds
* stored LIBR_CORE_LIBRARY hints in one variable
* Apply suggestions from code review
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>
* changes from code review
* increased parallel builds for Azure CI
* Apply suggestions from code review
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* Revert "specify the last supported version of scikit-learn (#2637)"
This reverts commit d100277649.
* ban scikit-learn 0.22.0 and skip broken test
* fix updated test
* fix lint test
* Revert "fix lint test"
This reverts commit 8b4db0805f.
* Added more linters on R code
* started working on implicit integers
* finished style changes to handle implicit integers
* regenned documentation and added concatenation linter
* changed channel for r-lintr
* try building stringi before lintr
* trying to get libicui18n
* trying another thing
* trying conda-forge again
* added re-install of stringi
* uncommented other stages
* Update .ci/test.sh
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>
* removed apt update and changed lintr version floor
* get lintr from CRAN
* R needs to come before C++ linting
* testing lintr install from CRAN
* trying one more thing
* more verbose
* order might matter
* removed commented code
* cleaned up linting block in test.sh
* grouped conda install calls and fixed a few integer array things
* moved clang linking commands to docker
* switch to dev container
* test: switch compilers
* switch compilers back
* switch back to production container
* compile SWIG artifact on Windows
* compile SWIG artifact on Windows
* combined swig and sdist jobs for Linux
* added conditions for artifacts publishing
* added SWIG artifact compilation on macOS
* hotfix
* test: switch compilers
* harsh workaround for OpenMP library conflict
* switch compilers back
* consistent order of tasks in condition
* dummy commit to trigger CI and fix CLA
* use file to install deps for docs
* added C_API docs
* use breathe without exhale
* added missed params descriptions and make Doxygen fail for warnings
* escape char hotfix
* ignore unknown directive for rstcheck
* better handle env variable
* hotfix for 'Unknown directive type' error with C_API=NO
* Update .gitignore
* fixed pylint
* use already defined constants in conf.py
* do not suppress Doxygen's output
* addressed review comments
* removed unneeded import
* added job for swig compilation on Linux with artifacts
* hotfix
* test: SWIG with Clang compiler
* switch compiler back to gcc
* switch to main docker
* set platform via A option
* style hotfix
* updated R installation script
* updated Python installation script
* updated CI test script
* provide VS version-ingependent link for redistributables download
* added link to VS 2019 redistributables
* added VS 2019 match for Boost binaries
* added fix for OpenMP on macOS into test script
* test: AppleClang on Travis
* use Mojave on Travis
* bash hotfix
* get back to gcc compiler on Travis macOS
* updated boost submodule
* updated docker with new stable Clang and CMake
* switch to dev docker
* updated setup script
* updated MinGW on Appveyor
* updated Azure config to use docker for GPU task
* do not upgrade gcc - takes too long
* test: switch compilers
* switch compilers back
* get back to main docker
Josh Maxwell
James Lamb
Chip Kerchner
Nikita Titov
Guolin Ke
Belinda Trotta
Nikita Titov
nabokovas