Граф коммитов

2767 Коммитов

Автор SHA1 Сообщение Дата
Nikita Titov c3ff187163
[ci] use pure `endif()` and `endfunction()` without expression inside in `CMakeLists.txt` (#4798)
* Update CMakeLists.txt

* Update FindLibR.cmake
2021-11-13 12:55:22 -06:00
david-cortes 2f59773d76
[R-package] Add `print()` and `summary()` methods for Booster (#4686)
* add print and summary S3 method

* correct wrong signature

* attempt at bypassing linter

* Update R-package/R/lgb.Booster.R

Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/src/lightgbm_R.h

Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update include/LightGBM/c_api.h

Co-authored-by: James Lamb <jaylamb20@gmail.com>

* add more tests

* linter

* don't pluralize single tree

* remove duplicated function

* update changed function name

* missing declaration

* Update lightgbm_R.h

* Update R-package/tests/testthat/test_lgb.Booster.R

Co-authored-by: James Lamb <jaylamb20@gmail.com>

* accommodate custom objectives in print

* linter

* linter

Co-authored-by: James Lamb <jaylamb20@gmail.com>
2021-11-13 11:30:44 -06:00
Nikita Titov 6e6fb14cdf
[docs] fix broken SynapseML link (#4795) 2021-11-13 06:14:16 +03:00
Roman Shaptala 6cbb3586b9
[python] Faster categorical column names selection (#4787)
* Faster categorical column names selection (#1)

* Faster categorical column names selection

Change slow and redundant dataframe query by select_dtypes into a dataframe.dtypes list comprehension

* Update compat with CategoricalDtype

* sort imports

* import CategoricalDtype from pandas.api.types

* add categorical import try/except
2021-11-12 10:24:46 +08:00
Michael Mahoney 3b6ebd794b
Add 'nrounds' as an alias for 'num_iterations' (fixes #4743) (#4746)
* Add 'nrounds' as an alias for 'num_iterations'

* Improve tests

* Compare against nrounds directly

* Fix whitespace lints
2021-11-11 12:12:17 +08:00
José Morales 99e0a4bd7b
[python-package] early stopping min_delta (fixes #2526) (#4580)
* initial changes

* initial version

* better handling of cases

* warn only with positive threshold

* remove early_stopping_threshold from high-level functions

* remove remaining early_stopping_threshold

* update test to use callback

* better handling of cases

* rename threshold to min_delta

enhance parameter description

update tests

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* reduce num_boost_round in tests

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* trigger ci

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-12@hotmail.com>
2021-11-10 16:17:06 +03:00
Nikita Titov 0a4d190828
[python][sklearn] respect objective aliases (#4758)
* respect objective aliases

* Update test_sklearn.py

* revert removal of blank lines

* add argument name which is being overwritten in warning message
2021-11-10 16:15:39 +03:00
Chen Yufei 15a63696c0
cmake: use object library to avoid duplicate compilation. (#4489)
* cmake: use object library to avoid duplicate compilation.

* debug: verbose make log for building r package.

* Include /usr/local/include for AppleClang.

* Revert "debug: verbose make log for building r package."

* update cmake comment and fix indentation

* debug cmake USE_DEBUG.

* Revert "debug cmake USt E_DEBUG."

* Add -fPIC for building shared library.

* Always set -fPIC for non MSVC compiler.

* debug: print exception in setup.py

* debug: print cmake output for vs build.

* debug: set opencl related target_xxx on lightgbm_objs.

* Define compile definitions, link libraries on lightgbm_objs.

* Add PUBLIC to target_link_libraries to expose library dependency.

* Use target_link_libraries on object library.

This should propagate usage requirements.

* Fix CUDA linking.

Linking object library (lightgbm_objs) to object library (histograms)
does not linked objects.

* Use PUBLIC link for lightgbm lib.

* Set cuda related properties on final targets.

* Remove debugging changes.

Revert "debug: print exception in setup.py"
Revert "debug: print cmake output for vs build."
etc.

* Remove -D_lightgbm_EXPORTS.

* Revert to add -fPIC only for NOT USE_DEBUG.

* Enable PIC for shared lib.

* Fix enable PIC.

* Use -fPIC for shared lib.

* testlightgbm depends only on object files.

* tweak build for R.

* Try to remove OpenMP related include dir settings.

* link with openmp for capi object library.

* Use PUBLIC for _lightgbm target_link_libraries.

* Try removing exports definition.

* fix typo

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* fix typo

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Add some comments for cmake code.

* Try to fix cmake warnings CUDA.

* revert accidentally commited R-package path change.

* Try to fix cmake CUDA warnings, set for _lightgbm target.

* Try to fix cmake CUDA warnings, set for lightgbm target.

* empty commit to trigger ci

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2021-11-10 09:45:21 +08:00
James Lamb 7152c49a76
[R-package] parallelize compilation in CMake-based builds (#4525)
* [R-package] parallelize compilation in CMake-based builds

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* working on adding -j

* pass -j through to install.libs.R

* add docs on -j

* use -j4

* Update R-package/README.md

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2021-11-10 09:39:59 +08:00
tongwu-msft 33a2f9ec05
Always respect forced splits, even when feature_fraction < 1.0 (fixes #4601) (#4725)
* issue fix #4601

* fix issue 4601 it2

* add tests for issue 4601

* fix warning

* fix warning

* add new line at end

* remove last line at end

* fix lint warning

* address comments

* address comments

* address comments

* fix address

* address comments

* revert seed

* fix recursive force split issue

* fix build error

* fix lint warning
2021-11-10 09:30:54 +08:00
Zhiyuan He b1facf5050
Suppress categorical warning (fixes #3379) 2021-11-08 10:06:50 +08:00
James Lamb 858cc0a759
[docs] [dask] Add return information to Dask fit() docs (fixes #4402) (#4716)
* [docs] [dask] Add return information to Dask fit() docs (fixes #4402)

* put return before note
2021-11-07 19:58:00 -06:00
James Lamb 560a03506b
[docs] add specific estimator names to sklearn fit() docs (#4774) 2021-11-07 19:57:27 -06:00
Nikita Titov cebdc2a8c4
[ci][tests][python] remove assertion for `filename` attribute that is no longer true with new version of graphviz (#4778) 2021-11-07 20:33:18 +03:00
James Lamb aafedd8a1c
[docs][R-package] update cran-comments for v3.3.1 release (#4738)
* [docs] [R-package] update cran-comments for v3.3.1 release

* Update R-package/cran-comments.md

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* update cran-comments.md now that v3.3.1 is accepted

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2021-11-07 18:18:44 +03:00
Nikita Titov e6273c72f1
[ci] Revert temp workaround for `freetype` version (#4776)
This reverts commit d62378b453.
2021-11-06 20:42:19 +03:00
James Lamb f39bf5bcf0
[ci] increase timeout for valgrind job to 240 minutes (#4773) 2021-11-06 10:19:35 -05:00
Nikita Titov aab212a782
[python][sklearn] add `n_estimators_` and `n_iter_` post-fit attributes (#4753)
* add n_estimators_ and n_iter_ post-fit attributes

* address review comments
2021-11-05 20:29:49 +03:00
James Lamb 99f0f3ecf1
[ci] only use conda-forge when installing R packages in docs builds (#4767) 2021-11-05 16:56:33 +03:00
Nikita Titov 55e9446ab5
[python] improve warning message about aliases in `cv()` function (#4766) 2021-11-05 16:28:46 +03:00
Nikita Titov 2394b41ac2
[ci] Temporary pin dask version at CI (#4770)
* pin Dask version at CI

* Update .vsts-ci.yml

* Update .vsts-ci.yml

* workaround for Python 3.6

* Update test.sh
2021-11-04 20:17:47 -05:00
James Lamb 1d0d746e7f
[ci] use wch1/r-debug image in Solaris tests (#4765)
* [ci] use wch1/r-debug image in Solaris tests

* no git in valgrind tests
2021-11-03 12:51:04 -05:00
James Lamb 8deb90948a
[ci] upgrade actions/checkout to v2.4.0 (#4763)
* [ci] upgrade actions/checkout to v2.4.0

* re-create GITHUB_WORKSPACE

* dont update cuda

* actually revert cuda
2021-11-03 18:06:05 +03:00
Nikita Titov da98f24711
[docs ][python] add `datatable` to the mocked modules during docs building process and sort them alphabetically (#4750) 2021-10-31 20:28:44 -05:00
James Lamb 08ccd4a3fd
[R-package] allow use of custom R executable when building CRAN package (#4754)
* [R-package] allow use of custom R executable building CRAN package

* Update build-cran-package.sh

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2021-10-30 22:31:35 -05:00
Nikita Titov dac0dffeb2
[docs] improve docs about `nthreads` parameter (#4756)
* in predict(), respect params set via `set_params()` after fit()

* extract docs changes
2021-10-31 02:31:48 +03:00
James Lamb d574fcbd00
[R-package] remove temporary files created in configure.win (#4752) 2021-10-30 19:14:06 +03:00
Nikita Titov dcae8dd569
[ci] indicate support of Monterey (#4732)
* indicate support of Monterey and drop Catalina

* Update test.sh

* restore Mojave
2021-10-29 23:59:21 -05:00
Nikita Titov 9a7562d660
[python] Make dummy classes constructible with any arguments (#4749)
* Make dummy classes constructible with any arguments

* Update compat.py
2021-10-29 23:45:20 -05:00
Nikita Titov d62378b453
[ci] Temporary pin freetype version at Windows CI (#4747)
* Update test_windows.ps1

* Update .appveyor.yml

* Update .appveyor.yml
2021-10-29 20:55:58 +03:00
Nikita Titov 96ecab6fb1
Remove checks for label when loading dataset from binary file because label is ignored in that case (#4737) 2021-10-29 16:40:43 +03:00
Nikita Titov 798dc1d419
[tests] [python] add test for non-serializable callback (#4741) 2021-10-28 23:25:22 -05:00
Nikita Titov e10cbd2353
[docs] update link to LightGBM Ruby (#4740) 2021-10-29 01:46:29 +03:00
Zhiyuan He 429148309a
Reset OpenMP thread number if num_threads <= 0 (#4704)
* mock func for no openmp

* use omp_get_max_threads

Co-authored-by: hzy46 <email@example.com>
2021-10-29 00:17:31 +08:00
Nikita Titov 765ceadc2e
Improve warning wordings (#4731)
* Update dataset_loader.cpp

* Update dataset_loader.cpp

* Update dataset_loader.cpp
2021-10-28 19:07:32 +03:00
Nikita Titov bc4e6686fb
[ci] Bump version for development (#4730)
* Update _pkgdown.yml

* Update .appveyor.yml

* Update VERSION.txt

* Auto-update configure

Co-authored-by: GitHub Actions Bot <githubactionsbot@users.noreply.github.com>
2021-10-28 05:50:47 +03:00
Nikita Titov 5fbfa00b42
Add some warnings when loading dataset from binary file (#4724) 2021-10-28 02:35:54 +03:00
James Lamb 585b86a370
[docs] fix broken SynapseML link (#4712)
* [docs] fix broken SynapseML link

* just remove link
2021-10-28 01:40:04 +03:00
James Lamb d4851c3381
release v3.3.1 (#4715)
* release v3.3.1

* update cran-comments

* Auto-update configure

Co-authored-by: GitHub Actions Bot <githubactionsbot@users.noreply.github.com>
Co-authored-by: Nikita Titov <nekit94-12@hotmail.com>
2021-10-27 00:01:22 -05:00
Nikita Titov 311017ae3d
[python][sklearn] Allow non-serializable objects in callbacks argument (#4723) 2021-10-27 03:04:10 +03:00
James Lamb f6c5574633
[ci] introduce CI jobs that mimic CRAN gcc-ASAN and clang-ASAN tests (fixes #4674) (#4678)
* add jobs mimicking CRAN gcc-ASAN and clang-ASAN

* comment out CI

* fix redirection

* remove unnecessary echo

* Revert "comment out CI"

This reverts commit 899fbb4574.

* remove redundant env variables and update README

* remove inaccurate comment

* change test title

* Revert "Fix ASAN issues with `std::function` usage (#4673)"

This reverts commit 13ed38ca55.

* Revert "Revert "Fix ASAN issues with `std::function` usage (#4673)""

This reverts commit 24c275ba84.

* revert unnecessary change in config order

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2021-10-27 02:25:35 +03:00
Nikita Titov adef94f4fa
[R-package] [test] add reference to the original issue in R-package test (#4720) 2021-10-26 13:19:13 -05:00
Jacob Stevenson 1cc84b35f8
[python] Improve error message for plot_metric with Booster (#4709)
* Improve error message for plot_metric with Booster

* Update error message
2021-10-26 23:19:23 +08:00
James Lamb f497068664
[R-package] allow for small numerical differences in Booster test (#4714)
* [R-package] allow for small numerical differences in Booster test

* only use less-strict test on Windows
2021-10-26 17:33:27 +03:00
shiyu1994 717f037c3a
[docs] Add Tong Wu and Zhiyuan He as code owners (#4717)
* add hzy46 and tongwu-msft as code owners

* fix github link for Zhiyuan He
2021-10-26 16:01:06 +08:00
Nikita Titov df12c1b955
[docs] fix R API link to point to the current version of docs (#4691)
* fix R API link to point to the current version of docs
2021-10-24 22:28:29 -05:00
Zhiyuan He dc02dcaf02
Fix some paramater hints when loading from binary file (#4701)
Co-authored-by: hzy46 <email@example.com>
2021-10-25 09:48:02 +08:00
Nikita Titov 51cd8fc2e2
[docs] update comment about preinstalled Java version for SWIG build (#4710) 2021-10-24 16:41:29 -04:00
Nikita Titov 47554c3794
[ci] fix CI Windows script to use downloaded SWIG, not the pre-installed one (#4711) 2021-10-23 22:06:38 +03:00
david-cortes a2b60e84c1
[R-package] expand user paths in file names (#4687) 2021-10-21 23:40:14 -04:00