* Updating PR template

due to a few recent misses, going to be a bit more rigorous

* Update .github/pull_request_template.md

Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>

* Update pull_request_template.md

Didn't update one instance of wxs

Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
This commit is contained in:
Clint Rutkas 2020-12-31 10:00:26 -08:00 коммит произвёл GitHub
Родитель ff07374e2a
Коммит 843d077da0
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
1 изменённых файлов: 16 добавлений и 11 удалений

27
.github/pull_request_template.md поставляемый
Просмотреть файл

@ -1,18 +1,23 @@
## Summary of the Pull Request
_What is this about?_
**What is this about:**
## PR Checklist
* [ ] Applies to #xxx
* [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/PowerToys) and sign the CLA
* [ ] Tests added/passed
* [ ] Requires documentation to be updated
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx
**What is include in the PR:**
## Info on Pull Request
**How does someone test / validate:**
_What does this include?_
## Quality Checklist
## Validation Steps Performed
- [ ] **Linked issue:** #xxx
- [ ] **Communication:** I've discussed this with core contributors in the issue.
- [ ] **Tests:** Added/updated and all pass
- [ ] **Installer:** Added/updated and all pass
- [ ] **Localization:** All end user facing strings can be localized
- [ ] **Docs:** Added/ updated
- [ ] **Binaries:** Any new files are added to WXS / YML
- [ ] No new binaries
- [ ] [YML for signing](https://github.com/microsoft/PowerToys/blob/master/.pipelines/pipeline.user.windows.yml#L68) for new binaries
- [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/master/installer/PowerToysSetup/Product.wxs) for new binaries
_How does someone test & validate?_
## Contributor License Agreement (CLA)
A CLA must be signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/PowerToys) and sign the CLA.