tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error
commita9c09546e9
upstream. If clk_get_rate() fails, the clk that has just been allocated needs to be freed. Cc: <stable@vger.kernel.org> # v3.3+ Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Fixes:5f5a7a5578
("serial: samsung: switch to clkdev based clock lookup") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Jiri Slaby <jirislaby@kernel.org> Message-ID: <e4baf6039368f52e5a5453982ddcb9a330fc689e.1686412569.git.christophe.jaillet@wanadoo.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
21e2fe510a
Коммит
073dbbe574
|
@ -1478,8 +1478,12 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport,
|
|||
continue;
|
||||
|
||||
rate = clk_get_rate(clk);
|
||||
if (!rate)
|
||||
if (!rate) {
|
||||
dev_err(ourport->port.dev,
|
||||
"Failed to get clock rate for %s.\n", clkname);
|
||||
clk_put(clk);
|
||||
continue;
|
||||
}
|
||||
|
||||
if (ourport->info->has_divslot) {
|
||||
unsigned long div = rate / req_baud;
|
||||
|
|
Загрузка…
Ссылка в новой задаче