batman-adv: Place kref_get for tt_orig_list_entry near use

It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
This commit is contained in:
Sven Eckelmann 2016-07-15 17:39:18 +02:00 коммит произвёл Simon Wunderlich
Родитель f257b99bec
Коммит 23f5548559
1 изменённых файлов: 1 добавлений и 1 удалений

Просмотреть файл

@ -1567,9 +1567,9 @@ batadv_tt_global_orig_entry_add(struct batadv_tt_global_entry *tt_global,
orig_entry->orig_node = orig_node; orig_entry->orig_node = orig_node;
orig_entry->ttvn = ttvn; orig_entry->ttvn = ttvn;
kref_init(&orig_entry->refcount); kref_init(&orig_entry->refcount);
kref_get(&orig_entry->refcount);
spin_lock_bh(&tt_global->list_lock); spin_lock_bh(&tt_global->list_lock);
kref_get(&orig_entry->refcount);
hlist_add_head_rcu(&orig_entry->list, hlist_add_head_rcu(&orig_entry->list,
&tt_global->orig_list); &tt_global->orig_list);
spin_unlock_bh(&tt_global->list_lock); spin_unlock_bh(&tt_global->list_lock);