cxl: Flesh out register names
Get a better naming scheme in place for upcoming additions. By dropping redundant usages of CXL and DVSEC where appropriate we can get more concise and also more grepable defines. Reviewed-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> Link: https://lore.kernel.org/r/164298414022.3018233.15522855498759815097.stgit@dwillia2-desk3.amr.corp.intel.com Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Родитель
4f195ee73a
Коммит
46c6ad2762
|
@ -370,10 +370,10 @@ static int cxl_map_regs(struct cxl_dev_state *cxlds, struct cxl_register_map *ma
|
|||
static void cxl_decode_regblock(u32 reg_lo, u32 reg_hi,
|
||||
struct cxl_register_map *map)
|
||||
{
|
||||
map->block_offset =
|
||||
((u64)reg_hi << 32) | (reg_lo & CXL_REGLOC_ADDR_MASK);
|
||||
map->barno = FIELD_GET(CXL_REGLOC_BIR_MASK, reg_lo);
|
||||
map->reg_type = FIELD_GET(CXL_REGLOC_RBI_MASK, reg_lo);
|
||||
map->block_offset = ((u64)reg_hi << 32) |
|
||||
(reg_lo & CXL_DVSEC_REG_LOCATOR_BLOCK_OFF_LOW_MASK);
|
||||
map->barno = FIELD_GET(CXL_DVSEC_REG_LOCATOR_BIR_MASK, reg_lo);
|
||||
map->reg_type = FIELD_GET(CXL_DVSEC_REG_LOCATOR_BLOCK_ID_MASK, reg_lo);
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -394,15 +394,15 @@ static int cxl_find_regblock(struct pci_dev *pdev, enum cxl_regloc_type type,
|
|||
int regloc, i;
|
||||
|
||||
regloc = pci_find_dvsec_capability(pdev, PCI_DVSEC_VENDOR_ID_CXL,
|
||||
PCI_DVSEC_ID_CXL_REGLOC_DVSEC_ID);
|
||||
CXL_DVSEC_REG_LOCATOR);
|
||||
if (!regloc)
|
||||
return -ENXIO;
|
||||
|
||||
pci_read_config_dword(pdev, regloc + PCI_DVSEC_HEADER1, ®loc_size);
|
||||
regloc_size = FIELD_GET(PCI_DVSEC_HEADER1_LENGTH_MASK, regloc_size);
|
||||
|
||||
regloc += PCI_DVSEC_ID_CXL_REGLOC_BLOCK1_OFFSET;
|
||||
regblocks = (regloc_size - PCI_DVSEC_ID_CXL_REGLOC_BLOCK1_OFFSET) / 8;
|
||||
regloc += CXL_DVSEC_REG_LOCATOR_BLOCK1_OFFSET;
|
||||
regblocks = (regloc_size - CXL_DVSEC_REG_LOCATOR_BLOCK1_OFFSET) / 8;
|
||||
|
||||
for (i = 0; i < regblocks; i++, regloc += 8) {
|
||||
u32 reg_lo, reg_hi;
|
||||
|
|
|
@ -7,17 +7,21 @@
|
|||
|
||||
/*
|
||||
* See section 8.1 Configuration Space Registers in the CXL 2.0
|
||||
* Specification
|
||||
* Specification. Names are taken straight from the specification with "CXL" and
|
||||
* "DVSEC" redundancies removed. When obvious, abbreviations may be used.
|
||||
*/
|
||||
#define PCI_DVSEC_HEADER1_LENGTH_MASK GENMASK(31, 20)
|
||||
#define PCI_DVSEC_VENDOR_ID_CXL 0x1E98
|
||||
#define PCI_DVSEC_ID_CXL 0x0
|
||||
|
||||
#define PCI_DVSEC_ID_CXL_REGLOC_DVSEC_ID 0x8
|
||||
#define PCI_DVSEC_ID_CXL_REGLOC_BLOCK1_OFFSET 0xC
|
||||
/* CXL 2.0 8.1.3: PCIe DVSEC for CXL Device */
|
||||
#define CXL_DVSEC_PCIE_DEVICE 0
|
||||
|
||||
/* BAR Indicator Register (BIR) */
|
||||
#define CXL_REGLOC_BIR_MASK GENMASK(2, 0)
|
||||
/* CXL 2.0 8.1.9: Register Locator DVSEC */
|
||||
#define CXL_DVSEC_REG_LOCATOR 8
|
||||
#define CXL_DVSEC_REG_LOCATOR_BLOCK1_OFFSET 0xC
|
||||
#define CXL_DVSEC_REG_LOCATOR_BIR_MASK GENMASK(2, 0)
|
||||
#define CXL_DVSEC_REG_LOCATOR_BLOCK_ID_MASK GENMASK(15, 8)
|
||||
#define CXL_DVSEC_REG_LOCATOR_BLOCK_OFF_LOW_MASK GENMASK(31, 16)
|
||||
|
||||
/* Register Block Identifier (RBI) */
|
||||
enum cxl_regloc_type {
|
||||
|
@ -28,7 +32,4 @@ enum cxl_regloc_type {
|
|||
CXL_REGLOC_RBI_TYPES
|
||||
};
|
||||
|
||||
#define CXL_REGLOC_RBI_MASK GENMASK(15, 8)
|
||||
#define CXL_REGLOC_ADDR_MASK GENMASK(31, 16)
|
||||
|
||||
#endif /* __CXL_PCI_H__ */
|
||||
|
|
Загрузка…
Ссылка в новой задаче