Chris Wilson 13be2efc39 rtc: cmos: Disable irq around direct invocation of cmos_interrupt() ... As previously noted in commit 66e4f4a9cc ("rtc: cmos: Use spin_lock_irqsave() in cmos_interrupt()"): <4>[ 254.192378] WARNING: inconsistent lock state <4>[ 254.192384] 5.12.0-rc1-CI-CI_DRM_9834+ #1 Not tainted <4>[ 254.192396] -------------------------------- <4>[ 254.192400] inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage. <4>[ 254.192409] rtcwake/5309 [HC0[0]:SC0[0]:HE1:SE1] takes: <4>[ 254.192429] ffffffff8263c5f8 (rtc_lock){?...}-{2:2}, at: cmos_interrupt+0x18/0x100 <4>[ 254.192481] {IN-HARDIRQ-W} state was registered at: <4>[ 254.192488] lock_acquire+0xd1/0x3d0 <4>[ 254.192504] _raw_spin_lock+0x2a/0x40 <4>[ 254.192519] cmos_interrupt+0x18/0x100 <4>[ 254.192536] rtc_handler+0x1f/0xc0 <4>[ 254.192553] acpi_ev_fixed_event_detect+0x109/0x13c <4>[ 254.192574] acpi_ev_sci_xrupt_handler+0xb/0x28 <4>[ 254.192596] acpi_irq+0x13/0x30 <4>[ 254.192620] __handle_irq_event_percpu+0x43/0x2c0 <4>[ 254.192641] handle_irq_event_percpu+0x2b/0x70 <4>[ 254.192661] handle_irq_event+0x2f/0x50 <4>[ 254.192680] handle_fasteoi_irq+0x9e/0x150 <4>[ 254.192693] __common_interrupt+0x76/0x140 <4>[ 254.192715] common_interrupt+0x96/0xc0 <4>[ 254.192732] asm_common_interrupt+0x1e/0x40 <4>[ 254.192750] _raw_spin_unlock_irqrestore+0x38/0x60 <4>[ 254.192767] resume_irqs+0xba/0xf0 <4>[ 254.192786] dpm_resume_noirq+0x245/0x3d0 <4>[ 254.192811] suspend_devices_and_enter+0x230/0xaa0 <4>[ 254.192835] pm_suspend.cold.8+0x301/0x34a <4>[ 254.192859] state_store+0x7b/0xe0 <4>[ 254.192879] kernfs_fop_write_iter+0x11d/0x1c0 <4>[ 254.192899] new_sync_write+0x11d/0x1b0 <4>[ 254.192916] vfs_write+0x265/0x390 <4>[ 254.192933] ksys_write+0x5a/0xd0 <4>[ 254.192949] do_syscall_64+0x33/0x80 <4>[ 254.192965] entry_SYSCALL_64_after_hwframe+0x44/0xae <4>[ 254.192986] irq event stamp: 43775 <4>[ 254.192994] hardirqs last enabled at (43775): [<ffffffff81c00c42>] asm_sysvec_apic_timer_interrupt+0x12/0x20 <4>[ 254.193023] hardirqs last disabled at (43774): [<ffffffff81aa691a>] sysvec_apic_timer_interrupt+0xa/0xb0 <4>[ 254.193049] softirqs last enabled at (42548): [<ffffffff81e00342>] __do_softirq+0x342/0x48e <4>[ 254.193074] softirqs last disabled at (42543): [<ffffffff810b45fd>] irq_exit_rcu+0xad/0xd0 <4>[ 254.193101] other info that might help us debug this: <4>[ 254.193107] Possible unsafe locking scenario: <4>[ 254.193112] CPU0 <4>[ 254.193117] ---- <4>[ 254.193121] lock(rtc_lock); <4>[ 254.193137] <Interrupt> <4>[ 254.193142] lock(rtc_lock); <4>[ 254.193156] *** DEADLOCK *** <4>[ 254.193161] 6 locks held by rtcwake/5309: <4>[ 254.193174] #0: ffff888104861430 (sb_writers#5){.+.+}-{0:0}, at: ksys_write+0x5a/0xd0 <4>[ 254.193232] #1: ffff88810f823288 (&of->mutex){+.+.}-{3:3}, at: kernfs_fop_write_iter+0xe7/0x1c0 <4>[ 254.193282] #2: ffff888100cef3c0 (kn->active#285 <7>[ 254.192706] i915 0000:00:02.0: [drm:intel_modeset_setup_hw_state [i915]] [CRTC:51:pipe A] hw state readout: disabled <4>[ 254.193307] ){.+.+}-{0:0}, at: kernfs_fop_write_iter+0xf0/0x1c0 <4>[ 254.193333] #3: ffffffff82649fa8 (system_transition_mutex){+.+.}-{3:3}, at: pm_suspend.cold.8+0xce/0x34a <4>[ 254.193387] #4: ffffffff827a2108 (acpi_scan_lock){+.+.}-{3:3}, at: acpi_suspend_begin+0x47/0x70 <4>[ 254.193433] #5: ffff8881019ea178 (&dev->mutex){....}-{3:3}, at: device_resume+0x68/0x1e0 <4>[ 254.193485] stack backtrace: <4>[ 254.193492] CPU: 1 PID: 5309 Comm: rtcwake Not tainted 5.12.0-rc1-CI-CI_DRM_9834+ #1 <4>[ 254.193514] Hardware name: Google Soraka/Soraka, BIOS MrChromebox-4.10 08/25/2019 <4>[ 254.193524] Call Trace: <4>[ 254.193536] dump_stack+0x7f/0xad <4>[ 254.193567] mark_lock.part.47+0x8ca/0xce0 <4>[ 254.193604] __lock_acquire+0x39b/0x2590 <4>[ 254.193626] ? asm_sysvec_apic_timer_interrupt+0x12/0x20 <4>[ 254.193660] lock_acquire+0xd1/0x3d0 <4>[ 254.193677] ? cmos_interrupt+0x18/0x100 <4>[ 254.193716] _raw_spin_lock+0x2a/0x40 <4>[ 254.193735] ? cmos_interrupt+0x18/0x100 <4>[ 254.193758] cmos_interrupt+0x18/0x100 <4>[ 254.193785] cmos_resume+0x2ac/0x2d0 <4>[ 254.193813] ? acpi_pm_set_device_wakeup+0x1f/0x110 <4>[ 254.193842] ? pnp_bus_suspend+0x10/0x10 <4>[ 254.193864] pnp_bus_resume+0x5e/0x90 <4>[ 254.193885] dpm_run_callback+0x5f/0x240 <4>[ 254.193914] device_resume+0xb2/0x1e0 <4>[ 254.193942] ? pm_dev_err+0x25/0x25 <4>[ 254.193974] dpm_resume+0xea/0x3f0 <4>[ 254.194005] dpm_resume_end+0x8/0x10 <4>[ 254.194030] suspend_devices_and_enter+0x29b/0xaa0 <4>[ 254.194066] pm_suspend.cold.8+0x301/0x34a <4>[ 254.194094] state_store+0x7b/0xe0 <4>[ 254.194124] kernfs_fop_write_iter+0x11d/0x1c0 <4>[ 254.194151] new_sync_write+0x11d/0x1b0 <4>[ 254.194183] vfs_write+0x265/0x390 <4>[ 254.194207] ksys_write+0x5a/0xd0 <4>[ 254.194232] do_syscall_64+0x33/0x80 <4>[ 254.194251] entry_SYSCALL_64_after_hwframe+0x44/0xae <4>[ 254.194274] RIP: 0033:0x7f07d79691e7 <4>[ 254.194293] Code: 64 89 02 48 c7 c0 ff ff ff ff eb bb 0f 1f 80 00 00 00 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 <4>[ 254.194312] RSP: 002b:00007ffd9cc2c768 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 <4>[ 254.194337] RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007f07d79691e7 <4>[ 254.194352] RDX: 0000000000000004 RSI: 0000556ebfc63590 RDI: 000000000000000b <4>[ 254.194366] RBP: 0000556ebfc63590 R08: 0000000000000000 R09: 0000000000000004 <4>[ 254.194379] R10: 0000556ebf0ec2a6 R11: 0000000000000246 R12: 0000000000000004 which breaks S3-resume on fi-kbl-soraka presumably as that's slow enough to trigger the alarm during the suspend. Fixes: 6950d046eb ("rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ") References: 66e4f4a9cc ("rtc: cmos: Use spin_lock_irqsave() in cmos_interrupt()"): Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Xiaofei Tan <tanxiaofei@huawei.com> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20210305122140.28774-1-chris@chris-wilson.co.uk		2021-09-14 10:20:19 +02:00
..
Kconfig	rtc: rx8010: select REGMAP_I2C	2021-09-09 10:18:40 +02:00
Makefile	rtc: move RTC_LIB_KUNIT_TEST to proper location	2021-08-10 23:22:20 +02:00
class.c	…
dev.c	…
interface.c	…
lib.c	rtc: Improve performance of rtc_time64_to_tm(). Add tests.	2021-08-10 00:09:21 +02:00
lib_test.c	rtc: lib_test: add MODULE_LICENSE	2021-08-10 23:21:46 +02:00
nvmem.c	…
proc.c	…
rtc-88pm80x.c	…
rtc-88pm860x.c	…
rtc-ab-b5ze-s3.c	…
rtc-ab-eoz9.c	…
rtc-ab8500.c	…
rtc-abx80x.c	…
rtc-ac100.c	…
rtc-armada38x.c	…
rtc-as3722.c	…
rtc-asm9260.c	…
rtc-aspeed.c	…
rtc-at91rm9200.c	…
rtc-at91sam9.c	rtc: at91sam9: Remove unnecessary offset variable checks	2021-07-10 02:42:08 +02:00
rtc-au1xxx.c	rtc: au1xxx: convert to SPDX identifier	2021-07-10 01:53:39 +02:00
rtc-bd70528.c	…
rtc-bq32k.c	…
rtc-bq4802.c	…
rtc-brcmstb-waketimer.c	…
rtc-cadence.c	…
rtc-cmos.c	rtc: cmos: Disable irq around direct invocation of cmos_interrupt()	2021-09-14 10:20:19 +02:00
rtc-core.h	…
rtc-cpcap.c	…
rtc-cros-ec.c	…
rtc-da9052.c	…
rtc-da9055.c	…
rtc-da9063.c	…
rtc-davinci.c	…
rtc-digicolor.c	…
rtc-dm355evm.c	…
rtc-ds1216.c	…
rtc-ds1286.c	…
rtc-ds1302.c	…
rtc-ds1305.c	…
rtc-ds1307.c	…
rtc-ds1343.c	…
rtc-ds1347.c	…
rtc-ds1374.c	rtc: ds1374: convert to SPDX identifier	2021-07-10 01:53:39 +02:00
rtc-ds1390.c	…
rtc-ds1511.c	…
rtc-ds1553.c	…
rtc-ds1672.c	…
rtc-ds1685.c	…
rtc-ds1742.c	…
rtc-ds2404.c	…
rtc-ds3232.c	…
rtc-efi.c	…
rtc-em3027.c	…
rtc-ep93xx.c	…
rtc-fm3130.c	…
rtc-fsl-ftm-alarm.c	…
rtc-ftrtc010.c	…
rtc-generic.c	…
rtc-goldfish.c	…
rtc-hid-sensor-time.c	…
rtc-hym8563.c	…
rtc-imx-sc.c	…
rtc-imxdi.c	…
rtc-isl1208.c	…
rtc-isl12022.c	…
rtc-isl12026.c	…
rtc-jz4740.c	…
rtc-lp8788.c	…
rtc-lpc24xx.c	…
rtc-lpc32xx.c	…
rtc-ls1x.c	…
rtc-m41t80.c	…
rtc-m41t93.c	…
rtc-m41t94.c	…
rtc-m48t35.c	…
rtc-m48t59.c	…
rtc-m48t86.c	…
rtc-max6900.c	rtc: max6900: convert to SPDX identifier	2021-07-10 01:53:39 +02:00
rtc-max6902.c	…
rtc-max6916.c	…
rtc-max8907.c	…
rtc-max8925.c	…
rtc-max8997.c	…
rtc-max8998.c	…
rtc-max77686.c	…
rtc-mc13xxx.c	…
rtc-mc146818-lib.c	…
rtc-mcp795.c	…
rtc-meson-vrtc.c	…
rtc-meson.c	…
rtc-moxart.c	…
rtc-mpc5121.c	…
rtc-msm6242.c	…
rtc-mt2712.c	…
rtc-mt6397.c	…
rtc-mt7622.c	…
rtc-mv.c	…
rtc-mxc.c	…
rtc-mxc_v2.c	…
rtc-ntxec.c	…
rtc-omap.c	…
rtc-opal.c	…
rtc-palmas.c	rtc: palmas: convert to SPDX identifier	2021-07-10 01:53:39 +02:00
rtc-pcap.c	…
rtc-pcf2123.c	…
rtc-pcf2127.c	rtc: pcf2127: handle timestamp interrupts	2021-07-10 02:58:31 +02:00
rtc-pcf8523.c	rtc: pcf8523: rename register and bit defines	2021-07-10 23:18:30 +02:00
rtc-pcf8563.c	…
rtc-pcf8583.c	…
rtc-pcf50633.c	…
rtc-pcf85063.c	…
rtc-pcf85363.c	…
rtc-pic32.c	…
rtc-pl030.c	…
rtc-pl031.c	…
rtc-pm8xxx.c	…
rtc-ps3.c	…
rtc-pxa.c	…
rtc-r7301.c	…
rtc-r9701.c	…
rtc-rc5t583.c	…
rtc-rc5t619.c	…
rtc-rk808.c	…
rtc-rp5c01.c	…
rtc-rs5c313.c	…
rtc-rs5c348.c	…
rtc-rs5c372.c	…
rtc-rtd119x.c	rtc: rtd119x: Fix format of SPDX identifier	2021-07-10 01:53:39 +02:00
rtc-rv3028.c	…
rtc-rv3029c2.c	…
rtc-rv3032.c	…
rtc-rv8803.c	…
rtc-rx4581.c	…
rtc-rx6110.c	…
rtc-rx8010.c	…
rtc-rx8025.c	rtc: rx8025: implement RX-8035 support	2021-08-17 23:48:33 +02:00
rtc-rx8581.c	…
rtc-s3c.c	…
rtc-s3c.h	…
rtc-s5m.c	rtc: s5m: set range	2021-08-06 10:31:59 +02:00
rtc-s35390a.c	…
rtc-sa1100.c	…
rtc-sa1100.h	…
rtc-sc27xx.c	rtc: sc27xx: Fix format of SPDX identifier	2021-07-10 01:53:39 +02:00
rtc-sd3078.c	…
rtc-sh.c	…
rtc-snvs.c	…
rtc-spear.c	rtc: spear: convert to SPDX identifier	2021-07-10 01:53:57 +02:00
rtc-st-lpc.c	…
rtc-starfire.c	…
rtc-stk17ta8.c	…
rtc-stm32.c	…
rtc-stmp3xxx.c	…
rtc-sun4v.c	…
rtc-sun6i.c	…
rtc-sunxi.c	…
rtc-tegra.c	…
rtc-test.c	…
rtc-tps6586x.c	rtc: tps6586x: convert to SPDX identifier	2021-07-10 01:53:40 +02:00
rtc-tps65910.c	rtc: tps65910: Correct driver module alias	2021-08-17 23:36:22 +02:00
rtc-tps80031.c	rtc: tps80031: convert to SPDX identifier	2021-07-10 01:53:39 +02:00
rtc-twl.c	…
rtc-v3020.c	…
rtc-vr41xx.c	…
rtc-vt8500.c	…
rtc-wilco-ec.c	…
rtc-wm831x.c	…
rtc-wm8350.c	…
rtc-x1205.c	…
rtc-xgene.c	…
rtc-zynqmp.c	…
sysfs.c	…