Zhihao Cheng a801fcfeef ubifs: Set/Clear I_LINKABLE under i_lock for whiteout inode ... xfstests-generic/476 reports a warning message as below: WARNING: CPU: 2 PID: 30347 at fs/inode.c:361 inc_nlink+0x52/0x70 Call Trace: do_rename+0x502/0xd40 [ubifs] ubifs_rename+0x8b/0x180 [ubifs] vfs_rename+0x476/0x1080 do_renameat2+0x67c/0x7b0 __x64_sys_renameat2+0x6e/0x90 do_syscall_64+0x66/0xe0 entry_SYSCALL_64_after_hwframe+0x44/0xae Following race case can cause this: rename_whiteout(Thread 1) wb_workfn(Thread 2) ubifs_rename do_rename __writeback_single_inode spin_lock(&inode->i_lock) whiteout->i_state |= I_LINKABLE inode->i_state &= ~dirty; ---- How race happens on i_state: (tmp = whiteout->i_state | I_LINKABLE) (tmp = inode->i_state & ~dirty) (whiteout->i_state = tmp) (inode->i_state = tmp) ---- spin_unlock(&inode->i_lock) inc_nlink(whiteout) WARN_ON(!(inode->i_state & I_LINKABLE)) !!! Fix to add i_lock to avoid i_state update race condition. Fixes: 9e0a1fff8d ("ubifs: Implement RENAME_WHITEOUT") Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> Signed-off-by: Richard Weinberger <richard@nod.at>		2021-06-22 09:21:39 +02:00
..
Kconfig	fscrypt: Allow modular crypto algorithms	2019-12-31 10:33:51 -06:00
Makefile	fscrypt: remove filesystem specific build config option	2019-01-23 23:56:43 -05:00
auth.c	ubifs: Fix memleak in ubifs_init_authentication	2021-02-12 21:53:22 +01:00
budget.c	ubifs: Limit the number of pages in shrink_liability	2019-08-22 17:25:33 +02:00
commit.c	ubifs: Pass node length in all node dumping callers	2020-12-13 22:12:32 +01:00
compress.c	ubifs: Add support for zstd compression.	2019-07-08 19:43:53 +02:00
crypto.c	fscrypt: introduce fscrypt_decrypt_block_inplace()	2019-05-28 10:27:53 -07:00
debug.c	ubifs: fix snprintf() checking	2021-06-18 22:04:47 +02:00
debug.h	ubifs: ubifs_dump_sleb: Remove unused function	2020-12-13 22:12:38 +01:00
dir.c	ubifs: Set/Clear I_LINKABLE under i_lock for whiteout inode	2021-06-22 09:21:39 +02:00
file.c	ubifs: convert to fileattr	2021-04-12 15:04:30 +02:00
find.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336	2019-06-05 17:37:07 +02:00
gc.c	treewide: Change list_sort to use const pointers	2021-04-08 16:04:22 -07:00
io.c	ubifs: Pass node length in all node dumping callers	2020-12-13 22:12:32 +01:00
ioctl.c	ubifs: convert to fileattr	2021-04-12 15:04:30 +02:00
journal.c	ubifs: Fix spelling mistakes	2021-06-22 09:21:39 +02:00
key.h	ubifs: allow both hash and disk name to be provided in no-key names	2020-01-22 14:49:56 -08:00
log.c	ubifs: remove unnecessary check in ubifs_log_start_commit	2019-07-08 19:43:51 +02:00
lprops.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
lpt.c	ubifs: Fix the printing type of c->big_lpt	2020-12-13 21:57:10 +01:00
lpt_commit.c	mm: remove the pgprot argument to __vmalloc	2020-06-02 10:59:11 -07:00
master.c	ubifs: Fix spelling mistakes	2021-06-22 09:21:39 +02:00
misc.c	ubifs: Allow setting assert action as mount parameter	2018-08-15 00:25:21 +02:00
misc.h	ubifs: misc.h: delete a duplicated word	2020-08-02 22:59:03 +02:00
orphan.c	ubifs: Pass node length in all node dumping callers	2020-12-13 22:12:32 +01:00
recovery.c	ubifs: Pass node length in all node dumping callers	2020-12-13 22:12:32 +01:00
replay.c	ubifs: Fix spelling mistakes	2021-06-22 09:21:39 +02:00
sb.c	ubifs: Default to zstd compression	2021-04-15 22:00:26 +02:00
scan.c	ubifs: Pass node length in all node dumping callers	2020-12-13 22:12:32 +01:00
shrinker.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336	2019-06-05 17:37:07 +02:00
super.c	ubifs: Fix spelling mistakes	2021-06-22 09:21:39 +02:00
tnc.c	ubifs: Pass node length in all node dumping callers	2020-12-13 22:12:32 +01:00
tnc_commit.c	ubifs: Fix spelling mistakes	2021-06-22 09:21:39 +02:00
tnc_misc.c	ubifs: Pass node length in all node dumping callers	2020-12-13 22:12:32 +01:00
ubifs-media.h	ubifs: Add support for zstd compression.	2019-07-08 19:43:53 +02:00
ubifs.h	ubifs: Fix spelling mistakes	2021-06-22 09:21:39 +02:00
xattr.c	ubifs: Remove ui_mutex in ubifs_xattr_get and change_xattr	2021-06-18 22:04:47 +02:00