* *Refactor single-service template to use locals block
*Resolve names of resources that can be overridden in tfvars
*Refactor HW template to use locals block
*Moved provider to commons.tf
*Following same pattern as other templates for resource naming
*Compute the basename consistently
*Fallback to admin RG for ACR if not specified in TF vars
*Randomization element for HW template resource names
*Randomization element for simple single-service template
*Terraform insists on determinism for count metaproperty
*Randomization element for ISO template
*Include randomized string in shortened names
* Tdevani workingbranch (#274)
* adding commits to pull out resource name into the templates
* updating az-isolated template for single region to update app service module
* *Use name prefixes on app services too
*updating the iso template documentation for inputs & outputs based on the recent changes
*updating readme for single region with the required variables
*Unit test fixes
*Remove resource names from asserts
*Remove resource names that are indeterminate
*Deterministic trigger for webhook creation
*Set ACR flag in ISO template
*Fix webhook URLs
*Remove hardcoded name checks from integration tests
*Webhook Name must be <= 50 chars
*Escaped res group param
*Resolves problems with AZ CLI commands for management of app service ACR pull and authentication
* Missed during rebase
* Global Web App name is capped at 60 characters total (https://docs.microsoft.com/en-us/azure/architecture/best-practices/naming-conventions#web)
* Proper name of trigger
* adding TF_CLI_ARGS as environment variable to pass in additional inputs to the cli
* adding changes to the documentation
* updating the environment template file to take out quotes and leave it as empty
* adding consistency with quotes for apply and destroy
* adding a check to see if the values for the TF_CLI_ARGS are unset or undefined
* removing quotations from the bash scripts for the additional args
* isolate the test env from others
* no dbl-quotes when expansion needed? also more settings to populate
* keep the Cobalt defaults for the example vars
* implement workaround for keyvault versioning in app settings
* Update unit tests with expected count
* Removed extra character from unauth of ase.tf
* add agent `pool` attributes to all `job` defs
* point the `release/provision` jobs at an `agent pool` not a `vmImage`
* move the `pool` def up, alike the build-stage
(and help keep it at the right indentation level)
* Pipeline updates to support configuration of skipping tests, always running jobs, and overriding Git credentials. Added App-specific pipeline to support version-n-go.
* Support env var > parameter > default for forcing the run and skipping tests. Mask PAT from output.
* Added Key Vault access policies for all app service identities.
* Incremented expected resource count since two were added (access policies for unauth app services and access policies for auth app services)
* Update descriptions
* Init empty manual testing plan doc
* manual testing doc outline
* update manual testing plan with scenarios
* Update manual testing plan
* Update manual testing plan
* Update manual testing plan
* Update manual testing plan
* Update manual testing plan
* Update manual testing plan
* WIP test plans for the scenarios. Needs more elaboration.
* Update manual testing plan with diagrams
* Update manual testing plan with diagrams
* Update manual testing plan with link to add pat owner doc
* Added 5th "nginx" test plan
* minor typos
* provide `az acr` examples that are closer to what's needed
provide `az acr import` examples for nginx
* more color on the nginx approach
* add in a weird easy-to-miss permission setting
* tweak notation
* working instructions for self-hosted Linux
* remove VIM command typos
* Design document for version and go
* Updated with info about file location
* Updated with info about pipeline description
* Removed copy/paste remnant
* Updated with setup doc link
* Updated with clarifying remarks about the pipeline location
* Updated with clarifying remarks about files and folders and pipelines
* Updated based on PR comments
* Closes#250 and tests in ISO int tests
* apache thrift go mod fix
* apache thrift go mod fix
* Add replace thrift in mod file
* Added comments to why we are not running specific tests
* changing the formatting setup of the readme and deleting the empty readme
* readjust the table of contents to move design towards the end
* some ideas for project main readme
* Refactor main project README.md to be smaller and reference other more granular README docs. Also added some high level template/module documentation.
* Adding in the main steps for the application developers - TODO adding in detailed instructions and UI images
* updating the getting started for app dev doc...Screenshots to be added
* updating the readme with the screenshots of the az devops portal steps
* Merged getting started documentation into a single feature branch to ensure coverage.
* update getting started doc
* update getting started doc
* update getting started doc
* Updates to docs; added preview feature notes and environment variable groups.
* update getting started doc
* update getting started doc
* update getting started doc
* Added initial cut of CLI version of app dev focused Getting Started
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* Updated with CLI commands
* Fixed removal of unneeded pieces.
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* Updates to CLI docs. Broke out steps into separate code blocks versus single code block.
* adding some minor changes to the app dev readme
* Moved getting started docs into new 'docs' directory.
* Updated links and resolved CLI docs comments.
* Update GETTING_STARTED_ADD_PAT_OWNER.md
* Update GETTING_STARTED_APP_DEV_CLI.md
* update getting started doc
* updated az isolated ase template with create authn feature
* add create authn feature; remove preexisting authn feature
* further remove external tenant azuread feature
update az hw unit test
fixed terraform linting errors
updated variable descriptions
* update unit tests
* update app service module dependency order
* refactor iso template web app integ test.
Co-authored-by: Dexter Williams dexterwilliams04@gmail.com
Co-authored-by: Megan Meyer memeyer@microsoft.com
force unit test to pass
force unit test to pass
force unit test to pass
reconcile broken iso template app service unit tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
temp bypass vnet and acr integ tests
refactor iso tempalte web app integ test
refactor iso tempalte web app integ test
code review update (comments, yagni, cli)
* Merging master into WIP for IP Whitelist Integration
Consolidating IP Whitelist changes and rebasing from master
Co-authored-by: Tasneem Devani <tasneem.devani@gmail.com>
Co-authored-by: Nick Iodice <nmiodice@gmail.com>
* unit and integration tests for ACR
* adding tests for keyvault and updating the expected whitelist IP address
* adding a minor change to change the keyvault IP rules to be in a list instead of a string
* adding a minor change to the keyvault whitelist IP
* Adding corrected value for whitelist IP block to change from IP Address or Range to Value.
* refactoring to include another function for the subnet
* fixing comment for IP whitelist
* Modifying the IP Rules string to be in CIDR format so that the test does not cause an issue
* Update infra/templates/az-isolated-service-single-region/terraform.tfvars
* fixed go format error
* fixed unit test to look for 1.1.1.1 instead of 1.1.1.1/32
* whitespace change
* * Unified internal/external templates to leverage common templates
* Integrated automated unit/integration testing to CI/CD process
* Generalized integration tests to work across different workspaces
* * Unified internal/external templates to leverage common templates
* Integrated automated unit/integration testing to CI/CD process
* Generalized integration tests to work across different workspaces
* Fixed minor template bugs I found in templates during the process
* Fixed Terraform linting strategy, which was broken after TF 12 upgrade
* Apply suggestions from code review
Adding suggestions from @iphilpot
Co-Authored-By: Ian Philpot <ian.philpot@microsoft.com>
* PR feedback round 1
* Outline of document
* Flow diag
* WIP int test doc
* Added reference link to MSFT Docs
* Edits before removing WIP
* Final edits
* Added reference to existing Auth function
* Updated per PR
* update auth settings of app service module
* rebase: refactored app-service-name to app-service-config in order to achieve multi-tenant, multi-client azure ad authentication for all templates. Pending tests to validate changes.
* Update external tenant id description
* update hello world tests
* update file names of az hw tests
* update az single region template with new authenticaiton inputs for app service
* update az isolated single region with new authentication inputs for app service
* update output app service name output of app service module
* reformat string construction of app service module's local exec provisioner
* reformat string construction of app service module's local exec provisioner
* reformat string construction of app service module's local exec provisioner
* updated references to app-service configurations app wide; Replaced enable-auth var used for driving auth enrollment with ad_client_id existence check
* fixed syntax errors caused by changes made to improve readability of local exec provisioner strings
* Update easyauth.md
* removed unnecessary interpolation syntax
* Altered scripts to work on OSX
* Moved YAML template file to root
* Test
* Revert
* Removed YAML file from root
* Removed caching from docker build command
* Added the resource group name to the list of outputs from the terraform module
* Removed unncessary changes
* Added missing end quote
* Fixed improperly referenced attribute
* Updated integration test to account for new output
* Altered scripts to work on OSX
* Moved YAML template file to root
* Test
* Revert
* Removed YAML file from root
* Removed caching from docker build command
* Added the resource group name to the list of outputs from the terraform module
* Removed unncessary changes
* Added missing end quote
* initialize storage account module
* update variables and var descriptions
* added service principal module reference to azure storage account
* upgrade storage account module to tf12
* adding storage account readme
* conform to tf 12 style; refine readme
* refactored to multi-container storage-account module
* remove serv principal display name var
* updated sa module to express 'multiple containers' in readme and in code
* Forced build
Go has been updated from v1.11 --> v1.12.5
Terraform has been udpated from v0.11.13 --> v0.12.1
The test harness has also been upgraded to perform a structural
comparison against the new terraform plan format introduced in v0.12.0
* Updates azuread provider to latest
* Adds tf module files for service principal generation/rbac
* Adds docs in module readme for service principal
* Adds scope variable to service principal role assingment
* Adds display name variable
* Updates readme and formats files
* Updates readme
* Apply suggestions from code review
Co-Authored-By: Nicholas M. Iodice <niiodice@microsoft.com>
Co-Authored-By: Dexter Williams <dexterwilliams04@gmail.com>
* Updates readme and main.locals per PR
* refactored azure simple hw resources into module
update to gitignore
improve test automation for az hello-world; make access restriction optional
* updated naming schmea
* removed name var from tf.vars
* removed name variable from tfvars
* updated helloworld integ test to always expect eastus datacenter
* improved subnet conditional logic for azure simple module
* azure simple now passes subnet_names to app service module
* subnet creation now keys off of vnet name.
* added wildcard to vscode ignore line
* update app service variable (app storage; formatting)
* removed data dump line from unit test go file; updated http assertion in integ test go file
* removed duplicate local
* remove ref to 'enable storage' from azure simple hw template.'
* Added more detailed descriptions for variables. Removed default values to prompt for necessary information.
* Added more detail to README
* Hide sensitive instrumentation key from console output
* Addressing PR comments
* Minor change to kick off another build
* Altered scripts to work on OSX
* Moved YAML template file to root
* Test
* Revert
* Removed YAML file from root
* Removed caching from docker build command
* Created ACR terraform module
* Added a readme for ACR and changed the service plan reference to a data connection.
* Added tags to module and changed naming scheme
* Fixed some issues pointed out by Erik
* Updated container registry documentation
* Formatted terraform files
Dexter Williams
Megan Meyer
Keith Rome
E (ianphil)
tasdevani21
Stephen Henderson
Nicholas M. Iodice
Erik Schlegel
Erik Schlegel
ericpera-msft
Rachel Simone Weil
Amanda Kaufman