* init - details follow:
- pulled in @nmiodice example
- began docs / README.md
- refactored example to follow other temp's more closely (break out ins & outs), and began massaging terminology to be consistent with other temps, AZ, AzDO, and the README.md
* further alignment with existing doc & use of .env
* ins, outs, and in-betweens defined
* more polish and clean-up
* more in inputs and resources
* Attention to creating the AzDO project (and parameterizing it).
* ignore .env
* align var groups with the latest requirements from Cobalt
* document outputs
* document inputs
* finish detailing in- & out-puts
* Initial commit.
* migrate git ignores into root-most level
* remove 'fixme' and add optional bits to create AzDO projects, as desired
* remove 'fixme' and add optional bits to create AzDO projects, as desired
* merge to upstream repo
* point to 'new' repo and add secret VGs
* lint all the things!
* stub new instructions to get the pipeline running the first time
Co-authored-by: Nicholas M. Iodice <niiodice@microsoft.com>
* Maven Azure Function Pipeline port
* Initialize Readme
* add environment boundaries seciton; update language
* add finishing touches before PR
* fix broken link
Co-authored-by: Dexter Williams <Dexterw@microsoft.com>
* Refactored unit and integration tests to use the terratest-abstraction library
* Fixed go module import issues
* updated readme
* added tlsconfig argument
Co-authored-by: AdanOrtiz <48809118+AdanOrtiz@users.noreply.github.com>
* Initial port
* removing licensing
* add maven service usage example w/ generic service name and updated yaml template paths
* removing licensing, update readme
* updating readme
* removing final service name for maven service pipeline
* update service usage docs
* update language for both markdown files
* add pipeline diagram
* update terminology
* remove non-generic implementation details and variables
* update readme w/ image upload language
* remove unrelated section from readme; per suggestion, reworded to highlight purpose
* update language; update puncuation
Co-authored-by: Dexter Williams <Dexterw@microsoft.com>
* Adding a reference to installing tree.
* Add in the command to show what names for locations are.
* Update the 'fill this in name' to be more precise.
* Add in an image showing what the final result will look like.
* Grammatical fixes, spacing fixes, and adding a bit more clarity in places.
* Undo a change that's not necessary and not in scope
* quick start guide - overview plus more
* quick start guide - az hello world readme plus more
* quick start guide - az hello world readme plus more
* quick start guide - revise overview language
* quick start guide - revise overview language
* quick start guide - revise hello word readme
* quick start guide - revise prereqs plus more
* quick start guide - reform Goals and Objectives plus more
* quick start guide - reformat prequisites and walkthrough title
* quick start guide - remove 'walkthrough' keyword plus more
* quick start guide - outline deployment steps for az-hello-world template
* quick start guide - update prereq table, add terraform links, plus more
* quick start guide - update instructions
* quick start guide - refine forking, cloning and local environment setup
* quick start guide - expand steps for setting up local environment
* quick start guide - expand steps for initializing a terraform environment plus more
* quick start guide - expand steps for major deployment step plus more
* quick start guide - revise deploy cobalt major step, expand validate infrastructure step plus more
* quick start guide - diagramming, quickstart gif and explanation updates
add reference to screen2gif
quick start guide - add azure simple cit architecture diagram in two places
quick start guide - resize azure simple hw architecture diagram in two places
quick start guide - revise language in several places.
quick start guide - refine language, remove 'output' reserved word, replace references to environment with workspace plus more
quick start guide - update title for architecture png, update resource validation with screenshots plus more
quick start guide - update architecture diagrams with app service staging slot plus more
quick start guide - address typo
quick start guide - revise header for architecture diagram, reframe language in final steps plus more
quick start guide - Swap order of goals and objectives list
quick start guide - change quick start to quickstart, revamp intro language
quick start guide - swap gif for much longer one with instrutions
quick start guide - update gif size
Update docs/2_QUICK_START_GUIDE.md
quick start guide - update gif size
* quick start guide - punctuation, retitle architecture diagram
* add easy auth to app service slots
linting adjustment
update existing tests and docs
forego removal of acr webhook integ tests for commenting out as acr webhook is no longer a feature
run go linter
forego removal of acr webhook integ tests but commented them out as acr webhook is no longer a feature
comment out unused imported go modules
restore ad-application count dependency
* removed dead code (acr webhooks are no longer a feature)
* Revert "removed dead code (acr webhooks are no longer a feature)"
This reverts commit fe2c7b7921.
* terraform linting
* Append PR number to TF Workspace Name when available
* Re-order names to preserve full WS name on resources with shorter maxlength
* Resolves 'Vault name must be between 3-24 alphanumeric characters. The name must begin with a letter, end with a letter or digit, and not contain consecutive hyphens.'
* Avoid double dashes in names when 'name' var is not present
* scripted workspace name computation
* Configurable PR and resource name isolation
* Edits to support whitelisting self-hosted build agents.
Also fixes an issue with PNG files when developing Cobalt on Windows machines.
Also has a couple temporary 'prefix' edits to isolate this work stream from the default AZ environment.
* Updating unit test counts
* updating lint error
* updating unit tests
* removing dynamic name key
* formatting
* formatting
* remove workstream-specific prefixes
* update test expectation
* removed out-modded tests
* removed un-needed integration tests
* update test resource count
* disable webhook int testing
* remove source code providing a default for `resource_ip_whitelist`
(demand it is provided at runtime by users)
* remove source code providing a default for `resource_ip_whitelist`
(demand it is provided at runtime by users)
* remove source code providing a default for `resource_ip_whitelist`
(demand it is provided at runtime by users)
* update unit_test to match expectations
* force TF CLI to gen errors for missing-but-required vars
* ensure certain new env vars are exported
* update int test
* remove dead code
* the list of IPs for unit tesings are misleading (these particular values aren't important)
* Explicitly set subscription and resource group for Az CLI commands, using reliable mechanism for resolving subscription ID
* Add explicit params to program blocks as well
* Remove ACR webhook code
* Refactor app service module to not require a container to be specified
for an app service
* Refactor app service module to not care about changes to specified
Docker contianer upon subsequent terraform apply commands
* Refactor isolated template to leave the docker container unspecified
* Update tests to reflect new behavior
* Refactor KV Access Policy to all be created in same way
Prior to this change, KV access policies were being created using the
`azurerm_key_vault` resource as well as the
`azurerm_key_vault_access_policy` resource. This is not advised
based on the documentation found here:
https://www.terraform.io/docs/providers/azurerm/r/key_vault.html#access_policy
* Adding explicit dependecy on keyvault ID with permissions for service principal
* *Refactor single-service template to use locals block
*Resolve names of resources that can be overridden in tfvars
*Refactor HW template to use locals block
*Moved provider to commons.tf
*Following same pattern as other templates for resource naming
*Compute the basename consistently
*Fallback to admin RG for ACR if not specified in TF vars
*Randomization element for HW template resource names
*Randomization element for simple single-service template
*Terraform insists on determinism for count metaproperty
*Randomization element for ISO template
*Include randomized string in shortened names
* Tdevani workingbranch (#274)
* adding commits to pull out resource name into the templates
* updating az-isolated template for single region to update app service module
* *Use name prefixes on app services too
*updating the iso template documentation for inputs & outputs based on the recent changes
*updating readme for single region with the required variables
*Unit test fixes
*Remove resource names from asserts
*Remove resource names that are indeterminate
*Deterministic trigger for webhook creation
*Set ACR flag in ISO template
*Fix webhook URLs
*Remove hardcoded name checks from integration tests
*Webhook Name must be <= 50 chars
*Escaped res group param
*Resolves problems with AZ CLI commands for management of app service ACR pull and authentication
* Missed during rebase
* Global Web App name is capped at 60 characters total (https://docs.microsoft.com/en-us/azure/architecture/best-practices/naming-conventions#web)
* Proper name of trigger
* adding TF_CLI_ARGS as environment variable to pass in additional inputs to the cli
* adding changes to the documentation
* updating the environment template file to take out quotes and leave it as empty
* adding consistency with quotes for apply and destroy
* adding a check to see if the values for the TF_CLI_ARGS are unset or undefined
* removing quotations from the bash scripts for the additional args
* isolate the test env from others
* no dbl-quotes when expansion needed? also more settings to populate
* keep the Cobalt defaults for the example vars
* implement workaround for keyvault versioning in app settings
* Update unit tests with expected count
* Removed extra character from unauth of ase.tf
* add agent `pool` attributes to all `job` defs
* point the `release/provision` jobs at an `agent pool` not a `vmImage`
* move the `pool` def up, alike the build-stage
(and help keep it at the right indentation level)
* Pipeline updates to support configuration of skipping tests, always running jobs, and overriding Git credentials. Added App-specific pipeline to support version-n-go.
* Support env var > parameter > default for forcing the run and skipping tests. Mask PAT from output.
* Added Key Vault access policies for all app service identities.
* Incremented expected resource count since two were added (access policies for unauth app services and access policies for auth app services)
* Update descriptions
* Init empty manual testing plan doc
* manual testing doc outline
* update manual testing plan with scenarios
* Update manual testing plan
* Update manual testing plan
* Update manual testing plan
* Update manual testing plan
* Update manual testing plan
* Update manual testing plan
* WIP test plans for the scenarios. Needs more elaboration.
* Update manual testing plan with diagrams
* Update manual testing plan with diagrams
* Update manual testing plan with link to add pat owner doc
* Added 5th "nginx" test plan
* minor typos
* provide `az acr` examples that are closer to what's needed
provide `az acr import` examples for nginx
* more color on the nginx approach
* add in a weird easy-to-miss permission setting
* tweak notation
* working instructions for self-hosted Linux
* remove VIM command typos
* Design document for version and go
* Updated with info about file location
* Updated with info about pipeline description
* Removed copy/paste remnant
* Updated with setup doc link
* Updated with clarifying remarks about the pipeline location
* Updated with clarifying remarks about files and folders and pipelines
* Updated based on PR comments
* Closes#250 and tests in ISO int tests
* apache thrift go mod fix
* apache thrift go mod fix
* Add replace thrift in mod file
* Added comments to why we are not running specific tests
* changing the formatting setup of the readme and deleting the empty readme
* readjust the table of contents to move design towards the end
* some ideas for project main readme
* Refactor main project README.md to be smaller and reference other more granular README docs. Also added some high level template/module documentation.
* Adding in the main steps for the application developers - TODO adding in detailed instructions and UI images
* updating the getting started for app dev doc...Screenshots to be added
* updating the readme with the screenshots of the az devops portal steps
* Merged getting started documentation into a single feature branch to ensure coverage.
* update getting started doc
* update getting started doc
* update getting started doc
* Updates to docs; added preview feature notes and environment variable groups.
* update getting started doc
* update getting started doc
* update getting started doc
* Added initial cut of CLI version of app dev focused Getting Started
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* Updated with CLI commands
* Fixed removal of unneeded pieces.
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* update getting started doc
* Updates to CLI docs. Broke out steps into separate code blocks versus single code block.
* adding some minor changes to the app dev readme
* Moved getting started docs into new 'docs' directory.
* Updated links and resolved CLI docs comments.
* Update GETTING_STARTED_ADD_PAT_OWNER.md
* Update GETTING_STARTED_APP_DEV_CLI.md
* update getting started doc
* updated az isolated ase template with create authn feature
* add create authn feature; remove preexisting authn feature
* further remove external tenant azuread feature
update az hw unit test
fixed terraform linting errors
updated variable descriptions
* update unit tests
* update app service module dependency order
* refactor iso template web app integ test.
Co-authored-by: Dexter Williams dexterwilliams04@gmail.com
Co-authored-by: Megan Meyer memeyer@microsoft.com
force unit test to pass
force unit test to pass
force unit test to pass
reconcile broken iso template app service unit tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
reconcile broken iso template app service integ** tests
temp bypass vnet and acr integ tests
refactor iso tempalte web app integ test
refactor iso tempalte web app integ test
code review update (comments, yagni, cli)
* Merging master into WIP for IP Whitelist Integration
Consolidating IP Whitelist changes and rebasing from master
Co-authored-by: Tasneem Devani <tasneem.devani@gmail.com>
Co-authored-by: Nick Iodice <nmiodice@gmail.com>
* unit and integration tests for ACR
* adding tests for keyvault and updating the expected whitelist IP address
* adding a minor change to change the keyvault IP rules to be in a list instead of a string
* adding a minor change to the keyvault whitelist IP
* Adding corrected value for whitelist IP block to change from IP Address or Range to Value.
* refactoring to include another function for the subnet
* fixing comment for IP whitelist
* Modifying the IP Rules string to be in CIDR format so that the test does not cause an issue
* Update infra/templates/az-isolated-service-single-region/terraform.tfvars
* fixed go format error
* fixed unit test to look for 1.1.1.1 instead of 1.1.1.1/32
* whitespace change
* * Unified internal/external templates to leverage common templates
* Integrated automated unit/integration testing to CI/CD process
* Generalized integration tests to work across different workspaces
* * Unified internal/external templates to leverage common templates
* Integrated automated unit/integration testing to CI/CD process
* Generalized integration tests to work across different workspaces
* Fixed minor template bugs I found in templates during the process
* Fixed Terraform linting strategy, which was broken after TF 12 upgrade
* Apply suggestions from code review
Adding suggestions from @iphilpot
Co-Authored-By: Ian Philpot <ian.philpot@microsoft.com>
* PR feedback round 1
Dexter Williams
Nicholas M. Iodice
Stephen Henderson
Hannah K
Heba Elayoty
Erik Schlegel
Keith Rome
Erik Schlegel
Megan Meyer
Megan Meyer
E (ianphil)
tasdevani21
Stephen Henderson