dependabot[bot]
7f1186b67b
Bump github/codeql-action from 2.1.9 to 2.1.10 ( #1103 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.1.9 to 2.1.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](7502d6e991...2f58583a1b
)
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-15 12:36:11 -06:00
Alan Jowett
9305a8edb7
Emit line directive for first line of BPF program ( #1101 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-14 21:20:29 -07:00
Shankar Seal
6b98a8d384
cmakefile ( #1075 )
2022-05-13 18:23:18 -06:00
Dave Thaler
b7df2bec27
Document whether to close fds returned from various APIs ( #1095 )
...
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
2022-05-12 16:21:16 -07:00
dependabot[bot]
59fc0838de
Bump external/Catch2 from `d9b0a38` to `ed6b38b` ( #1092 )
...
Bumps [external/Catch2](https://github.com/catchorg/Catch2 ) from `d9b0a38` to `ed6b38b`.
- [Release notes](https://github.com/catchorg/Catch2/releases )
- [Commits](d9b0a38f81...ed6b38b096
)
---
updated-dependencies:
- dependency-name: external/Catch2
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-12 16:46:42 -06:00
Alan Jowett
67baea13b5
Always deref filter context on flow-delete ( #1093 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-12 14:42:20 -07:00
Alan Jowett
e3f06ffc05
Fix write after free ( #1086 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-11 17:55:38 -06:00
Dave Thaler
3a9958f501
Support "netsh ebpf show sections" with native drivers ( #1070 )
...
* WIP: enumerate sections in native code
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Make bpf2c emit section names
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* More of PE section enumeration
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Fix program type and map count display for native programs
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Update cmake files
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Temporarily disable some compiler warnings for the pe-parse project
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Native programs have different sizes for skeleton in debug vs release
Also add text case for section is just ".text"
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Address PR feedback
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Force inlining utility functions inside ebpf programs
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Update expected output
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* More expected output changes
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Fix ebpfapi to allow a single section of name .text
To match libbpf behavior
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Fix test
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Resolve analysis warnings
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Fix analysis warnings
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Address PR comments from Anurag
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Fix test
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
2022-05-11 14:06:49 -07:00
Alan Jowett
80dd532e1f
Save pointer to IO_WORKITEM before completing detach ( #1088 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-11 13:41:54 -06:00
Alan Jowett
09ead0dba6
Move expected output to subfolder ( #1080 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-11 13:04:03 -06:00
Alan Jowett
04dc2904c1
Add negative tests for maps and programs ( #1072 )
...
* Add negative tests for maps and programs
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Tweak tests
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Tweak tests
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Add pin coverage
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix code analysis failure
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Add negative tests for maps and programs
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Tweak tests
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Tweak tests
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Add pin coverage
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix code analysis failure
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-11 12:20:08 -06:00
Alan Jowett
29c2af2a34
Skip checkout of repo for ossar scan ( #1081 )
...
* Skip checkout of repo for ossar scan
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix broken yaml
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix ossar dependency on git
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-11 11:33:36 -06:00
saxena-anurag
3b3a06ee3a
fix regression ( #1084 )
2022-05-11 10:02:25 -07:00
Alan Jowett
a97fec01c6
Revert /Qspectre for ebpf-verifier until performance issues are solved ( #1082 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-11 10:20:01 -06:00
saxena-anurag
377fa0db94
EX_PUSH_LOCK fix ( #1078 )
...
* bugfix
* address PR comments, build break
2022-05-10 19:56:31 -06:00
Alan Jowett
c5cb25b994
Pickup latest ebpf-verifier ( #1077 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: saxena-anurag <43585259+saxena-anurag@users.noreply.github.com>
2022-05-09 16:41:44 -06:00
Dave Thaler
1e1b18e374
Add support for bpf_program__type ( #1074 )
...
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
2022-05-09 10:11:48 -07:00
dependabot[bot]
e55fce64f5
Bump step-security/harden-runner from 1.4.2 to 1.4.3 ( #1068 )
...
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner ) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/step-security/harden-runner/releases )
- [Commits](34cbc43f0b...248ae51c2e
)
---
updated-dependencies:
- dependency-name: step-security/harden-runner
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-08 08:57:17 -07:00
dependabot[bot]
b9d3f0e65e
Bump external/Catch2 from `332de39` to `d9b0a38` ( #1067 )
...
Bumps [external/Catch2](https://github.com/catchorg/Catch2 ) from `332de39` to `d9b0a38`.
- [Release notes](https://github.com/catchorg/Catch2/releases )
- [Commits](332de39cd4...d9b0a38f81
)
---
updated-dependencies:
- dependency-name: external/Catch2
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-07 18:02:17 -06:00
Alan Jowett
c5b44d04e1
Add comments for map declarations ( #1064 )
...
* Add comments for map declarations
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Emit names instead of constants
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix build break
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-06 15:39:57 -06:00
Alan Jowett
d835854796
Add tests for bpf2c CLI interface ( #1062 )
...
* Add tests for bpf2c CLI interface
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix parsing
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-05 16:24:58 -06:00
Alan Jowett
0fdf2a5039
Modify bpf2c output to meet the coding standards. ( #1061 )
...
* Modify bpf2c to generate code that matches coding style.
Switch file extension of expected code to .c so that it enforces
coding style requirements.
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix file-rename in CMakeLists.txt
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix bad merge
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix line splitting
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-05 14:41:13 -06:00
Alan Jowett
9f97deba38
Resolve warnings in bpf2c generated code ( #1058 )
...
* Resolve warnings in bpf2c generated code
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Add negative test cases for raw BPF programs
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Add negative test cases for raw BPF programs
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-03 16:35:50 -06:00
saxena-anurag
dbbbd61b0f
fix ( #1054 )
2022-05-03 09:30:23 -06:00
Alan Jowett
b262f97825
Add SHA256 hash of ELF file when generating native binary ( #1047 )
...
* Add SHA256 hash of ELF file when generating native binary
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix CXX17 deprecation warnings
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
* Fix build
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Add CXXFLAGS
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Move CXX17 suppresion to top-level
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix builds
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Update expected bpf2c output
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Downgrade to LLVM 11 for bpf2c tests
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Revert clang11 in test
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Build sample ELF's with LLVM11
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Additional test cases
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: saxena-anurag <43585259+saxena-anurag@users.noreply.github.com>
2022-05-03 07:40:42 -07:00
Dave Thaler
cc44521dc8
Fix documentation typo ( #1055 )
...
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
2022-05-02 21:21:37 -06:00
Dave Thaler
033c3cc955
Add more bpf() api tests ( #1043 )
...
Fixes #1021
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
2022-05-02 17:40:00 -06:00
Alan Jowett
cd017611cf
Add coverage in bitmap, epoch, and ringbuffer. ( #1007 )
...
* Add coverage in bitmap, epoch, and ringbuffer.
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-02 12:39:58 -06:00
Alan Jowett
cda624862d
Upload cmake artifacts ( #1032 )
...
* Set CMAKE_SYSTEM_VERSION and CMAKE_CXX_STANDARD
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Switch to currently supported SDK version
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Upload build output as artifact.
Resolves : #1030
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-05-01 21:13:41 -06:00
Alan Jowett
80870a9f21
Set CXXFLAGS for ebpf-verifer and catch2 ( #1041 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: saxena-anurag <43585259+saxena-anurag@users.noreply.github.com>
2022-05-01 18:43:11 -06:00
saxena-anurag
dafd950314
Add negative native module tests ( #1039 )
...
* add tests, bugfix
* mark tests for Debug only
* fix build failure
* update cmake file
* Apply suggestions from code review
Co-authored-by: Dave Thaler <dthaler@microsoft.com>
* fix cmakelists
* fix build break
* fix typo
Co-authored-by: Dave Thaler <dthaler@microsoft.com>
2022-05-01 16:26:41 -07:00
saxena-anurag
b99986ab6c
Random crash fix - preemptible workitems ( #1042 )
2022-05-01 15:23:37 -07:00
dependabot[bot]
7c55993568
Bump github/codeql-action from 2.1.8 to 2.1.9 ( #1045 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.1.8 to 2.1.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](1ed1437484...7502d6e991
)
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-01 14:52:10 -06:00
dependabot[bot]
7e83ba30d9
Bump external/Catch2 from `9dc2296` to `332de39` ( #1044 )
...
Bumps [external/Catch2](https://github.com/catchorg/Catch2 ) from `9dc2296` to `332de39`.
- [Release notes](https://github.com/catchorg/Catch2/releases )
- [Commits](9dc229693d...332de39cd4
)
---
updated-dependencies:
- dependency-name: external/Catch2
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-01 12:58:50 -07:00
Alan Jowett
9c1bd80c6e
Switch fuzzing to run on sanitizer build ( #1035 )
...
* Switch fuzzing to run on sanitizer build
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Remove fuzzing coverage from blocking reporting
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-04-30 16:16:43 -07:00
saxena-anurag
24f098b869
workaround ( #1040 )
2022-04-29 18:20:12 -07:00
Alan Jowett
f158c67cb8
Integrate OSSAR (Open Source Static Analysis Runner) ( #1023 )
...
* Integrate OSSAR (Open Source Static Analysis Runner)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-04-29 12:55:55 -06:00
Alan Jowett
5a6c75b114
Set /Qspectre option on generated drivers ( #1022 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-04-29 11:39:12 -06:00
Alan Jowett
988ea276ea
Set CMAKE_SYSTEM_VERSION and CMAKE_CXX_STANDARD ( #1027 )
...
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-04-29 11:11:59 -06:00
Alan Jowett
a511af23b3
Run the CI/CD on push to main (after merge of a PR) ( #1033 )
...
* Run the CI/CD on push to main (after merge of a PR)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-04-28 21:06:52 -06:00
Dave Thaler
1e495e15d2
Add more libbpf api tests ( #1029 )
...
Addresses most of #1021
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Co-authored-by: Alan Jowett <alanjo@microsoft.com>
2022-04-28 15:31:33 -06:00
saxena-anurag
5be88a6432
Implement preemptible work items for user mode ( #1025 )
...
* fix
* cr comments
2022-04-28 09:03:55 -06:00
Alan Jowett
74973a92df
Enable capturing triage dump on test crash ( #1009 )
...
* Enable capturing triage dump on test crash
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* PR feedback
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-04-26 19:42:15 -07:00
Dave Thaler
02212c861c
Use LLVM version 11.0.1 ( #1016 )
...
* Use LLVM version 11.0.1
Fixes #962
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
* Updated expected bpf2c output from LLVM 11
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Co-authored-by: Alan Jowett <alanjo@microsoft.com>
2022-04-26 15:47:56 -06:00
Alan Jowett
ecc4d2d701
Add ETW tracing to CI/CD test run ( #1020 )
...
* Add ETW tracing to CI/CD test run
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Add ETW tracing to CI/CD test run
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Add ETW tracing to CI/CD test run
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix yaml
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Fix yaml
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
* Limit etw to where it makes sense
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2022-04-26 14:37:48 -06:00
saxena-anurag
ece1044444
Add Cilium regression tests ( #1015 )
...
* add cilium tests
* bugfix, fix include path for new tests
* disable verification for Debug build, disable code coverage
* cr comments
2022-04-26 13:59:00 -06:00
dependabot[bot]
aceafb1313
Bump external/Catch2 from `f526ff0` to `9dc2296` ( #1017 )
...
Bumps [external/Catch2](https://github.com/catchorg/Catch2 ) from `f526ff0` to `9dc2296`.
- [Release notes](https://github.com/catchorg/Catch2/releases )
- [Commits](f526ff0fc3...9dc229693d
)
---
updated-dependencies:
- dependency-name: external/Catch2
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-26 10:31:47 -07:00
Alessandro Gario
6a54714ec2
cmake: Add base targets ( #882 )
...
Signed-off-by: Alessandro Gario <alessandro.gario@gmail.com>
2022-04-26 05:39:37 -07:00
Alan Jowett
c26198788d
Set execution policy for powershell scripts ( #1013 )
...
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Co-authored-by: saxena-anurag <43585259+saxena-anurag@users.noreply.github.com>
2022-04-25 14:14:55 -06:00
dependabot[bot]
1266ee29e4
Bump external/ebpf-verifier from `13bf346` to `3a82b04` ( #1008 )
...
* Bump external/ebpf-verifier from `13bf346` to `3a82b04`
Bumps [external/ebpf-verifier](https://github.com/vbpf/ebpf-verifier ) from `13bf346` to `3a82b04`.
- [Release notes](https://github.com/vbpf/ebpf-verifier/releases )
- [Commits](13bf346f33...3a82b04f06
)
---
updated-dependencies:
- dependency-name: external/ebpf-verifier
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update verifier to latest
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dave Thaler <dthaler@microsoft.com>
2022-04-25 13:09:10 -06:00