Pavel Feldman
294f5c965a
chore: fix a lint on win ( #23554 )
2023-06-06 14:50:44 -07:00
Pavel Feldman
037da65d83
chore: fix ui mode tests on windows ( #23553 )
2023-06-06 14:24:42 -07:00
Max Schmitt
85be65b07b
chore: update npx playwright uninstall docs ( #23552 )
2023-06-06 22:09:15 +02:00
Max Schmitt
aab322f2a1
docs(best-practises): recommend no-floating-promises ( #23487 )
...
https://github.com/microsoft/playwright/issues/23339
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
2023-06-06 20:45:46 +02:00
Max Schmitt
8bc26a2b44
chore: wait for downloads getting removed on context.close() ( #23500 )
...
Before there was a race, that we ran into this code:
9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L236-L237)
and then into this code:
9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L429-L431)
which had the side effect, that the first call did not wait. Then
immediately clears the downloads Set and then the second call is a NOOP.
This ends up that the the removal of the downloads can happen after the
context is closed, hence the test is flaky.
Relates to https://github.com/microsoft/playwright/pull/6151 where it
got introduced. So something for @yury-s.
Fixes https://github.com/microsoft/playwright/issues/22525
2023-06-06 20:38:36 +02:00
Max Schmitt
ce2f902c1f
chore: fix UI Mode on Codespaces ( #23549 )
2023-06-06 20:09:39 +02:00
Pavel Feldman
6351630af2
chore: do not show the open error ( #23547 )
2023-06-06 11:09:08 -07:00
Debbie O'Brien
5e0195f7c4
docs: Soft expect example + tobeAttached ( #23475 )
2023-06-06 20:06:55 +02:00
Pavel Feldman
93e6a2f679
chore: print listening on message in terminal for web trace modes ( #23545 )
2023-06-06 10:03:14 -07:00
Pavel Feldman
d4349e5d6f
chore: print listening on message in terminal for web trace modes ( #23546 )
2023-06-06 09:36:49 -07:00
Pavel Feldman
699ac3a0f2
chore: allow opening ui mode over http ( #23536 )
2023-06-06 08:31:52 -07:00
Debbie O'Brien
dfd1518327
docs: explain attachments in ui mode ( #23472 )
2023-06-06 16:30:29 +02:00
Debbie O'Brien
dfe40de1fe
docs: add stderr and stdout to example ( #23474 )
2023-06-06 16:18:41 +02:00
dependabot[bot]
0feef340c9
chore(deps): bump vite from 4.3.3 to 4.3.9 ( #23537 )
2023-06-06 11:12:07 +02:00
Yury Semikhatsky
874f4525b4
fix(merger): total time is sum of shard total times ( #23534 )
2023-06-05 19:10:41 -07:00
Yury Semikhatsky
ceaa29cec1
chore: clear message for no reports ( #23492 )
2023-06-05 17:20:54 -07:00
Andrey Lushnikov
3a00fc4edf
fix: call `focus()` twice to workaround firefox not focusing element ( #23535 )
...
When focus is moved from one tab to another, it might require calling
`focus()` twice to actually focus an element in Firefox.
Fixes https://github.com/microsoft/playwright/issues/23117
2023-06-05 16:46:52 -07:00
Pavel Feldman
eacfff8127
chore: make trace viewer work over http ( #23531 )
2023-06-05 16:30:30 -07:00
Dmitry Gozman
6b687b6d69
fix(toHaveScreenshot): attach newly created missing expectations ( #23528 )
...
Fixes #23090 .
2023-06-05 14:57:06 -07:00
Max Schmitt
0e12831a02
chore: hide 'Open in VSCode' for folders in UI Mode ( #23499 )
2023-06-05 22:09:45 +02:00
KotlinIsland
afa531ef60
feat: Allow multiple trace uploads in the trace viewer ( #23517 )
2023-06-05 12:34:54 -07:00
Rui Figueira
ba69de8c7c
fix(check-deps): normalize paths in posix ( #23513 )
2023-06-05 12:33:54 -07:00
Pavel Feldman
def24c0a14
chore: propagate client-side instrumentation across connect ( #23524 )
...
Fixes https://github.com/microsoft/playwright/issues/23504
2023-06-05 12:28:20 -07:00
Pavel Feldman
2200892ac3
chore: unmute the console flush test ( #23525 )
...
Closes https://github.com/microsoft/playwright/issues/23107
2023-06-05 12:19:25 -07:00
Debbie O'Brien
a7b3c773c4
docs: rework locators to improve visibility ( #23473 )
2023-06-05 19:23:45 +02:00
Playwright Service
d95b6f40a4
feat(webkit): roll to r1860 ( #23494 )
...
Fixes https://github.com/microsoft/playwright/issues/20489
2023-06-05 09:51:39 -07:00
Dmitry Gozman
b518d1f6da
chore: update error message when using wrong cli ( #23512 )
...
Now recommends uninstalling other packages. Fixes #23314 .
Example messages:
```
Please install @playwright/test package before running "npx playwright show-report"
npm uninstall playwright playwright-firefox
npm install -D @playwright/test
```
```
Please install @playwright/test package before running "yarn playwright show-report"
yarn remove playwright playwright-chromium playwright-firefox playwright-webkit
yarn add -D @playwright/test
```
```
Please install @playwright/test package before running "pnpm exec playwright show-report"
pnpm remove playwright
pnpm add -D @playwright/test
```
2023-06-05 09:51:08 -07:00
Max Schmitt
80fe9748eb
chore: render plain class links in types ( #23508 )
2023-06-05 18:50:44 +02:00
Max Schmitt
75971af55b
feat(cli): introduce npx playwright uninstall ( #23128 )
...
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2023-06-05 18:50:21 +02:00
Kristo Jorgenson
d5d155df1f
fix(typescript): allow directory imports ( #23254 )
...
This updates previous work in #22887 to align more fully with
`--moduleResolution=bundler`, allowing index files to be imported with
the /index extension
---------
Signed-off-by: Kristo Jorgenson <kristojorg@users.noreply.github.com>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2023-06-05 08:58:25 -07:00
Max Schmitt
24ac25212b
chore: enable no-floating-promises on playwright-test ( #23484 )
2023-06-05 17:45:56 +02:00
Yury Semikhatsky
f15ea35bfb
fix(devops): remove 10 minutes timeout from merge workflow ( #23515 )
...
Downloading 457Mb of reports with traces (for tracing tests) takes >3
minutes, uploading it to Azure takes >5 minutes which easily exceeds 10
minutes budget.
2023-06-04 15:48:18 -07:00
Max Schmitt
dcc998d58c
chore: fix broken ct-core require ( #23507 )
...
This broke after https://github.com/microsoft/playwright/pull/23449 .
2023-06-04 18:07:42 +02:00
Gary McDonald
718ee69cb8
docs: fix various spelling mistakes in the docs project directory. ( #23510 )
...
Signed-off-by: Gary McDonald <mcdonagj@dukes.jmu.edu>
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2023-06-04 18:04:42 +02:00
Yury Semikhatsky
9cd49d5dd5
test: unflake "should stop tracing on requestContext.dispose()" ( #23489 )
...
Use Chromium instead of Firefox as it navigates faster and remove
timeout from the slow request handler, just make it hang.
Fixes #23116
2023-06-02 16:37:50 -07:00
Dmitry Gozman
e4a1273afa
test: enable user agent override for download in Chromium ( #23479 )
...
Fixes #22843 .
2023-06-02 15:02:54 -07:00
Max Schmitt
00f662531e
Revert "fix(tracing): workaround chromium scrollTop slowness" ( #23486 )
...
This commit reverts f6712ec43a
I manually ran
https://github.com/microsoft/playwright/issues/14037#issuecomment-1122256514
and made sure that the performance did not regress. ~same.
Fixes https://github.com/microsoft/playwright/issues/23455
2023-06-02 23:25:55 +02:00
Yury Semikhatsky
401fc4cb9e
fix(tracing): record available response headers without waiting for extra info ( #23483 )
...
Fixes #23115
2023-06-02 14:15:20 -07:00
Jan Molak
dd3ca6907a
docs: added Serenity/JS to the list of third-party reporters ( #23485 )
2023-06-02 14:13:32 -07:00
Dmitry Gozman
b1974961b0
docs: remove troubleshooting guide ( #23454 )
...
Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2023-06-02 14:13:02 -07:00
Sander
e47b23e5d4
chore(ct): internal types ( #23332 )
2023-06-02 14:11:03 -07:00
Ivaylo Pavlov
e3f91bbabf
Fix header to pass Selenium Grid Capabilities ( #23346 )
...
Fixes : #23345
2023-06-02 13:28:23 -07:00
Dmitriy Dudkevich
7ab754f5d5
fix: render actions in ui mode with browsers from selenium ( #23382 )
2023-06-02 13:24:21 -07:00
Francois La Cock
49c8c6fa33
Update best-practices-js.md ( #23466 )
2023-06-02 13:05:17 -07:00
Pavel Feldman
5a14619bab
chore: render route markers in the trace network panel ( #23476 )
...
Fixes https://github.com/microsoft/playwright/issues/23040
![net](https://github.com/microsoft/playwright/assets/883973/5191163e-63f9-4999-9197-d10dcd09a665 )
2023-06-02 13:00:27 -07:00
Max Schmitt
3c2a8fa306
chore: enable no-floating-promises ESLint rule for tests ( #23376 )
...
https://github.com/microsoft/playwright/issues/23339
2023-06-02 21:59:12 +02:00
Max Schmitt
af893a1019
chore: inherit apiRequestContext timeout from actionTimeout ( #23481 )
...
Fixes https://github.com/microsoft/playwright/issues/23344
2023-06-02 21:36:09 +02:00
Max Schmitt
b21c81d344
devops: add bot for Chromium --headless=new ( #23440 )
...
https://github.com/microsoft/playwright/issues/23389
2023-06-02 20:40:12 +02:00
Max Schmitt
a97bdd0016
chore: update typescript to 5.1.3 ( #23461 )
...
https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/
2023-06-02 18:57:09 +02:00
Dmitry Gozman
835f14d7c9
fix(pause): ignore `page.pause` on the server ( #23417 )
...
Fixes #23051 .
2023-06-02 08:32:30 -07:00