2019-10-16 20:03:47 +03:00
|
|
|
/*
|
2018-09-12 01:27:47 +03:00
|
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
2016-03-17 22:25:07 +03:00
|
|
|
*
|
2018-02-17 05:24:55 +03:00
|
|
|
* This source code is licensed under the MIT license found in the
|
|
|
|
* LICENSE file in the root directory of this source tree.
|
2016-03-17 22:25:07 +03:00
|
|
|
*/
|
|
|
|
|
CocoaPods frameworks compatibility: Step 2 (#25619)
Summary:
This is my proposal for fixing `use_frameworks!` compatibility without breaking all `<React/*>` imports I outlined in https://github.com/facebook/react-native/pull/25393#issuecomment-508457700. If accepted, it will fix https://github.com/facebook/react-native/issues/25349.
It builds on the changes I made in https://github.com/facebook/react-native/pull/25496 by ensuring each podspec has a unique value for `header_dir` so that framework imports do not conflict. Every podspec which should be included in the `<React/*>` namespace now includes it's headers from `React-Core.podspec`.
The following pods can still be imported with `<React/*>` and so should not have breaking changes: `React-ART`,`React-DevSupport`, `React-CoreModules`, `React-RCTActionSheet`, `React-RCTAnimation`, `React-RCTBlob`, `React-RCTImage`, `React-RCTLinking`, `React-RCTNetwork`, `React-RCTPushNotification`, `React-RCTSettings`, `React-RCTText`, `React-RCTSettings`, `React-RCTVibration`, `React-RCTWebSocket` .
There are still a few breaking changes which I hope will be acceptable:
- `React-Core.podspec` has been moved to the root of the project. Any `Podfile` that references it will need to update the path.
- ~~`React-turbomodule-core`'s headers now live under `<turbomodule/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- ~~`React-turbomodulesamples`'s headers now live under `<turbomodulesamples/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- ~~`React-TypeSaferty`'s headers now live under `<TypeSafety/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511040967.
- ~~`React-jscallinvoker`'s headers now live under `<jscallinvoker/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- Each podspec now uses `s.static_framework = true`. This means that a minimum of CocoaPods 1.5 ([released in April 2018](http://blog.cocoapods.org/CocoaPods-1.5.0/)) is now required. This is needed so that the ` __has_include` conditions can still work when frameworks are enabled.
Still to do:
- ~~Including `React-turbomodule-core` with `use_frameworks!` enabled causes the C++ import failures we saw in https://github.com/facebook/react-native/issues/25349. I'm sure it will be possible to fix this but I need to dig deeper (perhaps a custom modulemap would be needed).~~ Addressed by https://github.com/facebook/react-native/pull/25619/commits/33573511f02f3502a28bad48e085e9a4b8608302.
- I haven't got Fabric working yet. I wonder if it would be acceptable to move Fabric out of the `<React/*>` namespace since it is new? �
## Changelog
[iOS] [Fixed] - Fixed compatibility with CocoaPods frameworks.
Pull Request resolved: https://github.com/facebook/react-native/pull/25619
Test Plan:
### FB
```
buck build catalyst
```
### Sample Project
Everything should work exactly as before, where `use_frameworks!` is not in `Podfile`s. I have a branch on my [sample project](https://github.com/jtreanor/react-native-cocoapods-frameworks) here which has `use_frameworks!` in its `Podfile` to demonstrate this is fixed.
You can see that it works with these steps:
1. `git clone git@github.com:jtreanor/react-native-cocoapods-frameworks.git`
2. `git checkout fix-frameworks-subspecs`
3. `cd ios && pod install`
4. `cd .. && react-native run-ios`
The sample app will build and run successfully. To see that it still works without frameworks, remove `use_frameworks!` from the `Podfile` and do steps 3 and 4 again.
### RNTesterPods
`RNTesterPodsPods` can now work with or without `use_frameworks!`.
1. Go to the `RNTester` directory and run `pod install`.
2. Run the tests in `RNTesterPods.xcworkspace` to see that everything still works fine.
3. Uncomment the `use_frameworks!` line at the top of `RNTester/Podfile` and run `pod install` again.
4. Run the tests again and see that it still works with frameworks enabled.
Reviewed By: PeteTheHeat
Differential Revision: D16465247
Pulled By: PeteTheHeat
fbshipit-source-id: cad837e9cced06d30cc5b372af1c65c7780b9e7a
2019-07-25 08:26:42 +03:00
|
|
|
#import <React/RCTImageBlurUtils.h>
|
2016-03-17 22:25:07 +03:00
|
|
|
|
|
|
|
UIImage *RCTBlurredImageWithRadius(UIImage *inputImage, CGFloat radius)
|
|
|
|
{
|
|
|
|
CGImageRef imageRef = inputImage.CGImage;
|
|
|
|
CGFloat imageScale = inputImage.scale;
|
|
|
|
UIImageOrientation imageOrientation = inputImage.imageOrientation;
|
|
|
|
|
|
|
|
// Image must be nonzero size
|
|
|
|
if (CGImageGetWidth(imageRef) * CGImageGetHeight(imageRef) == 0) {
|
|
|
|
return inputImage;
|
|
|
|
}
|
|
|
|
|
|
|
|
//convert to ARGB if it isn't
|
|
|
|
if (CGImageGetBitsPerPixel(imageRef) != 32 ||
|
|
|
|
CGImageGetBitsPerComponent(imageRef) != 8 ||
|
|
|
|
!((CGImageGetBitmapInfo(imageRef) & kCGBitmapAlphaInfoMask))) {
|
|
|
|
UIGraphicsBeginImageContextWithOptions(inputImage.size, NO, inputImage.scale);
|
|
|
|
[inputImage drawAtPoint:CGPointZero];
|
|
|
|
imageRef = UIGraphicsGetImageFromCurrentImageContext().CGImage;
|
|
|
|
UIGraphicsEndImageContext();
|
|
|
|
}
|
|
|
|
|
|
|
|
vImage_Buffer buffer1, buffer2;
|
|
|
|
buffer1.width = buffer2.width = CGImageGetWidth(imageRef);
|
|
|
|
buffer1.height = buffer2.height = CGImageGetHeight(imageRef);
|
|
|
|
buffer1.rowBytes = buffer2.rowBytes = CGImageGetBytesPerRow(imageRef);
|
|
|
|
size_t bytes = buffer1.rowBytes * buffer1.height;
|
|
|
|
buffer1.data = malloc(bytes);
|
|
|
|
buffer2.data = malloc(bytes);
|
2018-08-09 04:24:47 +03:00
|
|
|
if (!buffer1.data || !buffer2.data) {
|
|
|
|
// CWE - 391 : Unchecked error condition
|
|
|
|
// https://www.cvedetails.com/cwe-details/391/Unchecked-Error-Condition.html
|
|
|
|
// https://eli.thegreenplace.net/2009/10/30/handling-out-of-memory-conditions-in-c
|
|
|
|
abort();
|
|
|
|
}
|
2016-03-17 22:25:07 +03:00
|
|
|
|
|
|
|
// A description of how to compute the box kernel width from the Gaussian
|
|
|
|
// radius (aka standard deviation) appears in the SVG spec:
|
|
|
|
// http://www.w3.org/TR/SVG/filters.html#feGaussianBlurElement
|
|
|
|
uint32_t boxSize = floor((radius * imageScale * 3 * sqrt(2 * M_PI) / 4 + 0.5) / 2);
|
|
|
|
boxSize |= 1; // Ensure boxSize is odd
|
|
|
|
|
|
|
|
//create temp buffer
|
|
|
|
void *tempBuffer = malloc((size_t)vImageBoxConvolve_ARGB8888(&buffer1, &buffer2, NULL, 0, 0, boxSize, boxSize,
|
|
|
|
NULL, kvImageEdgeExtend + kvImageGetTempBufferSize));
|
2018-08-09 04:24:47 +03:00
|
|
|
if (!tempBuffer) {
|
|
|
|
// CWE - 391 : Unchecked error condition
|
|
|
|
// https://www.cvedetails.com/cwe-details/391/Unchecked-Error-Condition.html
|
|
|
|
// https://eli.thegreenplace.net/2009/10/30/handling-out-of-memory-conditions-in-c
|
|
|
|
abort();
|
|
|
|
}
|
2016-03-17 22:25:07 +03:00
|
|
|
|
|
|
|
//copy image data
|
|
|
|
CFDataRef dataSource = CGDataProviderCopyData(CGImageGetDataProvider(imageRef));
|
|
|
|
memcpy(buffer1.data, CFDataGetBytePtr(dataSource), bytes);
|
|
|
|
CFRelease(dataSource);
|
|
|
|
|
|
|
|
//perform blur
|
|
|
|
vImageBoxConvolve_ARGB8888(&buffer1, &buffer2, tempBuffer, 0, 0, boxSize, boxSize, NULL, kvImageEdgeExtend);
|
|
|
|
vImageBoxConvolve_ARGB8888(&buffer2, &buffer1, tempBuffer, 0, 0, boxSize, boxSize, NULL, kvImageEdgeExtend);
|
|
|
|
vImageBoxConvolve_ARGB8888(&buffer1, &buffer2, tempBuffer, 0, 0, boxSize, boxSize, NULL, kvImageEdgeExtend);
|
|
|
|
|
|
|
|
//free buffers
|
|
|
|
free(buffer2.data);
|
|
|
|
free(tempBuffer);
|
|
|
|
|
|
|
|
//create image context from buffer
|
|
|
|
CGContextRef ctx = CGBitmapContextCreate(buffer1.data, buffer1.width, buffer1.height,
|
|
|
|
8, buffer1.rowBytes, CGImageGetColorSpace(imageRef),
|
|
|
|
CGImageGetBitmapInfo(imageRef));
|
|
|
|
|
|
|
|
//create image from context
|
|
|
|
imageRef = CGBitmapContextCreateImage(ctx);
|
|
|
|
UIImage *outputImage = [UIImage imageWithCGImage:imageRef scale:imageScale orientation:imageOrientation];
|
|
|
|
CGImageRelease(imageRef);
|
|
|
|
CGContextRelease(ctx);
|
|
|
|
free(buffer1.data);
|
|
|
|
return outputImage;
|
|
|
|
}
|