* Refreshing JSI interfaces to the latest
* Trying to fix build breaks on Apple platforms
* More build break fixes for apple platform .. adding jsilib.h
* Replace space with tab
* Reverting xcodeproj
* Fixing file paths in pbxproj
* Adding jsilib metadata
* Fixing MAC build
* Fixing MAC build
* configured the JS Engine
* cleaned code
* made the requested changes
* removed unwanted files
* added .vscode to gitignore
* made the suggested changes
* made changes mentioned in the comments
Summary:
PR https://github.com/facebook/react-native/pull/24633 introduced some inconsistency in crash messaging, this PR fix it. Asked by mhorowitz
[General] [Added] - Consistent reporting native module name on crash on native side
Pull Request resolved: https://github.com/facebook/react-native/pull/24704
Differential Revision: D15237424
Pulled By: cpojer
fbshipit-source-id: ded8db45b2a2ec9998ff33fdbecef3f12c19578f
// ScriptStore manages versioned storage of both source scripts and prepared scripts. We intent to pass a ScriptSTore implementation
// directly into the JSI runtime from host. It will enable the following,
// 1. Pass richer data and metadata on the source scripts from host to JSI runtime without being constrained by the various layers in between.
// 2. Potential performance benefits as it will allow us to directly stream the source script and the prepared scripts from arbitrary storages and encoding without being constrained by intermediate layers.
// 3. Consolidate Source script versioning and storage logic into a single component.
// 4. Consolidate prepared script storage and persistance formats across platforms and aross JS-engines.
// 5. Allow co-existance of multiple Javascript engines, versions, strategies. (Some more work required to support multi-version)
// 6. Allow platform/storage/engine specific extensions for better performance.
Summary:
After upgrading RN from 0.57 to 0.59.4 we've received a lot of crash reports like `Exception in HostObject::get: <unknown>` with no clue what native module caused the crash. This commit adds native module name on crash in this situations. Related to https://github.com/facebook/react-native/issues/24607.
[General] [Added] - Report native module name on crash when native module has failed to load
Pull Request resolved: https://github.com/facebook/react-native/pull/24633
Differential Revision: D15120225
Pulled By: cpojer
fbshipit-source-id: cf8e3e5953548a58f1d010eb70343da5ee946ae8
Summary:
Related 094f221a0c, restructure the jsi directory, so update the podspec file either.
cc. shergin cpojer
[iOS] [Fixed] - Update jsi podspec to support new directory structure
Pull Request resolved: https://github.com/facebook/react-native/pull/24388
Differential Revision: D14869999
Pulled By: cpojer
fbshipit-source-id: 0a5df7e2ad83702c0498b2f70072735accc7f54c
Summary: This change synchronizes the JSI API with its upstream, aiming to make this easier to automate in the future.
Reviewed By: mhorowitz
Differential Revision: D14783311
fbshipit-source-id: c180d0f728afbeb87a3e8e7331a39c06e73b907e
Summary: This will simplify updating the JSI API from upstream in the future.
Reviewed By: mhorowitz
Differential Revision: D14762674
fbshipit-source-id: fa4a86f08425943e301da4ef3df9893ebaa1493e
* Revert "Updating glog version to latest(0.3.5) which is the version RN is using now (#32)"
This reverts commit 4bfaca4eb5.
* Revert "Adding logging support on droid and logging failure message (#31)"
This reverts commit 7fd45d01b6.
Summary:
This is the couple of hacks I used after I finished #23802 in order to get fabric working on RNTester. This is inspired from prior work by kmagiera.
The goal of this PR is to show others what I’m struggling with, and to eventually merge it sans hacks.
- Yarn Install
- Uncomment the commented out pods in RNTester's pod file
- Open RNTesterPods workspace
- Run App
- this is only for pods, the non-pod RNTester will no longer work until updated with fabric too.
- `SurfaceHostingView` & `SurfaceHostingProxyRootView` both try to start the surface immediately, this leads to a race condition due to the javascript not having loaded yet, the hack here is:
1. Swizzle the `start` method on `RCTFabricSurface` to no-op when called.
2. Add observer for `RCTJavaScriptDidLoadNotification`
3. Call private method `_startAllSurfaces` on `_surfacePresenter` in AppDelegate when we receive `RCTJavaScriptDidLoadNotification`.
[General] [Added] - Use Fabric in RNTester
Pull Request resolved: https://github.com/facebook/react-native/pull/23803
Reviewed By: shergin, mdvacca
Differential Revision: D14450726
Pulled By: fkgozali
fbshipit-source-id: 8ae2d48634fecb60db539aaf0a2c89ba1f572c27
Summary:
Fixes#23459. It is not legal to write the character array of a std::string, and can result in undefined behavior.
[General] [Fixed] - Crash when substring intersects with emoji
Pull Request resolved: https://github.com/facebook/react-native/pull/23609
Differential Revision: D14198159
Pulled By: mdvacca
fbshipit-source-id: 71060b1b99ddab89793c98c09f99ec9974479e62
Anandraj
Yichen Yao
Andrew Coates
REDMOND\acoates
Onti Vals
Christopher Hogan
Rohit Jain (MOD)
Andrew Coates
t-nanava
BarinderGrewal
tudorms
Dmitry Dushkin
Zeyad Salloum
rohitjain85
zhongwuzw
Will Holen
Marc Horowitz
Jacob Bower
REDMOND\acoates
ericlewis