Ramanpreet Nara
c8701b6b36
Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible
...
Summary:
Couldn't make RCTImageEditingManager and RCTImageStoreManager TurboModule-compatible because their specs live in fb-internal code. I will tackle them in a subsequent diff. See T54946472.
Changelog: [iOS][Added] Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible
Reviewed By: PeteTheHeat
Differential Revision: D17936483
fbshipit-source-id: 2266c9ea1ca7ecd52717d9a963e39245da312312
2019-10-21 17:15:33 -07:00
Ramanpreet Nara
d8fda74c24
Move RCTImage NativeModules back to RCTImage
...
Summary:
In D16805827, I moved `RCTImageLoader`, `RCTImageStoreManager`, and `RCTImageEditingManager` to `CoreModules`. This was necessary to turn `RCTImageLoader` into a TurboModule. However, after D17671288 landed, it's no longer necessary to have OSS NativeModules in `CoreModules`. Therefore, I'm moving these NativeModules back to `RCTImage`.
Changelog: [iOS][Fixed] Move RCTImage NativeModules back to RCTImage
Reviewed By: shergin
Differential Revision: D17921612
fbshipit-source-id: 8ae36d2dc8deaf704313cbe2479bfa011ebcbfbc
2019-10-21 17:15:32 -07:00
Peter Argany
06599b3e59
Fix bug in iOS13 nested text rendering
...
Summary:
This fixes a bug reported by Oculus and OSS.
https://github.com/facebook/react-native/issues/26577
When rendering images nested in a `<Text/>` node, on the native side, `RCTTextShadowView` adds an empty NSTextAttachment to the attributed string to add some extra space. The image is then overlaid in the empty space . This all works fine and dandy on iOS12 and below.
Starting in iOS13, an empty NSTextAttachment doesn't render as blank space. It renders as the "missing image" white page. When the real image is overlaid on the white page, it looks super broken. See github issue and test plan for examples.
This fix is to assign an empty image to `NSTextAttachment`. I tried seeing if there was any other attribute we could use to just add white space to an attributed string, but this seems like the best one.
Changelog: [iOS][Fixed] Fixed bug rendering nested text on iOS13
Reviewed By: xyin96
Differential Revision: D18048277
fbshipit-source-id: 711cee96934fc1937d694621a4417c152dde3a31
2019-10-21 16:31:05 -07:00
Joshua Gross
2ea33044bd
Use `getReactApplicationContextIfActiveOrWarn` in modules that access JS or Native modules through ReactApplicationContext
...
Summary:
In D18032458 we introduce `getReactApplicationContextIfActiveOrWarn`. In this diff, modules that access a JS or Native module through ReactApplicationContext need to check if the CatalystInstance is still alive before continuing.
Changelog: [Internal]
Reviewed By: furdei
Differential Revision: D18032788
fbshipit-source-id: 5152783afd0b93b8ce0970fe4a509ea71396a54a
2019-10-21 15:59:21 -07:00
Joshua Gross
b12a29cfcb
Implement `getReactApplicationContextIfActiveOrWarn` in `ReactContextBaseJavaModule` to generalize checking `hasActiveCatalystInstance` and warning when it's dead
...
Summary:
In three previous diffs (D18020359 D17998627 D17969056), I implemented this logic in three different modules. There are potentially hundreds of modules where we should be implementing this check, so I'm moving the important logic into ReactContextBaseJavaModule.
Additionally, `WebSocketModule` was retaining its own copy of ReactApplicationContext instead of using the built-in `getReactApplicationContext`, so I removed that ivar from `WebSocketModule`.
Changelog:
[Internal]
Reviewed By: mdvacca
Differential Revision: D18032458
fbshipit-source-id: 9114120d3b80334df8d2e0813e36d21c667fc1bd
2019-10-21 15:59:21 -07:00
David Vacca
e21ed675ec
Refactor FabricSoLoader to ensure sDidInit is accessed correctly
...
Summary:
sDidInit can be accessed from different threads, this diff refactors the definition of this variable to be volatile and also to be assigned at the end of the staticInit() method.
Changelog:
Ensure proper initialization of FabricSoLoder
Reviewed By: ejanzer
Differential Revision: D18010919
fbshipit-source-id: 3ec7b19fdc15056b90fc01281b8c3888e93a7dd3
2019-10-21 14:42:45 -07:00
Frieder Bluemle
ff6b2ff325
Update Gradle wrapper to 5.6.3 ( #26915 )
...
Summary:
Gradle wrapper `5.6.3`
## Changelog
[Android] [Changed] - Gradle wrapper 5.6.3
Pull Request resolved: https://github.com/facebook/react-native/pull/26915
Test Plan: Builds successfully.
Differential Revision: D18045686
Pulled By: mdvacca
fbshipit-source-id: b2cbe91c42c61aa340c1169d2555c9d821fcf11f
2019-10-21 13:30:52 -07:00
Joshua Gross
cd12f256e9
Change `tearDownReactContext` ordering to prevent null assertion
...
Summary:
In `tearDownReactContext`, `reactContext.destroy()` sets `mCatalystInstance` to null. We cannot call `reactContext.getCatalystInstance()` after that without hitting an assertion. Change ordering so that doesn't happen in reload or teardown.
Changelog: [Internal]
Reviewed By: makovkastar
Differential Revision: D18041279
fbshipit-source-id: 22658dc506b76cf58aee1008841abacfe9410c9d
2019-10-21 11:47:39 -07:00
David Vacca
585dfff22b
Disable preallocation of views in Mounting layer of fabric
...
Summary:
This diff adds an experiment to disable the preallocation of views on the mounting layer of Fabric
Changelog:
Add a ReactNativeConfig to configure the preallocation of views in the mounting layer of Fabric
Reviewed By: shergin
Differential Revision: D17949681
fbshipit-source-id: 0af63df22aff9e94289bc8a8217c79222f1fd61c
2019-10-21 11:47:39 -07:00
Luna Wei
d61b381320
Convert scrollresponder dipatches to native commands
...
Summary: Changelog: [Internal] Convert scrollTo, scrollToEnd, flashScrollIndicators to use native commands
Reviewed By: TheSavior
Differential Revision: D17983169
fbshipit-source-id: 91bb3e6f0890f15717f0a8c15a8b65613856a71d
2019-10-21 11:34:55 -07:00
Andres Suarez
d8560a838b
Tidy up license headers [3/n]
...
Summary: Changelog: [General] [Fixed] - License header cleanup
Differential Revision: D18033336
fbshipit-source-id: 0334bfa2d61314de6ee9e7302205c08574abc0d9
2019-10-21 10:43:00 -07:00
Rick Hanlon
42ac240bce
Don't wrap console methods for metro logging in Chrome debugger ( #26883 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/26883
This diff fixes an issue reported in https://github.com/facebook/react-native/issues/26788 where logs in the Chrome console were showing a different location than previous versions.
In the change here, we stop wrapping the console functions to attach the metro websocket in any environment that isn't a native app environment. We do this by checking `global.nativeLoggingHook` which is bound only by native apps and not environments like the Chrome DevTools.
Changelog: [General][Fixed] - Fix wrong lines logging in Chrome debugger
Reviewed By: cpojer, gaearon
Differential Revision: D17951707
fbshipit-source-id: f045ea9abaa8aecc6afb8eca7db9842146a3d872
2019-10-21 10:05:40 -07:00
Valentin Shergin
50c59aa7f8
Fabric: Changing signature of ShadowNode::replaceChild to avoid shared_from_this()
...
Summary:
This change in the method signature allows removing usage of `shared_from_this()`.
After this change we will have only one usage of `shared_from_this()`.
Changelog: [Internal] Small Fabric-specific optimization.
Reviewed By: sammy-SC
Differential Revision: D17973956
fbshipit-source-id: 19818b0855565d872005062ba2992718ca89b372
2019-10-21 09:44:25 -07:00
Valentin Shergin
7186a65b13
Fabric: Changes in `BaseTextShadowNode` to remove usage of `shared_from_this()`
...
Summary:
This is another step on the journey of removing `enable_shared_from_this`.
It's unclear why we used that before but it's clear now that using shared_ptr here is not necessary because all computation around happens inside the single callstack, so by definition we don't have object life-time concerns here.
Changelog: [Internal] Small Fabric-specific optimization.
Reviewed By: sammy-SC
Differential Revision: D17973957
fbshipit-source-id: 09a65c78e22083ed21b041240307f4858379cc60
2019-10-21 09:44:25 -07:00
Valentin Shergin
c5f704b8e3
Changing signature of `RootShadowNode::clone()` to remove a `shared_from_this()` call
...
Summary:
This is the first diff in the journey of removing `enable_shared_from_this` from `ShadowNode` class.
In general, using `enable_shared_from_this` is fine, it's a normal standard feature and there is nothing wrong with that... besides the fact that using this thing is usually an indication of overall poor design.
In Fabric, we don't really have a good reason for that, I think in all cases it can be avoided, so I think we should remove that.
Removing that is also code-size and perf win.
This particular diff changes the signature of `RootShadowNode::clone()` which allows removing the necessity of usage `.shared_from_this()` from callsites.
The rest changes are purely cosmetical.
Changelog: [Internal] Small Fabric-specific optimization.
Reviewed By: sammy-SC
Differential Revision: D17973958
fbshipit-source-id: 5539ceff9d11b4281a6ebe8d80e90d6bd90e44d8
2019-10-21 09:44:25 -07:00
Dan Abramov
a7e5a0a3dd
React sync for revisions 85d05b3...4eeee35
...
Summary:
This sync includes the following changes:
- **[4eeee358e](https://github.com/facebook/react/commit/4eeee358e )**: [SuspenseList] Store lastEffect before rendering (#17131 ) //<Sebastian Markbåge>//
- **[4fb5bf61d](https://github.com/facebook/react/commit/4fb5bf61d )**: [react-interactions] Fix focus-visible heuristic (#17124 ) //<Nicolas Gallagher>//
- **[8facc0537](https://github.com/facebook/react/commit/8facc0537 )**: [react-interactions] Allow event.preventDefault on LegacyPress responder (#17113 ) //<Dominic Gannaway>//
- **[7cec15155](https://github.com/facebook/react/commit/7cec15155 )**: Remove prefixed concurrent APIs from www build (#17108 ) //<Andrew Clark>//
- **[ed5f010ae](https://github.com/facebook/react/commit/ed5f010ae )**: Client render Suspense content if there's no boundary match (#16945 ) //<Sebastian Markbåge>//
- **[916937563](https://github.com/facebook/react/commit/916937563 )**: [react-interactions] Add onFocusWithin event to FocusWithin responder (#17115 ) //<Dominic Gannaway>//
- **[d7feeb25a](https://github.com/facebook/react/commit/d7feeb25a )**: unstable_createRoot -> createRoot in test (#17107 ) //<Andrew Clark>//
- **[6ff23f2a5](https://github.com/facebook/react/commit/6ff23f2a5 )**: Change retry priority to "Never" for dehydrated boundaries (#17105 ) //<Sebastian Markbåge>//
- **[3ac0eb075](https://github.com/facebook/react/commit/3ac0eb075 )**: Modify Babel React JSX Duplicate Children Fix (#17101 ) //<Luna Ruan>//
- **[43562455c](https://github.com/facebook/react/commit/43562455c )**: Temporary patch www fork with prefixed APIs (#17103 ) //<Andrew Clark>//
- **[9123c479f](https://github.com/facebook/react/commit/9123c479f )**: Enable concurrent APIs in all experimental forks (#17102 ) //<Andrew Clark>//
- **[30c5daf94](https://github.com/facebook/react/commit/30c5daf94 )**: Remove concurrent apis from stable (#17088 ) //<Andrew Clark>//
- **[4cb399a43](https://github.com/facebook/react/commit/4cb399a43 )**: [react-interactions] Modify Scope query mechanism (#17095 ) //<Dominic Gannaway>//
- **[e7704e22a](https://github.com/facebook/react/commit/e7704e22a )**: [babel-plugin-react-jsx] Avoid duplicate "children" key in props object (#17094 ) //<Dominic Gannaway>//
- **[fdba0e5ce](https://github.com/facebook/react/commit/fdba0e5ce )**: Fixed a bug with illegal invocation for Trusted Types (#17083 ) //<Krzysztof Kotowicz>//
- **[d364d8555](https://github.com/facebook/react/commit/d364d8555 )**: Set up experimental builds (#17071 ) //<Andrew Clark>//
- **[d5b54d0c3](https://github.com/facebook/react/commit/d5b54d0c3 )**: [SuspenseList] Fix bugs with dropped Promises (#17082 ) //<Sebastian Markbåge>//
- **[75955bf1d](https://github.com/facebook/react/commit/75955bf1d )**: Pass prod error messages directly to constructor (#17063 ) //<Andrew Clark>//
- **[0ac8e563d](https://github.com/facebook/react/commit/0ac8e563d )**: [react-interactions] Add getInstanceFromNode support to TestHostRenderer (#17065 ) //<Dominic Gannaway>//
- **[22b2642a5](https://github.com/facebook/react/commit/22b2642a5 )**: DevTools test shell tweaks (#17054 ) //<Brian Vaughn>//
- **[4be45be5f](https://github.com/facebook/react/commit/4be45be5f )**: Stop warning about setNativeProps being deprecated (#17045 ) //<Eli White>//
- **[b71ab61c8](https://github.com/facebook/react/commit/b71ab61c8 )**: [react-interactions] Adds more experimental Scope API methods (#17042 ) //<Dominic Gannaway>//
- **[5a71cbe7a](https://github.com/facebook/react/commit/5a71cbe7a )**: Remove unused export //<Andrew Clark>//
- **[71d012ecd](https://github.com/facebook/react/commit/71d012ecd )**: Remove dormant createBatch experiment (#17035 ) //<Andrew Clark>//
- **[cd1b167ad](https://github.com/facebook/react/commit/cd1b167ad )**: [Scheduler Profiler] Use microsecond precision (#17010 ) //<Andrew Clark>//
- **[55731fd8c](https://github.com/facebook/react/commit/55731fd8c )**: [react-interactions] Refine a11y component flow types (#17032 ) //<Dominic Gannaway>//
- **[a011aacaf](https://github.com/facebook/react/commit/a011aacaf )**: [react-interactions] Remove FB builds of a11y components (#17030 ) //<Dominic Gannaway>//
- **[fff5b1ca7](https://github.com/facebook/react/commit/fff5b1ca7 )**: [react-interactions] Add FocusTable colSpan support (#17019 ) //<Dominic Gannaway>//
- **[4bc52ef0d](https://github.com/facebook/react/commit/4bc52ef0d )**: Revert "update hideOrUnhideAllChildren to hide portals that aren't wrapped in a host component (#16992 )" (#17011 ) //<Luna Ruan>//
- **[3a2b5f148](https://github.com/facebook/react/commit/3a2b5f148 )**: [Selective Hydration] ReactDOM.unstable_scheduleHydration(domNode) (#17004 ) //<Sebastian Markbåge>//
- **[26ba38ae4](https://github.com/facebook/react/commit/26ba38ae4 )**: [EnterLeaveEventPlugin] Fix bug when dealing with unhandled DOM nodes (#17006 ) //<Dominic Gannaway>//
- **[d256f88ac](https://github.com/facebook/react/commit/d256f88ac )**: Update local version numbers for 16.10.2 release //<Andrew Clark>//
- **[a8b8ffb89](https://github.com/facebook/react/commit/a8b8ffb89 )**: DevTools v4.1.3 -> v4.2.0 //<Brian Vaughn>//
- **[0545f366d](https://github.com/facebook/react/commit/0545f366d )**: Added trace updates feature (DOM only) (#16989 ) //<Brian Vaughn>//
- **[e09097a75](https://github.com/facebook/react/commit/e09097a75 )**: chore: upgrade to jest 24 (#15778 ) //<Simen Bekkhus>//
- **[5943b1da6](https://github.com/facebook/react/commit/5943b1da6 )**: Fixing grammatical errors in error message (#16973 ) //<Rane Wallin>//
- **[4c5698400](https://github.com/facebook/react/commit/4c5698400 )**: [react-interactions] Remove context.setTimeout & context.clearTimeout (#17000 ) //<Dominic Gannaway>//
- **[b33633d93](https://github.com/facebook/react/commit/b33633d93 )**: [react-interactions] Repurpose React a11y modules (#16997 ) //<Dominic Gannaway>//
- **[de2edc268](https://github.com/facebook/react/commit/de2edc268 )**: update hideOrUnhideAllChildren to hide portals that aren't wrapped in a host component (#16992 ) //<Luna Ruan>//
- **[bb680a090](https://github.com/facebook/react/commit/bb680a090 )**: [Selective Hydration] Prioritize the last continuous target (#16937 ) //<Sebastian Markbåge>//
- **[10277cc5b](https://github.com/facebook/react/commit/10277cc5b )**: Remove unused canonical check in fiber host component (#16914 ) //<Eli White>//
- **[ab1a4f249](https://github.com/facebook/react/commit/ab1a4f249 )**: Move eventSystemFlags to last argument in event plugin extractors (#16978 ) //<Nicolas Gallagher>//
- **[f6efb224b](https://github.com/facebook/react/commit/f6efb224b )**: [react-interactions] Tap cancels on second pointerdown (#16936 ) //<Nicolas Gallagher>//
- **[34457729a](https://github.com/facebook/react/commit/34457729a )**: [react-interactions] Add allowModifiers flag to FocusList + FocusTable (#16971 ) //<Dominic Gannaway>//
- **[b34f042e5](https://github.com/facebook/react/commit/b34f042e5 )**: Fix mouseenter handlers fired twice (#16928 ) //<Rango Yuan>//
- **[2c8832075](https://github.com/facebook/react/commit/2c8832075 )**: React DevTools v4.1.2 -> v.4.1.3 //<Brian Vaughn>//
- **[6c73a1e77](https://github.com/facebook/react/commit/6c73a1e77 )**: Updated DevTools CHANGELOG //<Brian Vaughn>//
- **[6a3de7a41](https://github.com/facebook/react/commit/6a3de7a41 )**: [DevTools] postMessage target origin needs to be '*' for local files (#16953 ) //<David Huang>//
- **[ac8e8b327](https://github.com/facebook/react/commit/ac8e8b327 )**: [react-interactions] Add tab handling to FocusList (#16958 ) //<Dominic Gannaway>//
- **[10c7dfe3b](https://github.com/facebook/react/commit/10c7dfe3b )**: [react-interactins] FocusTable tabScope handling+tabIndex control (#16922 ) //<Dominic Gannaway>//
- **[d3622d0f9](https://github.com/facebook/react/commit/d3622d0f9 )**: chore: updated comment message (#16949 ) //<Kirankumar Ambati>//
- **[2a264a9db](https://github.com/facebook/react/commit/2a264a9db )**: Update local version numbers for 16.10.1 release //<Andrew Clark>//
- **[d8a76ad58](https://github.com/facebook/react/commit/d8a76ad58 )**: Allow Suspense Mismatch on the Client to Silently Proceed (#16943 ) //<Sebastian Markbåge>//
- **[9d637844e](https://github.com/facebook/react/commit/9d637844e )**: Remove enableUserBlockingEvents flag (#16882 ) //<Sebastian Markbåge>//
- **[fe31cc710](https://github.com/facebook/react/commit/fe31cc710 )**: [Selective Hydration] Increase priority for non-synchronous discrete events and retries (#16935 ) //<Sebastian Markbåge>//
- **[b55067961](https://github.com/facebook/react/commit/b55067961 )**: Fixed typo in DevTools CHANGELOG //<Brian Vaughn>//
- **[5184346da](https://github.com/facebook/react/commit/5184346da )**: DevTools v4.1.1 -> v4.1.2 //<Brian Vaughn>//
- **[d4278663c](https://github.com/facebook/react/commit/d4278663c )**: Replaced === check with Object.is() to support values like NaN (#16934 ) //<Brian Vaughn>//
- **[d1121c017](https://github.com/facebook/react/commit/d1121c017 )**: [react-interactions] Fix virtual click heuristic (#16915 ) //<Nicolas Gallagher>//
- **[93f5f11b7](https://github.com/facebook/react/commit/93f5f11b7 )**: Update local version numbers for 16.10 release //<Andrew Clark>//
- **[c8dc7a926](https://github.com/facebook/react/commit/c8dc7a926 )**: expose isHydrating (#16909 ) //<Luna Ruan>//
- **[db8afe4f6](https://github.com/facebook/react/commit/db8afe4f6 )**: Add HostComponent type to ReactNative (#16898 ) //<Eli White>//
- **[fad510210](https://github.com/facebook/react/commit/fad510210 )**: [bugfix] Fix false positive render phase update (#16907 ) //<Andrew Clark>//
- **[a9cd9a765](https://github.com/facebook/react/commit/a9cd9a765 )**: DevTools v4.1.0 -> v4.1.1 //<Brian Vaughn>//
- **[b6606ecba](https://github.com/facebook/react/commit/b6606ecba )**: DevTools shows unsupported renderer version dialog (#16897 ) //<Brian Vaughn>//
- **[84e83db1e](https://github.com/facebook/react/commit/84e83db1e )**: Updated DevTools CHANGELOG //<Brian Vaughn>//
- **[b9811ed5b](https://github.com/facebook/react/commit/b9811ed5b )**: [react-interactions] Add wrapping support to FocusList/FocusTable (#16903 ) //<Dominic Gannaway>//
- **[49b0cb6db](https://github.com/facebook/react/commit/49b0cb6db )**: Moving backend injection to the content script (#16900 ) //<David Huang>//
- **[3694a3b5e](https://github.com/facebook/react/commit/3694a3b5e )**: Selective Hydration (#16880 ) //<Sebastian Markbåge>//
- **[4bb0e96b4](https://github.com/facebook/react/commit/4bb0e96b4 )**: [react-interactions] FocusTable key press bound propgataion (#16895 ) //<Dominic Gannaway>//
- **[fa1a32622](https://github.com/facebook/react/commit/fa1a32622 )**: Update useEditableValue hook to sync external value changes (#16878 ) //<Brian Vaughn>//
- **[57bf275fb](https://github.com/facebook/react/commit/57bf275fb )**: [devtools] Add support for React Scope symbol/number (#16893 ) //<Dominic Gannaway>//
- **[7c3bd08b3](https://github.com/facebook/react/commit/7c3bd08b3 )**: [react-interactions] Add more documentation for a11y components (#16894 ) //<Dominic Gannaway>//
- **[a06d181af](https://github.com/facebook/react/commit/a06d181af )**: Include tag in begin/complete invariant (#16881 ) //<Sebastian Markbåge>//
- **[0d8c0cd09](https://github.com/facebook/react/commit/0d8c0cd09 )**: These flags are hard coded in our internal config (#16883 ) //<Sebastian Markbåge>//
- **[d6d83d706](https://github.com/facebook/react/commit/d6d83d706 )**: [react-interactions] Add Portal propagation configuration (#16889 ) //<Dominic Gannaway>//
- **[d0ebde77f](https://github.com/facebook/react/commit/d0ebde77f )**: [react-interactions] Add initial docs explaining React Scopes (#16892 ) //<Dominic Gannaway>//
- **[32e5c97d1](https://github.com/facebook/react/commit/32e5c97d1 )**: [React Native] Improve errors for invalid ViewConfig getter functions (#16879 ) //<Joshua Gross>//
- **[ebc299fc2](https://github.com/facebook/react/commit/ebc299fc2 )**: [react-interactions] TabFocus -> FocusManager (#16874 ) //<Dominic Gannaway>//
- **[793f176da](https://github.com/facebook/react/commit/793f176da )**: [react-interactions] Make FocusList bundle (#16876 ) //<Dominic Gannaway>//
- **[68a87eee5](https://github.com/facebook/react/commit/68a87eee5 )**: [react-interactions] Add FocusList component (#16875 ) //<Dominic Gannaway>//
- **[18d2e0c03](https://github.com/facebook/react/commit/18d2e0c03 )**: Warning system refactoring (part 1) (#16799 ) //<Jessica Franco>//
- **[8b580a89d](https://github.com/facebook/react/commit/8b580a89d )**: Idle updates should not be blocked by hidden work (#16871 ) //<Andrew Clark>//
- **[c5e7190ed](https://github.com/facebook/react/commit/c5e7190ed )**: [react-interactions] Press with useRef instead of useState (#16870 ) //<Nicolas Gallagher>//
- **[911104a12](https://github.com/facebook/react/commit/911104a12 )**: DevTools CHANGELOG update //<Brian Vaughn>//
- **[bce2ac63a](https://github.com/facebook/react/commit/bce2ac63a )**: Revert change to backend injection method from PR #16752 (#16864 ) //<Brian Vaughn>//
- **[9b3cde9b6](https://github.com/facebook/react/commit/9b3cde9b6 )**: Fix DevTools v4.1 editable hook regression (#16867 ) //<Brian Vaughn>//
- **[1a6294d3e](https://github.com/facebook/react/commit/1a6294d3e )**: [react-interaction] Refactor a11y components more (#16866 ) //<Dominic Gannaway>//
- **[1758b3f7b](https://github.com/facebook/react/commit/1758b3f7b )**: [react-interactions] Add no-op stopPropagation + preventDefault to Press (#16868 ) //<Dominic Gannaway>//
- **[013b7ad11](https://github.com/facebook/react/commit/013b7ad11 )**: [suspense][error handling] Inline renderRoot and fix error handling bug (#16801 ) //<Andrew Clark>//
- **[0a527707c](https://github.com/facebook/react/commit/0a527707c )**: Event Replaying (#16725 ) //<Sebastian Markbåge>//
- **[a87d245fc](https://github.com/facebook/react/commit/a87d245fc )**: [work loop] Prevent work loop from being inlined (#16865 ) //<Andrew Clark>//
- **[312b462d5](https://github.com/facebook/react/commit/312b462d5 )**: [react-interactions] Improve consistency of Tap responder (#16837 ) //<Nicolas Gallagher>//
- **[70754f10d](https://github.com/facebook/react/commit/70754f10d )**: [react-interaction] Tweak Focus Table component (#16862 ) //<Dominic Gannaway>//
- **[d7f6dd5a8](https://github.com/facebook/react/commit/d7f6dd5a8 )**: [react-interactions] Fix typo in FocusTable (#16860 ) //<Dominic Gannaway>//
- **[cef47cbc0](https://github.com/facebook/react/commit/cef47cbc0 )**: Rename experimental react-ui => react-interactions (#16842 ) //<Dan Abramov>//
- **[57a5805a9](https://github.com/facebook/react/commit/57a5805a9 )**: [react-ui] Add preventDefault+stopPropagation to Keyboard + update Focus components (#16833 ) //<Dominic Gannaway>//
- **[08b51aa38](https://github.com/facebook/react/commit/08b51aa38 )**: Added React DevTools v4.1.0 release date to CHANGELOG //<Brian Vaughn>//
- **[b5cebedfb](https://github.com/facebook/react/commit/b5cebedfb )**: React DevTools version bump 4.0.6 -> 4.1.0 //<Brian Vaughn>//
- **[fd870e6b6](https://github.com/facebook/react/commit/fd870e6b6 )**: [react-ui/events] Tap responder API changes (#16827 ) //<Nicolas Gallagher>//
- **[4ddcb8e13](https://github.com/facebook/react/commit/4ddcb8e13 )**: [DevTools] Remove Welcome dialog (#16834 ) //<Dan Abramov>//
- **[924a30578](https://github.com/facebook/react/commit/924a30578 )**: [react-ui] Remove event object warnings (#16822 ) //<Dominic Gannaway>//
- **[a5df18a9e](https://github.com/facebook/react/commit/a5df18a9e )**: prevent firefox marking required textareas invalid (#16578 ) //<halvves>//
- **[f818af9b0](https://github.com/facebook/react/commit/f818af9b0 )**: [Fresh] Always remount classes (#16823 ) //<Dan Abramov>//
- **[6ecfa90eb](https://github.com/facebook/react/commit/6ecfa90eb )**: [React Native] Fix for view config registrations (#16821 ) //<Ricky>//
- **[18cb59050](https://github.com/facebook/react/commit/18cb59050 )**: [react-core] Do not null fiber.sibling in detachFiber (#16820 ) //<Dominic Gannaway>//
- **[d862f0ea5](https://github.com/facebook/react/commit/d862f0ea5 )**: Optimize objectIs (#16212 ) //<Kuba Juszczyk>//
- **[d1c255586](https://github.com/facebook/react/commit/d1c255586 )**: [react-devtools-shared] Added string type check for object name prop in getDisplayName function (#16798 ) //<Pavlo Tymchuk>//
- **[70dcdd265](https://github.com/facebook/react/commit/70dcdd265 )**: Updated pending CHANGELOG for DevTools //<Brian Vaughn>//
- **[8f1533f4d](https://github.com/facebook/react/commit/8f1533f4d )**: [react-ui] Fix bundle name [hotfix] (#16811 ) //<Dominic Gannaway>//
- **[7c802de79](https://github.com/facebook/react/commit/7c802de79 )**: [react-a11y] Add react-ui/accessibility to bundle build (#16804 ) //<Dominic Gannaway>//
- **[901139c29](https://github.com/facebook/react/commit/901139c29 )**: [scheduler][profiler] Start time of delayed tasks (#16809 ) //<Andrew Clark>//
- **[f40ceb001](https://github.com/facebook/react/commit/f40ceb001 )**: [react-ui] FocusGrid -> ReactFocusTable + tweaks and fixes (#16806 ) //<Dominic Gannaway>//
- **[2f1e8c5f7](https://github.com/facebook/react/commit/2f1e8c5f7 )**: [react-core] Clear more properties in detachFiber (#16807 ) //<Dominic Gannaway>//
- **[8e0c57412](https://github.com/facebook/react/commit/8e0c57412 )**: Follow-up to initial Trusted Types support (#16795 ) //<Dan Abramov>//
- **[3af05de1a](https://github.com/facebook/react/commit/3af05de1a )**: [react-ui] usePress from useKeyboard and useTap (#16772 ) //<Nicolas Gallagher>//
- **[494300b36](https://github.com/facebook/react/commit/494300b36 )**: [react-ui] Move experimental event+a11y work to react-ui package (#16794 ) //<Dominic Gannaway>//
- **[9691eb273](https://github.com/facebook/react/commit/9691eb273 )**: [react-events] Keyboard support for virtual clicks (#16780 ) //<Nicolas Gallagher>//
- **[b8d079b41](https://github.com/facebook/react/commit/b8d079b41 )**: Add trusted types to react on client side (#16157 ) //<Emanuel Tesař>//
- **[cdbfa5044](https://github.com/facebook/react/commit/cdbfa5044 )**: fix typo inteval -> interval & continutation -> continuation (#16760 ) //<Heaven>//
- **[45b6443c9](https://github.com/facebook/react/commit/45b6443c9 )**: Spelling is fundamental (#16782 ) //<Andrew Clark>//
- **[45898d0be](https://github.com/facebook/react/commit/45898d0be )**: [Scheduler] Prevent event log from growing unbounded (#16781 ) //<Andrew Clark>//
- **[87eaa90ef](https://github.com/facebook/react/commit/87eaa90ef )**: [react-events] Keyboard calls preventDefault on 'click' events (#16779 ) //<Nicolas Gallagher>//
- **[0c0b30b8c](https://github.com/facebook/react/commit/0c0b30b8c )**: Remove unnecessary interaction tracing ping wrapper (#16777 ) //<Brian Vaughn>//
- **[137ea783b](https://github.com/facebook/react/commit/137ea783b )**: Re-enable risky work loop changes (#16771 ) //<Andrew Clark>//
- **[d6f6b951e](https://github.com/facebook/react/commit/d6f6b951e )**: Support disabling interaction tracing for suspense promises (#16776 ) //<Brian Vaughn>//
- **[b4b8a349a](https://github.com/facebook/react/commit/b4b8a349a )**: [react-interactions] Add experimental FocusGrid API (#16766 ) //<Dominic Gannaway>//
- **[a7dabcb60](https://github.com/facebook/react/commit/a7dabcb60 )**: Revert "Re-arrange slightly to prevent refactor hazard (#16743 )" (#16769 ) //<Andrew Clark>//
- **[4b0b556dc](https://github.com/facebook/react/commit/4b0b556dc )**: [react-interactions] Refactor TabFocusController (#16768 ) //<Dominic Gannaway>//
- **[fb39f6292](https://github.com/facebook/react/commit/fb39f6292 )**: Added upcoming changes to DevTools CHANGELOG //<Brian Vaughn>//
- **[ba932a5ad](https://github.com/facebook/react/commit/ba932a5ad )**: fix: inspect ClassComponent.render instead of constructor, fixes #16749 (#16759 ) //<Anton Korzunov>//
- **[35a202d0e](https://github.com/facebook/react/commit/35a202d0e )**: [react-events] Ensure we restore currentInstance + currentTimers (#16758 ) //<Dominic Gannaway>//
- **[3717c25a7](https://github.com/facebook/react/commit/3717c25a7 )**: [react-interactions] More Tab Focus control handling (#16751 ) //<Dominic Gannaway>//
- **[0a2215cc0](https://github.com/facebook/react/commit/0a2215cc0 )**: [Scheduler][www] Put profiling feature behind flag (#16757 ) //<Andrew Clark>//
- **[efa780d0a](https://github.com/facebook/react/commit/efa780d0a )**: Removed DT inject() script since it's no longer being used //<Brian Vaughn>//
- **[4290967d4](https://github.com/facebook/react/commit/4290967d4 )**: Merge branch 'tt-compat' of https://github.com/onionymous/react into onionymous-tt-compat //<Brian Vaughn>//
- **[f09854a9e](https://github.com/facebook/react/commit/f09854a9e )**: Moved inline comment. //<Brian Vaughn>//
- **[776d1c69b](https://github.com/facebook/react/commit/776d1c69b )**: Lint fixes //<Stephanie Ding>//
- **[2e75000f4](https://github.com/facebook/react/commit/2e75000f4 )**: Removed done(), added some comments explaining the change //<Stephanie Ding>//
- **[8a6cd3cd1](https://github.com/facebook/react/commit/8a6cd3cd1 )**: remove ability to inject arbitrary scripts //<Stephanie Ding>//
- **[d51f062d0](https://github.com/facebook/react/commit/d51f062d0 )**: Formatting changes //<Stephanie Ding>//
- **[85c721101](https://github.com/facebook/react/commit/85c721101 )**: Moved injection logic to content script //<Stephanie Ding>//
- **[788036c7e](https://github.com/facebook/react/commit/788036c7e )**: Moved backend injection logic to content script //<Stephanie Ding>//
- **[c93038fab](https://github.com/facebook/react/commit/c93038fab )**: Moved backend injection logic to content script //<Stephanie Ding>//
- **[3a49dff38](https://github.com/facebook/react/commit/3a49dff38 )**: [react-events] Use context.objectAssign in Tap responder (#16748 ) //<Dominic Gannaway>//
- **[56114a4b2](https://github.com/facebook/react/commit/56114a4b2 )**: Change `trackedTouchCount` console.error to warn (#16750 ) //<Matt Kane>//
- **[ae724be7b](https://github.com/facebook/react/commit/ae724be7b )**: [react-interactions] Add TabFocusContainer and TabbableScope UI components (#16732 ) //<Dominic Gannaway>//
- **[ab4951fc0](https://github.com/facebook/react/commit/ab4951fc0 )**: Re-arrange slightly to prevent refactor hazard (#16743 ) //<Andrew Clark>//
- **[b0a8a3e04](https://github.com/facebook/react/commit/b0a8a3e04 )**: Mark root as already hydrated after committing (#16739 ) //<Sebastian Markbåge>//
- **[e04f4259c](https://github.com/facebook/react/commit/e04f4259c )**: Handle SuspenseListComponent getting retried (#16745 ) //<Sebastian Markbåge>//
- **[2c98af77c](https://github.com/facebook/react/commit/2c98af77c )**: DevTools: Props editing interface tweaks (#16740 ) //<Brian Vaughn>//
- **[2ce5801c2](https://github.com/facebook/react/commit/2ce5801c2 )**: Added upcoming changes to DevTools CHANGELOG //<Brian Vaughn>//
- **[709baf1fe](https://github.com/facebook/react/commit/709baf1fe )**: [DevTools] Support for adding props | Improved state/props value editing (#16700 ) //<Hristo Kanchev>//
- **[4ef6387d6](https://github.com/facebook/react/commit/4ef6387d6 )**: [DevTools] [Context] Legacy Context (#16617 ) //<Hristo Kanchev>//
- **[c317fc273](https://github.com/facebook/react/commit/c317fc273 )**: Correct link for troubleshooting react-dev-tools (#16690 ) (#16708 ) //<Liad Yosef>//
- **[41a78cd85](https://github.com/facebook/react/commit/41a78cd85 )**: [react-events] Tap: add maximumDistance prop (#16689 ) //<Nicolas Gallagher>//
- **[240040078](https://github.com/facebook/react/commit/240040078 )**: react-refresh@0.4.2 //<Dan Abramov>//
- **[ba6bb0fcc](https://github.com/facebook/react/commit/ba6bb0fcc )**: [Fresh] Hash signatures (#16738 ) //<Dan Abramov>//
- **[fd3e8cb0a](https://github.com/facebook/react/commit/fd3e8cb0a )**: [react-events] Remove stopPropagation (Press) + use document for delegation (#16730 ) //<Dominic Gannaway>//
- **[38c03ce00](https://github.com/facebook/react/commit/38c03ce00 )**: Fix typo in commet (#16727 ) //<Heaven>//
- **[4905590e1](https://github.com/facebook/react/commit/4905590e1 )**: Fixed font family issue in FF. (#16701 ) //<Hristo Kanchev>//
- **[35f447ddb](https://github.com/facebook/react/commit/35f447ddb )**: Remove console.log from copyWithSet (#16716 ) //<Daniel Lo Nigro>//
- **[440cbf2ee](https://github.com/facebook/react/commit/440cbf2ee )**: Let's schedule the passive effects even earlier (#16714 ) //<Sebastian Markbåge>//
- **[cc2492ccf](https://github.com/facebook/react/commit/cc2492ccf )**: Schedule passive callbacks before layout effects are invoked (#16713 ) //<Sebastian Markbåge>//
- **[031eba789](https://github.com/facebook/react/commit/031eba789 )**: [react-events] Tap: change order of events (#16694 ) //<Nicolas Gallagher>//
- **[f26fe8c0a](https://github.com/facebook/react/commit/f26fe8c0a )**: [react-events] Keyboard: fix callback return types (#16693 ) //<Nicolas Gallagher>//
- **[9444c876d](https://github.com/facebook/react/commit/9444c876d )**: Remove wrong copy-paste code in test (#16695 ) //<Heaven>//
- **[b260bef39](https://github.com/facebook/react/commit/b260bef39 )**: [Fresh] Add skipEnvCheck option to Babel plugin (#16688 ) //<Dan Abramov>//
- **[2f1588185](https://github.com/facebook/react/commit/2f1588185 )**: react-refresh@0.4.1 //<Dan Abramov>//
- **[9044bb0fa](https://github.com/facebook/react/commit/9044bb0fa )**: [Fresh] Fix a crash with implicit arrow return (#16687 ) //<Dan Abramov>//
- **[21d79ce04](https://github.com/facebook/react/commit/21d79ce04 )**: Add FreshRuntime WWW bundle, remove ESLint (#16684 ) //<Dan Abramov>//
- **[206d61f72](https://github.com/facebook/react/commit/206d61f72 )**: fix typos on react-devtools comments (#16681 ) //<Alex Rohleder>//
- **[61836fba2](https://github.com/facebook/react/commit/61836fba2 )**: Fix typo: wnless -> unless (#16680 ) //<Heaven>//
- **[e11bf42ce](https://github.com/facebook/react/commit/e11bf42ce )**: Check for Suspense boundary in a root Container (#16673 ) //<Sebastian Markbåge>//
- **[962dfc2c3](https://github.com/facebook/react/commit/962dfc2c3 )**: Remove experimental scheduler flags (#16672 ) //<Dan Abramov>//
- **[ff006451a](https://github.com/facebook/react/commit/ff006451a )**: [react-events] Fix isTargetWithinNode type (#16671 ) //<Nicolas Gallagher>//
- **[040ca0fad](https://github.com/facebook/react/commit/040ca0fad )**: Enable MessageLoop implementation by default (#16408 ) //<Dan Abramov>//
- **[d96f478f8](https://github.com/facebook/react/commit/d96f478f8 )**: use-subscription tearing fix (#16623 ) //<Brian Vaughn>//
- **[79e46b677](https://github.com/facebook/react/commit/79e46b677 )**: updated flags from false to dicated on www (#16647 ) //<Luna Ruan>//
- **[8d7c733f1](https://github.com/facebook/react/commit/8d7c733f1 )**: [Partial Hydration] Don't invoke listeners on parent of dehydrated event target (#16591 ) //<Sebastian Markbåge>//
- **[9ce8711d5](https://github.com/facebook/react/commit/9ce8711d5 )**: [react-events] Tap responder (#16628 ) //<Nicolas Gallagher>//
- **[e86146e71](https://github.com/facebook/react/commit/e86146e71 )**: [react-events] Refine executeUserEventHandler (#16662 ) //<Dominic Gannaway>//
- **[c66edb9f8](https://github.com/facebook/react/commit/c66edb9f8 )**: [react-events] Refactor getCurrentTarget to getResponderNode (#16660 ) //<Dominic Gannaway>//
- **[9ff60ff16](https://github.com/facebook/react/commit/9ff60ff16 )**: [react-events] Fix Scope listener issue (#16658 ) //<Dominic Gannaway>//
- **[7126a37bf](https://github.com/facebook/react/commit/7126a37bf )**: [react-events] Keyboard responder propagation handling (#16657 ) //<Dominic Gannaway>//
- **[539640d89](https://github.com/facebook/react/commit/539640d89 )**: [react-events] Various core tweaks for event responder system (#16654 ) //<Dominic Gannaway>//
- **[af032764a](https://github.com/facebook/react/commit/af032764a )**: [react-events] Adds preventKeys support to Keyboard responder (#16642 ) //<Dominic Gannaway>//
- **[f705e2bac](https://github.com/facebook/react/commit/f705e2bac )**: Updated pending CHANGELOG for DevTools //<Brian Vaughn>//
- **[77bb10239](https://github.com/facebook/react/commit/77bb10239 )**: [DevTools] [Profiler]: Save profile now working in Firefox (#16612 ) //<Hristo Kanchev>//
- **[92f094d86](https://github.com/facebook/react/commit/92f094d86 )**: fix typo: oncurrent - concurrent (#16633 ) //<Heaven>//
- **[46f912fd5](https://github.com/facebook/react/commit/46f912fd5 )**: [react-core] Add more support for experimental React Scope API (#16621 ) //<Dominic Gannaway>//
- **[f962feb88](https://github.com/facebook/react/commit/f962feb88 )**: Updated extensions build-from-source instructions in README //<Brian Vaughn>//
- **[4e544cffe](https://github.com/facebook/react/commit/4e544cffe )**: [react-events] Split out mixed event responder tests (#16608 ) //<Dominic Gannaway>//
- **[f61138e06](https://github.com/facebook/react/commit/f61138e06 )**: Use renderToStaticMarkup for tests (#16516 ) //<Gerald Monaco>//
- **[980112b14](https://github.com/facebook/react/commit/980112b14 )**: rephrase comment (#16559 ) //<James George>//
- **[8a7c2e50f](https://github.com/facebook/react/commit/8a7c2e50f )**: Remove duplicate character in regex group (#16572 ) //<Bas Peeters>//
- **[557d472fe](https://github.com/facebook/react/commit/557d472fe )**: add <thead>, <tfoot> to table > tr warning (#16535 ) //<Tom Quirk>//
- **[bd79be9b6](https://github.com/facebook/react/commit/bd79be9b6 )**: [react-core] Add experimental React Scope component API (#16587 ) //<Dominic Gannaway>//
- **[996acf903](https://github.com/facebook/react/commit/996acf903 )**: Updated DevTools extension build script to work when run remotely (#16603 ) //<Brian Vaughn>//
- **[34aaec6f9](https://github.com/facebook/react/commit/34aaec6f9 )**: [react-events] Ensure screen reader virtual clicks support preventDefault (#16600 ) //<Dominic Gannaway>//
- **[01fb68b9b](https://github.com/facebook/react/commit/01fb68b9b )**: Don't ignore dependencies for render phase update (#16574 ) //<Dan Abramov>//
- **[b034ac6d3](https://github.com/facebook/react/commit/b034ac6d3 )**: Merge branch 'master' into devtools-v4-merge //<Brian Vaughn>//
- **[f51253775](https://github.com/facebook/react/commit/f51253775 )**: Babel Transform JSX to React.jsx/React.jsxDEV Plugin (#16432 ) //<Luna Ruan>//
- **[cb15f18dc](https://github.com/facebook/react/commit/cb15f18dc )**: [react-events] Improve mock event object accuracy (#16590 ) //<Nicolas Gallagher>//
- **[bc8b15332](https://github.com/facebook/react/commit/bc8b15332 )**: Updated README docs, example screenshots, etc //<Brian Vaughn>//
- **[7153dd516](https://github.com/facebook/react/commit/7153dd516 )**: Fixed a StyleEditor variable resolution regression //<Brian Vaughn>//
- **[33d439f8f](https://github.com/facebook/react/commit/33d439f8f )**: Merge branch 'master' into devtools-v4-merge //<Brian Vaughn>//
- **[4ef269606](https://github.com/facebook/react/commit/4ef269606 )**: [react-events] Support screen reader virtual clicks (#16584 ) //<Dominic Gannaway>//
- **[fb316787c](https://github.com/facebook/react/commit/fb316787c )**: Removed unused Chrome Flow types //<Brian Vaughn>//
- **[8e1434e80](https://github.com/facebook/react/commit/8e1434e80 )**: Added FB copyright header //<Brian Vaughn>//
- **[49b0f87d1](https://github.com/facebook/react/commit/49b0f87d1 )**: Suppress act/renderer warning for DevTools tests //<Brian Vaughn>//
- **[8c684bf7e](https://github.com/facebook/react/commit/8c684bf7e )**: Removed forked DevTools Flow types //<Brian Vaughn>//
- **[9a016c0c2](https://github.com/facebook/react/commit/9a016c0c2 )**: Removed outdated snapshot //<Brian Vaughn>//
- **[896c993ad](https://github.com/facebook/react/commit/896c993ad )**: Fixed remaining DevTools broken tests by fixing a hydration/spread bug //<Brian Vaughn>//
- **[e3cc42be9](https://github.com/facebook/react/commit/e3cc42be9 )**: Fix Console patching test by resetting modules //<Brian Vaughn>//
- **[177f357d9](https://github.com/facebook/react/commit/177f357d9 )**: Updated DevTools test setup to no longer mock test renerer //<Brian Vaughn>//
- **[a48593a8d](https://github.com/facebook/react/commit/a48593a8d )**: Iterating on DevTools tests: Trying to run tests against pre-build react-dom and react-test-renderers //<Brian Vaughn>//
- **[ee4806f47](https://github.com/facebook/react/commit/ee4806f47 )**: Fixed flushing problem with tests //<Brian Vaughn>//
- **[9d4fd7a24](https://github.com/facebook/react/commit/9d4fd7a24 )**: Merged changes from 4.0.5 -> 4.0.6 from DevTools fork //<Brian Vaughn>//
- **[a39d9c3df](https://github.com/facebook/react/commit/a39d9c3df )**: 4.0.5 -> 4.0.6 //<Brian Vaughn>//
- **[84b492f34](https://github.com/facebook/react/commit/84b492f34 )**: Polyfill Symbol usage //<Brian Vaughn>//
- **[c00a92064](https://github.com/facebook/react/commit/c00a92064 )**: Merge branch 'master' into devtools-v4-merge //<Brian Vaughn>//
- **[0da7bd060](https://github.com/facebook/react/commit/0da7bd060 )**: React DevTools CHANGELOG entry for 4.0.6 //<Brian Vaughn>//
- **[fc8077207](https://github.com/facebook/react/commit/fc8077207 )**: [react-events] Ensure updateEventListeners updates in commit phase (#16540 ) //<Dominic Gannaway>//
- **[0f6e3cd61](https://github.com/facebook/react/commit/0f6e3cd61 )**: [Scheduler] Profiler Features (second try) (#16542 ) //<Dan Abramov>//
- **[474b650ca](https://github.com/facebook/react/commit/474b650ca )**: [react-events] Rename hook exports (#16533 ) //<Nicolas Gallagher>//
- **[2f03aa6ee](https://github.com/facebook/react/commit/2f03aa6ee )**: [react-events] Fix middle-click for Press (#16546 ) //<Nicolas Gallagher>//
- **[16c340863](https://github.com/facebook/react/commit/16c340863 )**: Only warn in case the fourth argument is a function (#16543 ) //<Bruno Scopelliti>//
- **[05f5192e8](https://github.com/facebook/react/commit/05f5192e8 )**: [Partial Hydration] Dispatching events should not work until hydration commits (#16532 ) //<Sebastian Markbåge>//
- **[8a01b50fc](https://github.com/facebook/react/commit/8a01b50fc )**: eslint-plugin-react-hooks@2.0.1 //<Dan Abramov>//
- **[3ed289b3b](https://github.com/facebook/react/commit/3ed289b3b )**: Clear canceled task node early (#16403 ) //<Dan Abramov>//
- **[067282905](https://github.com/facebook/react/commit/067282905 )**: Bump ESLint plugin to 2.0 (#16528 ) //<Dan Abramov>//
- **[2559111c2](https://github.com/facebook/react/commit/2559111c2 )**: [react-events] Rely on 'buttons' rather than 'button' (#16479 ) //<Nicolas Gallagher>//
- **[c433fbb59](https://github.com/facebook/react/commit/c433fbb59 )**: Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455 )"" (#16525 ) //<Dan Abramov>//
- **[507f0fb37](https://github.com/facebook/react/commit/507f0fb37 )**: Revert "[ESLint] Forbid top-level use*() calls (#16455 )" (#16522 ) //<Sunil Pai>//
- **[66c9fedc3](https://github.com/facebook/react/commit/66c9fedc3 )**: Flow fixes //<Brian Vaughn>//
- **[2e549efae](https://github.com/facebook/react/commit/2e549efae )**: Moved DevTools custom Flow definitions //<Brian Vaughn>//
- **[4da836af7](https://github.com/facebook/react/commit/4da836af7 )**: Merged changes from 4.0.0 -> 4.0.5 from DevTools fork //<Brian Vaughn>//
- **[5441b094a](https://github.com/facebook/react/commit/5441b094a )**: 4.0.4 -> 4.0.5 //<Brian Vaughn>//
- **[d2456c757](https://github.com/facebook/react/commit/d2456c757 )**: Fixed standalone target not properly serving backend over localhost:8097 //<Brian Vaughn>//
- **[3c6a21946](https://github.com/facebook/react/commit/3c6a21946 )**: 4.0.3 -> 4.0.4 //<Brian Vaughn>//
- **[95ca07955](https://github.com/facebook/react/commit/95ca07955 )**: Fixed standalone bug that prevented backend from being served over localhost:8097 //<Brian Vaughn>//
- **[95ffd3ccf](https://github.com/facebook/react/commit/95ffd3ccf )**: 4.0.2 -> 4.0.3 //<Brian Vaughn>//
- **[2bcc6c6d0](https://github.com/facebook/react/commit/2bcc6c6d0 )**: 4.0.1 -> 4.0.2 //<Brian Vaughn>//
- **[c100cc7b3](https://github.com/facebook/react/commit/c100cc7b3 )**: 4.0.0 -> 4.0.1 //<Brian Vaughn>//
- **[0763c48ed](https://github.com/facebook/react/commit/0763c48ed )**: Bumped all versions to 4.0.0 //<Brian Vaughn>//
- **[732f3a6ef](https://github.com/facebook/react/commit/732f3a6ef )**: 4.0.0-alpha.9 -> 4.0.0-alpha.10 //<Brian Vaughn>//
- **[db9e5c971](https://github.com/facebook/react/commit/db9e5c971 )**: Updated all GitHub links to point to React repo //<Brian Vaughn>//
- **[833f20634](https://github.com/facebook/react/commit/833f20634 )**: Merge branch 'master' into devtools-v4-merge //<Brian Vaughn>//
- **[efa5dbe7a](https://github.com/facebook/react/commit/efa5dbe7a )**: Update CHANGELOG.md (#16439 ) //<bbolek>//
- **[da0a47bec](https://github.com/facebook/react/commit/da0a47bec )**: fix typo in CHNAGELOG.md (#16447 ) //<Heaven>//
- **[69aafbf4d](https://github.com/facebook/react/commit/69aafbf4d )**: Fix spelling in react-devtools CHANGELOG.md (#16448 ) //<Morgan McCauley>//
- **[c80678c76](https://github.com/facebook/react/commit/c80678c76 )**: Add "hydrationOptions" behind the enableSuspenseCallback flag (#16434 ) //<Sebastian Markbåge>//
- **[2d68bd096](https://github.com/facebook/react/commit/2d68bd096 )**: Fix message loop behavior when host callback is cancelled (#16407 ) //<Dan Abramov>//
- **[96eb703bb](https://github.com/facebook/react/commit/96eb703bb )**: [ESLint] Forbid top-level use*() calls (#16455 ) //<Dan Abramov>//
- **[56f93a7f3](https://github.com/facebook/react/commit/56f93a7f3 )**: Throw on unhandled SSR suspending (#16460 ) //<Dan Abramov>//
- **[dce430ad9](https://github.com/facebook/react/commit/dce430ad9 )**: [Flare] Rework the responder dispatching/batching mechanism (#16334 ) //<Dominic Gannaway>//
- **[6ae6a7c02](https://github.com/facebook/react/commit/6ae6a7c02 )**: Updated React DevTools changelog for 4.0.5 //<Brian Vaughn>//
- **[56d1b0fb5](https://github.com/facebook/react/commit/56d1b0fb5 )**: [react-events] DOM event testing library (#16433 ) //<Nicolas Gallagher>//
- **[e89c19d16](https://github.com/facebook/react/commit/e89c19d16 )**: Added DevTools 4.0.4 CHANGELOG entry //<Brian Vaughn>//
- **[d97af798d](https://github.com/facebook/react/commit/d97af798d )**: Updated DevTools CHANLOGE to add an unreleased change //<Brian Vaughn>//
- **[21e793fb4](https://github.com/facebook/react/commit/21e793fb4 )**: Added 4.0.1, 4.0.2, and 4.0.3 changelog entries (#16438 ) //<Brian Vaughn>//
- **[c1d3f7f1a](https://github.com/facebook/react/commit/c1d3f7f1a )**: [DevTools Changelog] Add a note on 4.0.2 //<Dan Abramov>//
- **[6f86294e6](https://github.com/facebook/react/commit/6f86294e6 )**: [DevTools Changelog] Add a note about restoring selection (#16409 ) //<Dan Abramov>//
- **[600c57a9b](https://github.com/facebook/react/commit/600c57a9b )**: Added OVERVIEW.md and updated CHANGELOG to point to it (#16405 ) //<Brian Vaughn>//
- **[9b5985b3c](https://github.com/facebook/react/commit/9b5985b3c )**: Added release date to DevTools CHANGELOG //<Brian Vaughn>//
- **[ebd1f5ddb](https://github.com/facebook/react/commit/ebd1f5ddb )**: [react-events] Press: improve test coverage (#16397 ) //<Nicolas Gallagher>//
- **[85fbe3be3](https://github.com/facebook/react/commit/85fbe3be3 )**: Merge branch 'master' into devtools-v4-merge //<Brian Vaughn>//
- **[a9304e79d](https://github.com/facebook/react/commit/a9304e79d )**: Add DevTools package placeholder package.json //<Brian Vaughn>//
- **[6edff8f5e](https://github.com/facebook/react/commit/6edff8f5e )**: Added CHANGELOG and READMEs for DevTools v4 NPM packages (#16404 ) //<Brian Vaughn>//
- **[7ce229d3b](https://github.com/facebook/react/commit/7ce229d3b )**: Made some incremental progress on Jest tests //<Brian Vaughn>//
- **[41db902ed](https://github.com/facebook/react/commit/41db902ed )**: Removed unused __TEST__ files //<Brian Vaughn>//
- **[a473dca59](https://github.com/facebook/react/commit/a473dca59 )**: Merge branch 'master' into devtools-v4-merge //<Brian Vaughn>//
- **[4ba141230](https://github.com/facebook/react/commit/4ba141230 )**: Revert "[Scheduler] Profiling features (#16145 )" (#16392 ) //<Dan Abramov>//
- **[407816725](https://github.com/facebook/react/commit/407816725 )**: Removed (no longer necessary) node->node-events mapping //<Brian Vaughn>//
- **[d7ca8847f](https://github.com/facebook/react/commit/d7ca8847f )**: Add build-info.json to package files array for non-private DT packages //<Brian Vaughn>//
- **[39209dc5b](https://github.com/facebook/react/commit/39209dc5b )**: Update react-devtools-inline to embed react-debug-tools since it's not published yet //<Brian Vaughn>//
- **[45dff31a7](https://github.com/facebook/react/commit/45dff31a7 )**: Patched up react-devtools-core Webpack configs //<Brian Vaughn>//
- **[58b39c60d](https://github.com/facebook/react/commit/58b39c60d )**: Fixed web extensions //<Brian Vaughn>//
- **[30b8ef375](https://github.com/facebook/react/commit/30b8ef375 )**: Iterated on Webpack configs until I got the inline and shell packages seemingly working //<Brian Vaughn>//
- **[44e410900](https://github.com/facebook/react/commit/44e410900 )**: Merged master (with events -> legacy-events package rename) //<Brian Vaughn>//
- **[b1a03dfdc](https://github.com/facebook/react/commit/b1a03dfdc )**: Rename legacy "events" package to "legacy-events" (#16388 ) //<Brian Vaughn>//
- **[9e64bf18e](https://github.com/facebook/react/commit/9e64bf18e )**: [eslint-plugin-react-hooks] Fixed crash when referencing arguments in arrow functions. (#16356 ) //<Hristo Kanchev>//
- **[e308a037b](https://github.com/facebook/react/commit/e308a037b )**: chore: make tests compatible with Jest 24 (#15779 ) //<Simen Bekkhus>//
- **[5fa99b5aa](https://github.com/facebook/react/commit/5fa99b5aa )**: chore: add eslint-plugin-jest's valid-expect rule (#16332 ) //<Simen Bekkhus>//
- **[a34ca7bce](https://github.com/facebook/react/commit/a34ca7bce )**: [Scheduler] Profiling features (#16145 ) //<Andrew Clark>//
- **[56636353d](https://github.com/facebook/react/commit/56636353d )**: Partial support for React.lazy() in server renderer. (#16383 ) //<Lee Byron>//
- **[6fbe63054](https://github.com/facebook/react/commit/6fbe63054 )**: [Partial Hydration] Attempt hydration at a higher pri first if props/context changes (#16352 ) //<Sebastian Markbåge>//
- **[e0a521b02](https://github.com/facebook/react/commit/e0a521b02 )**: Make component stack last argument for deprecation warnings (#16384 ) //<Dan Abramov>//
- **[1fd3906e9](https://github.com/facebook/react/commit/1fd3906e9 )**: Remove "Waiting for async callback" User Timing measurement (#16379 ) //<Dan Abramov>//
- **[89bbffed6](https://github.com/facebook/react/commit/89bbffed6 )**: Cleanup Babel PR (ReactFreshPlugin) (#16340 ) //<lunaruan>//
- **[441d014ce](https://github.com/facebook/react/commit/441d014ce )**: Cleaned up some extnesions build script stuff //<Brian Vaughn>//
- **[380da5fcc](https://github.com/facebook/react/commit/380da5fcc )**: Moved OVERVIEW //<Brian Vaughn>//
- **[b73e293cc](https://github.com/facebook/react/commit/b73e293cc )**: Moved CHANGELOG //<Brian Vaughn>//
- **[ac2e861fb](https://github.com/facebook/react/commit/ac2e861fb )**: Fixed a bunch of Lint issues //<Brian Vaughn>//
- **[51626ae2f](https://github.com/facebook/react/commit/51626ae2f )**: Prettier //<Brian Vaughn>//
- **[f7afe1b86](https://github.com/facebook/react/commit/f7afe1b86 )**: Moved shell fixture into packages/react-devtools-shell //<Brian Vaughn>//
- **[183f96f2a](https://github.com/facebook/react/commit/183f96f2a )**: Prettier //<Brian Vaughn>//
- **[edc46d7be](https://github.com/facebook/react/commit/edc46d7be )**: Misc Flow and import fixes //<Brian Vaughn>//
- **[08743b1a8](https://github.com/facebook/react/commit/08743b1a8 )**: Reorganized folders into packages/* //<Brian Vaughn>//
- **[ec7ef50e8](https://github.com/facebook/react/commit/ec7ef50e8 )**: Reorganized things again into packages //<Brian Vaughn>//
- **[65b93cd16](https://github.com/facebook/react/commit/65b93cd16 )**: Merge remote-tracking branch 'devtools-merge/master' into devtools-v4-merge //<Brian Vaughn>//
- **[6eb04b2b1](https://github.com/facebook/react/commit/6eb04b2b1 )**: 4.0.0-alpha.8 -> 4.0.0-alpha.9 //<Brian Vaughn>//
- **[8001b6432](https://github.com/facebook/react/commit/8001b6432 )**: Fixed raw-loader + Jest problem //<Brian Vaughn>//
- **[2eb3f4e9b](https://github.com/facebook/react/commit/2eb3f4e9b )**: README typofix //<Brian Vaughn>//
- **[2015a39c2](https://github.com/facebook/react/commit/2015a39c2 )**: 4.0.0-alpha.7 -> 4.0.0-alpha.8 //<Brian Vaughn>//
- **[e015e3d93](https://github.com/facebook/react/commit/e015e3d93 )**: Added not about sync/batched root API being required //<Brian Vaughn>//
- **[baac1dcc5](https://github.com/facebook/react/commit/baac1dcc5 )**: Inline package tweaks: * Ignore messages from the DevTools browser extension. * Cleanup/clarify README //<Brian Vaughn>//
- **[dc8580e64](https://github.com/facebook/react/commit/dc8580e64 )**: New NPM package react-devtools-inline (#363 ) //<Brian Vaughn>//
- **[db8542ad9](https://github.com/facebook/react/commit/db8542ad9 )**: Refactor inspect/select logic so that $r contains hooks data (#364 ) //<Brian Vaughn>//
- **[62e5fd57a](https://github.com/facebook/react/commit/62e5fd57a )**: NPM package versions 4.0.0-alpha.5 -> 4.0.0-alpha.6 //<Brian Vaughn>//
- **[4f8b7864e](https://github.com/facebook/react/commit/4f8b7864e )**: Add "Welcome to the new DevTools" notification //<Brian Vaughn>//
- **[3b2905b69](https://github.com/facebook/react/commit/3b2905b69 )**: NPM package versions 4.0.0-alpha.4 -> 4.0.0-alpha.5 //<Brian Vaughn>//
- **[7385de9fc](https://github.com/facebook/react/commit/7385de9fc )**: react-devtools-core standalone bugfix: prevent electron crash //<Brian Vaughn>//
- **[76c67399d](https://github.com/facebook/react/commit/76c67399d )**: Re-enabled packages backend build to be production mode (whoops) //<Brian Vaughn>//
- **[050cb8452](https://github.com/facebook/react/commit/050cb8452 )**: 4.0.0-alpha.3 -> 4.0.0-alpha.4 //<Brian Vaughn>//
- **[1e8aa8105](https://github.com/facebook/react/commit/1e8aa8105 )**: Re-enable "view source" button for standalone shell //<Brian Vaughn>//
- **[c7aff5503](https://github.com/facebook/react/commit/c7aff5503 )**: 4.0.0-alpha.2 -> 4.0.0-alpha.3 //<Brian Vaughn>//
- **[9a05e0b60](https://github.com/facebook/react/commit/9a05e0b60 )**: Disable view-source button in standalone mode if no project roots are provided //<Brian Vaughn>//
- **[56b001761](https://github.com/facebook/react/commit/56b001761 )**: 4.0.0-alpha.1 -> 4.0.0-alpha.2 //<Brian Vaughn>//
- **[f74c89b14](https://github.com/facebook/react/commit/f74c89b14 )**: Misc improvements based on user feedback from Tim //<Brian Vaughn>//
- **[ffb19346c](https://github.com/facebook/react/commit/ffb19346c )**: NPM packages 4.0.0-alpha.0 -> 4.0.0-alpha.1 //<Brian Vaughn>//
- **[4b34a77d2](https://github.com/facebook/react/commit/4b34a77d2 )**: Improve Bridge Flow types (#352 ) //<Brian Vaughn>//
- **[39ad101ea](https://github.com/facebook/react/commit/39ad101ea )**: Removed reference to setDefaultThemeName() method //<Brian Vaughn>//
- **[167daf7a4](https://github.com/facebook/react/commit/167daf7a4 )**: Updating NPM packages as 4.0.0-alpha.0 //<Brian Vaughn>//
- **[249a2e043](https://github.com/facebook/react/commit/249a2e043 )**: Detect React Native v3 backend and show warning //<Brian Vaughn>//
- **[cb3fb4212](https://github.com/facebook/react/commit/cb3fb4212 )**: Patch console to append component stacks (#348 ) //<Brian Vaughn>//
- **[0f2fb5bad](https://github.com/facebook/react/commit/0f2fb5bad )**: Standalone NPM packages and React Native support (#335 ) //<Brian Vaughn>//
- **[21d6395a1](https://github.com/facebook/react/commit/21d6395a1 )**: Add test case for #16359 (#16371 ) //<Andrew Clark>//
- **[a29adc9f6](https://github.com/facebook/react/commit/a29adc9f6 )**: Dehydrated suspense boundaries in suspense list (#16369 ) //<Sebastian Markbåge>//
- **[50addf4c0](https://github.com/facebook/react/commit/50addf4c0 )**: Refactor Partial Hydration (#16346 ) //<Sebastian Markbåge>//
- **[c2034716a](https://github.com/facebook/react/commit/c2034716a )**: Fix typo in error code map (#16373 ) //<Andrew Clark>//
- **[62b04cfa7](https://github.com/facebook/react/commit/62b04cfa7 )**: Remove unused import //<Andrew Clark>//
- **[3eeb64551](https://github.com/facebook/react/commit/3eeb64551 )**: Remove flag that reverts #15650 (#16372 ) //<Andrew Clark>//
- **[2716d91ec](https://github.com/facebook/react/commit/2716d91ec )**: Reset didReceiveUpdate in beginWork (#16359 ) //<Sebastian Markbåge>//
- **[9449f8bf3](https://github.com/facebook/react/commit/9449f8bf3 )**: [react-events] Fix keyboard responder test (#16368 ) //<Nicolas Gallagher>//
- **[107521a95](https://github.com/facebook/react/commit/107521a95 )**: [react-events] Focus/FocusWithin responders with fallbacks (#16343 ) //<Nicolas Gallagher>//
- **[7a7e792a6](https://github.com/facebook/react/commit/7a7e792a6 )**: Make SchedulerMinHeap flow strict (#16351 ) //<Desmond Brand>//
- **[e349da19b](https://github.com/facebook/react/commit/e349da19b )**: [Scheduler] Temporarily remove wrapper function (#16345 ) //<Andrew Clark>//
- **[0bd0c5269](https://github.com/facebook/react/commit/0bd0c5269 )**: Upgrade ESLint so we can use JSX Fragment syntax (#16328 ) //<Andrew Clark>//
- **[07d062dea](https://github.com/facebook/react/commit/07d062dea )**: Mark spawned work for client-rendered suspense boundary (#16341 ) //<Sebastian Markbåge>//
- **[07a02fb80](https://github.com/facebook/react/commit/07a02fb80 )**: [react-events] Refactor unit tests for Hover (#16320 ) //<Nicolas Gallagher>//
- **[f62b53d90](https://github.com/facebook/react/commit/f62b53d90 )**: fix some missing assertions (#16336 ) //<Sunil Pai>//
- **[b9faa3b09](https://github.com/facebook/react/commit/b9faa3b09 )**: [act] remove obsolete container element (#16312 ) //<Sunil Pai>//
- **[66a474227](https://github.com/facebook/react/commit/66a474227 )**: use a different link in the UNSAFE_ component warnings (#16321 ) //<Sunil Pai>//
- **[8d5403877](https://github.com/facebook/react/commit/8d5403877 )**: Add use-subscription to Rollup bundle config (#16326 ) //<Brian Vaughn>//
- **[b12a98206](https://github.com/facebook/react/commit/b12a98206 )**: Babel 7 (#16297 ) //<lunaruan>//
- **[d77c6232d](https://github.com/facebook/react/commit/d77c6232d )**: [Scheduler] Store Tasks on a Min Binary Heap (#16245 ) //<Andrew Clark>//
- **[95767acf8](https://github.com/facebook/react/commit/95767acf8 )**: Bump deps in packages/**/package.json (#16325 ) //<Andrew Clark>//
- **[6536973a0](https://github.com/facebook/react/commit/6536973a0 )**: Prepare use-subscription v1 for publishing (#16324 ) //<Brian Vaughn>//
Changelog:
[General][Changed] - React sync for revisions 85d05b3...4eeee35
Reviewed By: TheSavior
Differential Revision: D18008433
fbshipit-source-id: 3b528bb5019d84c69e4dda4f836e852a4f263ba4
2019-10-21 07:36:10 -07:00
Samuel Susla
75b9f9d5dd
Fabric: Add proper type to TargetState
...
Summary:
There isn't a need for using `std::shared_ptr<const void>` as the type is known.
changelog: [internal]
Reviewed By: shergin
Differential Revision: D18032518
fbshipit-source-id: 7860f9be8ba1a05a725e8bf7260a496d51194f2f
2019-10-21 06:27:26 -07:00
Samuel Susla
7e49cf1930
Fabric: Remove redundant class forward declaration
...
Summary:
Remove redundant forward declaration and make default constructor explicit.
changelog: [internal]
Reviewed By: shergin
Differential Revision: D18032511
fbshipit-source-id: 18d3f9c869a69949e6965cd7e32e0f284723f2e3
2019-10-21 06:24:18 -07:00
Valentin Shergin
fd07fc9454
Fabric: Removing deprecated API from ComponentDescriptorRegistry
...
Summary:
We don't use it anymore.
Changelog: [Internal] Removing internal deprecated API (Fabric)
Reviewed By: mdvacca
Differential Revision: D18010490
fbshipit-source-id: c6da7fae071356e06bb0920f5a26d6c9b239c052
2019-10-20 20:53:21 -07:00
Valentin Shergin
c8176881ce
Fabric: Using ComponentDescriptorProviderRegistry in UITemplateProcessorTest
...
Summary:
ComponentDescriptorProviderRegistry is a new API for component registration.
Changelog: [Internal] Fabric-specific change in UIManager test.
Reviewed By: mdvacca
Differential Revision: D18010489
fbshipit-source-id: d615bfb5c9437da7358c0bd8465ab4b6525089e6
2019-10-20 20:53:20 -07:00
Valentin Shergin
8a8ff63b7d
Fabric: Unification of constructor signature of ComponentDescriptors
...
Summary:
This is the first step to migrate the registration of Android-specific `ComponentDescriptors` to `ComponentDescriptorProviderRegistry`.
`ComponentDescriptorProviderRegistry` is a never API for component registration that supports reactive registration and simplified signatures for `registry` (`add`) method.
It's tedious to keep those signatures in sync with the base class (`ComponentDescriptor`), we have an idea how to make it better by using a single struct with all params but a migration to that will be a separate effort.
The changes are pure syntactical.
Changelog: [Internal] Internal changes in Fabric.
Reviewed By: mdvacca
Differential Revision: D18010488
fbshipit-source-id: 4cbfdbcae235b32a94b38df2095c956299764e59
2019-10-20 20:53:20 -07:00
Tim Yung
72890965f3
RN: Create `TouchableWithoutFeedback.unstable_Experiment`
...
Summary:
Creates `TouchableWithoutFeedback.unstable_Experiment` for use to experiment with alternate implementations.
Changelog:
[Internal]
Reviewed By: TheSavior
Differential Revision: D18027430
fbshipit-source-id: 74b90da3398618dced2279cdbad8e05dafdc1919
2019-10-19 09:51:49 -07:00
Tim Yung
b15473fec4
RN: Cleanup `TouchableWithoutFeedback` Flow Types
...
Summary:
Cleans up the Flow types for `TouchableWithoutFeedback`.
This required converting `TVEventHandler` into a class so that Flow understands it is a instantiable type.
Changelog:
[Internal]
Reviewed By: TheSavior
Differential Revision: D18029290
fbshipit-source-id: 7855f3286020c1a1fe8b72c0303cd6b0b3389fd2
2019-10-19 09:51:49 -07:00
Joshua Gross
1e9d4cde4b
Wait until everything is destroyed before returning from CatalystInstanceImpl.destroy
...
Summary:
CatalystInstanceImpl.destroy does a bunch of stuff in each of the relevant threads (Native Module thread, JS thread, UI thread).
This change creates a V1 destroy method (unchanged) and a V2 destroy method. The goal is to resolve (and catch!) race conditions in native modules and JSI modules that could occur during teardown; and mitigate race conditions that occur in RN teardown, like deallocation of C++ objects (scheduler, JS VM, and UIManager for Fabric).
Changelog:
[Internal] Experiment to fix deallocation race conditions
Reviewed By: mdvacca
Differential Revision: D18001677
fbshipit-source-id: 5955da0a7b726491c7d749642475f0fba74cce5a
2019-10-19 02:30:09 -07:00
Joshua Gross
9ddc038e54
WebSocketModule should verify that Catalyst is alive before getting a JS module
...
Summary:
WebSocketModule can be called asynchronously while the ReactContext/CatalystInstance is being torn down. Trying to get a JS module at this time will result in a crash if the ReactContext has already torn down Catalyst. Check explicitly that Catalyst is still alive before trying to emit an event to JS via some JS module.
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D18020359
fbshipit-source-id: 1b77abd457c7d97bd241389251890bb682b6fde3
2019-10-19 02:30:09 -07:00
Joshua Gross
46a28e5460
AppStateModule should verify that Catalyst is alive before getting a JS module
...
Summary:
AppStateModule can be called indirectly when the ReactContext is torn down. Trying to get a JS module at this time will result in a crash if the ReactContext has already torn down Catalyst. Check explicitly that Catalyst is still alive before trying to emit an event to JS via some JS module.
Changelog: [Internal]
Reviewed By: ejanzer, mdvacca
Differential Revision: D17969056
fbshipit-source-id: dd446de57280e588a73f3e228bac82b3d67ecdc0
2019-10-19 02:30:09 -07:00
Joshua Gross
f8bf65b8fd
Make sure FabricUIManager doesn't double-free Binding, or double-destroy itself
...
Summary:
While unlikely, in exceptional cases it's possible that `onCatalystInstanceDestroy` is called multiple times, especially since there's no restrictions as to which thread this is called on (currently it's only called on the JS thread from CatalystInstanceImpl) and no synchronization. Make sure it tears down cleanly if called multiple times, and report soft exceptions if that's detected.
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D18001678
fbshipit-source-id: 4a7c37b5b3c2207ba1dd9c7d85690391f799518d
2019-10-19 02:30:08 -07:00
Joshua Gross
95a43f3366
Set `mCatalystInstance` to null when destroying ReactContext
...
Summary:
We want ReactContext to blow up if it tries to use `mCatalystInstance` after `destroy` is called.
Changelog:
[[Internal]]
Reviewed By: mdvacca
Differential Revision: D17944723
fbshipit-source-id: cfe8a8b98473f53dd68bbcd91a71f58bd7a0c503
2019-10-19 02:30:08 -07:00
Matias Alvin
36672c3851
Fix Switch component accessibility role ( #26899 )
...
Summary:
`accessibilityRole` communicates the purpose of a component to the user of assistive technology. It needs to have the correct value for it to be fully utilized.
Switch component has `accessibilityRole` of a `button` instead of `switch` on default. Change the component default role to `switch`.
## Changelog
[General] [Fixed] - Change default `accessibilityRole` of Switch component from `button` to `switch`
Pull Request resolved: https://github.com/facebook/react-native/pull/26899
Test Plan:
- All unit test passed
- On Switch component, it's supposed to have `switch` like element type on both platform. (`XCUIElementTypeSwitch` on iOS)
fix [https://github.com/facebook/react-native/issues/26873 ](https://github.com/facebook/react-native/issues/26873 )
Reviewed By: yungsters
Differential Revision: D18002755
Pulled By: mdvacca
fbshipit-source-id: 60446f94b23f8355f954805fb4dc08c89d08e492
2019-10-18 22:14:35 -07:00
Ramanpreet Nara
d3ac9fa0c3
Check in OSS NativeModule specs
...
Summary:
This diff checks in the output from `fbsource//xplat/js:FBReactNativeSpec-flow-type-android-files` into `react-native-github/ReactAndroid/src/main/java/com/facebook/fbreact/specs/`.
To update the codegen output, please run:
```
js1 build oss-native-modules-specs -p android
```
To use the codegen, add the following as a buck dep to your target:
```
fbsource//xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/fbreact/specs:FBReactNativeSpecAndroid
```
Changelog: [Android][Added] Check in TurboModules codegen
Reviewed By: fkgozali
Differential Revision: D17990380
fbshipit-source-id: 94895e375311e9360c308dffadf1558a5ff04212
2019-10-18 16:24:09 -07:00
Eli White
48f367da91
Checkbox: remove cast through any
...
Summary:
$title
Changelog:
[Internal]
Reviewed By: JoshuaGross
Differential Revision: D17934095
fbshipit-source-id: 9447680dea6bdd3576164d624c9231a0f77f5c2a
2019-10-18 16:15:37 -07:00
Joshua Gross
526a010ad7
Add `ThreadConfined(UI)` to CatalystInstanceImpl.destroy
...
Summary:
This already has an assert that `destroy` should only be called on the UI thread. Add an annotation.
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D17989113
fbshipit-source-id: fd44f321cbcb7f0a18383ca6226cce72e5991eea
2019-10-18 15:08:53 -07:00
Eli White
84915a2d68
Make SafeAreView flow strict-local
...
Summary:
The forwardRef calls were able to be cleaned up and consolidated a bit.
Changelog:
[Changed][SafeAreaView] Improved SafeAreaView's typing, removing extra underscore from display name
Reviewed By: cpojer
Differential Revision: D17881901
fbshipit-source-id: 00f876d34600f4cfd44075eb7ad7192c9a885907
2019-10-18 14:50:59 -07:00
Eli White
f12c0e7eb0
Delete WindowedListView
...
Summary:
This is an experimental component that is not exported from React Native. It is one of the last direct users of ScrollResponder keeping us from being able to refactor and improve the typing of ScrollResponder and ScrollView.
Changelog:
[Remove] Remove experimental WindowedListView
Reviewed By: yungsters
Differential Revision: D17989714
fbshipit-source-id: ff098100458f638b99be8ab1a29371ab788f424e
2019-10-18 14:45:19 -07:00
Valentin Shergin
dbc7e4e527
Fabric: More type asserts in ConcreteComponentDescriptor
...
Summary:
`ConcreteComponentDescriptor` is a major place where dynamic dispatch calls end up. We see some amount of crashes that can be caused by an invalid pointer to a ComponentDescriptor, those checks can help verify this theory. Anyway, it's a good practice to fail earlier.
Changelog: [Internal] - Stability improvements (Fabric)
Reviewed By: sammy-SC
Differential Revision: D17991515
fbshipit-source-id: 1cac372a12b49430a3d1db66c8fc673e6adc32e9
2019-10-18 09:27:48 -07:00
David Vacca
3408dc0b3e
Customize ExceptionHandler in ReactAppTestActivity
...
Summary:
This diff extends the ReactAppTestActivity to allow customization of the RN ExceptionHandler
Changelog:
This diff extends the ReactAppTestActivity to allow customization of the RN ExceptionHandler
Reviewed By: JoshuaGross
Differential Revision: D17993132
fbshipit-source-id: 7320d35a4d88d56a7356f2863829c88758c08341
2019-10-18 09:09:30 -07:00
David Vacca
8425292eb4
Report Redbox error when a component is not implemented
...
Summary:
This diff ensures that a redbox is reported when a component is not registered in Fabric.
Changelog:
Ensure a redbox is reported when components are not registered in Fabric.
Reviewed By: shergin
Differential Revision: D17970793
fbshipit-source-id: 7afd7e6b0b9c0ff6d2bd475dbf6979d83fec093c
2019-10-18 09:09:30 -07:00
generatedunixname89002005287564
9ce3588f1e
Daily `arc lint --take BUCKFORMAT`
...
Reviewed By: zertosh
Differential Revision: D17978944
fbshipit-source-id: 9c9d4d6e6abe49005558d52b47a5a3b38cbb6d92
2019-10-17 12:16:15 -07:00
Mehdi Mulani
a7d55c9a2a
Explicitly set RCTWebSocketModule's methodQueue
...
Summary:
@public
It seems no one was setting this. Also couldn't find the RCTBlobModule.
Changelog: [iOS] [Fixed] - Set RCTWebSocketModule's methodQueue
Reviewed By: fkgozali
Differential Revision: D17964367
fbshipit-source-id: b2e2bde31dce4a35ff60163c5a31c3d64fcd9024
2019-10-17 11:59:11 -07:00
Dulmandakh
acd4a3b1d4
fix Android CI ( #26862 )
...
Summary:
This PR fixes Android CI.
## Changelog
[Android] [Fixed] - fix Android CI
Pull Request resolved: https://github.com/facebook/react-native/pull/26862
Test Plan: Android CI is green again
Differential Revision: D17925576
Pulled By: mdvacca
fbshipit-source-id: 90bdccda96a11210254a9eaab3c373151057f332
2019-10-17 01:07:53 -07:00
Ramanpreet Nara
2b5f4de7eb
Make RCTTiming TurboModule-compatible
...
Summary: Changelog: [iOS][Added] Make RCTTiming TurboModule-compatible
Reviewed By: PeteTheHeat
Differential Revision: D17891665
fbshipit-source-id: e0d36ccfb4f3f1d428668836a8b66698d51bdeaf
2019-10-16 19:00:26 -07:00
Ramanpreet Nara
791931454e
Make RCTNativeAnimatedModule TurboModule-compatible
...
Summary:
**Note:** I had to relax the `AnimatedNodeConfig` and `AnimatingNodeConfig` flow types, because they didn't have all the properties. I created a task to improve the flow types.
Changelog: [iOS][Added] Make RCTNativeAnimatedMoudle TurboModule-compatible
Reviewed By: PeteTheHeat
Differential Revision: D17692715
fbshipit-source-id: ab3680c30ca3d5b1eb866ef1104587cae695ad15
2019-10-16 19:00:26 -07:00
Valentin Shergin
05862faab4
Farbic: Making `ShadowNode::revision_` debug only
...
Summary:
We use this piece of data only for debug purposes, so there is no need to pay for that in prod.
Changelog: [Internal] - Small optimization in `ShadowNode` (Fabric)
Reviewed By: JoshuaGross
Differential Revision: D17961209
fbshipit-source-id: 2a0d609ac4d3c4815b26789551a4c51bcf91dea4
2019-10-16 17:53:15 -07:00
David Vacca
a4ebd87a81
Fix TM SoundManager not found in iOS apps
...
Summary:
This diff fixes an error affecting of loading of Ads Manager iOS app
Changelog: [Internal]
Reviewed By: fkgozali
Differential Revision: D17958919
fbshipit-source-id: d87f169954d891ee2fcb1143f1985ea3811b949c
2019-10-16 14:51:24 -07:00
Emily Janzer
f2f4d33a3a
Remove unsupported flow types from OSS native module specs
...
Summary:
Some of our NativeModule type specs aren't compatible with our Android codegen and type safety checks - specifically, we don't support `$ReadOnly` in our type checks, and we don't support map types in the codegen. Removing these from a couple of the OSS type specs so we can enable codegen for these modules (eventually).
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D17882093
fbshipit-source-id: 6e8669e4be775347199b2b5346bd8d40d7620886
2019-10-16 11:14:04 -07:00
Andres Suarez
aee88b6843
Tidy up license headers [3/n]
...
Summary: Changelog: [General] [Fixed] - License header cleanup
Reviewed By: yungsters
Differential Revision: D17952693
fbshipit-source-id: 8fcb8e58a2e04e7a3169f4d525bffc00835768e6
2019-10-16 10:06:34 -07:00
Andres Suarez
3b31e69e28
Tidy up license headers [2/n]
...
Summary: Changelog: [General] [Fixed] - License header cleanup
Reviewed By: yungsters
Differential Revision: D17952694
fbshipit-source-id: 17c87de7ebb271fa2ac8d00af72a4d1addef8bd0
2019-10-16 10:06:34 -07:00
Andres Suarez
722feeb02b
Tidy up license headers [1/n]
...
Summary: Changelog: [General] [Fixed] - License header cleanup
Reviewed By: yungsters
Differential Revision: D17952695
fbshipit-source-id: 81aa607612ba1357ef7814ef20371335151afe7e
2019-10-16 10:06:33 -07:00
Dan Abramov
4ed05ca241
Send early logs to Metro too
...
Summary:
If you `console.log` early enough in the initialization sequence, it won't get sent to Metro because `hmrClient` isn't initialized yet. I've added a rolling array to catch at most 100 of those, and send them after we initialize.
Changelog: [General] [Fixed] - Early logs don't get dropped by Metro now
Reviewed By: cpojer
Differential Revision: D17952097
fbshipit-source-id: 964b4735a6a7c3ccd115f44151139d718bf5b26d
2019-10-16 08:03:21 -07:00
Samuel Susla
0d1b9b5397
Add MaskedView to LegacyViewManagerInterop white list
...
Summary:
For components to be used with LegacyViewManagerInterop they need to be added to a white list.
This makes it possible to test it out and assure proper functionality.
Changelog: [Internal]
Reviewed By: shergin
Differential Revision: D17906107
fbshipit-source-id: 60ee99e6b973ba2d6fe804f3c99e492603d3cf8f
2019-10-16 04:26:44 -07:00