Граф коммитов

1361 Коммитов

Автор SHA1 Сообщение Дата
Christina Lin c7b2dc1042
DevHub Pastebin Re-implementation (#22664)
* Added view attachment link on DevHub in relation to  #22640

* lint

* renamed attachment_link to attachment_url

* js attachment_url

* test update

* doc

* test

* dont hardcode test

* lint

* limit queries

* Use correct pk in reverse
2024-09-17 13:21:44 -04:00
Christina Lin c6026f6d89
Reviewer Tools Pastebin Re-implementation (#22640)
* Added pastebin reimplementation on reviewer tools side

* make lint

* Moved attachment upload box to own section (and available for all actions)

* Fixed css for textareas, returned datetime-wrapper

* Missing assignment

* Updated naming for files, limited to .txt and .zip, temporarily updated query number assertion

* added waffle enable-activity-log-attachments for user facing menus;

* testing

* corrected test

* Removed zip allowance

* migration conflict

* test (temp)

* import

* remove git_extraction.py from pr

* ???

* numQueries

* review changes

* lint

* prettier

* review changes

* lol lint

* review comment
2024-09-13 13:58:33 -04:00
Mathieu Pillard e29adf662c
Replace AMO favicon with Firefox logo (#22650) 2024-09-09 17:47:30 +02:00
Kevin Meinhardt 2a64618e9d
Enable Production Mode via DEBUG or docker-compose.ci.yml (#22613)
* TMP: clean bake metadata file

* SPLIT: Log UWSGI in docker compose console

Remove PID

* SPLIT: Raise error in update_assets if file not found

* Enable Production mode via DEBUG and or docker-compose.ci.yml

* Option 1: Load node_modules from statifiles directory

* Option 2: Load node_modules via django-node-asset

* separate ./static from locally built static files

* Add docs for static file serving

* TMP: fixes from code review

* Update docs/topics/development/static-files.md

Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>

* TMP: update docs

---------

Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>
2024-09-05 16:20:03 +02:00
Christina Lin cedcc4917e
Show All Current Authors on the Review Page (#22548)
* Show all current authors on the review page

* Removed extra style

* Added tests

* ruff formatting

* ruff format

* Changed to use class rather than inline style

* Updated tests, better conditional

* Dotted underline under unlisted authors

* Removed underline, modified conditional, removed sidebar Author

* Extra space

* 300 weight font
2024-08-19 13:09:02 +01:00
Christina Lin 91a4e2c70b
Add Submit Button to Review Due Date Changes (#22555)
* Changed due_date_update to update on blur rather than on change

* Add visual indicator (button) of status of date change

* prettier

* removed extra </li>

* moved inline style to class

* Submit on click rather than onblur
2024-08-09 13:07:12 -04:00
Andrew Williamson fe1a9e3ef9
Add a filter to the review queue for due date reasons (#22558)
* Add a filter to the review queue for due date reasons

* use cleaned values of due_date_reasons for safety
2024-08-09 17:01:28 +01:00
Andrew Williamson 9a628ac360
Expose all the reasons why there is a due_date to the extensions queue (queryset) (#22530)
* set due_date_reasons bitmask when setting due_date

* add no_transforms in Version.should_have_due_date

* Only annotate Version qs when nessecary

* refactor to make VersionManager.should_have_due_date efficient

* Add flags for newly exposed reasons for due_date

* get_due_date_reason_qs -> get_due_date_reason_q_objects; add docstring

* exclude has developer reply from needs_human_review_other

* fix linelength that ruff format didn't autofix
2024-08-06 15:06:58 +01:00
dependabot[bot] 4b76b7cee4
Bump django from 4.2.13 to 4.2.14 in /requirements (#22461)
* Bump django from 4.2.13 to 4.2.14 in /requirements

Bumps [django](https://github.com/django/django) from 4.2.13 to 4.2.14.
- [Commits](https://github.com/django/django/compare/4.2.13...4.2.14)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* rm one-time fix_missing_icons command

* fix Storage tests to not save to absolute paths

* rm unused import

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Williamson <awilliamson@mozilla.com>
2024-07-17 09:43:09 +01:00
Andrew Williamson f85937b394
split appeal job action from abuse job action (#22406)
* split appeal job action from abuse job action

* don't localise hidden activity log format labels
2024-06-25 22:56:51 +01:00
Andrew Williamson 8d1d7d471d
split resolving jobs functionality into seperate action from comment (#22375) 2024-06-18 17:27:08 +01:00
Andrew Williamson c92e6a2910
Implement resolving jobs as invalid in reviewer tools (#22278)
* only clear abuse/appeal related NHR for resolving jobs

* Allow some policies to be selectable in reviewer tools

* reset due_date after setting NHR to inactive
2024-05-30 15:02:13 +01:00
Mathieu Pillard 686ad55a2d
Remove `fill="context-fill" and `fill-opacity="context-fill-opacity"` from Hero SVGs (#22267)
This was preventing them from being displayed when loaded as <img> in Chrome
and some image viewers. We are not using them as masks so that shouldn't matter.
2024-05-22 10:52:13 +02:00
Andrew Williamson 00d1e42275
show special flag for nhr from abuse reports in review queue (#22151)
* show special flag for nhr from abuse reports in review queue

* refactor NeedsHumanReview REASON constants into Choices

* split single flag into three types of abuse/appeal

* optimize queryset construction
2024-04-23 20:10:27 +01:00
Mathieu Pillard 229e8dab84
Handle "original" size icon being absent when disabling, falling back on largest size (#22126) 2024-04-18 17:54:15 +02:00
Kevin Meinhardt 26be57fcaf
Improve usability of verify email page when verification is pending or timedout (#22084)
* Remove code snippet filter for email history in verify email flow

* Improve UI usability for verify email flow with pending/timedout state

* Extend suppressed email verification timeout to 1 minute

* Update src/olympia/devhub/templates/devhub/verify_email.html

Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>

* Update src/olympia/devhub/templates/devhub/verify_email.html

Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>

* Update src/olympia/devhub/templates/devhub/verify_email.html

Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>

* Update src/olympia/devhub/templates/devhub/verify_email.html

Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>

* Add css truncation to email history table cells

* Increase email verification timeout to 10 minutes and refresh rate to 30 seconds

* Add amo_devhub suffix to SUPPORT_EMAIL

* Fix support link test

* Improve confirmation delivered screen on email suppression flow:

- hide table if email is confirmed delivered
- add a "success" header to indicate it all went well

---------

Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>
2024-04-02 10:05:38 +02:00
Kevin Meinhardt 56f6d9d370
Use proper css syntax for table styles on verify-email page (#22047) 2024-03-20 16:50:21 +01:00
Kevin Meinhardt 059193a3d3
Simplify socketlabs check for status and messaging when something goes wrong. (#22005)
* Simplify socketlabs check for status and messaging when something goes wrong.

* Fix comments

* Add more details and formatting to suppressed email status table.

* Copy fixes and updates

* Update src/olympia/devhub/templates/devhub/verify_email.html

Co-authored-by: Francesco Lodolo <flodolo@mozilla.com>

---------

Co-authored-by: Mozilla Add-ons Robot <addons-dev-automation+github@mozilla.com>
Co-authored-by: Francesco Lodolo <flodolo@mozilla.com>
2024-03-19 17:30:54 +01:00
Andrew Williamson ba5fdc81a4
Expose escalation reason in reviewer tools (#21929) 2024-02-28 11:38:34 +00:00
Kevin Meinhardt 4ca4686edd
Implement email verification flow (#21603)
* feat(): add email_verification property to UserProfile

* feat(users): add useful properties to SuppressedEmailVerification model

* feat(devhub): add email verification flow view logic

* chore(): use date only values for socketlabs recipient search
2024-01-08 13:13:41 +01:00
Kevin Meinhardt e6f7967539
feat(): add notification displaying suppressed emails (#21599) 2023-12-19 12:29:56 +01:00
dependabot[bot] ab9f944c57
Bump prettier from 3.0.3 to 3.1.0 (#21426)
* Bump prettier from 3.0.3 to 3.1.0

Bumps [prettier](https://github.com/prettier/prettier) from 3.0.3 to 3.1.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/3.0.3...3.1.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump that back

* Prettify

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mathieu Pillard <mpillard@mozilla.com>
2023-12-11 12:18:29 +01:00
Mathieu Pillard 7b136ae4e3
Fix stats menu items indentation (#21419) 2023-11-09 21:31:51 +01:00
Andrew Williamson 8a07cad47b
replace force disable/enable buttons with actions (#21382)
* replace force disable/enable buttons with actions

* update api docs

* move activity logging back to reviewer tools

* expose enable/disable activity log to developers

* correctly stringify activity log in reviewer tools important changes

* rm unused line

* review fixes
2023-11-07 17:30:58 +00:00
Mathieu Pillard e5de4ecc7c
Merge per-application categories, add command to merge and clean up obsolete ones (#21212)
Expose categories flat in API v5, add compatibility shim for previous versions.
2023-10-26 14:43:31 +02:00
Mathieu Pillard 562ce3dc2f
Appeal form & logic for abuse reports handled by Cinder (#21291)
* Appeal form & logic for abuse reports handled by Cinder
2023-10-11 15:30:15 +02:00
Mathieu Pillard ecaa646e82
Trigger change event to reset custom validity when Firefox for Android is checked (#21295)
The modal calls e.preventsDefault(), so the click never goes through,
preventing change event from firing normally, which in turn leaves our custom
validity enabled and triggers a validation error on submit. Manually triggering
change works around this
2023-10-10 14:45:38 +02:00
Mathieu Pillard 01ac2a3df3
Additional l10n tweaks to android modal / footer (#21284) 2023-10-05 23:30:51 +02:00
Mathieu Pillard 6654db6bbf
Fix modals to appear in fixed position, and ensure Android compat gets checked (#21279)
* Fix modals to appear in fixed position, and ensure Android compat gets checked

* No need to wrap this
2023-10-05 15:55:33 +02:00
Mathieu Pillard 3122b60698
Show modal warning at submission time when Android compatibility is checked (#21224)
* Show modal warning at submission time when Android compatibility is checked
2023-10-04 10:32:12 +02:00
Mathieu Pillard 8d00231f29
Harmonize footers across devhub (and frontend pages a bit more) (#21244)
* Harmonize footers across devhub (and frontend pages a bit more)

Changes:
- Copy over fonts from addons-frontend, use Inter everywhere
- Use photon-footer everywhere, adding a light blue margin before
  to make the transition less aggressive and match header
- Fix error pages block to align content correctly
- Translate strings in footer
2023-10-02 16:12:51 +02:00
Mathieu Pillard 0444929d2f
Center the site notice text in devhub new landing (#21200) 2023-09-15 14:42:57 +02:00
Andrew Williamson a02d62857f
fix reviewer warning message (#21199) 2023-09-15 11:52:21 +01:00
Andrew Williamson ffd40c0ada
call review watching endpoint on setinterval (#21178) 2023-09-13 15:56:56 +01:00
Mathieu Pillard 1d264b7bf8
Limit compatibility for Firefox for Android (#21152)
* Limit compatibility for Firefox for Android

- Extensions are either compatible with Fennec or Fenix >= 119.0a1, unless they are recommended/line.
- If they are compatible with Fennec, they strict compatibility is enabled.
2023-09-12 11:10:17 +02:00
Andrew Williamson fdc043d856
return usage_per_version adus as list to preserve order (#21066)
* return usage_per_version adus as list to preserve order

* prettier fix
2023-08-16 13:21:47 +01:00
Andrew Williamson 11cf428802
add canned reasons to blocksubmission admin (#20978)
* add canned reasons to blocksubmission admin

* build on ReviewActionReason for canned response instead

* Fix reviewers tests that didn't create a complete ReviewActionReason

* in migration default canned_block_reason field to '' for existing records
2023-07-13 13:55:46 +01:00
Mathieu Pillard 117dd81743
Split New Theme submission from the rest (#20968)
* Split New Theme Submission from the rest

For simplicity new version creation are not modified in this commit,
because we're already able to serve different content for them, or
gate them however we'd like, as we already have the add-on available.

* Display error message when trying to use theme submission flow to upload a non-theme

Note: this is not intended as a security measure, it's only to be
nice to users who accidentally ended up in the wrong flow.
2023-07-11 14:05:12 +02:00
Andrew Williamson 80bdb33b8f
allow reason & url to be changed/cleared on blocklistsubmission (#20941) 2023-07-07 18:13:24 +01:00
Andrew Williamson cb1aef685e
correctly show minimum adu returned for max results length adu list (#20967) 2023-07-07 17:48:53 +01:00
Andrew Williamson bec51655da
fix blocklistsubmission all|none links (#20929) 2023-07-04 16:22:47 +01:00
Andrew Williamson 7bd1883f6f
add select all|none links for [un]block version checkboxes (#20912) 2023-06-30 16:09:36 +01:00
Andrew Williamson 8fce06e757
define if a blocklistsubmission updaates metadata (#20907) 2023-06-30 14:56:03 +01:00
Andrew Williamson 5d8ed69812
update hero admin page styles (#20900) 2023-06-29 15:26:21 +01:00
Andrew Williamson 2f895832ea
change version checkboxes to make it clearer between blocking and already blocked (#20887)
* change version checkboxes to make it clearer between blocking and already blocked

* wrap blocked and not blocked icon & version string in a span, with title
2023-06-28 15:45:39 +01:00
Andrew Williamson 706798d37e
per version blocks (#20829)
* track Blocked versions per version

* update api docs

* test fixes

* scanners test fixes

* drop now obsolete create_blockversions command

* address review comments; fix failing tests

* restore warning messages about a version being in a submission or block

* add extra tests + optimizations

* Fix failing blocklist/test_serializers.py test
2023-06-26 11:00:10 +01:00
Mathieu Pillard b204dde19e
Don't require a comment for clear pending rejection/clear needs human review (#20881)
+ drive by cleanup: JS code for set needs human review is no longer needed
since it's a regular action and not a button calling the API now.
2023-06-26 11:59:55 +02:00
Mathieu Pillard 445458fe84
Fix error message not appearing on reviewer actions with invalid form (#20880)
The actions are no longer wrapped in a <li> following Django 4.2 upgrade.
2023-06-26 11:59:43 +02:00
Rob Wu b5d05761a4
Add word-break:break-word to uses of white-space:pre-wrap (#20854)
`white-space: pre-wrap` prevents lines from being broken unless an
explicit line break is in there.

Since the content of these fields are external (user-generated), there
is no guarantee of the line length to be within reasonable bounds.

Rather than stretching the layout, add `word-break: break-word` to allow
the line to be wrapped regardless.
2023-06-20 16:25:37 +01:00
Mathieu Pillard 879ce0d576
Don't show code manager links to non-reviewers (#20812)
* Don't show code manager links to non-reviewers
2023-06-12 11:09:28 +02:00