mozilla
/
bedrock
зеркало из https://github.com/mozilla/bedrock.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Fix careers listings filtering (Fixes #12490) (#12492)

This commit is contained in:
Alex Gibson 2022-12-16 11:07:37 +00:00 коммит произвёл GitHub
Родитель 3778445d23
Коммит ab337f8c05
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
2 изменённых файлов: 10 добавлений и 10 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

4
media/js/careers/listings/filters.es6.js
Просмотреть файл

@ -124,7 +124,7 @@ PositionFilters.prototype = {
for (let i = 0; i < positions.length; i++) { for (let i = 0; i < positions.length; i++) {
const data = positions.item(i).dataset[field]; const data = positions.item(i).dataset[field];
if (data.indexOf(value + ',') === -1) { if (data.indexOf(value) === -1) {
positions.item(i).classList.add('hidden'); positions.item(i).classList.add('hidden');
} }
} }
@ -139,7 +139,7 @@ PositionFilters.prototype = {
const positions = this.positionTable.getElementsByClassName('position'); const positions = this.positionTable.getElementsByClassName('position');
for (let i = 0; i < positions.length; i++) { for (let i = 0; i < positions.length; i++) {
const data = positions.item(i).dataset.location; const data = positions.item(i).dataset.location + ',';
// When user selects 'Remote' only list jobs explicitly marked // When user selects 'Remote' only list jobs explicitly marked
// Remote otherwise list jobs matching value (which is a mozilla // Remote otherwise list jobs matching value (which is a mozilla

16
tests/unit/spec/careers/filters.js
Просмотреть файл

@ -57,42 +57,42 @@ describe('filters.js', function () {
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
<tr class="position" data-team="Business Development," data-type="," data-location="San Francisco Office,"> <tr class="position" data-team="Business Development" data-type="" data-location="San Francisco Office">
<td class="title"><a href="#">Operations Specialist - Business Development</a></td> <td class="title"><a href="#">Operations Specialist - Business Development</a></td>
<td class="location">San Francisco Office</td> <td class="location">San Francisco Office</td>
<td class="name">Business Development</td> <td class="name">Business Development</td>
</tr> </tr>
<tr class="position" data-team="Core Product-Firefox," data-type="," data-location="Remote San Francisco Bay Area,"> <tr class="position" data-team="Core Product-Firefox" data-type="" data-location="Remote San Francisco Bay Area">
<td class="title"><a href="#"> Localization Program Manager </a></td> <td class="title"><a href="#"> Localization Program Manager </a></td>
<td class="location">Remote San Francisco Bay Area</td> <td class="location">Remote San Francisco Bay Area</td>
<td class="name">Core Product-Firefox</td> <td class="name">Core Product-Firefox</td>
</tr> </tr>
<tr class="position" data-team="Core Product-Firefox," data-type="," data-location="Remote Canada,"> <tr class="position" data-team="Core Product-Firefox" data-type="" data-location="Remote Canada">
<td class="title"><a href="#">Senior Program Manager</a></td> <td class="title"><a href="#">Senior Program Manager</a></td>
<td class="location">Remote Canada</td> <td class="location">Remote Canada</td>
<td class="name">Core Product-Firefox</td> <td class="name">Core Product-Firefox</td>
</tr> </tr>
<tr class="position" data-team="Core Product-Security," data-type="," data-location="Remote US,"> <tr class="position" data-team="Core Product-Security" data-type="" data-location="Remote US">
<td class="title"><a href="#">Senior Software Engineer (C++)</a></td> <td class="title"><a href="#">Senior Software Engineer (C++)</a></td>
<td class="location">Remote US</td> <td class="location">Remote US</td>
<td class="name">Core Product-Security</td> <td class="name">Core Product-Security</td>
</tr> </tr>
<tr class="position" data-team="Core Product-Security," data-type="," data-location="San Francisco Office,"> <tr class="position" data-team="Core Product-Security" data-type="" data-location="San Francisco Office">
<td class="title"><a href="#">Senior UI Engineer</a></td> <td class="title"><a href="#">Senior UI Engineer</a></td>
<td class="location">San Francisco Office</td> <td class="location">San Francisco Office</td>
<td class="name">Core Product-Security</td> <td class="name">Core Product-Security</td>
</tr> </tr>
<tr class="position" data-team="Data Organization," data-type="," data-location="Remote Canada,Remote Germany,Remote US,"> <tr class="position" data-team="Data Organization" data-type="" data-location="Remote Canada,Remote Germany,Remote US">
<td class="title"><a href="#">Data Engineer</a></td> <td class="title"><a href="#">Data Engineer</a></td>
<td class="location">Remote Canada, Remote Germany, Remote US</td> <td class="location">Remote Canada, Remote Germany, Remote US</td>
<td class="name">Data Organization</td> <td class="name">Data Organization</td>
</tr> </tr>
<tr class="position" data-team="Data Organization," data-type="," data-location="Remote Canada,Remote US,"> <tr class="position" data-team="Data Organization" data-type="" data-location="Remote Canada,Remote US">
<td class="title"><a href="#">Inference Data Scientist (Staff Level)</a></td> <td class="title"><a href="#">Inference Data Scientist (Staff Level)</a></td>
<td class="location">Remote Canada, Remote US</td> <td class="location">Remote Canada, Remote US</td>
<td class="name">Data Organization</td> <td class="name">Data Organization</td>
</tr> </tr>
<tr class="position" data-team="Mozilla Foundation," data-type="," data-location="Remote,"> <tr class="position" data-team="Mozilla Foundation" data-type="" data-location="Remote">
<td class="title"><a href="#">Senior Software Engineer</a></td> <td class="title"><a href="#">Senior Software Engineer</a></td>
<td class="location">Remote</td> <td class="location">Remote</td>
<td class="name">Mozilla Foundation</td> <td class="name">Mozilla Foundation</td>