Update dependency eslint to v7 (#1852)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Peter deHaan <peter@deseloper.com>

.eslintrc.js

@@ -1,7 +1,9 @@
+"use strict";
+
 module.exports = {
   env: {
     es6: true,
-    node: true
+    node: true,
   },
   extends: [
     "eslint:recommended",
@@ -10,28 +12,28 @@ module.exports = {
   overrides: [
     {
       files: [
-        'public/js/**/*.js'
+        "public/js/**/*.js",
       ],
       env: {
         browser: true,
-        node: false
+        node: false,
       },
       rules: {
-        "strict": "off"
-      }
+        "strict": "off",
+      },
     },
     {
       files: [
-        'scripts/*.js',
+        "scripts/*.js",
       ],
       rules: {
         "no-console": "off",
         "no-process-exit": "off",
-      }
+      },
     },
     {
       files: [
-        'tests/**/*.js',
+        "tests/**/*.js",
       ],
       env: {
         jest: true,
@@ -39,13 +41,16 @@ module.exports = {
     },
     {
       files: [
-        'tests/integration/**/*.js',
+        "tests/integration/**/*.js",
       ],
       globals: {
         "$": "readonly",
         "$$": "readonly",
         "browser": "readonly",
       },
+      rules: {
+        "valid-jsdoc": "off",
+      },
     },
   ],
   plugins: [
@@ -58,6 +63,7 @@ module.exports = {
     "eqeqeq": "error",
     "no-console": ["error", {allow: ["error", "info", "warn"]}],
     "no-process-env": "error",
+    "no-prototype-builtins": "off",
     "no-trailing-spaces": "error",
     "no-unused-vars": ["error", {vars: "all", args: "none", ignoreRestSiblings: false}],
     "no-var": "error",
@@ -68,5 +74,5 @@ module.exports = {
     "semi": ["error", "always"],
     "strict": ["error", "safe"],
     "valid-jsdoc": "warn",
-  }
+  },
 };

controllers/hibp.js

@@ -115,7 +115,7 @@ async function notify (req, res) {
           ctaHref: ctaHref,
           whichPartial: "email_partials/report",
           preFxaSubscriber,
-        },
+        }
       );
       notifiedRecipients.push(breachedEmail);
     }

package.json

@@ -53,7 +53,7 @@
     "chai": "4.2.0",
     "clean-css-cli": "4.3.0",
     "coveralls": "3.1.0",
-    "eslint": "4.19.1",
+    "eslint": "7.6.0",
     "eslint-plugin-node": "6.0.1",
     "faucet": "0.0.1",
     "htmllint-cli": "0.0.7",

scripts/send-email-to-pre-fxa-subscribers.js

@@ -58,7 +58,7 @@ if (!START_PAGE) {
             whichPartial: "email_partials/pre-fxa",
             preFxaEmail: true,
             email: subscriberEmail,
-          },
+          }
         );
         notifiedSubscribers.push(subscriberEmail);
         console.log(`Sent email to ${subscriberEmail}, info: ${JSON.stringify(sendInfo)}`);

template-helpers/index.js

@@ -28,6 +28,6 @@ module.exports = {
     legacyHelpers,
     scanResults,
     signUpBanners,
-    upgrade,
+    upgrade
   ),
 };

tests/integration/pages/desktop/scanResults.page.js

@@ -1,6 +1,3 @@
-/* global $$ */
-/* global $ */
-
 "use strict";
 
 class ScanResultsPage {

tests/integration/pages/desktop/userPreferences.page.js

@@ -1,5 +1,3 @@
-/* global $ */
-
 "use strict";
 
 class UserPreferencesPage {