The js unit test targets have subtle dependencies on sources.
Specifically, a rule pulls in js files and generates/runs js tests for
them. This can be an issue with a relative path when the commands are
run in parallel because a relative path may not exist. In this case, the
rule for cr.js which is in ui depends on chrome. An easy way to repro
this failure is:
$ ninja -C out/Debug unit_tests
$ rm -rf out/Debug/test_data
$ ninja -C out/Debug test_data/chrome/../ui/webui/resources/js/cr.js
Ninja is fine because it normalizes the path early enough whereas in
python we relied on the system to compute the path but out/Debug/test_data/chrome may not exist
BUG=235731
Hat-tip to cjhopman for help debugging.
Review URL: https://chromiumcodereview.appspot.com/14432003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@197224 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
* Rename aura_shell_unittests target to ash_unittests
* Add a target for aura_shell_unittests that makes a copy of ash_unittests
We need the old copy until we can switch the build bots to using the new copy.
cp.py needs to change slightly to preserve the executable bit of the test binary.
BUG=110107
TEST=Run build/gyp_chromium, inspected build.ninja files to verify rules existed for both ash_unittests and aura_shell_unittests, built and ran both targets
TBR=thestig@chromium.org for trivial rename in tools/valgrind/chrome_test.py
Review URL: https://chromiumcodereview.appspot.com/10700163
git-svn-id: http://src.chromium.org/svn/trunk/src/build@146654 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Print Preview unit_tests were good to tackle because it brought in a dependency on the need
to include another js file.
This also hilighted another need - that of being able to include non-generative js files in gyp
and have them copied to the test_data dir, while doing both generation and copy for gtest files.
I changed the "extension" of files which generate C++ with gtest-like syntax to .gtestjs and
added a copyjs rule to the chrome_tests.gypi.
FWIW, I believe this is mostly needed for unit_tests and only applied it there, although I would
be amenable to also making this change for the webui tests to make it clear that they are not
plain js files.
R=dpapad@chromium.org
BUG=101443,102222
TEST=unit_tests --gtest_filter=PrintPreviewUtilsUnitTest.*
Review URL: http://codereview.chromium.org/8438063
git-svn-id: http://src.chromium.org/svn/trunk/src/build@109310 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
yfriedman@chromium.org
jamescook@chromium.org
maruel@chromium.org
scr@chromium.org