The `file` program follows POSIX as outlined here:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/file.html
Specifically, this part causes troubles:
If the file named by the file operand does not exist, cannot be read, or
the type of the file named by the file operand cannot be determined, this
shall not be considered an error that affects the exit status.
With older versions of `file` (that does not conform to POSIX), this
script will exit 0 with "unknown" as its output when "$1" does not exist.
But with recent releases (that conform to POSIX), this script will exit 1
and can break the build.
Have the script explicitly check for the existence of $1 and if it does
not exist, then runt he unknown logic like normal.
BUG=chromium:332547
TEST=ran python_arch.sh on bogus files with new & old `file` programs
Review URL: https://codereview.chromium.org/137433002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244778 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The emulator sdk root is now downloaded into the source tree (and .gitingore'd).
That means that doing a clobber on the src directory will delete the emulator
SDK downloaded by build/android/install_emulator_deps.py.
This change allows developers to have an emulator SDK located somewhere else
that they can point the avd.py script to. Also, some bots will remove the src
directory between builds. Rather than make the bots re-download the emulator sdk
everytime, this allows them to have an emulator SDK installed somewhere else and
point to it.
BUG=304129
TBR=craigdh@chromium.org
Review URL: https://codereview.chromium.org/132793003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244637 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes make_global_settings closer to the GYP version. Previously it had relied on GYP concatenating two lists when running with goma, but it doesn't actually behave this way, resulting in unexpected output.
TBR=scottmg
Review URL: https://codereview.chromium.org/132833002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244104 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes unwind support consistent on Linux (used by
base::debug::StackTrace). A combination of arch-specific toolchain defaults
and arch-specific cflags made the previous behavior inconsistent.
Unwind tables are useful for development and much cheaper than
debuginfo, so enable them for all non-official builds.
TEST=build for ia32, x64, arm (compared defaults & official)
BUG=180975
Review URL: https://codereview.chromium.org/129283003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243919 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The dependency is unnecessary and causes build error in the standalone webrtc project due to missing base.gyp when SCTP is enabled (it depends on usrsctp.gyp, which depends on system.gyp). All system.typ needs from base.gyp is the "include_dirs" pointing to ".." relative to "base". So we can remove the dependency on base.gyp and add "include_dirs":["../.."] instead.
BUG=
Review URL: https://codereview.chromium.org/128933005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243863 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
With this change, `gclient runhooks` creates ninja files by default on
Windows. To build, run `ninja -C out\Release chrome`. The output appears
in out\ instead of build\.
If you need to use a VS build for some reason, you can still
`set GYP_GENERATORS=msvs`. This is no longer a tested configuration.
Bots should automatically pick up the binaries in the new location (out).
If something does break, it should be safe to revert this change, and bots
should then automatically go back to picking up binaries from the old
location (build).
R=thakis@chromium.org
BUG=303291
Review URL: https://codereview.chromium.org/111183004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243782 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix a few instances of HashMap to SparseArray in
AwQuotaManagerBridge.java
Pass null locale to String.format, which implies "no
localization is applied".
Pass Locale.ENGLISH toLowerCase as suggested by the
documentation.
Removed some unneeded supressions.
BUG=
Review URL: https://codereview.chromium.org/126453006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243781 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds arm version and some android configuration build flags.
This adds most of the logic from common.gypi to the Android GN build.
This is currently missing the crtbegin/end stuff and won't actually make real Android builds. The logic in this patch is just the initial conversion that will require testing and several more passes of fixes.
R=torne@chromium.org, torne
Review URL: https://codereview.chromium.org/121173005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243681 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Rebooting s3 devices causes device to be flaky during the deploy step. This is
likely because WaitForPackageManager() does not wait long enough on the s3
devices. I've verified locally on the bot that without the reboot in the
provision step, the devices are more reliable (i.e. deploy step passes).
BUG=321063
TBR=frankf@chromium.org
Review URL: https://codereview.chromium.org/122313008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243542 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes gyp_chromium pass defines defined via -D on the command line to GN.
Fixes double-escaping of strings from supplemental.gypi files.
Pass use_goma to the GN build.
Handle "use_goma" and "use_goma=1" (same for other boolean values). Previously values with no equals sign were getting converted to 'true', which doesn't match '1' which we look for.
Output goma wrappers in the GYP header for Windows toolchains.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/123463005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243446 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds a build step to generate mirrored images for use in
right-to-left (RTL) languages. Images are mirrored by flipping the
original image over the vertical axis. Every image must be explicitly
listed as mirrorable or non-mirrorable in a config file.
The goal: ensure that our RTL image assets are always up-to-date.
BUG=290225
NOTRY=true
Review URL: https://codereview.chromium.org/106173002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243332 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
raymes@google.com
brettw@chromium.org
vapier@chromium.org
thestig@chromium.org
bolian@chromium.org
navabi@google.com
thakis@chromium.org
jam@chromium.org
spang@chromium.org
hans@chromium.org
dalecurtis@google.com
frankf@chromium.org
phoglund@chromium.org
bulach@chromium.org
szym@chromium.org
jiayl@chromium.org
eugenis@chromium.org
nick@chromium.org
scottmg@chromium.org
boliu@chromium.org
bbudge@chromium.org
sbc@chromium.org
newt@chromium.org
kbr@chromium.org
iancottrell@chromium.org