Now that android_webview_build is no longer supported, the extra level
of indirection of including cpufeatures.gypi instead of directly
depending on the cpufeatures target is not necessary. Remove the cases
in the Chromium tree. Other references appear in projects pulled in via
DEPS that will have to be fixed separately before cpufeatures.gypi can
be entirely deleted.
BUG=440793
Review URL: https://codereview.chromium.org/1045123005
Cr-Original-Commit-Position: refs/heads/master@{#324117}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9845b890dd38f0b88b0304f3bd6c437a7c6f8f8d
When you run `gn gen out-gn/Debug` on Mac you get the following:
ERROR at //build/toolchain/mac/BUILD.gn:200:12: Build argument has no effect.
os = current_os
^---------
The variable "os" was set as a build argument
but never appeared in a declare_args() block in any buildfile.
BUG=None
TEST=`gn gen out-gn/Debug` passes without the above error
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1064063002
Cr-Original-Commit-Position: refs/heads/master@{#324109}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 53ec706bbc5debe052dd51e4d93e2de4c2802ab2
Adds a new junit_binary template for gyp which makes it easy to
make new Junit test suites by setting a lot of the options and
necessary dependencies for you.
Also, adds a new java_binary.gypi file which uses the
create_java_binary_script.py similiar to how the java_binary
GN template works when main_class is specified. This lets
GYP and GN work similiar when building a junit binary, so
our test runner can run them the same way.
Finally, because of the slightly different way were now running
the junit binary, the java classpath contains all of the jars
instead of just the test jar (before we were running
java -jar test_jar.jar which set the classpath to just be
test_jar.jar). Therefore, we can simplify things and just look
in the classpath for the paths to the Robolectric dependencies
when running Robolectric junit tests.
BUG=
Review URL: https://codereview.chromium.org/1057783002
Cr-Original-Commit-Position: refs/heads/master@{#324093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ad64324d470c43b29854282d5ad5b1ff75dfc6c
- Chrome has been targetting 22 for a while now so updating to match it.
- Chrome has deprecated ICS so raising minSdkVersion to 16.
BUG=473837
Review URL: https://codereview.chromium.org/1061713002
Cr-Original-Commit-Position: refs/heads/master@{#323947}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1d807cd78fe35e59218b1cb9a78a93a13a4b0e10
Switch all battery related device interaction from
DeviceUtils to BatteryUtils. Currently they reside in device
utils, which has a lot of functionality around a lot of
different device interactions. This will consolidate all
current and future power related phone interactions into one location.
BUG=472763
Review URL: https://codereview.chromium.org/1057563002
Cr-Original-Commit-Position: refs/heads/master@{#323940}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58368d3ea55f26f5eb98a76cb7985f580f23ff8c
Cast Ozone is now fully implemented in chromecast/ozone, including
the Ozone factory function. The CastEglPlatform interface is moved
to public and its implementation will be loaded from shared library.
BUG=
Review URL: https://codereview.chromium.org/1059073002
Cr-Original-Commit-Position: refs/heads/master@{#323916}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3d0e49f9b24f3496aee8a10262fb87434dcd67a8
ChromeOS may use 32bit userspace on 64bit kernel. Make sure all 64bits are used when acessing file.
note: _FILE_OFFSET_BITS is already set to 64 on posix.
BUG=471407
Review URL: https://codereview.chromium.org/1059613002
Cr-Original-Commit-Position: refs/heads/master@{#323688}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f33a81c14818d8cdde53e3dc34f1b1344a4583f3
This change adds a HTML/CSS version of the YES/NO feedback form that
appears at the bottom of a distilled page. This form is either at
the bottom of the page or at the bottom of the distilled article
depending on which is larger.
This change depends on:
https://codereview.chromium.org/1015463004/
BUG=
Review URL: https://codereview.chromium.org/1049043003
Cr-Original-Commit-Position: refs/heads/master@{#323582}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 87f0c35db730f3351b2da0858f4b93b5a58da33c
Currently, the gyp variables CC_wrapper and CXX_wrapper can be set in
the chromium.gyp_env file. However, the host compiler wrapper variable
cannot. By exposing this variable, embedders can more easily
use tools like ccache or icecream when developing for android.
BUG=471340
Review URL: https://codereview.chromium.org/1044423005
Cr-Original-Commit-Position: refs/heads/master@{#323557}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 73e65d4adbbc1cc83f7e59b2dfe60107c2dd186e
Trusty seems to have dificulty installing gcc-arm-linux-gnueabihf
and gcc-4.8-multilib without these extra packages being listed
on the install line also.
BUG=435056
Review URL: https://codereview.chromium.org/1049833003
Cr-Original-Commit-Position: refs/heads/master@{#323281}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b5d4ded25739d583663fd17569de96394f84c267
This change will allow us to get the test results information
to our testrunner without having to parse stdout. This will fix
the issue of junit tests not showing up on the test report step
on our bots.
BUG=465755
Review URL: https://codereview.chromium.org/1003463002
Cr-Original-Commit-Position: refs/heads/master@{#323255}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c638a07bf65457b24956785146d3429045a47fe2
There are a few targets we build in a GYP build of Chromium that
we don't actually need and shouldn't be building. We will track
them in a 'gyp_only' target to indicate that they don't need to
be ported to GN.
TBR=brettw@chromium.org
BUG=461019
Review URL: https://codereview.chromium.org/1041163004
Cr-Original-Commit-Position: refs/heads/master@{#323170}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aa9e60e1e08b558a89d0883cdc807ea48f934492
It requires internal test files, hence it was not tested.
Partially tested on Linux with the following command lines:
$ gn gen out-gn --args='internal_gles2_conform_tests'
Formatted with the following command line:
$ gn format --in-place gpu/gles2_conform_support/BUILD.gn
BUG=432959
TEST=see above
R=dpranke@chromium.org,sievers@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1033373002
Cr-Original-Commit-Position: refs/heads/master@{#323082}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 719f00367465a6b940dc2804be147a0b23546cf4
All the bots force the value of target_subarch so the default value is only
used by developpers. Since the vast majority of the devices used on a daily
basis by developpers are 64-bit devices swap the default to 64-bit.
BUG=None
Review URL: https://codereview.chromium.org/1021513002
Cr-Original-Commit-Position: refs/heads/master@{#323039}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4ef3ab4e104014a35ac36903368b0111c52a1389
iOS like Android does not compile render_text.cc used by canvas_skia.cc
so change the value of use_canvas_skia to 0 on that platform to prevent
invisible dependency (currently the linker is removing the methods that
do depends on render_text.cc since they are not used).
BUG=None
Review URL: https://codereview.chromium.org/1044843002
Cr-Original-Commit-Position: refs/heads/master@{#323029}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 48c11af6c797badfc9e8e9e2e48113b2b04ed4b0
Remove most references to android_webview_build from the build directory
now that we no longer support that build configuration. Fold conditions
into their parents where appropriate. Leave the variable itself defined
to 0 as not all uses in the tree have been removed yet.
A few references are left alone here and will be removed separately in
later changes that will be larger refactorings to eliminate other
variables.
BUG=440793
Review URL: https://codereview.chromium.org/1043913002
Cr-Original-Commit-Position: refs/heads/master@{#323013}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c6fe7a775af41cd98533e89a902b8b67044caa87
This CL ensures that locks are taken in the same order in both threads in order to avoid deadlocks.
BUG=433993
TEST=Existing WebRtc content_browsertests with TSAN enabled.
Review URL: https://codereview.chromium.org/1036993003
Cr-Original-Commit-Position: refs/heads/master@{#322995}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5330f31cf74e3756dc2103f8c3d5840b5f6a2884
jrummell
inferno
machenbach
mfoltz
torne
tfarina
rnephew
mikecase
jbudorick
rmcilroy
aurimas
sbc
halliwell
gunsch
cjhopman
wangxianzhu
oshima
halton.huo
mdjones
cwgreene
glider
dpranke
khorimoto
tobiasjs
mostynb
pcc
sdefresne
guidou