This is to fix a bug introduced by r221426 on the WebView telemetry bot.
The issue was related to the fact that ls -l can return no output if the
target folder exists but is empty.
This change makes the IsProtectedFile logic inside _SetCommandLineFile
more reliable, introducing the IsFileWritableOnDevice method in adb
commands.
BUG=284468
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/23477053
git-svn-id: http://src.chromium.org/svn/trunk/src/build@222349 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
breaks XP Tests:
ActivityLogPrerenderTest.TestScriptInjected
FindInPageTest.PrepopulateRespectBlank
KeyboardAccessTest.TestAltMenuKeyboardAccessFocusOmnibox
KeyboardAccessTest.TestMenuKeyboardOpenDismiss
> Switch all windows bots to use Aura.
>
> Because we've been shipping Aura to canary for a while. And because force compositor landed 40 hours ago and things seem ok. See https://codereview.chromium.org/23874016/
>
> This also allows to see perf numbers for Aura.
>
> This has happened before see for example r204698, r211007 and 214056 as an experiment but this time it might stick.
>
> BUG=259185
> TEST=none
> TBR=scottmg
>
> Review URL: https://codereview.chromium.org/23816007TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/23523035
git-svn-id: http://src.chromium.org/svn/trunk/src/build@221952 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
--
Use Finch to compare the performances of CLD1 and CLD2
Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used.
By this CL, each platform will have the below status:
Linux: Use both CLD1 and CLD2 (and use Finch).
Mac OS X: Use both CLD1 and CLD2 (and use Finch).
Windows: Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap.
iOS: Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.)
Android: Still use only CLD1. (The same reason as iOS)
So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.)
BUG=240647
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221380
Review URL: https://chromiumcodereview.appspot.com/22867032
git-svn-id: http://src.chromium.org/svn/trunk/src/build@221675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Changes to enable annotating known leaks in blink so that leak sanitizer doesn't raise alarm.
Removing addition of StringImpl::createStatic from tools/lsan/suppressions.txt
This patch currently just handles Leak Sanitizer only. The changes for Heap Checker would be done in a follow up patch.
BUG=268258
TEST=Running content_unittests with Leak Sanitizer enabled.
Output of Leak Sanitizer before the fix: http://pastebin.com/niDgRNAQ
Output of Leak Sanitizer after the fix: http://pastebin.com/v6hF43Lj
Review URL: https://chromiumcodereview.appspot.com/23460014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@221586 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This folder was created specifically to ensure infrastructure
team had visibility and veto before changes go live that can
negatively affect stability of production systems.
yfriedman and bulach were added because they are general android
owners and to ensure that minor changes do not get blocked.
> [android] Add frankf and craigdh to build/android/buildbot/OWNERS.
>
> BUG=None
> TEST=None
> NOTRY=True
>
> Review URL: https://chromiumcodereview.appspot.com/23129027TBR=craigdh@chromium.org
Review URL: https://codereview.chromium.org/23567017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@221567 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used.
By this CL, each platform will have the below status:
Linux: Use both CLD1 and CLD2 (and use Finch).
Mac OS X: Use both CLD1 and CLD2 (and use Finch).
Windows: Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap.
iOS: Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.)
Android: Still use only CLD1. (The same reason as iOS)
So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.)
BUG=240647
Review URL: https://chromiumcodereview.appspot.com/22867032
git-svn-id: http://src.chromium.org/svn/trunk/src/build@221380 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
In Xcode, each project has a warning that "Build only for active
architecture" should be enabled for Debug configuration. This change to
common.gypi sets the ONLY_ACTIVE_ARCH variable at the project level for
Debug configurations.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23684011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@220960 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Re-enable linker warnings being treated as errors when using the system
version of skia, since there are no more warnings in this configuration.
Also, fix the global disabling of linker warnings (introduced to fix mac
builds) to only apply to host targets.
BUG=157326
Review URL: https://chromiumcodereview.appspot.com/23506016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@220873 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
r220846 was not the root cause of the failure.
> Revert 220846 "Make landmines.py take an extra script via an env..."
>
> It broke telemetry_unittests.
> http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/8782/steps/telemetry_unittests/logs/stdio
>
> E:\b\depot_tools\python_bin\python_slave.exe src\tools\telemetry\run_tests --browser=release_x64
> No adb found in $PATH, fallback to checked in binary.
> Traceback (most recent call last):
> File "src\tools\telemetry\run_tests", line 8, in <module>
> from telemetry.unittest import gtest_testrunner
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\__init__.py", line 12, in <module>
> from telemetry.core.browser_options import BrowserFinderOptions
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\browser_options.py", line 12, in <module>
> from telemetry.core import browser_finder
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\browser_finder.py", line 9, in <module>
> from telemetry.core.backends.chrome import android_browser_finder
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\android_browser_finder.py", line 17, in <module>
> from telemetry.core.backends.chrome import android_browser_backend
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\android_browser_backend.py", line 15, in <module>
> from telemetry.core.backends.chrome import chrome_browser_backend
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\chrome_browser_backend.py", line 19, in <module>
> from telemetry.core.backends.chrome import extension_dict_backend
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\extension_dict_backend.py", line 9, in <module>
> from telemetry.core.backends.chrome import inspector_backend
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\inspector_backend.py", line 19, in <module>
> from telemetry.core.jsheap import model
> ImportError: No module named jsheap
>
> > Make landmines.py take an extra script via an env var.
> >
> > The extra Python script to run can be specified via env var
> > EXTRA_LANDMINES_SCRIPT.
> >
> > BUG=223636
> >
> > Review URL: https://chromiumcodereview.appspot.com/23604016
>
> TBR=sivachandra@chromium.org
>
> Review URL: https://codereview.chromium.org/23533016TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/23532029
git-svn-id: http://src.chromium.org/svn/trunk/src/build@220870 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It broke telemetry_unittests.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/8782/steps/telemetry_unittests/logs/stdio
E:\b\depot_tools\python_bin\python_slave.exe src\tools\telemetry\run_tests --browser=release_x64
No adb found in $PATH, fallback to checked in binary.
Traceback (most recent call last):
File "src\tools\telemetry\run_tests", line 8, in <module>
from telemetry.unittest import gtest_testrunner
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\__init__.py", line 12, in <module>
from telemetry.core.browser_options import BrowserFinderOptions
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\browser_options.py", line 12, in <module>
from telemetry.core import browser_finder
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\browser_finder.py", line 9, in <module>
from telemetry.core.backends.chrome import android_browser_finder
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\android_browser_finder.py", line 17, in <module>
from telemetry.core.backends.chrome import android_browser_backend
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\android_browser_backend.py", line 15, in <module>
from telemetry.core.backends.chrome import chrome_browser_backend
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\chrome_browser_backend.py", line 19, in <module>
from telemetry.core.backends.chrome import extension_dict_backend
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\extension_dict_backend.py", line 9, in <module>
from telemetry.core.backends.chrome import inspector_backend
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\inspector_backend.py", line 19, in <module>
from telemetry.core.jsheap import model
ImportError: No module named jsheap
> Make landmines.py take an extra script via an env var.
>
> The extra Python script to run can be specified via env var
> EXTRA_LANDMINES_SCRIPT.
>
> BUG=223636
>
> Review URL: https://chromiumcodereview.appspot.com/23604016TBR=sivachandra@chromium.org
Review URL: https://codereview.chromium.org/23533016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@220853 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
primiano@chromium.org
craigdh@chromium.org
kkania@chromium.org
groby@chromium.org
dtrainor@chromium.org
raphael.kubo.da.costa@intel.com
dpranke@chromium.org
thakis@chromium.org
johnme@chromium.org
vitalybuka@chromium.org
cpu@chromium.org
johnw@google.com
erg@chromium.org
ilevy@chromium.org
frankf@chromium.org
bulach@chromium.org
hajimehoshi@chromium.org
cevans@chromium.org
sivachandra@chromium.org
plundblad@chromium.org
r.kasibhatla@samsung.com
navabi@google.com
pneubeck@chromium.org
skyostil@google.com
glider@chromium.org
nyquist@chromium.org
mariakhomenko@chromium.org
sievers@chromium.org
jeanfrancoisg@chromium.org
oshima@chromium.org
peter@chromium.org
lliabraa@chromium.org
torne@chromium.org
tkent@chromium.org