Created by flipping enable_app_list to '0' everywhere except ChromeOS,
ensuring it passes CQ, then flipping it back.
Mostly just splitting app_list source files out to their own gyp
variables.
This will allow us to test new code needed for previously supported
platforms. The code will be required as soon as enable_app_list is
flipped to 0. E.g. calls to --show-app-list will just show chrome://apps
instead.
Builds upon initial work in https://codereview.chromium.org/1747773002/
BUG=600915
COLLABORATOR=wierichs@google.com
Review-Url: https://codereview.chromium.org/1861233003
Cr-Original-Commit-Position: refs/heads/master@{#393474}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d13e0cdf6fc5fddb580968adb2a5b9c5379a4404
This sets it as a data_deps so that any targets depending on the sanitizer
will also pick up the runtime file when being isolated.
Because the ASan runtime uses @loader_path this will not work for bundled
targets, only standalone executables.
BUG=597066,431177
R=aizatsky@chromium.org
Review-Url: https://codereview.chromium.org/1963253002
Cr-Original-Commit-Position: refs/heads/master@{#393335}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 45384fb36763bb34ac3a7395d2dc941754a276ae
This CL makes sure that frame pointers (used for fast stack unwinding)
are not omitted when enable_profiling is true. There are two changes:
1. Don't add -fomit-frame-pointer flag (Android-specific change).
2. Add -fno-omit-frame-pointer flag even in debug builds. This is needed
for Android where debug builds are optimized too (-Os).
BUG=602701
Review-Url: https://codereview.chromium.org/1965143003
Cr-Original-Commit-Position: refs/heads/master@{#393320}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 14430a4de781aca8e67f6ec7b8893647d7ee26d9
Previously, we were only processing resources on aapt or sdk jar _path_
change.
This also removes an unrelated debug print statement.
BUG=603138
Review-Url: https://codereview.chromium.org/1967153002
Cr-Original-Commit-Position: refs/heads/master@{#392957}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a211f7633c4dc0f2b1fb1c8a40040e84e9568d47
libjpeg_turbo.gyp is located in third-party and is updated
by rolling to a recent commit:
414f243 Remove unused MJPEG define from libjpeg-turbo GYP file
414f2433e6634942b9ceea9450bdc21dcc5520cf
by Noel Gordon
BUG=608347
Review-Url: https://codereview.chromium.org/1961933002
Cr-Original-Commit-Position: refs/heads/master@{#392934}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 50a66e887857dc4117e64f5150c0bafc5097279e
Add a new target convert_plist to invoke "plutil -convert" only on a
given plist file. This is used as iOS needs to convert all plist to
binary in bundle, including plist that are not Info.plist files.
Fix ios_info_plist and info_plist templates to also forward "visibility"
from the invoker.
BUG=459705
Review-Url: https://codereview.chromium.org/1964393002
Cr-Original-Commit-Position: refs/heads/master@{#392924}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7f441707e74fd96a04ecdd0c97f1f66d83e7bf5d
Reason for revert:
Seemingly breaks incremental builds.
Original issue's description:
> Add directory option for JUnit coverage files.
>
> Added runtime option --coverage-dir to let the users decide where to store
> coverage.ec.
>
> BUG=608072
>
> Committed: https://crrev.com/de08f6f711ebd74fe493584e0694bcce51693318
> Cr-Commit-Position: refs/heads/master@{#392727}
TBR=mikecase@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=608072
Review-Url: https://codereview.chromium.org/1973503002
Cr-Original-Commit-Position: refs/heads/master@{#392908}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0b730799f2f2f2d9d07b75f3fadd2ed387336a02
This adds the required framework to libs[] wherever they are required (most
of the changes in this CL). It also enables the component build optimization
of creating a non-bundled dylib to roll up all the sources and dependencies.
The framework then links that, which allows the build to not copy the bundled
library if any sources change. This is based on the technique implemented
https://codereview.chromium.org/11420019/.
BUG=431177
R=thakis@chromium.org,brettw@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/1961473003
Cr-Original-Commit-Position: refs/heads/master@{#392823}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 02aa51cf444626f4781824c17178376c0459ad83
Since the bots run gyp_chromium seperately from runhooks, the hermetic mac
toolchain environment variables need to be set in this script as well.
BUG=474373
Review-Url: https://codereview.chromium.org/1970623002
Cr-Original-Commit-Position: refs/heads/master@{#392822}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 588af0bb9a83d6441c00858ca5ae74a919706e74
lld-link expects LIB to be ;-separated even on non-Windows. Hopefully
it'll eventually use a flag for system lib dirs instead of looking at env vars,
but for now it looks at env vars.
(clang-cl also expects INCLUDE to be ;-separated, but it already uses
-imsvc instead of the INCLUDE env var to find system include dirs.)
BUG=495204
Review-Url: https://codereview.chromium.org/1970443002
Cr-Original-Commit-Position: refs/heads/master@{#392676}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b61345c8939bfc9e23f9a2442e681b54566120ca
The compiler only needs the INCLUDE environment var, and those contents
can just be passed via flags. clang-cl's -imsvc flag adds include directories
as-if they're from INCLUDE (i.e. they're in the right place in the directory
search order, and they're treated as system headers that don't emit warnings).
In 64-bit builds, this would also work for MSVC, but MSVC happily warns about
questionable code in system headers if enough warnings are turned on, so we would
just use /I there (and make sure the flags are early on the compile command so
that these directories are searched at the same time as they would be with INCLUDE).
However, in 32-bit builds, MSVC needs PATH to contain both the 32-bit and the 64-bit
bin directories to load dlls. Since invoking the compiler so differently for 32-bit
and 64-bit is strange, only do this simplification for clang-cl for now.
goma doesn't yet know the -imsvc flag flag, so this is blocked on goma learning
about this clang-cl flag (https://b//28179421).
Build time impact:
64-bit debug builds symbol_level=1, building some binary ("gn")
before:
clang-cl: 34.9s, 35.1s, 35.1s
cl: 26.3s, 26.1s, 27.6s
after:
clang-cl: 33.8s, 33.7s, 34s
cl: 27s, 34.5s, 26.7s
So no discernible build perf difference, but fewer processes
and less reliance on these environment files seems like a good
change anyhow.
It also helps with a potential cross-compile of chrome/win, since
ninja's -t msvc only exists in ninja/win.
BUG=588831
Review-Url: https://codereview.chromium.org/1724533002
Cr-Original-Commit-Position: refs/heads/master@{#392624}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8435ab74b05929d290a11808a0a94ea7536531d7
Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.
BUG=585576
Review-Url: https://codereview.chromium.org/1952153002
Cr-Original-Commit-Position: refs/heads/master@{#392620}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd2adf0e9718ec28f46dde4c09e379c9df82065e
Accepting an older license will break newer toolchains. Check if a bot's
last agreed to toolchain is newer. If it's older, accept the hermetic toolchain.
BUG=
Review-Url: https://codereview.chromium.org/1956073003
Cr-Original-Commit-Position: refs/heads/master@{#392356}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10dc9038e9e0e42efa7a53c4f6857a6749ceea0b
Add a new script to copy data into an iOS/Mac bundle based on the gyp
script (but removing extra work that is not required as it is done in
previous steps).
BUG=297668
Review-Url: https://codereview.chromium.org/1946203002
Cr-Original-Commit-Position: refs/heads/master@{#392332}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62321627a76f6990ce912fc24fd5d1c6d0ab7c74
In clang builds, we use the same compiler binary for 32-bit and 64-bit
builds, so we need to tell that binary if it should produce 32-bit or
64-bit object files.
The //build/config/compiler:compiler config takes care of adding -m32
and -m64 flags, but the mini_installer target removed that config,
removing these flags (and other important compiler flags such as
-fmsc-version).
It looks like removing this config isn't really necessary -- the only
compiler flag that mini_installer wants to change is /GS-, to disable
buffer security checks. I first thought I'd move /GS into its own
config so that mini_installer can remove it, but it turns out /GS is
on by default. So don't pass /GS in :compiler, and do pass /GS- in
mini_installer.
No target should remove //build/config/compiler:compiler from its configs.
BUG=498033
Review-Url: https://codereview.chromium.org/1957523005
Cr-Original-Commit-Position: refs/heads/master@{#392175}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7170da48a964aa08a16fbf03ce17dbd78b596500
Some were obsolete, some I implemented in this patch. Some I left as-is if they applied to Mac or iOS.
A few items are TODOs for when transition is complete. I changed these to "TODO(GYP_GONE)"
This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1953523002
Cr-Original-Commit-Position: refs/heads/master@{#391943}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9427f9e3edb7be9bd540bb35b3d3156c08c3df6
gn always quotes arguments using the host rules.
No behavior change except when targeting Windows from non-Windows
hosts, which isn't allowed yet in build/config/BUILDCONFIG.gn
BUG=600223
Review-Url: https://codereview.chromium.org/1947223003
Cr-Original-Commit-Position: refs/heads/master@{#391892}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6bcb18bfa6f9a7bbc3f9fa4cc3953d0a215eaac5
Includes the following commits:
Add PRIVATE flags to global symbols
51655203fbc949e6423dcd13ce22fe30ab5b5ea2
Fix INLINE macro on Windows
9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04
Update to libjpeg_turbo 1.4.90
0d47d2d3a728e78676a15b1d818cc668cb7e5a9c
Add default variable 'use_system_yasm%':
9d35298a6223278a66423f828a949d93d94d5911
Update README.chromium about the 32-bit argument patch
c653af70b7b2bbd3e8cd16c17bc2705cf25b1469
BUG=608347
Review-Url: https://codereview.chromium.org/1935113002
Cr-Original-Commit-Position: refs/heads/master@{#391883}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 346f74fb31a84f8453e885337e0765576b4f35b6
Also fix some libaddressinput dependencies/includes which incorrectly used ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for chrome://settings/autofill regardless of the use of the dialog).
Also move some color constants closer to where they're used for the card unmask dialog.
BUG=337587, 608824
TBR=palmer@chromium.org
Review-Url: https://codereview.chromium.org/1931043002
Cr-Original-Commit-Position: refs/heads/master@{#391821}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e62c2a4c85f206833cb058932cfe62b3c347c685
The removed exception is raised when I am testing link to a jar file which
extract from a .aar file through an action. For example:
action("extract_aar") {
script = ".."
...
outputs = ["$root_out_dir/test.jar",]
}
android_java_prebuilt("test_prebuilt") {
jar_path = "$root_out_dir/test.jar"
deps = [":extract_aar"]
}
It looks like the exception is unnecessary anymore so removing it.
BUG=NONE
Review-Url: https://codereview.chromium.org/1929163003
Cr-Original-Commit-Position: refs/heads/master@{#391586}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 01ec845c3abedb6e8b279386577e521e0e43e9b8
The new Clang toolchain rolled yesterday makes LTO devirtualization
working on visibility basis, instead of being based on a blacklist.
This CL just removes the now unsupported option.
BUG=601822
Review-Url: https://codereview.chromium.org/1947103002
Cr-Original-Commit-Position: refs/heads/master@{#391572}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 806f95f1974ea657e43b854c3ec30c2b59eca8b4