Граф коммитов

5 Коммитов

Автор SHA1 Сообщение Дата
joi@chromium.org 7464670db3 Use precompiled headers on Windows only when a flag is set.
I would have preferred if precompiled headers could be enabled by
default. The motivation for this change is primarily that Visual
Studio does the wrong thing on preprocessor flag changes - instead of
rebuilding precompiled headers, it errors out on any file that uses
them, saying that the precompiled header was built with different
flags! This causes a world of hurt on our infrastructure stuff,
particularly on trybots as they may be jumping back and forth between
revisions before and after a flag change.

Prior to this change, only Debug builds used precompiled headers and
Release builds did not. The reason Release builds did not was that
official builds were running out of memory with precompiled headers
enabled. The distinction of Debug vs. Release is no longer necessary
after the flag is added, so removing that extra bit of complexity from
the .gyp files.

BUG=none
TEST=it builds


Review URL: http://codereview.chromium.org/8041022

git-svn-id: http://src.chromium.org/svn/trunk/src/build@102839 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-27 00:15:16 +00:00
joi@chromium.org 17492745b4 Relanding precompiled header support for VS 2008, now enabled for
Debug builds only as official builds were failing with out of memory
errors.

This is mostly a revert of http://crrev.com/101836 which was a
revert of the original change, http://crrev.com/101474, except for a
modification to build/win_precompile.gypi to only enable use of
precompiled headers in the Debug configuration.

BUG=none
TEST=it builds

Review URL: http://codereview.chromium.org/7977003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@102029 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-20 21:46:48 +00:00
joi@chromium.org a22b81862a Temporary revert of r101474, will re-land tomorrow with a change to disable use of precompiled headers in Release builds as our Canary builds are failing with out of memory messages.
Original change description: Switch on use of precompiled headers for VS 2008.

The precompiled header brings in more definitions of abs() for the base/time_win.cc file, and a hint to the compiler was needed to let VS 2008 build the file correctly.

On VS 2008 only, the mini_installer target did not link correctly with precompiled headers enabled so this change disables them for that project.

BUG=none
TEST=it builds (esp. on Windows), existing tests pass

Review URL: http://codereview.chromium.org/7910002

TBR=laforge@chromium.org
Review URL: http://codereview.chromium.org/7945017

git-svn-id: http://src.chromium.org/svn/trunk/src/build@101836 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-19 21:29:33 +00:00
joi@chromium.org c912f5404f Switch on use of precompiled headers for VS 2008.
The precompiled header brings in more definitions of abs() for the base/time_win.cc file, and a hint to the compiler was needed to let VS 2008 build the file correctly.

On VS 2008 only, the mini_installer target did not link correctly with precompiled headers enabled so this change disables them for that project.

BUG=none
TEST=it builds (esp. on Windows), existing tests pass

Review URL: http://codereview.chromium.org/7910002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@101474 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-16 09:54:23 +00:00
joi@chromium.org 2869c0a819 Use precompiled headers for most large projects where the .gyp file
is not a third party file.

On my machine, this speeds up a full recompile of the 'chrome' target
in Debug mode by about 18%.

BUG=none
TEST=it builds, existing tests pass

Review URL: http://codereview.chromium.org/7706011

git-svn-id: http://src.chromium.org/svn/trunk/src/build@99949 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-07 14:14:54 +00:00