There is already a remoting_enable.gni file in the remoting directory. This
flag should be contained in there rather than in the global feature flags file.
Review-Url: https://codereview.chromium.org/2410973002
Cr-Original-Commit-Position: refs/heads/master@{#424824}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b112cd25fcc75ec6d764a789acebfa60022780d
Reduces hot-cache link time from 49s to 23s (gcc) and binary size from 72M to
67M (gcc) -- faster links and a 5MB smaller binary.
(With clang, it's 36s to 19.5s and 75M to 69M.)
It also makes the chrome/android/arm64 config more similar to most other build
configs.
We used to not use this because of
https://sourceware.org/bugzilla/show_bug.cgi?id=18348 , but the gold binary
in NDK r12b (which we currently use) has the flags added in the patches on
that bug, so it should be fine now.
BUG=481855
Review-Url: https://codereview.chromium.org/2410233002
Cr-Original-Commit-Position: refs/heads/master@{#424747}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a4baf802f3058b66976a2085278f13ab3bcd8092
Newer NDKs define snprintf() (and other functions) to a macro when using clang,
to implement a kind of _FORTIFY_SOURCE support. This means it's impossible to
declare your own base::snprintf(), like base/strings/string_util.h does. A
future NDK will have a better fortify story that doesn't depend on macros,
but for now build with -Dsnprintf=snprintf to tell the NDK that it shouldn't
define snprintf as a macro. This will disable fortify for snprintf.
This matters for 64-bit only because we use NDK 21 for 64-bit builds but
we use NDK 16 for 32-bit builds. NDK 16 never does any fortify stuff, so
while this CL does remove fortify checking for snprintf() (but not for any
other function), 64-bit binaries are still better-protected than 32-bit
binaries. (And ideally this situation is just temporary.)
With this, x64 and mips64el build fine with clang. With this and
https://codereview.chromium.org/2404193003/, arm64 builds fine with
clang. I verified that a clang-built arm64 Chromium starts up fine
on my Pixel XL and can navigate to a few websites.
BUG=539781
Review-Url: https://codereview.chromium.org/2409173004
Cr-Original-Commit-Position: refs/heads/master@{#424729}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3ae9e5b283ea81dc1605f70970828064deacba2a
Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.
A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.
TBR=jrummell@chromium.org (original reviewer)
TBR=jschuh@chromium.org (render_messages.h owners)
TBR=ddorwin@chromium.org (widevine owners)
Reland of http://crrev.com/2411433002 with official build fix.
Review-Url: https://codereview.chromium.org/2409423002
Cr-Original-Commit-Position: refs/heads/master@{#424687}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c5fcdd0ce8d04569d054322ca21f37272d07005a
Moves
enable_captive_portal_detection
enable_hangout_services_extension
enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=jschuh (render_messages.h)
Review-Url: https://codereview.chromium.org/2405013002
Cr-Original-Commit-Position: refs/heads/master@{#424659}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ab78fefbe385452fae85587b505bcc1bac60a17f
Reason for revert:
Broke build https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/14706
Original issue's description:
> Move ENABLE_PEPPER_CDMS to a buildflag header.
>
> Removes the global build flag and #define and converts to a buildflag header in
> ppapi/features.
>
> A new target "//third_party/widevine/cdm:headers" was added since
> widevine_cdm_version.h was unreferenced in the build. Given that this file now
> requires //ppapi/features we really need "gn check" to work on it. I made the
> existing users of ":version_h" reference this new target which encompasses the
> public headers of the widevine CDM.
>
> TBR=jschuh (render_messages.h)
>
> Committed: https://crrev.com/e23a62a0c4b56618da615698717ed53983854f8d
> Cr-Commit-Position: refs/heads/master@{#424477}
TBR=jrummell@chromium.org,ddorwin@chromium.org,jschuh@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2412493003
Cr-Original-Commit-Position: refs/heads/master@{#424507}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d7d8a5e77ba0ee8c4c0e03a2ac4b15977926ca6
Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.
A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.
TBR=jschuh (render_messages.h)
Review-Url: https://codereview.chromium.org/2411433002
Cr-Original-Commit-Position: refs/heads/master@{#424477}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e23a62a0c4b56618da615698717ed53983854f8d
clang uses the same compiler binary no matter what arch it's targeting,
so it needs to know where to find the (arch-dependent) linker. It needs
to know this no matter if the linker is BFD ld or gold.
This is needed to make things link in chrome/android/arm64
builds with clang.
use_gold defaults to true on android for x86, x64, and arm, but not for arm64,
see build/config/compiler/compiler.gni. It also doesn't default to true
for mips, but mips had a special-case branch adding --gcc-toolchain
before this change.
(We should probably use gold in arm64 android builds by default too, but
that's for a different CL.)
BUG=539781
Review-Url: https://codereview.chromium.org/2404193003
Cr-Original-Commit-Position: refs/heads/master@{#424441}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1a11042f1f1a1532bfba1f0cb8fcb9eac23edd06
Revert these two CLs to have monochrome working again on ToT.
Revert "Move PathUtils to use ContextUtils."
commit 7200e9f34aa2e9006d8ea5540035de744b13d27d.
Revert "Reland of Move language pak files to assets."
commit 67101cd0338a409d80689b9c9c875c95ccde7957.
BUG=653771,644377, 529604
TBR==agrieve@chromium.org,tedchoc@chromium.org,slan@chromium.org,xunjieli@chromium.org,torne@chromium.org,nyquist@chromium.org,wnwen@chromium.org, michaelbai@chomium.org, estevenson@chromium.org
Review-Url: https://codereview.chromium.org/2406093002
Cr-Original-Commit-Position: refs/heads/master@{#424345}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5cb262f964b4a158be02b5497462e2e8d170a59b
Reason for revert:
Breaking monochrome (chrome not booting up)
BUG=652984, 653771
Original issue's description:
> Store only locale paks rather than all assets within BuildConfig.java
>
> This works around Monochrome having diffferent BuildConfig.java for
> 32/64 bit.
>
> BUG=652984
>
> Committed: https://crrev.com/4e09dacc10a8a359785c6f49d75653ce7cfd00ec
> Cr-Commit-Position: refs/heads/master@{#423587}
TBR=tedchoc@chromium.org,michaelbai@chromium.org,agrieve@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652984
Review-Url: https://codereview.chromium.org/2404043002
Cr-Original-Commit-Position: refs/heads/master@{#424304}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 01fbbca601e78b594cebe62b8eb804ca7d6ff0aa
a16a7fd4ef88 win: Make DumpAndCrash() always terminate, and tidy up
special codes
1e6dbcb3008f Support passing DEVELOPER_DIR to mig.py
Review-Url: https://codereview.chromium.org/2405563002
Cr-Original-Commit-Position: refs/heads/master@{#423958}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 869230baa78b8e945632559a51fcba020dc9a7f8
As part of making the Android Blimp APK compatible with the
//blimp/client/public APIs, this first CL moves the session code into
//blimp/client/app. This includes the GN-targets to ensure that they are
easily identifiable as belonging to the app directory.
This moves the APK-target itself, which means that the testing bots
needed to be updated with the new path to the target. In addition, the
lint suppressions needed to be updated with a new path.
The //blimp/client:blimp_unittests_java_deps (moved from //blimp), still
needs to be referred to directly by //blimp/BUILD.gn, because adding it
as a deps to //blimp/client:unit_tests on the Android platform does not
make the Java classes end up in the unit test APK. Other than this, the
rest of the targets have now been moved to //blimp/client and
//blimp/client/app.
Some targets have been renamed since they now reside in the app
directory.
Lastly, since the visibility parts of //blimp/client/core is cleaned up,
a bug was also filed for removing the visibility for internal core
targets for the engine browser tests.
BUG=651964, 653789
Review-Url: https://codereview.chromium.org/2387813002
Cr-Original-Commit-Position: refs/heads/master@{#423825}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ce09cbb95446995ca12230ccf86b3467d0259f1
Add a ignore_elf32_limitations flag in
build/config/compiler/compiler.gni to turn off
assertion for Cronet builds.
This CL additionally adds is_clang to the
assertion per comment in 648948.
BUG=651887,648948
Review-Url: https://codereview.chromium.org/2395603003
Cr-Original-Commit-Position: refs/heads/master@{#423564}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6d32a26068321e5976494501c51a33636a42c13f
There is only 1 instance in which the bootclasspath variable is
currently used. In this case, adding bootclasspath as an input
sometimes causes an error where GN complains that there is no
path (via public_deps) to the target that generates the input file.
Since public_deps is not supported for java_prebuilt targets, I
think the simplest thing to do is just remove this file from
list of inputs.
BUG=635913
Review-Url: https://codereview.chromium.org/2388153006
Cr-Original-Commit-Position: refs/heads/master@{#423289}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff
This is better for coverage guided fuzzing builds as less optimization
means more branches in the generated code.
BUG=643249
Review-Url: https://codereview.chromium.org/2389923003
Cr-Original-Commit-Position: refs/heads/master@{#423217}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aaa26c162de624ebcf7a120e85fef3e19ec02151
When code signing is disabled, the embedded.mobileprovision file
should not be copied into the generated bundle, so move the copy
after the check of --disable-code-signature.
Remove the embedded.mobileprovision from the bundle if it exists
so that switching ios_enable_code_signing from true to false works.
BUG=None
Review-Url: https://codereview.chromium.org/2397433002
Cr-Original-Commit-Position: refs/heads/master@{#423111}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 98ca7be1e2734af19697a244879bac6a059db148
The original CL is here: https://codereview.chromium.org/2367673002/
It was reverted because of compile failure with gn flags:
is_debug=false
is_component_build=true
target_os="android"
The reason is gvr uses API that only available in Android N SDK. For
release build, proguard detected the dependancy and results a compile
error. N SDK is in the process of rolling to chromium
https://codereview.chromium.org/2350013004/
In this CL, I restricted WebVr to debug build only. This could unblock
us. And I will remove the is_debug restriction once N is in Chromium
BUG=389343
TBR=dtrainor@
Review-Url: https://codereview.chromium.org/2396663002
Cr-Original-Commit-Position: refs/heads/master@{#423005}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 511e7f727be80e20d41fc5fd07cf8b5244cafbf0
clang-format wraps long lines, so java_cpp_enum.py should also
handle multi-line enum entries.
Also changed the HeaderParser to ignore empty comments.
BUG=652018
Review-Url: https://codereview.chromium.org/2396533002
Cr-Original-Commit-Position: refs/heads/master@{#422863}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9066edf6a2199aa3390cc55e89a93f858b50761b
Reverted by:
https://codereview.chromium.org/2369683002/
Reason for reland:
I've reworked it so that:
1. The list of pak files to extract are not set on start-up, but rather lazy initialized
2. This is done by putting the list of locale assets right in base's BuildConfig.java
3. Downstream parts have been upstreams so that this won't require a 2-sided patch
Language pak files were moved to res/raw when split apks was being implemented.
Moving them to assets with a java constant keeping track of pak file locations
will improve lookup time and save some space (no more xml files and
resources.arsc).
Other notables:
- .pak filenames no longer mangled. No more .lpak. no more hyphens to _s
- Ensures that monochrome doesn't extract files by extracting only when
files are compressed.
BUG=529604
Review-Url: https://codereview.chromium.org/2371843002
Cr-Original-Commit-Position: refs/heads/master@{#422836}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67101cd0338a409d80689b9c9c875c95ccde7957
Reason for revert:
Break gclient for the open contributors.
Original issue's description:
> Automatically copy the DIA DLL in the Syzygy binaries directory.
>
> Committed: https://crrev.com/f34c072397b99c313e79cd10a77f5ca397154399
> Cr-Commit-Position: refs/heads/master@{#422655}
TBR=chrisha@chromium.org,siggi@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2390993002
Cr-Original-Commit-Position: refs/heads/master@{#422767}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bcc865c6e04ee070d0745c645c5bcc0d1cb890bc
This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.
BUG=623989
Review-Url: https://codereview.chromium.org/2364233003
Cr-Original-Commit-Position: refs/heads/master@{#422649}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8d53345794d41eb28671c65157fa3c0df093ba99
No more --gc-sections in debug mode for test targets either.
Re-enable instrumentation of globals in ASAN builds.
This is effectively a reland of r387491.
BUG=159801, 159847
Review-Url: https://codereview.chromium.org/2384953003
Cr-Original-Commit-Position: refs/heads/master@{#422638}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 404b02529e8f0139fa719f34ffa326014096a7c7
agrieve
brettw
thomasanderson
mikecase
thakis
alph
pwnall
lukasza
sgurun
erikchen
mmoroz
thestig
mark
nyquist
yyanagisawa
xunjieli
ochang
jbudorick
sdefresne
bshe
estevenson
sebmarchand
stip
dpranke