This has been on everywhere for m39 and m40. People should not be
turning it off by this point, it will start to break soon.
BUG=169282
Review URL: https://codereview.chromium.org/830273003
Cr-Original-Commit-Position: refs/heads/master@{#312877}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 27f39f26c1636f9f09c79ab44f86e91b114b9a61
The command passed as a parameter to some implementations of "su" must
be enclosed in quotation marks. Otherwise, the command contains spaces,
can be splited into several commands. For example 'su -c echo foo' can
be executed by "su" as two commands: "echo" and "foo". The right way to
run this is 'su -c "echo foo"'. This patch fixes "su" behaviour and
still works fine without --su-prefix flag
Added quotes around adb shell command
R=jbudorick@chromium.org, klundberg@chromium.org
TEST=Run build/android/adb_gdb with parameter --su-prefix="su -c", on device which is rooted with "SuperSU v1.99 - Copyright (C) 2012-2014 - Chainfire"
Review URL: https://codereview.chromium.org/855943002
Cr-Original-Commit-Position: refs/heads/master@{#312845}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8fe7481f6b9d9c4012390b959fc7a305111a5a23
provision_devices.py currently relies on the builder name to determine
the desired device configuration for perf bots. To safely phase this out
this CL:
- exposes these configuration settings as command line options
- sets default values for these options based on the builder name, thus
matching the previous behaviour of the script on all bots.
- explicitly adding these options on the perf bots will also maintain the
same script behaviour, namely:
--wait-for-battery --disable-network --disable-java-debug
- after all perf-bot recipes are updated, we can remove the
builder-name-sniffing code.
In the process we also upgrade from optparse to argparse for handling
command line options.
BUG=450984
Review URL: https://codereview.chromium.org/869563002
Cr-Original-Commit-Position: refs/heads/master@{#312818}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b205693d72e37d173f7dabcefe6c02f115509f27
The raw output from a /analyze build is large -- about 370 MB. This is
unwieldy. It turns out that ~96% of the raw warning count is from two
warning types, and neither warning type is particularly valuable. So,
I'm suppressing them. This brings the warning output down to
~8 MB which is far more manageable, making it easier to look at in
buildbot output, faster to parse, faster to download, etc. And, the
two suppressed warnings have not been valuable so losing them is
not a problem.
BUG=427616
Review URL: https://codereview.chromium.org/862083003
Cr-Original-Commit-Position: refs/heads/master@{#312678}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a2e871611f1b74569c98ac2265a7f31d41568725
We would like to use app_shell as the basis for all
content-browser integration tests within the
extensions layer.
This simply moves the test target up to the parent
//extensions path and renames it to
extensions_browsertests
BUG=388893
R=yoz@chromium.org
Review URL: https://codereview.chromium.org/797023006
Cr-Original-Commit-Position: refs/heads/master@{#312669}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ea9df2af195b5b08909dc30e05bab95f6cfcd66f
This picks up:
-Fix Android ARM Neon build.
-Fix Android GN build.
This also fixes an issue with the GN ARM NEON build.
BUG=451035
Review URL: https://codereview.chromium.org/871433002
Cr-Original-Commit-Position: refs/heads/master@{#312629}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d2a76a150091e5c5f1d9e4a42a27d6f1f7538137
The ffmpeg build on mips is broken which manifests in build errors when
z,defs is specified. The owners of this build would like the compile
time error to be suppressed for now while they work on a proper fix.
BUG=450771,371125
Review URL: https://codereview.chromium.org/864193002
Cr-Original-Commit-Position: refs/heads/master@{#312557}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9267528ad62c796f30c9f51f398fbfa29f0232a1
Compiling with -Wl,-z,defs and asan requires declaring a dependency on
//build/config/sanitizers:deps in every shared_library and executable,
however piles and piles of targets do not do this yet so this flag busts
the asan/etc builds in GN. Disable for now so we can add the
dependencies bit by bit.
R=thakis@chromium.org
BUG=371125
Review URL: https://codereview.chromium.org/810563008
Cr-Original-Commit-Position: refs/heads/master@{#312543}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2eff74b542c9dceb330967c7fa06274a4addf443
This is the minimum to trigger/collect instrumentation tests.
There is still more to be done before this is working 100%.
BUG=448627
Review URL: https://codereview.chromium.org/832493005
Cr-Original-Commit-Position: refs/heads/master@{#312457}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e416dff2dcefa69fc5c2d5ae928376364e4926f3
Since the BoringSSL switch, this cannot possibly work. (There isn't an
openssl.gyp to swap out anyway.)
BUG=none
Review URL: https://codereview.chromium.org/859073002
Cr-Original-Commit-Position: refs/heads/master@{#312452}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b60792760a1291c50594f213a0bc5e71d020e4d
Jinja2 defaults to utf-8 for templates... unless the template is loaded
using env.from_string. Since we process manifest xml files which are
declared utf-8, the wrapper should treat them as utf-8 properly.
BUG=
Review URL: https://codereview.chromium.org/816813003
Cr-Original-Commit-Position: refs/heads/master@{#312352}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dad6da460d13947b90750195bc4957349e670e61
This tells the linker to resolve symbols for shared libraries at build
time, not run time. This alerts developers much earlier that their
dependencies are underspecified.
BUG=371125
Review URL: https://codereview.chromium.org/843583006
Cr-Original-Commit-Position: refs/heads/master@{#312317}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4359db72cde4fe4eeb4125d9a88af765fcdf39f1
This CL move //mojo/public and //mojo/edk to live in the following locations:
- //third_party/mojo/src/mojo/public
- //third_party/mojo/src/mojo/edk
It moves the related gypfiles from //mojo to //third_party/mojo and updates
them as necessary to account for the file moves. It also updates clients of the
mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK
and EDK build systems are maintained in the Mojo repo and designed to be
flexible wrt the location of the SDK/EDK in a client repo, so no changes are
needed.
This CL does not update include paths to the code being moved to limit the
number of moving parts, instead relying on the include_dirs that the SDK and
EDK targets supply to their direct dependents to ensure that include paths
continue to resolve correctly.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/814543006
Cr-Original-Commit-Position: refs/heads/master@{#312129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 70fb54767b472a5edfb859e489beeeec7abdb0e4
Limited to very few cases for now (non-chromeos, non-android,
non-official, component builds only).
BUG=371125
TBR=piman,dalecurtis
Review URL: https://codereview.chromium.org/854753002
Cr-Original-Commit-Position: refs/heads/master@{#312020}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: faffc1a04d17dd977ff9eb335c0c67b3b86dad5e
The UIAutomator test cases determine the Chrome package
being tested based on a UIAutomator command argument. This
argument is currently not being added to the command being
run. This CL adds the "test_package" argument.
BUG=
Review URL: https://codereview.chromium.org/855753002
Cr-Original-Commit-Position: refs/heads/master@{#311997}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0db7bc37e20bfe3696f065dc78848204fbc9c388
cjhopman
tbarzic
danakj
rnephew
ripp
perezju
vchigrin
eugenis
brucedawson
kerz
rockot
erikwright
inferno
fdegans
jamesr
jaekyun
cpu
thakis
wtc
davidben
hush
eugenebut
qsr
tsniatowski
william.xie
navabi
pkotwicz
droger
erg
jochen
noyau
blundell
timloh
thestig
jayker
timurrrr