The moves NetError.java (generated from NetError.template) from
out/Debug/gen/templates/org.chromium.net/NetError.java
to
out/Debug/gen/templates/org/chromium/net/NetError.java
This is intended to help IDEs find the generated files.
Review URL: https://chromiumcodereview.appspot.com/12374036
git-svn-id: http://src.chromium.org/svn/trunk/src/build@185702 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It builds and runs, but not a whole lot else. This change includes:
* ChromeFrameAutomationProvider is now OS_WIN only. In practice, this
has been the case for some time. Now it's formalized by giving the
implementation files the _win suffix.
* Automation messages and datatypes used exclusively by Chrome Frame now
use HWND directly rather than a toolkit-specific gfx typedef of one
since the requirement is that an actual HWND be sent over the
channel. A change in toolkit (e.g., switching to Aura) must not change
this. As a consequence of this change, some automation types and
messages are now only defined for OS_WIN builds.
* ExternalTabContainerWin is no longer derived from a NativeWidget type
(this was previously the case so that the ETCW could be notified of NW
lifecycle events). Now, in contrast, ETCW registers itself as an
observer of its Widget. Two additional lifecycle methods have been
added to WidgetObserver: OnWidgetCreated and OnWidgetDestroyed.
* ExternalTabContianerWin initializes its Widget with an instance of
DesktopNativeWidgetAura when use_aura.
* A special note about HWND IPC marshaling: this change adds a type
mapping from HWND to a generic HANDLE in ipc_message_utils.h, which
allows for the removal of a hack in content_message_generator.h to
marshal HWNDs.
This change reverts all of:
* r178752 -- Remove CF from all.gyp targets if use_aura is defined.
* r164590 -- Remove setup -> Chrome Frame dependency. Make it possible
to build an installer for Aura.
and portions of:
* r99993 -- Get chrome to link with USE_AURA
* r99787 -- Preliminary work to allow Chrome to build with USE_AURA.
BUG=171018
TEST=chrome_frame_tests provides good coverage in non-Aura builds.
Review URL: https://chromiumcodereview.appspot.com/12220101
git-svn-id: http://src.chromium.org/svn/trunk/src/build@185328 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
For the WebView build we need to support building on Mac, after
generating the makefiles on Linux. Add an option to envsetup.sh to
override the detected host OS.
The Android build system handles the actual logic of knowing how to
build host binaries on mac, so this is the only change that's needed (to
get V8 to use the right value of host_os in gyp).
BUG=
Review URL: https://chromiumcodereview.appspot.com/12317098
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184449 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Files.app's ui used to be unresponsive, when displaying large images. This was caused because of contex.drawImage() synchronous
call on the UI thread, which takes sometimes even 300 ms per one picture. In case of loading more images it causes ui freezes.
This patch solves this issue by introducing an image loader extension, which loads and resizes images asynchronously.
With this fix, we will be able to enable mosaic view on each volume, not only on Drive.
TEST=Check thumbnails in Files.app, including photo importer and gallery.
BUG=175697, 176237, 168035
Review URL: https://chromiumcodereview.appspot.com/12304013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184088 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Added call to a new script in:
build/install-build-deps.sh
to download and install the ChromeOS default font
(Noto Sans UI). The installation is in:
/usr/local/share/fonts.
ChromeOS on Linux will use the font if present.
The installation creates (or recreates) a subdir:
"chromeos". In it it creates a .stamp file which is used
to avoid re-installation if it is already up to date.
It also creates a README file.
BUG=148945
TEST=manual;
One way to test is to instrument the file:
src/ui/gfx/platform_font_pango.cc
to log default_font_->GetFontName(); in ctor
PlatformFontPango::PlatformFontPango()
Expect:
W/out font installation: DejaVu Sans
With font installation: Noto Sans UI
Review URL: https://chromiumcodereview.appspot.com/12313039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184006 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Summary of try run with flag enabled as warning:
On linux_clang, there's false positives from a bunch of assert usage that does !"string" or "string" for a true or false value. It's only in third_party (Mesa, skia, libjingle, etc.) so it probably wouldn't be too hard to disable the warnings in those subtrees.
It diagnoses 4 useful locations:
1.
../../base/debug/trace_event_unittest.cc:70:41: warning: implicit conversion turns string literal into bool: 'const char [2]' to 'bool' [-Wstring-conversion]
TraceLog::GetInstance()->SetEnabled("*");
~~~~~~~~ ^~~
2.
../../sync/syncable/entry_kernel.cc:77:38: warning: implicit conversion turns string literal into bool: 'const char [5]' to 'bool' [-Wstring-conversion]
value->SetBoolean("encrypted", "true");
~~~~~ ^~~~~~
3.
../../chrome/browser/webdata/web_data_service.cc:334:17: warning: implicit conversion turns string literal into bool: 'const char [44]' to 'bool' [-Wstring-conversion]
DLOG_ASSERT("WebDataService dtor called without Shutdown");
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:595:43: note: expanded from macro 'DLOG_ASSERT'
4.
../../chrome/browser/renderer_host/web_cache_manager_unittest.cc:259:20: warning: implicit conversion turns string literal into bool: 'const char [29]' to 'bool' [-Wstring-conversion]
EXPECT_FALSE("Unexpected entry in strategy");
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Finding #1 is what made me look into this, #3 and #4 are not doing what they're supposed to, and #2 is kind of funny so not all is lost.
So, 3 bugs and 1 very-close-to-a-bug: seems worth enabling.
R=thakis@chromium.orgTBR=darin@chromium.org, dhollowa@chromium.org, brettw@chromium.org, zea@chromium.org
BUG=177306
Review URL: https://chromiumcodereview.appspot.com/12258039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183998 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We want to run only one testcase each time the test activity is invoked.
Next:
Currently the APK is reinstalled before runnning each test case, avoiding that (and other test data setup) will speed up tests a lot.
build/android/run_browser_tests.py -vvv -f SessionHistoryTest.BasicBackForward:SessionHistoryTest.FrameBackForward
BUG=138275
Review URL: https://chromiumcodereview.appspot.com/12263024
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183982 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
leozwang@chromium.org
mostynb@opera.com
bartfab@chromium.org
csharp@chromium.org
teravest@chromium.org
thestig@chromium.org
nileshagrawal@chromium.org
bevc@chromium.org
ilevy@chromium.org
frankf@chromium.org
scottmg@chromium.org
iannucci@chromium.org
newt@chromium.org
kristianm@chromium.org
grt@chromium.org
msw@chromium.org
craigdh@chromium.org
sschmitz@chromium.org
thakis@chromium.org
eugenis@chromium.org
bulach@chromium.org
yfriedman@chromium.org
siggi@chromium.org
torne@chromium.org
jschuh@chromium.org
maruel@chromium.org
wfh@chromium.org
mtomasz@chromium.org
calvinlo@chromium.org
aruslan@chromium.org