build/android/screenshot.py was creating a DeviceUtils. Then grabbing
it's old_interface (i.e. an AndroidCommands) and calling screenshot on
that. That then called TakeScreenshot from
build/android/pylib/screenshot.py passing itself. But
build/android/pylib/screenshot.py expects a DeviceUtils, not an
AndroidCommands. So wrap the AndroidCommands back into a DeviceUtils
first.
build/android/screenshot.py could probably just call into
build/android/pylib/screenshot.py directly.
TBR=jbudorick
NOTRY=true
Review URL: https://codereview.chromium.org/234533003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263157 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
r262292 accidentally broke android_gyp. Unbreak it for a while, by using
an env var with a long name that hopefully nobody will refer to from anywhere
in the 3-4 weeks it's going to be in the tree.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/234223002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263143 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
As third_party/binutils is 2.24, this also satisfies the binutils version requirements for Debug Fission. Thus, when building with clang on Ubuntu Precise it should now be enabled. This should cause a significant speedup in linking for most chrome developers on Linux.
Requires;
* https://codereview.chromium.org/209853003/ - Adding binutils as a DEPS to allow DebugFission on Ubuntu Precise when compiling with clang.
BUG=352046
Review URL: https://codereview.chromium.org/196573022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262794 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes the GN build of Skia compile and adds it to the GN build.
Previously, the configuration of the GN Skia tried to match the confusing array
of skia targets. This new version dispenses with that and just adds all files
(except SSE ones) to one target. I'm not even sure if it's necessary to split
out the SSE ones, but it seems nice since that target will get more complicated
when we add Arm and MIPS support.
I audited the defines again and added some to the main build config that had
been added to the GYP build recently.
This improves some operator error messages that I found confusing when I had errors in my file.
BUG=
R=djsollen@google.com, scottmg@chromium.org
Review URL: https://codereview.chromium.org/214883005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262779 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds an error check when invoking templates which caused really confusing messages if the template invocation encountered an error (because we'd continue running).
Hooks up the provider for programatically defined variables in template invocations so those can be used.
Sets the current directory in a template invocation to be that of the invoking file.
No longer define the target-related programatic variables in an import. Using these in an import will give the directory relative to the import, which is probabyl not what you want.
Fix the Windows build by adding a missing library. Add a warning not to add more to the main list (this added .lib is pretty obscure).
BUG=
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/226223006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262524 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds support for a new value type, a dictionary. To script it looks the same as a scope, but the existing scope didn't have the right memory management semantics for this.
Adds a new input conversion mode to interpret the result of a script as a GN block (basically an eval) and get the result in a dictionary. This allows returning named sets of things from a script. Updates the accessor and defined stuff to work with this new type.
Adds some features to the input file manager so that when we do dynamic reading from a script we keep the text of the read around which means we can give proper errors that refer to the script output, and don't have to do the weird recursive set origin thing to clear out the pointers that became invalid when the InputFile went out of scope.
This allows us to give better error messages when parsing input. The error handling in the input conversion code is changed accordingly.
Checks for unused variables both in code that instantiates a template, and in the template code itself.
Adds a shared python script for outputting values from Python to GN.
Adds a python script to read .gypi files and return the value as a GN scope.
BUG=
R=dpranke@chromium.org, scottmg@chromium.org
Review URL: https://codereview.chromium.org/223783005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262045 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Suspected of causing:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20(dbg)/builds/71338/steps/compile/logs/stdio
[13474/21627] CXX obj/cc/animation/cc_unittests.scrollbar_animation_controller_linear_fade_unittest.o
FAILED: cd ../../remoting; python ../tools/gypv8sh.py ../out/Debug/d8 ../chrome/third_party/mock4js/mock4js.js ../third_party/accessibility-audit/axs_testing.js ../chrome/test/data/webui/test_api.js ../chrome/test/base/js2gtest.js unit "webapp/all_js_load.gtestjs" "chrome/webapp/all_js_load.gtestjs" "../out/Debug/obj/remoting/remoting_unittests.gen/chrome/webapp/all_js_load-gen.cc" "../out/Debug/test_data/chrome/webapp/all_js_load.gtestjs"
../out/Debug/d8: error while loading shared libraries: libicui18n.so: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "../tools/gypv8sh.py", line 55, in <module>
sys.exit(main())
File "../tools/gypv8sh.py", line 44, in main
subprocess.check_call(cmd, stdin=subprocess.PIPE, stdout=f)
File "/usr/lib/python2.7/subprocess.py", line 511, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../out/Debug/d8', '-e', 'arguments=["../chrome/test/base/js2gtest.js", "webapp/all_js_load.gtestjs", "chrome/webapp/all_js_load.gtestjs", "../out/Debug/obj/remoting/remoting_unittests.gen/chrome/webapp/all_js_load-gen.cc", "unit"]', '../chrome/third_party/mock4js/mock4js.js', '../third_party/accessibility-audit/axs_testing.js', '../chrome/test/data/webui/test_api.js', '../chrome/test/base/js2gtest.js']' returned non-zero exit status 127
FAILED: cd ../../remoting; python ../tools/gypv8sh.py ../out/Debug/d8 ../chrome/third_party/mock4js/mock4js.js ../third_party/accessibility-audit/axs_testing.js ../chrome/test/data/webui/test_api.js ../chrome/test/base/js2gtest.js unit "webapp/browser_globals.gtestjs" "chrome/webapp/browser_globals.gtestjs" "../out/Debug/obj/remoting/remoting_unittests.gen/chrome/webapp/browser_globals-gen.cc" "../out/Debug/test_data/chrome/webapp/browser_globals.gtestjs"
../out/Debug/d8: error while loading shared libraries: libicui18n.so: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "../tools/gypv8sh.py", line 55, in <module>
sys.exit(main())
File "../tools/gypv8sh.py", line 44, in main
subprocess.check_call(cmd, stdin=subprocess.PIPE, stdout=f)
File "/usr/lib/python2.7/subprocess.py", line 511, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../out/Debug/d8', '-e', 'arguments=["../chrome/test/base/js2gtest.js", "webapp/browser_globals.gtestjs", "chrome/webapp/browser_globals.gtestjs", "../out/Debug/obj/remoting/remoting_unittests.gen/chrome/webapp/browser_globals-gen.cc", "unit"]', '../chrome/third_party/mock4js/mock4js.js', '../third_party/accessibility-audit/axs_testing.js', '../chrome/test/data/webui/test_api.js', '../chrome/test/base/js2gtest.js']' returned non-zero exit status 127
FAILED: cd ../../remoting; python ../tools/gypv8sh.py ../out/Debug/d8 ../chrome/third_party/mock4js/mock4js.js ../third_party/accessibility-audit/axs_testing.js ../chrome/test/data/webui/test_api.js ../chrome/test/base/js2gtest.js unit "webapp/format_iq.gtestjs" "chrome/webapp/format_iq.gtestjs" "../out/Debug/obj/remoting/remoting_unittests.gen/chrome/webapp/format_iq-gen.cc" "../out/Debug/test_data/chrome/webapp/format_iq.gtestjs"
../out/Debug/d8: error while loading shared libraries: libicui18n.so: cannot open shared object file: No such file or directory
Traceback (most recent call last):
File "../tools/gypv8sh.py", line 55, in <module>
sys.exit(main())
File "../tools/gypv8sh.py", line 44, in main
subprocess.check_call(cmd, stdin=subprocess.PIPE, stdout=f)
File "/usr/lib/python2.7/subprocess.py", line 511, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../out/Debug/d8', '-e', 'arguments=["../chrome/test/base/js2gtest.js", "webapp/format_iq.gtestjs", "chrome/webapp/format_iq.gtestjs", "../out/Debug/obj/remoting/remoting_unittests.gen/chrome/webapp/format_iq-gen.cc", "unit"]', '../chrome/third_party/mock4js/mock4js.js', '../third_party/accessibility-audit/axs_testing.js', '../chrome/test/data/webui/test_api.js', '../chrome/test/base/js2gtest.js']' returned non-zero exit status 127
ninja: build stopped: subcommand failed.
> When "linux_use_gold_binary" is set, we now use gold from third_party/binutils rather than third_party/gold (allowing us to remove third_party/gold dependency).
>
> As third_party/binutils is 2.24, this also satisfies the binutils version requirements for Debug Fission. Thus, when building with clang on Ubuntu Precise it should now be enabled. This should cause a significant speedup in linking for most chrome developers on Linux.
>
> Requires;
> * https://codereview.chromium.org/209853003/ - Adding binutils as a DEPS to allow DebugFission on Ubuntu Precise when compiling with clang.
>
> BUG=352046
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261778
>
> Review URL: https://codereview.chromium.org/196573022TBR=mithro@mithis.com
Review URL: https://codereview.chromium.org/225093013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262036 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We don't have 32bit clang binaries, but several 32bit builders.
(And since clang now needs a c++11 compiler newer than gcc4.6 to
compile, we can't tell these bots to just build clang themselves
either.)
BUG=360311
Review URL: https://codereview.chromium.org/227133002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262030 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Other projects use depot_tools (which pulls in this hook) and chromium's build/
(where the hook lives) but don't use git modules (e.g. webrtc).
This first landed as r257470 but was accidentally undone by r259711.
Review URL: https://codereview.chromium.org/225583008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261931 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The status quo was unmaintainable. These 'component build specific .isolate
files' are superseeded by tools/isolate_driver.py which packages dynamic
libraries automatically.
The new way is much more sane and dynamic, isolate_driver.py is currently very
crude but 'does the job', the expected way to make it work is to read the .ninja
files to extract all the dynamic libraries marked as a dependency to the main
target being executed.
TBR=csharp@chromium.org
BUG=333473
Review URL: https://codereview.chromium.org/226123004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261871 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This moves app_shell GYP entries from a chrome.gyp include into
a new apps/shell/app_shell.gyp.
It also breaks down dependencies with more granularity and separates
temporary undesirable app_shell_lib dependencies from acceptable ones.
This was reverted due to a bug in the gyp file breaking a builder.
app_shell_temporary_deps should not have been a static_library target.
BUG=359678
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/225023002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261800 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Broke ASAN builders: e.g. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Builder/builds/2502/steps/runhooks/logs/stdio
________ running '/usr/bin/python src/build/gyp_chromium' in '/b/build/slave/Linux_ASan_LSan_Builder/build'
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /b/build/slave/Linux_ASan_LSan_Builder/build
Updating projects from gyp files...
/bin/sh: 1: clang++: not found
compiler_version.py failed to execute: clang++ -Xassembler --version -x assembler -c /dev/null
Command 'clang++ -Xassembler --version -x assembler -c /dev/null' returned non-zero exit status 127
gyp: Call to 'python ../build/compiler_version.py assembler' returned exit status 1.
program finished with exit code 2
elapsedTime=6.794917
> When "linux_use_gold_binary" is set, we now use gold from third_party/binutils rather than third_party/gold (allowing us to remove third_party/gold dependency).
>
> As third_party/binutils is 2.24, this also satisfies the binutils version requirements for Debug Fission. Thus, when building with clang on Ubuntu Precise it should now be enabled. This should cause a significant speedup in linking for most chrome developers on Linux.
>
> Requires;
> * https://codereview.chromium.org/209853003/ - Adding binutils as a DEPS to allow DebugFission on Ubuntu Precise when compiling with clang.
>
> BUG=352046
>
> Review URL: https://codereview.chromium.org/196573022TBR=mithro@mithis.com
Review URL: https://codereview.chromium.org/224933007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261782 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
mithro@mithis.com
cjhopman@chromium.org
sievers@google.com
thakis@chromium.org
brettw@chromium.org
oshima@chromium.org
jbudorick@chromium.org
zhaoqin@google.com
glider@chromium.org
rmcilroy@chromium.org
sdefresne@chromium.org
erikchen@chromium.org
scottmg@chromium.org
qsr@chromium.org
gunsch@chromium.org
jschuh@chromium.org
mostynb@opera.com
wibling@chromium.org
phajdan.jr@chromium.org
sky@chromium.org
tfarina@chromium.org
thestig@chromium.org
fischman@chromium.org
tommycli@chromium.org
jochen@chromium.org
maruel@chromium.org
jam@chromium.org
rockot@google.com
hinoka@google.com