This fixes a lot of minor mistakes (mostly missing/extra files and flags) for the Mac GN build.
I separated out some clang flags into a config for extra clang warnings. Several of the third party libraries needed to remove this.
Removes the use_nss flag and uses !use_openssl. This is a result of discussion with rsleevi.
Removes extra duplicate net build file from secondary tree.
ui/gesture_events seems to be getting compiled in GN with more strict warnings than in GYP. Rather than fix this, I fixed the warning in the gesture recognizer unit test. It was returning a const copy (the const is pointless when you're copying).
This also removes a bunch of old GYP integration stuff that was left in the GN build.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/239543013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@264626 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
process_resources.py currently considers aapt to have failed if it
outputs anything to stderr. Change this to ignore lines printed to
stderr that contain "libpng warning", which is a known non-error
condition.
BUG=364355
Review URL: https://codereview.chromium.org/238043011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@264623 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Instead, apply them as direct_dependent_settings to dependents of the
instrumented_libraries target. This is functionally equivalent, but reduces code
duplication, improves locality and also allows us to disable the use of
instrumented libraries on a target-by-target basis.
BUG=313751
TBR=glider@chromium.org
TEST=MSan
NOTRY=true
Review URL: https://codereview.chromium.org/240413004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@264281 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
linux_use_bundled_binutils adds the binutils to cflags.
linux_use_bundled_gold adds it to the ldflags. The former
does not work when cross compiling to ARM as the other
binutils do not currently support ARM. This was causing the
ARM cross compile (for which we do want use the bundled
gold) to break.
I think the word "bundled" works better than "binary" since
it distinguishes from the system gold (which is also a binary).
BUG=363661
TEST=linux_arm_cross_compile trybot
Review URL: https://codereview.chromium.org/239163003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@264165 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This does the net target. I started doing some more that are commented out at the bottom, and there are a few more after that do do. The deps of these targets started to build up to an unreasonable level and this should be a good checkpoint.
Fix grit rule.
Fix SSL dependent configs
Add TLD cleanup
Add gconf and gio targets for Linux.
Add sources filtering for ChromeOS, .rc, and .mm files. Remove built-in code that removes .rc and .mm files (this wasn't quite complete so causes problems).
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/236713002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263967 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a copy of https://codereview.chromium.org/201153007 and https://codereview.chromium.org/213113002
updated to the current trunk with more descriptive comments in sanitizer_options.cc and the additional
legacy_pthread_cond=1 option for the Linux Official builds (legacy_pthread_cond is to be deprecated,
thus we don't enable it on the bots).
This CL introduces a module, base/debug/sanitizer_options.cc, which will override
the defaults for various dynamic tools (only ASan at this moment). For every executable
built with a dynamic tool this module will be linked into that executable, providing
weak functions to be called by the tool.
The existing declaration of __asan_default_options() in chrome/app/chrome_exe_main_gtk.cc
has been moved into sanitizer_options.cc (now every binary built with GOOGLE_CHROME_BUILD=1
will have the same options as google-chrome-asan.
The existing declaration of __asan_default_options() in chrome/nacl/nacl_helper_linux.cc
has been kept as is, but we had to remove -Wl,-u_sanitizer_options_link_helper to avoid picking sanitizer_options.cc.
The default options target is deliberately disabled on 32-bit Chromium OS builds,
where one of the host binaries (mksnapshot.ia32) is 32-bit despite host_arch==x86_64.
GYP changes for OSX and iOS will be committed separately.
TBR=thakis@chromium.org,mseaborn@chromium.org
BUG=302040
Review URL: https://codereview.chromium.org/238123003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263941 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a copy of https://codereview.chromium.org/201153007 and https://codereview.chromium.org/213113002
updated to the current trunk with more descriptive comments in sanitizer_options.cc and the additional
legacy_pthread_cond=1 option for the Linux builds.
This CL introduces a module, base/debug/sanitizer_options.cc, which will override
the defaults for various dynamic tools (only ASan at this moment). For every executable
built with a dynamic tool this module will be linked into that executable, providing
weak functions to be called by the tool.
The existing declaration of __asan_default_options() in chrome/app/chrome_exe_main_gtk.cc
has been moved into sanitizer_options.cc (now every binary built with GOOGLE_CHROME_BUILD=1
will have the same options as google-chrome-asan.
The existing declaration of __asan_default_options() in chrome/nacl/nacl_helper_linux.cc
has been kept as is, but we had to remove -Wl,-u_sanitizer_options_link_helper to avoid picking sanitizer_options.cc.
The default options target is deliberately disabled on 32-bit Chromium OS builds, where one of the host binaries (mksnapshot.ia32) is 32-bit despite host_arch==x86_64.
GYP changes for OSX and iOS will be committed separately.
BUG=302040,341805
TBR=thakis@chromium.org,mseaborn@chromium.org
Review URL: https://codereview.chromium.org/230263003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263625 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- on Windows: with Aura + removal of the accelerated surface support, the only
"transport"-type surfaces are TextureImageTransportSurfaces and
IOSurfaceImageTransportSurface. The GpuHostMsg_AcceleratedSurface* messages can
go directly to the UI thread without the need for filtering on the IO thread.
- on both Mac and Windows, we use the compositor thread always, so we don't need
the ViewMsg_SwapBuffers_ACK and associated logic any more.
BUG=None
Review URL: https://codereview.chromium.org/137663006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263475 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This fixes enough issues so that we can compile and link some libraries, but
it is not yet a working build.
Work remaining:
- base needs JNI support ('base_jni_headers', etc.)
- we need to figure out what should link and/or be APKs to run the tests
- we need to adjust GN to only build in the host config, not the target config.
R=brettw@chromium.org, cjhopman@chromium.org
TBR=jam
BUG=360936
Review URL: https://codereview.chromium.org/227673008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263440 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The eclipse gyp generator is used to generate eclipse project files, not
to actually build anything. Landmines should return early if the gyp
generator is eclipse rather than failing with the error "Unexpected
GYP_GENERATORS (eclipse)"
Review URL: https://codereview.chromium.org/236063002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263438 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This also removes some patterns from the sources assignment filter, and adds scary comments not to make it bigger. The GYP version of this is out of control so I want to set a clear policy of what is included and not.
I removed X-related stuff from the filter (there are only about 50 files around the tree) and added manual rules for the affected files.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/235983002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263394 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Fix get_device_configuration.py to use build_device.GetAttachedDevices
without the () as it is now a list not a method since () was added at
build_device.GetAttachedDevices
- Fix device_utils.py to check for unicode as well as str since the config
push_libraries was loading had unicode for the device id
NOTRY=true
BUG=267773
Review URL: https://codereview.chromium.org/233203003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263317 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds static initializers. See:
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/63585
# profile_avatar_icon_util.cc profiles::kNoHighResAvatar
# profile_avatar_icon_util.cc profiles::kDefaultAvatarIconResourceFileNames+0xd0
> Newly created profiles should have the grey silhouette as avatar.
> The name should still be automatically generated.
>
> Also, all the avatar icons are becoming squares (31x38 -> 38x38). New resources will be committed and necessary code changes have been made.
>
>
> BUG=337986
> TEST=When creating a new profile from anywhere except the settings. Also, verify avatar icons are still rendered correctly, whether GAIA, the placeholder or a cartoon icon.
> page, the automatically assigned avatar should the grey
> placeholder (silhouette).
>
> Review URL: https://codereview.chromium.org/212603011TBR=mlerman@chromium.org
Review URL: https://codereview.chromium.org/234583008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263284 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The name should still be automatically generated.
Also, all the avatar icons are becoming squares (31x38 -> 38x38). New resources will be committed and necessary code changes have been made.
BUG=337986
TEST=When creating a new profile from anywhere except the settings. Also, verify avatar icons are still rendered correctly, whether GAIA, the placeholder or a cartoon icon.
page, the automatically assigned avatar should the grey
placeholder (silhouette).
Review URL: https://codereview.chromium.org/212603011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263262 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
brettw@chromium.org
newt@chromium.org
erg@chromium.org
davemoore@chromium.org
jamescook@chromium.org
terry@google.com
thestig@chromium.org
bratell@opera.com
tnagel@chromium.org
thakis@chromium.org
earthdok@chromium.org
spang@chromium.org
sbc@chromium.org
jochen@chromium.org
bungeman@chromium.org
jbudorick@chromium.org
glider@chromium.org
scottmg@chromium.org
fischman@chromium.org
mithro@mithis.com
nyquist@chromium.org
tfarina@chromium.org
piman@chromium.org
dpranke@chromium.org
dtrainor@chromium.org
viettrungluu@chromium.org
mlerman@chromium.org