There is no way to see/list the categories present for recording the chrome traces (when running from adb_profile_chrome.py) unlike the UI. Adding the "list" command for --categories option, to keep the usage same as with systrace option.
Usage: build/android/adb_profile_chrome --categories list
BUG=366679
TESTS=To be added.
Review URL: https://codereview.chromium.org/257093004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268841 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Don't add -fuse-ld=gold to cflags, since gyp emits ninja files that
compile with -c, which means the linker is not used, making the flag
useless.
Removing ignored options makes the compiler commands (slightly)
easier to read, and can avoid some errors in mismatched icecc setups.
BUG=352046
Review URL: https://codereview.chromium.org/265263002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268377 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Instead of passing libc++.so and libc++abi.so on the command line to the linker,
we want to be able to simply pass -stdlib=libc++ to the clang driver and let it
make the decision about linking the DSOs. In this way we can avoid linking
libc++ into C executables.
To this effect we introduce a proxy target which adds -stdlib=libc++ to direct
dependents' flags but does not link the actual DSO. We also link libc++abi
statically into libc++. The latter change is necessary because clang's
-stdlib=libc++ mode is set up to use libsupc++ as the ABI implementation, and
will not automatically pick up libc++abi.so.
BUG=318770
R=glider@chromium.org, thakis@chromium.org
NOTRY=true
TEST=msan
Review URL: https://codereview.chromium.org/264613005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268169 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Previously "gn args" printed build arguments. That has now moved to "gn args <outdir> --list" along with a new --short mode that's a bit more convenient for some uses.
Now "gn args" runs your editor on the build arguments for the given output directory, and re-generates the build given those arguments. This is an easier way to manage changing build arguments for a build (previously you would have to re-type everything or edit build.ninja manually).
"gn gen" now always uses the existing arguments for the given output dir, unless "--args" is manually specified (giving the old behavior of just using those). This also allows a more convenient way for a user to recover from a borked build (sincetimes I ran into a state where something was missing that prevent ninja from even starting enough to rebuild the build).
I removed the "show" and "refresh" ninja phony rules since the new commands cover those cases.
This patch adds some additional tracing to build startup since I noticed it was missing when trying to figure out why the args command was so slow (I fixed the main reason, it was with new code I added).
Added proper escaping for printing string values and unit tests for these.
Two minor build file fixes.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/265693003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268042 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
To run the toolkit-views app launcher on Mac, it needs a new app list
service + supporting classes. It's going to look a lot like the Linux
one. This CL starts by sharing what can be shared between Windows and
Linux, in preparation for using it on Mac as well.
It does this principally by:
- Moving `app_list_shower` to `app_list_shower_views`, making it views-specific;
- Adding AppListServiceViews, which Win/Linux (and soon Mac) inherit from;
- Rearranging the delegation to eliminate some boilerplate.
Other changes:
- Removed AppList container abstract interface (now just access AppListView);
- Removed AppListFactory (now AppListShower::MakeViewForCurrentProfile());
- Moved AppListControllerDelegateLinux to AppListControllerDelegateViews;
- Most of AppListServiceLinux moves to AppListServiceViews;
- Added AppListShowerDelegate and AppListShower given virtual method
hooks to assist testability (previously AppListShower was given a NULL
service/delegate in tests);
- Positioning logic in AppListWin/AppListLinux made static/stateless;
- Removes the `on_should_dismiss_` closure (now just dismiss via the service;
- Big trim of AppListServiceWin and AppListServiceLinux - now these are
just platform-specific stuff.
BUG=365977
TEST=Just refactoring, nothing should change
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267184
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267354
Review URL: https://codereview.chromium.org/225053004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268035 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Broke windows compile:
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_wrapper.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj /Fdobj\net\hpack_fuzz_wrapper.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_wrapper.cc(38) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_example_generator.cc /Foobj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj /Fdobj\net\hpack_example_generator.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(51) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(52) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &'
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(68) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(69) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_mutator.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj /Fdobj\net\hpack_fuzz_mutator.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(53) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(56) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(57) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &'
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(72) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(73) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
> Add hpack_fuzz_wrapper to chromium_builder_asan.
>
> BUG=353237
>
> Review URL: https://codereview.chromium.org/266003005TBR=jgraettinger@chromium.org
Review URL: https://codereview.chromium.org/268863002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268024 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
gyp can cache and re-use the output of scripts that have the same
invocation, and all the test data copying uses "test/data". This is
a relative path, so it's not really the same command, causing flaky
compile failures.
This works around the bug by artificially introducing variation into
the invocation string.
NOTRY=true
BUG=369533
Review URL: https://codereview.chromium.org/265043003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@267919 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Because the content_browsertests tearDown logic is broken with respect
to threading on Android, we here work around the problem by sleeping in
the tearDown to give the IO thread time to finish its work. This will
lengthen the execution time of the tests but hopefully make the tests
stable enough to last us until the Clank team finds time to rewrite the
tearDown logic.
BUG=362852
Review URL: https://codereview.chromium.org/251323002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@267858 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Updates NaCl revision from 13106 -> 13115
This CL reverts revision 266284.
Now that we have split up the toolchain into multiple tars, we should
use the package versioning script to manage which tars to extract.
Unfortunately, currently the SDK uses different directory names compared
to what the NaCl toolchain directories normally use, so we also must map
and move the toolchain directories to the SDK ones.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3839
Review URL: https://codereview.chromium.org/261773002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@267711 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently when telemetry asks to read/write a protected file, it attempts doing
so with the 'su' command, but not all devices have the 'su' command installed.
In this case telemetry ignores all errors and continues silently.
This change:
1. chooses the best method to access protected files: 'adb root' or 'su'
2. caches the choice
3. throws warnings each time a protected file cannot be accessed
BUG=366640
Review URL: https://codereview.chromium.org/251743003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@267137 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
bengr@chromium.org
yfriedman@chromium.org
zhaoqin@google.com
dmikurube@chromium.org
r.kasibhatla@samsung.com
mmenke@chromium.org
timurrrr@chromium.org
hans@chromium.org
navabi@google.com
phoglund@chromium.org
ckocagil@chromium.org
mostynb@opera.com
loislo@chromium.org
jgraettinger@chromium.org
earthdok@chromium.org
phajdan.jr@chromium.org
brettw@chromium.org
tapted@chromium.org
dbeam@chromium.org
vandebo@chromium.org
ilevy@chromium.org
kerz@chromium.org
stuartmorgan@chromium.org
niklase@chromium.org
benm@chromium.org
dyen@chromium.org
spang@chromium.org
thestig@chromium.org
tommycli@chromium.org
thakis@chromium.org
davidben@chromium.org
rsesek@chromium.org
andrewhayden@chromium.org
qsr@chromium.org
tfarina@chromium.org
pasko@chromium.org