The viewed page can now be rendered all at once, or with a single page
update, followed by additional page content sent via HTML. While more
pages are loading, a progress indicator is present.
The title for a page was added to DistilledPageProto so its accessible
during partial distillation. This was already stored in
DistilledPageData so it's just moved.
BUG=319881
Review URL: https://codereview.chromium.org/260073009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270622 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Speculative revert: Compilation appears broken on http://chromegw.corp.google.com/i/chromium.linux/builders/Linux%20Builder%20%28dbg%29 after this CL, with libgfx-related errors:
FAILED: /b/build/goma/gomacc c++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -B/b/build/slave/Linux_Builder__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -L. -Wl,-uIsHeapProfilerRunning,-uProfilerStart -Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi -Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl -Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14UnIgnoreObjectEPKv -m64 -Wl,--icf=none -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o gfx_unittests -Wl,--start-group obj/ui/gfx/gfx_unittests.font_unittest.o obj/ui/gfx/image/gfx_unittests.image_family_unittest.o obj/ui/gfx/image/gfx_unittests.image_skia_unittest.o obj/ui/gfx/image/gfx_unittests.image_unittest.o obj/ui/gfx/image/gfx_unittests.image_unittest_util.o obj/ui/gfx/test/gfx_unittests.run_all_unittests.o obj/ui/gfx/gfx_unittests.text_elider_unittest.o obj/ui/gfx/gfx_unittests.text_utils_unittest.o obj/ui/gfx/animation/gfx_unittests.animation_container_unittest.o obj/ui/gfx/animation/gfx_unittests.animation_unittest.o obj/ui/gfx/animation/gfx_unittests.multi_animation_unittest.o obj/ui/gfx/animation/gfx_unittests.slide_animation_unittest.o obj/ui/gfx/animation/gfx_unittests.tween_unittest.o obj/ui/gfx/gfx_unittests.blit_unittest.o obj/ui/gfx/gfx_unittests.break_list_unittest.o obj/ui/gfx/codec/gfx_unittests.jpeg_codec_unittest.o obj/ui/gfx/codec/gfx_unittests.png_codec_unittest.o obj/ui/gfx/gfx_unittests.color_analysis_unittest.o obj/ui/gfx/gfx_unittests.color_utils_unittest.o obj/ui/gfx/gfx_unittests.display_unittest.o obj/ui/gfx/geometry/gfx_unittests.box_unittest.o obj/ui/gfx/geometry/gfx_unittests.cubic_bezier_unittest.o obj/ui/gfx/geometry/gfx_unittests.insets_unittest.o obj/ui/gfx/geometry/gfx_unittests.matrix3_unittest.o obj/ui/gfx/geometry/gfx_unittests.point_unittest.o obj/ui/gfx/geometry/gfx_unittests.point3_unittest.o obj/ui/gfx/geometry/gfx_unittests.quad_unittest.o obj/ui/gfx/geometry/gfx_unittests.r_tree_unittest.o obj/ui/gfx/geometry/gfx_unittests.rect_unittest.o obj/ui/gfx/geometry/gfx_unittests.safe_integer_conversions_unittest.o obj/ui/gfx/geometry/gfx_unittests.size_unittest.o obj/ui/gfx/geometry/gfx_unittests.vector2d_unittest.o obj/ui/gfx/geometry/gfx_unittests.vector3d_unittest.o obj/ui/gfx/image/gfx_unittests.image_util_unittest.o obj/ui/gfx/range/gfx_unittests.range_unittest.o obj/ui/gfx/gfx_unittests.sequential_id_generator_unittest.o obj/ui/gfx/gfx_unittests.shadow_value_unittest.o obj/ui/gfx/gfx_unittests.skbitmap_operations_unittest.o obj/ui/gfx/gfx_unittests.skrect_conversion_unittest.o obj/ui/gfx/gfx_unittests.transform_util_unittest.o obj/ui/gfx/gfx_unittests.utf16_indexing_unittest.o obj/ui/gfx/gfx_unittests.transform_unittest.o obj/ui/gfx/gfx_unittests.interpolated_transform_unittest.o obj/ui/gfx/gfx_unittests.platform_font_pango_unittest.o obj/base/libtest_support_base.a obj/testing/libgtest.a obj/third_party/libpng/libpng.a obj/ui/gfx/libgfx_test_support.a obj/base/allocator/liballocator.a obj/base/libbase_static.a obj/testing/libgmock.a obj/third_party/libxml/libxml2.a obj/third_party/zlib/libchrome_zlib.a obj/base/third_party/dynamic_annotations/libdynamic_annotations.a lib/libui_base.so lib/libgfx.so lib/libicuuc.so lib/libskia.so lib/libbase.so lib/libgfx_geometry.so lib/libbase_i18n.so -Wl,--end-group -lrt -ldl -lfontconfig -lpangocairo-1.0 -lcairo -lpangoft2-1.0 -lpango-1.0 -lfreetype -lgobject-2.0 -lglib-2.0
lib/libgfx.so:error: undefined reference to 'XCreateRegion'
lib/libgfx.so:error: undefined reference to 'XUnionRectWithRegion'
lib/libgfx.so:error: undefined reference to 'XPolygonRegion'
collect2: ld returned 1 exit status
Original issue's description:
> Move a good set of gfx unit tests into gfx_unittests target.
>
> This requires to major changes:
>
> 1- It requires the introduction of GfxTestSuite to allow us to
> initialize the ResourceBundle which is required for some of these tests
> to pass.
> 2- It requires to split gfx_unittests target out of gfx.gyp, into
> gfx_tests.gyp. This is necessary because otherwise a circular dependency
> between ui_base.gyp and gfx.gyp would arise.
>
> The circular dependency is the form of:
> gfx.gyp -> ui_base.gyp -> gfx.gyp
>
> And is created because gfx_unittests now requires ResourceBundle to link
> which is in ui_base target.
>
> BUG=331829
> TEST=ui_unittests,gfx_unittests
> R=danakj@chromium.org
> TBR=ben@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270586TBR=ben@chromium.org,danakj@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331829
Review URL: https://codereview.chromium.org/290453002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270600 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This requires to major changes:
1- It requires the introduction of GfxTestSuite to allow us to
initialize the ResourceBundle which is required for some of these tests
to pass.
2- It requires to split gfx_unittests target out of gfx.gyp, into
gfx_tests.gyp. This is necessary because otherwise a circular dependency
between ui_base.gyp and gfx.gyp would arise.
The circular dependency is the form of:
gfx.gyp -> ui_base.gyp -> gfx.gyp
And is created because gfx_unittests now requires ResourceBundle to link
which is in ui_base target.
BUG=331829
TEST=ui_unittests,gfx_unittests
R=danakj@chromium.orgTBR=ben@chromium.org
Review URL: https://codereview.chromium.org/280973003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270586 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The x86 device can not dump battery information with 'adb dumbsys battery'. This
is causing the x86 instrumentation bot to fail on device status check. This is a
temporary fix until we determine how to check battery info on x86 devices.
BUG=371719
Review URL: https://codereview.chromium.org/284953002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270516 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculative revert because we think this might have caused Mac Build bot
failure "gyp: Call to 'python ../../../build/mac/find_sdk.py 10.6' returned exit status -9."
> ozone: Add egltest platform
>
> This supports testing rendering using EGL. Creation of the
> EGLNativeWindowType is punted to a separate library, which has an
> interface defined in eglplatform_shim.h.
>
> TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist
> BUG=none
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/288603002TBR=spang@chromium.org
Review URL: https://codereview.chromium.org/288013002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270474 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This supports testing rendering using EGL. Creation of the
EGLNativeWindowType is punted to a separate library, which has an
interface defined in eglplatform_shim.h.
TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/288603002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270471 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Make Android tools build as position independent executable by
default, as it now required by Android.
- Introduce a wrapper for running PIE on Android ICS (its linker
doesn't support PIE).
- Add the plumbing for running the PIE wrapper in the test/telemetry
python scripts.
BUG=373219
NOTRY=true
Review URL: https://codereview.chromium.org/287513002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270406 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds a script for retrieving and installing Syzygy binaries. Currently binaries are checked in to an SVN repository and installed via a DEPS dependency. The Syzygy team is moving to git, and archiving their binaries on Google Common Data Storage. A later CL will move to using this script, installing the binaries via a DEPS hook.
BUG=
R=siggi@chromium.org
Review URL: https://codereview.chromium.org/288703002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270401 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Down to 3m22 (without the other optimizations..)
/proc/pid/smaps is kind of large.
It was only used by old style perf tests downstream, long gone
in favor of Telemetry.
Use "showmap %pid" directly, which crunches the data in the device.
Also, while at it, remove GetMemoryUsageForPackage: no longer used.
BUG=
Review URL: https://codereview.chromium.org/280703010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270395 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Some minor tweaks in STL usage in GN itself to enable it to compile using the Android version of the STL. Enable this in the build (not so much because we need a GN binary on Android, but for build verification purposes).
Moved the executable_ldconfig config from the linux file to the gcc one since its shared between the Linux and Android builds. Added "-Bdynamic" and "-Wl,-z,nocopyreloc" to this on Android.
Moved some sysroot path components from sysroot.gni to android/config.gni (which sysroot uses) so it can be shared with the toolchain definitions.
Added the android_full_debug build flag. Made the "optimize off" mode of the build match the GYP build's "light optimization" on Android contingent on this flag.
Pulls out the optimize and optimize_max shared flags into one list to avoid duplication.
Adds a bunch of linker optimization flags that should be passed on non-Mac Posix platforms, and turns on dead code stripping for Mac builds.
Adds functionality to the gcc toolchain template to be able to insert strings before and after the libs. Adds a wrapper template for android toolchains that sets these accordingly to get the gross Android crtbegin/end files inserted in the right place on the linker line.
Made the android_ndk_root variable relative to the source root rather than the system root. Uses of this now rebase according to their own needs which makes some of the arguments a lot easier to follow.
Build file updates for base and libevent for Android. Implement ashmem library.
The only change on desktop linux is the addition of -Wl,--fatal-warnings to the linker line.
R=ajwong@chromium.org, cjhopman@chromium.org, scottmg@chromium.org
Review URL: https://codereview.chromium.org/275703003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270138 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.
TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.
BUG=300084, 303862
R=sky@chromium.org
Review URL: https://codereview.chromium.org/25108005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269892 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Android uses gcc 4.8 for target on arm64, so -Wno-unused-local-typedefs
gets added to the gcc command line; unfortunately the host toolchain on
mac does not support this flag. We have no way to detect the host
toolchain version in the WebView build because we generate makefiles in
advance instead of on the build machine, so just hardcode an exception
until the instances of this warning can be fixed and this entire
conditional section removed.
BUG=321833
Review URL: https://codereview.chromium.org/277983002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269766 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This removes the use of a static initializer and makes it possible
for clients to pass a key without owning the memory where the
key is stored (as would be the case if passed to a static const char*).
BUG=371626, 371204
Review URL: https://codereview.chromium.org/279633003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269578 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When clang is turned on or off, or when clang is updated, all .o files and all
precompiled headers need to be rebuilt. This is currently done by having the
update script remove the out/ directory. This has issues:
* It fails to catch build directories with different names (e.g. out_android)
* It removes other build artifacts (like resources) that don't need rebuilding
* It doesn't happen when turning clang off (i.e. moving clang -> gcc).
Instead, let common.gypi add a define with the current clang revision to each
source file. This way, the clang revision is on each compile's command line
and the build system's commandline tracking can take care of the rebuilding.
BUG=nativeclient:3840
NOTRY=true
Review URL: https://codereview.chromium.org/268363020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269427 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We keep seeing the INSTALL_FAILED_INSUFFICIENT_STORAGE error on the devices. The
APK we install to check for this failure succeeds even when this error exists on
the device (presumably because the APK we install is too small). Thus, this CL
will always wipe the device. It removes the reboot, because that would make the
step take too long.
BUG=335549
TBR=yfriedman@chromium.org
Review URL: https://codereview.chromium.org/255783008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269408 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This removes all the code that we used for talking to the
peerconnection_server. I also cleaned up tons of dead code from the
test javascript (most of which was used in the old manual test page,
which is now completely self-contained and doesn't use this javascript
anymore).
In place of the peerconnection_server, we'll send signaling information
through the test using ExecuteJavascript calls from the browser test.
This was a bit tricky to design since the javascript can't talk back
to the browser test without the browser test initiating the talking.
The basic design became
1. Test asks tab 1 to get user media and create an offer with audio
and video. The offer is returned to the test as a JSON encoded
session description.
2. The test asks tab 2 to get user media and create a peer connection.
3. The test passes the offer to tab2 and asks it to create an answer,
and the answer is returned to the test like the offer in 1.
4. The test asks tab 1 to accept the answer.
5. Both tabs are now gathering ICE candidates.
6. The test asks tab 1 to return its ICE candidates (waiting for
gathering to complete if necessary). The candidates are then sent
to tab 2 which processes them. The ICE candidates are passed as
JSON encoded RTCIceCandidate instances.
7. 6) is repeated, but from tab 2 to tab 1.
8. We wait for video / audio to start playing.
In general this is a more synchronous design compared to the
peerconnection_server design as the test used to merely arbitrate
connections to the server and then let the javascript in the two tabs
talk to each other asynchronously as far as the test was concerned.
This seems to work though, and the test has full control over what
happens. Hopefully it makes the negotiation flow clearer rather than
having this magical out-of-band signaling channel that the server
enabled previously.
BUG=369469
Review URL: https://codereview.chromium.org/271653002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269311 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Causes a sizes regression, starting in http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64712
+# data_reduction_proxy_settings.cc data_reduction_proxy::DataReductionProxySettings::key_
+# data_reduction_proxy_settings.cc __cxa_atexit@plt [registers a dtor to run at exit]
+# data_reduction_proxy_settings.cc __init_array_end+0x3868
+# data_reduction_proxy_settings.cc __init_array_end+0x3b88
+# data_reduction_proxy_settings.cc __init_array_end+0x530
Original issue's description:
> Collect data reduction proxy UMA on all platforms
>
> UMA for the data reduction proxy was gated behind preprocessor
> directives that resticted the logic to Android and iOS. This
> change opens UMA calculations and collection up to all platforms.
>
> BUG=369619
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269026TBR=mef@chromium.org,marq@chromium.org,bengr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=369619
Review URL: https://codereview.chromium.org/274453011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269041 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
yfriedman@chromium.org
vabr@chromium.org
tfarina@chromium.org
derat@chromium.org
chrisha@chromium.org
navabi@google.com
vrk@chromium.org
spang@chromium.org
jiayl@chromium.org
dalecurtis@chromium.org
primiano@chromium.org
chrisha@google.com
bulach@chromium.org
jbudorick@chromium.org
thestig@chromium.org
piman@chromium.org
erg@chromium.org
brettw@chromium.org
cjhopman@chromium.org
dyen@chromium.org
rmcilroy@chromium.org
vandebo@chromium.org
scottmg@chromium.org
rkc@chromium.org
sadrul@chromium.org
mkosiba@chromium.org
torne@chromium.org
sungmann.cho@navercorp.com
iannucci@chromium.org
oshima@chromium.org
bengr@chromium.org
skyostil@chromium.org
ycheo@chromium.org
thakis@chromium.org
joone.hur@intel.com
phoglund@chromium.org
tapted@chromium.org