Adds a protobuf target and a template for defining protos. This handles doing host builds of protoc when cross-compiling.
The command buffer sevice wants more optimization on Android, so this patch generalizes the solution. Normally Android, like Windows, optimizes for size. This now adds support on Android for speed optimization just like Windows does. Mac & Linux always optimize for speed.
Removes the declare_args call around the gcc_version. This was parameterized to be different if is_android was set, which isn't valid because build parameters can't vary across toolchains. Since this value is derived from the environment, I just removed the declare_args call.
BUG=
R=piman@chromium.org
Review URL: https://codereview.chromium.org/289953004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271941 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
https://src.chromium.org/viewvc/chrome?view=rev&revision=271919 fixes the
compiler crash, http://src.chromium.org/viewvc/chrome?view=rev&revision=271780
fixes the bug in landmines that didn't allow the initial land/revert to
go smoothly.
Should be A-OK this time.
> Revert 271721 "VS2013 Update 2"
>
> static_library build ICEing on some builders on mini_installer.
>
> > VS2013 Update 2
> >
> > As discussed in the linked bug, the toolchain2013.py script in
> > depot_tools is no longer workable (because the update for Update 2 is
> > supplied as a .msp that must be applied against a system-installed
> > VS2013).
> >
> > As such, the Express hash here is not updated.
> >
> > The hash zip referenced here was built as follows:
> > - Install VS2013 Update 2 on a clean VM
> > - Copy DIA SDK\, VC\
> > - Copy DLLs from VC\redist to sys32\ and sys64\
> > - Copy win8sdk unchanged from previous .zip.
> > - Delete various unused arm\ subdirectories
> > - Delete the IDE-only Snippets, etc. subdirectories in VC\
> > - Patch VC\include\xtree to disable warning 4702 per request in
> > http://crbug.com/346399 .
> >
> > A followup change will be to write a script that does these steps
> > semi-automatically, hopefully for Express too, though there is the
> > added complication of the WDK/ATL/MFC hacking required there. In
> > particular, this script will not be useful for a dev to actually run
> > as part of runhooks, but will be a bit useful for deployment/
> > documentation of the above process.
> >
> > In the interim there are no extremely-pressing reasons for Express
> > users to update to Update2 that I'm aware of, so they get non-Update2
> > for now.
> >
> > R=iannucci@chromium.org
> > BUG=372451,346399,371847,339215,350639
> >
> > Review URL: https://codereview.chromium.org/284663003
>
> TBR=scottmg@chromium.org
>
> Review URL: https://codereview.chromium.org/297753002TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/295093004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271921 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently:
- Based on #if, switches renderer rendering to PDF for preview
- Add PdfToEmfConvert based on PWGRasterConverter
- Various plumbing.
Preview works the same as other PDF based platforms. For getting
to EMF, the when PRINTING_WIN_USES_PDF_AS_METAFILE is on, the
renderer generates a PDF instead of EMF directly (this contains
all the pages in the desired range). This is returned to
PrintViewManagerBase, where it's passed to PdfToEmfConverter which
uses the sandboxed utility process and pdf.dll to convert via
RenderPDFPageToDC. The utility process renderers one emf page at
at time (into numbered files) to avoid having a very large emf file.
As this uses pdf.dll this is currently off-by-default controlled by
the gyp variable win_pdf_metafile_for_printing.
R=vitalybuka@chromium.org
BUG=170859
Review URL: https://codereview.chromium.org/255543006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271772 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a skeleton build file for content/common that lists the basic deps, and processes the sources. This can keep track of the deps that have been converted and allows easy testing of the .gypi reading.
Changes content_common.gypi to separate out the public and private sources. The .gypi combines them both into the 'sources' so current users of this file should not be affected. This allows the GN build to declare the public API.
Enhance the gypi-to-gn script to strip conditions and collapse variables to allow the content .gypis to be read in.
Adds some simple BUILD.gn files for dependencies of content/common
Fix typo in accessibility.gyp that I discovered when writing the GN build.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/287233002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271767 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
static_library build ICEing on some builders on mini_installer.
> VS2013 Update 2
>
> As discussed in the linked bug, the toolchain2013.py script in
> depot_tools is no longer workable (because the update for Update 2 is
> supplied as a .msp that must be applied against a system-installed
> VS2013).
>
> As such, the Express hash here is not updated.
>
> The hash zip referenced here was built as follows:
> - Install VS2013 Update 2 on a clean VM
> - Copy DIA SDK\, VC\
> - Copy DLLs from VC\redist to sys32\ and sys64\
> - Copy win8sdk unchanged from previous .zip.
> - Delete various unused arm\ subdirectories
> - Delete the IDE-only Snippets, etc. subdirectories in VC\
> - Patch VC\include\xtree to disable warning 4702 per request in
> http://crbug.com/346399 .
>
> A followup change will be to write a script that does these steps
> semi-automatically, hopefully for Express too, though there is the
> added complication of the WDK/ATL/MFC hacking required there. In
> particular, this script will not be useful for a dev to actually run
> as part of runhooks, but will be a bit useful for deployment/
> documentation of the above process.
>
> In the interim there are no extremely-pressing reasons for Express
> users to update to Update2 that I'm aware of, so they get non-Update2
> for now.
>
> R=iannucci@chromium.org
> BUG=372451,346399,371847,339215,350639
>
> Review URL: https://codereview.chromium.org/284663003TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/297753002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271737 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
[This is take three. I believe that I've now fixed all the static
initializers (including both files named debug_utils.cc that were
including <iostream>), the packaging failures, and the black border
on the app list as pointed out by mgiuca@.]
Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.
TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.
BUG=300084, 303862
TBR=sky@chromium.org
First Review URL: https://codereview.chromium.org/25108005
Review URL: https://codereview.chromium.org/292443002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271725 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Parameterize webrtc enabling.
Add use_seccomp_pbf flag
Add a webkit version target
Work on ui/base GN build, especially on Windows. This target is a mess (in GYP). This patch tries to make it make a bit more sense while fixing the errors I found.
Fix ui/gl target for non-Linux platform. A bunch of X11 stuff was not parameterized.
Add unscaled resources target
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/287343006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271724 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
As discussed in the linked bug, the toolchain2013.py script in
depot_tools is no longer workable (because the update for Update 2 is
supplied as a .msp that must be applied against a system-installed
VS2013).
As such, the Express hash here is not updated.
The hash zip referenced here was built as follows:
- Install VS2013 Update 2 on a clean VM
- Copy DIA SDK\, VC\
- Copy DLLs from VC\redist to sys32\ and sys64\
- Copy win8sdk unchanged from previous .zip.
- Delete various unused arm\ subdirectories
- Delete the IDE-only Snippets, etc. subdirectories in VC\
- Patch VC\include\xtree to disable warning 4702 per request in
http://crbug.com/346399 .
A followup change will be to write a script that does these steps
semi-automatically, hopefully for Express too, though there is the
added complication of the WDK/ATL/MFC hacking required there. In
particular, this script will not be useful for a dev to actually run
as part of runhooks, but will be a bit useful for deployment/
documentation of the above process.
In the interim there are no extremely-pressing reasons for Express
users to update to Update2 that I'm aware of, so they get non-Update2
for now.
R=iannucci@chromium.org
BUG=372451,346399,371847,339215,350639
Review URL: https://codereview.chromium.org/284663003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271721 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Each time we add a new platform in the default build, products that want
only a single platform have to add an entry to GYP_DEFINES to turn it back
off.
This introduces a new setting, ozone_auto_platforms. If this is turned off
in GYP_DEFINES, we'll only build platforms that are explicitly enabled.
TEST=runhooks
BUG=none
Review URL: https://codereview.chromium.org/288273002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271101 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds a meta-target "//base/allocator" that forwards to tcmallor or nothing depending on the build configuration.
Write tcmalloc target definition.
Write base unit tests prefs, and some support targets from base.gypi.
Fix a bunch of added files in the base target that were exposed by linking the unit tests.
Removes toolkit_uses_gtk which was removed from the GYP build.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/288203003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds special handling for variables that begin with underscores, which is inspired by Dart. Such variables are not imported when doing an import, which gives .gni files a way to have intermediate private variables that won't pollute the scopes of the files that include them.
This also applies to the root build config, which can have private values now.
Adds some missing unused variable checks. This was disabled because processing imports would mean all imported variables were unused, and files not using all of them would get unused variable errors. This adds the option to mark merged values on a scope as used, which is used for imported values.
BUG=341738
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/287693002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271078 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This extracts the device temp file creation deletion into a context
manager. This context manager will delete the temporary file when
leaving the with: scope.
Also changes logic for finding a temp file from a linear search from 0
to just using a random number (still checking that the file doesn't
exist). Both of these approaches could return the same file in
consecutive calls if the earlier files aren't written to (though it is
nearly impossible with the random number approach instead of essentially
guaranteed).
Removed the temp file name patterns and just added a prefix+suffix
argument to DeviceTempFile (like tempfile.NamedTemporaryFile).
BUG=371054
Review URL: https://codereview.chromium.org/276813002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270917 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This supports testing rendering using EGL. Creation of the
EGLNativeWindowType is punted to a separate library, which has an
interface defined in eglplatform_shim.h.
TEST=ninja -C out_ozone/Debug aura_builder &&
content_shell --ozone-platform=egltest --ignore-gpu-blacklist
BUG=none
TBR=spang
Review URL: https://codereview.chromium.org/282193003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270737 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
radhikabhar@chromium.org
brettw@chromium.org
jam@chromium.org
zea@chromium.org
scottmg@chromium.org
tfarina@chromium.org
navabi@google.com
cjhopman@chromium.org
cthomp@chromium.org
mlamouri@chromium.org
kkimlabs@chromium.org
thakis@chromium.org
erg@chromium.org
spang@chromium.org
qsr@chromium.org
glider@chromium.org
thestig@chromium.org
dtseng@chromium.org
dmazzoni@chromium.org
bulach@chromium.org
jbudorick@chromium.org
fdegans@chromium.org
szager@chromium.org
iannucci@chromium.org
hinoka@google.com
hans@chromium.org
pasko@chromium.org
nbarth@chromium.org
starodub@google.com
phajdan.jr@chromium.org