The js unit test targets have subtle dependencies on sources.
Specifically, a rule pulls in js files and generates/runs js tests for
them. This can be an issue with a relative path when the commands are
run in parallel because a relative path may not exist. In this case, the
rule for cr.js which is in ui depends on chrome. An easy way to repro
this failure is:
$ ninja -C out/Debug unit_tests
$ rm -rf out/Debug/test_data
$ ninja -C out/Debug test_data/chrome/../ui/webui/resources/js/cr.js
Ninja is fine because it normalizes the path early enough whereas in
python we relied on the system to compute the path but out/Debug/test_data/chrome may not exist
BUG=235731
Hat-tip to cjhopman for help debugging.
Review URL: https://chromiumcodereview.appspot.com/14432003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@197224 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Small set of changes in gyp files to enable build for libchromeview for
MIPS-Android.
It also includes minor change in base/debug/stack_trace_android.cc to
redefine SIGSTKFLT for MIPS, since MIPS does not have SIGSTKFLT.
BUG=130022
TEST=build libchromeview
Review URL: https://chromiumcodereview.appspot.com/14241008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@196938 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
gcc_version previously existed only under certain conditions; currently,
os_posix==1 and OS!="mac" and OS!="ios".
These same checks had to be repeated everywhere gcc_version was used, and
they often got out of sync (many places still do not check for OS!="ios",
for example).
We now always gcc_version. Its default value is 0, and it is then changed to
something meaningful under that condition mentioned above. This allows us to
remove the duplicated checks currently spread across the .gyp files in the
tree.
BUG=
Review URL: https://chromiumcodereview.appspot.com/13912027
git-svn-id: http://src.chromium.org/svn/trunk/src/build@196910 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This patch deprecates armv7 and adds arm_version that takes an integer
value representing the ARM architecture level.
In addition arm_arch, arm_tune, arm_fpu, arm_float_abi and arm_thumb can
be set to fine tune CPU related compiler flags, defaults are provided for
ARM versions 5 to 7.
BUG=234135
Review URL: https://chromiumcodereview.appspot.com/14065005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@196702 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The combination of generated shim headers, the system ICU targets being
type "none", and ui being a static library caused some dependencies to
be missed out when use_system_icu==1. Make ui a hard dependency to work
around this.
BUG=
Review URL: https://chromiumcodereview.appspot.com/14472005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@196700 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
In addition move C4355 to list of sanctioned compiler warning suppressions.
The warning was disabled globally for ~2 years, meaning the macro wasn't providing any value. Refer to bug and chromium-dev@ discussion for details.
BUG=234765
Review URL: https://chromiumcodereview.appspot.com/14472011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@196671 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Historically, WebSettings management is used to be in the ContentSettings class,
while only WebView actually needs it. Chrome for Android is only interested in
the value of the "JavaScript enabled" setting.
This change leaves zoom-related settings intact, as moving them will require
decoupling of the ZoomManager class from the ContentView* family of classes,
which deserves a separate change.
BUG=b/8296421
Review URL: https://chromiumcodereview.appspot.com/14271024
git-svn-id: http://src.chromium.org/svn/trunk/src/build@196399 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Debug APKs with native libraries should include gdbserver. Copy this
into the apk_package_native_libs_dir. Then, the apkbuilder task will
include this in the APK for debug builds (but not for release builds).
TEST=unzip -l ContentShell.apk should list gdbserver for debug builds
(but not for release)
Review URL: https://chromiumcodereview.appspot.com/14200040
git-svn-id: http://src.chromium.org/svn/trunk/src/build@196203 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If a user reinstalls/uninstalls/etc an APK, then the next build of that
APK should always install it (regardless of whether the md5sum of the
inputs matches the recording or not).
Adds an option to CheckCallAndRecord to force the call.
NOTRY=true
BUG=158821,234048
Review URL: https://codereview.chromium.org/14254005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@196170 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This needs a little bit of explanation. Normally, we would want to restructure
the code to have separate variables for "--lib32" and for the result of the
"yes_no" question. But that requires more global changes.
Instead, in this case, we want to very clearly document that we added an
early "if" statement to break out. And this is intended to be a temporary
measure until the entire feature is fully removed.
So, I instead opted for resetting the "do_inst_lib32" variable -- and a lengthy
comment explaining this decision.
BUG=233047
TEST=run with --lib32 and verify that entering "N" aborts the installation.
Review URL: https://chromiumcodereview.appspot.com/14166013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@195950 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If the device folder is not specific to debug/release, then switching
configurations changes the state on the device without updating the
corresponding records on the host (i.e. it only updates the ones for
that configuration).
NOTRY=true
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/14238023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@195852 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
DomOperationsTests.*, DomSerializerTests.* and ResourceFetcherTests.* depended on TestShell loading URLs correctly. That couldn't be done with RenderViewTest harness since ResourceDispatcher code isn't hooked up. I added a mechanism for the browser test harness to run code on the renderer thread when running in --single-process mode. That way a "browser test" can poke at the renderer code. single-process mode doesn't work on Linux Aura, so disabled those tests there for now (bug 234172). DomSerializerTests.* fail on Android. They never ran there before since test_shell_tests never worked there, so just disabled them there with a note to investigate.
Note CppBoundClassTest is trivial and doesn't depend on loading, so I just made it a RenderViewTest.
I removed plugin_tests.cc:
-PluginTest.Refresh won't work with sharding. It's for a use case we don't care much about anyways, so a regression, if it happens, isn't critical.
-PluginTest.DeleteFrameDuringEvent is a duplicate of PluginTest.SelfDeletePluginInvokeInSynchronousMouseUp
-PluginTest.ForceReload is for in process plugins (i.e. test shell), doesn't apply to our multi-process plugins
-PluginTest.PluginVisibilty is currently disabled and failing. I thought about porting it and fixing it, but it seemed low priority since it'd be flaky to test this with our multi-process plugins. This code also doesn't change anymore, and if we had a regression we would catch this pretty quickly. If we regress we can write a test then.
mock_spellcheck_unittest.cc: was testing a mock object used in TestShell. Since TestShell is going away, there's no need for this test. if the object breaks and no existing tests break, then it's a non-issue.
memory_file_util.cc wasn't used other than in its unittest. I removed the code and its test.
CppBoundClassTest.* could be converted to a RenderViewTest. The remaining tests (HostVarTrackerTest.*, papiPluginInstanceTest.*, PpapiCustomInterfaceFactoryTest.*, QuotaFileIOTest.*, WebkitGlueUserAgentTest.* were converted to content_unittests.
I will delete the unused webkit/data in a follow up patch (try servers are failing on applying the delete).
BUG=126514,234172,111601,51622
Review URL: https://codereview.chromium.org/14304004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@195701 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculating this is the cause of these OS X release builder hangs:
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/11074/steps/compile/logs/stdiohttp://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/12424/steps/compile/logs/stdio
Relevant compile output:
=== BUILD AGGREGATE TARGET base_unittests_run OF PROJECT base WITH CONFIGURATION Release ===
Check dependencies
PhaseScriptExecution "Rule \"isolate\"" ../xcodebuild/base.build/Release/base_unittests_run.build/Script-5816EF986C49795B2FAB6114.sh
cd /Volumes/data/b/build/slave/cr-mac-rel/build/src/base
/bin/sh -c /Volumes/data/b/build/slave/cr-mac-rel/build/src/base/../xcodebuild/base.build/Release/base_unittests_run.build/Script-5816EF986C49795B2FAB6114.sh
python ../tools/swarm_client/isolate.py check --outdir "/Volumes/data/b/build/slave/cr-mac-rel/build/src/base/../xcodebuild/Release/ " --variable PRODUCT_DIR "/Volumes/data/b/build/slave/cr-mac-rel/build/src/base/../xcodebuild/Release " --variable "OS=mac" --result "/Volumes/data/b/build/slave/cr-mac-rel/build/src/base/../xcodebuild/Release/base_unittests.isolated" --isolate "base_unittests.isolate" --ignore_broken_items
command timed out: 1200 seconds without output, attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=4205.819860
> Reenable test_isolate_mode=check by default on OSX.
>
> This is not necessary to default to noop anymore. Defaulting to check was
> disabled on OSX because a problem during archival with symlink path case. This
> was fixed inside swarm_client.
>
> R=csharp@chromium.org
> BUG=98637
>
> Review URL: https://chromiumcodereview.appspot.com/14404011TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/13996018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@195664 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
asan's clang is currently pinned to a very old revision and hence includes
a very old plugin. Since all other bots run the plugin, we don't really
lose coverage by disabling the plugin on asan bots for now.
BUG=170629
TBR=glider
Review URL: https://chromiumcodereview.appspot.com/14305005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@195479 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This allows developers to force the values of individual flags in their
chrome/supplement.gypi. Add documentation for how a user can do that.
Also add a comment about the fastbuild option, but do not ever set it
by default.
NOTRY=true
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/14366023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@195334 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
laforge@chromium.org
davemoore@chromium.org
sivachandra@chromium.org
yfriedman@chromium.org
nileshagrawal@chromium.org
bulach@chromium.org
digit@chromium.org
petarj@mips.com
raphael.kubo.da.costa@intel.com
phajdan.jr@chromium.org
ohrn@opera.com
torne@chromium.org
scherkus@chromium.org
tfarina@chromium.org
palmer@chromium.org
rtoy@google.com
mnaganov@chromium.org
grt@chromium.org
cjhopman@chromium.org
ukai@chromium.org
navabi@google.com
abarth@chromium.org
markus@chromium.org
noamsml@chromium.org
xusydoc@chromium.org
jam@chromium.org
wittman@chromium.org
thakis@chromium.org
maruel@chromium.org
frankf@chromium.org
tapted@chromium.org
gavinp@chromium.org
ppi@chromium.org