Seems causing failures on mac asan bots, e.g:
http://build.chromium.org/p/chromium.memory/waterfall?builder=Mac%20ASan%2064%20Tests%20(1)
> Enable mac_strip_release under ASan on OSX. Remove the .saves files.
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> Because the ASan API functions are now undefined in the executables, it's
> actually senseless to use the .saves files to preserve those functions.
> This CL deletes the .saves files and turns mac_strip_release on for ASan
> builds.
>
> BUG=148383,242503,170739,166857
> R=mark@chromium.org
>
> Review URL: https://codereview.chromium.org/292153006TBR=glider@chromium.org
Review URL: https://codereview.chromium.org/298333007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@273302 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.
Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).
Because the ASan API functions are now undefined in the executables, it's
actually senseless to use the .saves files to preserve those functions.
This CL deletes the .saves files and turns mac_strip_release on for ASan
builds.
BUG=148383,242503,170739,166857
R=mark@chromium.org
Review URL: https://codereview.chromium.org/292153006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@273199 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Turn on ENABLE_NEW_GAMEPAD_API flag so that the new gamepad code is used.
Also remove the old code on Chromium side. The ENABLE_NEW_GAMEPAD_API is only
needed until the Blink side #ifdefs are removed.
BUG=344556
Review URL: https://codereview.chromium.org/289423004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272723 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The refactoring in the final patchset landed as r269766 got the
condition backwards (the pre-refactoring version worked), so we were
accidentally excluding flag only on *target* builds, instead of host
builds as intended (the target compiler supports this flag). Fix it.
BUG=321833
R=primiano@chromium.org
Review URL: https://codereview.chromium.org/296273002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272511 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Previously we would not define it in component builds because it didn't work with old versions of MSVC. These days it should work.
The macro is extra important for Clang, which doesn't currently support exceptions on Windows.
BUG=82385
Review URL: https://codereview.chromium.org/287193012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272478 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This flag defaults to true for official builds and false for unofficial builds. If the flag is false, Chromium will connect to sandbox wallet servers.
Net effect: instead of being controller by Chrome vs. Chromium, the default is controlled by Official vs. Unofficial buildtype.
BUG=334088
Review URL: https://codereview.chromium.org/288003004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272348 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds tools and gyp targets to build ChromeVox directly from its original
source in the Chromium repository instead of using precompiled obfuscated
JavaScript binaries. In addition, this adds infrastructure to run
ChromeVox 'unbundled' inside of a chromeos build.
Note that this is still experimental and not enabled by default. Also, the
manifest to run ChromeVox unbundled is not provided yet.
BUG=371692
R=dtseng@chromium.org,dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/299703003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272146 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently:
- Based on #if, switches renderer rendering to PDF for preview
- Add PdfToEmfConvert based on PWGRasterConverter
- Various plumbing.
Preview works the same as other PDF based platforms. For getting
to EMF, the when PRINTING_WIN_USES_PDF_AS_METAFILE is on, the
renderer generates a PDF instead of EMF directly (this contains
all the pages in the desired range). This is returned to
PrintViewManagerBase, where it's passed to PdfToEmfConverter which
uses the sandboxed utility process and pdf.dll to convert via
RenderPDFPageToDC. The utility process renderers one emf page at
at time (into numbered files) to avoid having a very large emf file.
As this uses pdf.dll this is currently off-by-default controlled by
the gyp variable win_pdf_metafile_for_printing.
R=vitalybuka@chromium.org
BUG=170859
Review URL: https://codereview.chromium.org/255543006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271772 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
[This is take three. I believe that I've now fixed all the static
initializers (including both files named debug_utils.cc that were
including <iostream>), the packaging failures, and the black border
on the app list as pointed out by mgiuca@.]
Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.
TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.
BUG=300084, 303862
TBR=sky@chromium.org
First Review URL: https://codereview.chromium.org/25108005
Review URL: https://codereview.chromium.org/292443002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271725 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Each time we add a new platform in the default build, products that want
only a single platform have to add an entry to GYP_DEFINES to turn it back
off.
This introduces a new setting, ozone_auto_platforms. If this is turned off
in GYP_DEFINES, we'll only build platforms that are explicitly enabled.
TEST=runhooks
BUG=none
Review URL: https://codereview.chromium.org/288273002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271101 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This supports testing rendering using EGL. Creation of the
EGLNativeWindowType is punted to a separate library, which has an
interface defined in eglplatform_shim.h.
TEST=ninja -C out_ozone/Debug aura_builder &&
content_shell --ozone-platform=egltest --ignore-gpu-blacklist
BUG=none
TBR=spang
Review URL: https://codereview.chromium.org/282193003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270737 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculative revert because we think this might have caused Mac Build bot
failure "gyp: Call to 'python ../../../build/mac/find_sdk.py 10.6' returned exit status -9."
> ozone: Add egltest platform
>
> This supports testing rendering using EGL. Creation of the
> EGLNativeWindowType is punted to a separate library, which has an
> interface defined in eglplatform_shim.h.
>
> TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist
> BUG=none
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/288603002TBR=spang@chromium.org
Review URL: https://codereview.chromium.org/288013002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270474 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This supports testing rendering using EGL. Creation of the
EGLNativeWindowType is punted to a separate library, which has an
interface defined in eglplatform_shim.h.
TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/288603002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270471 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Make Android tools build as position independent executable by
default, as it now required by Android.
- Introduce a wrapper for running PIE on Android ICS (its linker
doesn't support PIE).
- Add the plumbing for running the PIE wrapper in the test/telemetry
python scripts.
BUG=373219
NOTRY=true
Review URL: https://codereview.chromium.org/287513002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270406 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.
TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.
BUG=300084, 303862
R=sky@chromium.org
Review URL: https://codereview.chromium.org/25108005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269892 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Android uses gcc 4.8 for target on arm64, so -Wno-unused-local-typedefs
gets added to the gcc command line; unfortunately the host toolchain on
mac does not support this flag. We have no way to detect the host
toolchain version in the WebView build because we generate makefiles in
advance instead of on the build machine, so just hardcode an exception
until the instances of this warning can be fixed and this entire
conditional section removed.
BUG=321833
Review URL: https://codereview.chromium.org/277983002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269766 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This removes the use of a static initializer and makes it possible
for clients to pass a key without owning the memory where the
key is stored (as would be the case if passed to a static const char*).
BUG=371626, 371204
Review URL: https://codereview.chromium.org/279633003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269578 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When clang is turned on or off, or when clang is updated, all .o files and all
precompiled headers need to be rebuilt. This is currently done by having the
update script remove the out/ directory. This has issues:
* It fails to catch build directories with different names (e.g. out_android)
* It removes other build artifacts (like resources) that don't need rebuilding
* It doesn't happen when turning clang off (i.e. moving clang -> gcc).
Instead, let common.gypi add a define with the current clang revision to each
source file. This way, the clang revision is on each compile's command line
and the build system's commandline tracking can take care of the rebuilding.
BUG=nativeclient:3840
NOTRY=true
Review URL: https://codereview.chromium.org/268363020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269427 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Causes a sizes regression, starting in http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64712
+# data_reduction_proxy_settings.cc data_reduction_proxy::DataReductionProxySettings::key_
+# data_reduction_proxy_settings.cc __cxa_atexit@plt [registers a dtor to run at exit]
+# data_reduction_proxy_settings.cc __init_array_end+0x3868
+# data_reduction_proxy_settings.cc __init_array_end+0x3b88
+# data_reduction_proxy_settings.cc __init_array_end+0x530
Original issue's description:
> Collect data reduction proxy UMA on all platforms
>
> UMA for the data reduction proxy was gated behind preprocessor
> directives that resticted the logic to Android and iOS. This
> change opens UMA calculations and collection up to all platforms.
>
> BUG=369619
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269026TBR=mef@chromium.org,marq@chromium.org,bengr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=369619
Review URL: https://codereview.chromium.org/274453011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269041 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
dnicoara@chromium.org
ronghuawu@chromium.org
mvanouwerkerk@chromium.org
glider@chromium.org
henrika@google.com
qsr@chromium.org
torne@chromium.org
ch.dumez@samsung.com
pkasting@chromium.org
kbr@chromium.org
hans@chromium.org
noamsml@chromium.org
estade@chromium.org
scottmg@chromium.org
plundblad@chromium.org
thakis@chromium.org
erg@chromium.org
spang@chromium.org
thestig@chromium.org
jam@chromium.org
dtseng@chromium.org
fdegans@chromium.org
pasko@chromium.org
nbarth@chromium.org
derat@chromium.org
vrk@chromium.org
primiano@chromium.org
cjhopman@chromium.org
sadrul@chromium.org
bengr@chromium.org
ycheo@chromium.org
tapted@chromium.org
dmikurube@chromium.org
mmenke@chromium.org