It appears the "*" path in the case statement is never
matched due to the double-quotes (tested with bash 4.3.11 on
Trusty 14.04). Removing the quoting aligns with other case
statements in the script, and solves the problem. This bug
made https://codereview.chromium.org/2650823010 not have any
effect, which was discovered when deploying ARM 64 bots for
WebRTC.
BUG=684356,webrtc:7024
Review-Url: https://codereview.chromium.org/2790453002
Cr-Original-Commit-Position: refs/heads/master@{#460733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95504aea9818ec4e593358d0373f9c41531a3b67
This CL adds the following packages to install-build-deps.sh:
libgtk-3-dev
libgtk-3-0
libgtk-3-0-dbg
libgtk-3-0:i386
In addition, it also refactors dev_list, lib_list, dbg_list, and
nacl_list so that each package is on a separate line. It was getting
ridiculous reformatting everything every time a new package was added.
BUG=695541
R=dpranke@chromium.orgCC=thestig@chromium.org,erg@chromium.org
Review-Url: https://codereview.chromium.org/2730523002
Cr-Original-Commit-Position: refs/heads/master@{#454118}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 20032a5cd3037ac303100cae6585e279d6908c23
This is needed to avoid AR errors in build/toolchain/gcc_ar_wrapper.py
during compile when building for Linux ARM64.
The size of thew new dependency is ~19MB on Linux.
BUG=684356,webrtc:7024
Review-Url: https://codereview.chromium.org/2650823010
Cr-Original-Commit-Position: refs/heads/master@{#446656}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 74c7e4b3a075d01cb9f04b8c746fa8bc888ed768
This CL
- Enables jessie support in install-build-deps.sh
- Adds a note in linux_build_instructions.md about adding the
'contrib' component in sources.list.
- Fixes a bug in package_exists where if a ppa is added, a package is
installed from it, and then the ppa is removed, and the package is
removed but not purged, package_exists would still return true for
the package.
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2556133003
Cr-Original-Commit-Position: refs/heads/master@{#437198}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b4a2bcaef478f19b5a244d5102b412dea5372ecd
Previously we were installing Ubuntu language packs to just for their locales.
According to apt, these packages took up ~25Mb of space, and the packages are
not available on Debian. This CL uses locale-gen to generate the needed locales
instead.
The locales are only needed in the following tests:
fr_FR.UTF-8: TimeFormatBrowserTest.DecimalPointNotDot
da_DK.UTF-8: LocaleTestDanish.TestStart
he_IL.UTF-8: LocaleTestHebrew.TestStart
zh_TW.UTF-8: LocaleTestTraditionalChinese.TestStart
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2559463004
Cr-Original-Commit-Position: refs/heads/master@{#437136}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5ef5c3d2c48d8ae8cb9b90376649688b35ce2057
Reason for revert:
This change breaks the following bot: http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/56654
This appears to be the intended behavior of the change, although the bots should probably not break when it lands to avoid a closed tree.
Original issue's description:
> Add check_build_deps step to gclient runhooks
>
> This CL adds a build hook to ensure that any necessary build
> dependencies are installed before proceeding with the
> build. A failure would indicate install_build_deps.sh
> needs to be rerun.
>
> BUG=666937
> R=dpranke@chromium.org
>
> Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230
> Cr-Commit-Position: refs/heads/master@{#433603}
TBR=dpranke@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=666937
Review-Url: https://codereview.chromium.org/2521733002
Cr-Original-Commit-Position: refs/heads/master@{#433611}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ae919e5336c1d4a3a3455f82f85cdd06162d2f1
This CL adds a build hook to ensure that any necessary build
dependencies are installed before proceeding with the
build. A failure would indicate install_build_deps.sh
needs to be rerun.
BUG=666937
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2505413003
Cr-Original-Commit-Position: refs/heads/master@{#433603}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e8942c0a68a986313e2927de584a644c8d21b230
The algorithm we were using to parse the output of dpkg-query was out of date because the format changed.
This CL tries to make as little assumptions as possible about the output of dpkg-query, using the return code to determine failure instead of the output. However, we still rely on the last word of an error message being a package name, although this is only used to display which packages are missing.
BUG=666937
R=mmoss@chromium.org,dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2519523002
Cr-Original-Commit-Position: refs/heads/master@{#433327}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 73b3a441a128d14c81bed7afc981d35f0f401f1d
See bug, apparently it's "an up-to-date thing" but "thing is up to date".
The bug is only about grd files, but I went through `git grep -l up-to-date`
while I was at it.
BUG=344535
TBR=IPC owner
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2059143002
Cr-Original-Commit-Position: refs/heads/master@{#399698}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3e861deabe8e47db274ed779acc1a3b80837e16d
This relands https://codereview.chromium.org/1773233002/.
Original description:
Media Galleries Partial Deprecation: Remove image metadata & libexif.
Removing libexif is a great thing.
It will remove a ~200KB DLL from Windows, Mac, and ChromeOS. It will remove bugs and security issues.
BUG=542912,577272
TBR=
Review URL: https://codereview.chromium.org/1803883002
Cr-Original-Commit-Position: refs/heads/master@{#381121}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cd96b6f874573d7089bf2eb9d54ed53d7469bb56
Reason for revert:
Causes build errors on official waterfall.
https://bugs.chromium.org/p/chromium/issues/detail?id=593580
Original issue's description:
> Media Galleries Partial Deprecation: Remove image metadata & libexif.
>
> Removing libexif is a great thing.
>
> It will remove a ~200KB DLL from Windows, Mac, and ChromeOS. It will remove bugs and security issues.
>
> BUG=542912,577272
>
> Committed: https://crrev.com/f3890c75101ff9b07f48aed992285cc45bf5b4d5
> Cr-Commit-Position: refs/heads/master@{#380306}
TBR=phajdan.jr@chromium.org,rdevlin.cronin@chromium.org,thakis@chromium.org,tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=542912,577272
Review URL: https://codereview.chromium.org/1791623002
Cr-Original-Commit-Position: refs/heads/master@{#380852}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0978e4ebde4a1c07f4e8da88cc9daa7732a63b1a
Removing libexif is a great thing.
It will remove a ~200KB DLL from Windows, Mac, and ChromeOS. It will remove bugs and security issues.
BUG=542912,577272
Review URL: https://codereview.chromium.org/1773233002
Cr-Original-Commit-Position: refs/heads/master@{#380306}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f3890c75101ff9b07f48aed992285cc45bf5b4d5
On leading-edge Ubuntu versions there are no LTS backport packages, and
dpkg-query prints an error about nothing matching the wildcard to
stderr, which has caused at least one user to think the script didn't
install mesa correctly. The script handles this case just fine, though
(it expands to an empty array and sets mesa_variant to emptystring,
whcih is correct), so just redirect stderr to avoid this spurious error
message.
BUG=
Review URL: https://codereview.chromium.org/1721763003
Cr-Original-Commit-Position: refs/heads/master@{#377332}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 12cd9f6cf09631a18f11f123cc02e753dfcaa199
This is a documentation-only change.
Disabling presubmit checks, due to "noparent" settings for the following files:
components/policy/resources/policy_templates.json
content/common/font_config_ipc_linux.h
BUG=567488
NOPRESUBMIT=true
TBR=atwilson,dcheng
Review URL: https://codereview.chromium.org/1592403002
Cr-Original-Commit-Position: refs/heads/master@{#374213}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df175a8c3d1c1060f96d123a5896fdfbe4b3782d
Instead of hardcoding a list of which LTS variants of mesa might be
installed, just query for any package that matches the expected pattern
and if exactly one is installed, use that. If zero are installed, use
the base package. There shouldn't be more than one as these packages
conflict with each other, so just abort if that happens.
This avoids needing to extend the loop in this script every time a new
Ubuntu backport package is added.
BUG=
Review URL: https://codereview.chromium.org/1434453002
Cr-Original-Commit-Position: refs/heads/master@{#358039}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8a6eb6958e85d742f70a8cc4c85a24c5efa93cee
This CL fixes a detection of 64-bit architecture when /sbin/init is
symlink. On Ubuntu 15.04, /sbin/init is symlink to /lib/systemd/systemd
and therefore the |file| command doesn't show anything except the path
it refers to.
BUG=
TEST=
R=primiano@chromium.org,sbc@chromium.org,scottmg@chromium.org
Review URL: https://codereview.chromium.org/1300613002
Cr-Original-Commit-Position: refs/heads/master@{#349373}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0a79d699ff6d87346347aa0f2d91d8e5dddd6924
"realpath" is used by several CrOS tools.
It is needed on builders that build Chromium through the CrOS toolchain.
BUG=chromium:491287
TEST=None
Review URL: https://codereview.chromium.org/1156763002
Cr-Original-Commit-Position: refs/heads/master@{#331434}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a8491d157d1613c41426e91a3ac479766dd7a31
Trusty seems to have dificulty installing gcc-arm-linux-gnueabihf
and gcc-4.8-multilib without these extra packages being listed
on the install line also.
BUG=435056
Review URL: https://codereview.chromium.org/1049833003
Cr-Original-Commit-Position: refs/heads/master@{#323281}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b5d4ded25739d583663fd17569de96394f84c267
On a fresh install of Ubuntu Trusty + Cinnamon, install-build-deps.sh failed, because:
* it was looking for libgl1-mesa-dev
* Cinnamon forced libgl1-mesa-dev-lts-utopic to be installed
* there cannot be two versions of libgl1-mesa-dev* installed
This CL adds libgl1-mesa-dev and mesa-common-dev to the group of packages, for which the correct "mesa_variant" suffix is guessed. It also adds "-lts-utopic" to the list of explored suffixes.
BUG=466787
Review URL: https://codereview.chromium.org/1003853003
Cr-Original-Commit-Position: refs/heads/master@{#320889}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f1e8b17f4827ad6030c19f71ebf8e34c91248e2b
Previously we were installing and using libssl0.9.8:i386
which was actually a miss-match with the 1.0.0 headers
installed by libssl-dev.
TEST=local (remove links and run install-build-deps.sh)
Review URL: https://codereview.chromium.org/913183004
Cr-Original-Commit-Position: refs/heads/master@{#316319}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6ab44c3694b129131b964cada9feb78a1cc880a2
Added utopic in list of supported version.
BUG=437593
TEST=run install-build-deps.sh on ubuntu14.10 or use utopic chroot
environment.
NOTRY=true
Review URL: https://codereview.chromium.org/769653002
Cr-Original-Commit-Position: refs/heads/master@{#306365}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6be55c61cc912e3b6ef911323e958f77e7d2f03f
Currently install-build-deps-android.sh installs g++-multilib which
conflicts with packages installed by install-build-deps.sh (since
gcc-multilib contains a /usr/include/asm symlink and the crosscompiler
packagers don't want you to accidentally include the wrong
architecture's asm headers).
The g++-multilib package was wrongly commented as being required for
Android SDK; it turns out these requirements have changed, so I
updated the libraries required for the Android SDK based on their docs.
g++-4.8-multilib is however still (likely) needed, alongside
linux-libc-dev:i386, for compiling the V8 snapshot. So I've
consolidated those deps, and the logic for selecting them, under the
--lib32 flag of install-build-deps (to avoid duplicating the code in
both). I updated the `if (trusty) install g++-4.8-multilib` logic so
it chooses the right version of the multilib automatically, rather
than hardcoding the version needed for trusty (which will break in
utopic or beyond).
Finally I removed the `sudo apt-get update` in
install-build-deps-android which is redundant now that we call
install-build-deps which already does that. And I added `sudo dpkg
--add-architecture i386` which seems to have been missing from these
scripts.
BUG=435056
Review URL: https://codereview.chromium.org/740963002
Cr-Original-Commit-Position: refs/heads/master@{#305991}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 49bb458a54a0e959f91ef612c79fad89e7d65c91
The package python-opencv recently added to install-build-deps depends on the python-numpy package. However, on Ubuntu 12.*, the package manager doesn't know about this dependency, so python-opencv crashes without explicitly installing python-numpy.
So basically, this just explicitly lists a dependency that already was a dependency.
BUG=424345
Review URL: https://codereview.chromium.org/744883002
Cr-Original-Commit-Position: refs/heads/master@{#305214}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f041a51d5b0fd89519aa0d5dc772d658723a29a6
dpks-query is spamming stderr when the packages we query are not found.
Silencing stderr for dpkg-query.
BUG=429719
NOTRY=true
Review URL: https://codereview.chromium.org/695373002
Cr-Original-Commit-Position: refs/heads/master@{#302457}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b83ed9b4f2089e06fa6aa1808f85eae7c34ebd01
In order for us to support OAuth-authenticated access to Rietveld, we
need to be able to generate signed authorization requests in the Rietveld
upload scripts. That requires us to have either the python OpenSSL wrappers
plus OpenSSL itself installed, or to use the python pyCrypto library.
Currently the bots use python-openssl, but don't work on Windows as a result.
We add the python-openssl wrapper to be consistent, but want to switch
to pycrypto, so once we have all the bots using pycrypto, we can drop
python-openssl from the list.
R=thestig@chromium.org
BUG=371620, 375971
NOTRY=true
Review URL: https://codereview.chromium.org/287053007
Cr-Original-Commit-Position: refs/heads/master@{#297021}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fedbbb0aa762826ba2fc85a2b934dc9660639aa7
BUG=chromium:410129
TEST=remove linux-libc-dev:i386 then run ninja -> fails
TEST=install linux-libc-dev:i386 then run ninja -> works
Review URL: https://codereview.chromium.org/593573002
Cr-Original-Commit-Position: refs/heads/master@{#296231}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 34687555d4f325291d0c660dda2f6970f8df5b9a
kjellander
thomasanderson
friedman
marcin
anthonyvd
jack
horo
thakis
j.isorce
vadimsh
krasin
ellyjones
tommycli
erikchen
torne
mostynb
halton.huo
reveman
ki.stfu
abarth
dnj
sbc
thestig
lfg
vabr
johnme
samahto
mthiesse
primiano
dpranke
wnhuang
Brad Nelson