wnwen
6268c3a8bd
Android: Upgrade to Android Studio 2.3
...
Support Clank development with the next version of Android Studio.
BUG=700438
Review-Url: https://codereview.chromium.org/2797703004
Cr-Original-Commit-Position: refs/heads/master@{#462050}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fdea62ce258c0abf7327f1081af9d964818c440f
2017-04-05 13:12:54 +00:00
hzl
a312720424
Save the logcat file in isolated directory.
...
Previously we store the logcat into a temporary directory, which will be
deleted shortly. That means logcat will not be viewable in the isolated
directory.
In this cl, we are storing the logcat in the isolated directory, for
later easier view. This is a temporary fix before result details is
enabled.
BUG=707387
Review-Url: https://codereview.chromium.org/2797773003
Cr-Original-Commit-Position: refs/heads/master@{#461898}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9ae14459caaa7f3b049b3d44be2c209890773213
2017-04-04 23:38:02 +00:00
baxley
5ab348ff9e
Reland [iOS] Disable NSAssert and GTMDevAssert on release builds.
...
This was present in build/common.gypi and was inadvertently dropped
during the conversion to GN (removed by http://crrev.com/2355673003 ,
but hadn't been added to GN).
patch from issue 2637853002 at patchset 20001
(http://crrev.com/2637853002#ps20001 )
BUG=673253
Review-Url: https://codereview.chromium.org/2770733003
Cr-Original-Commit-Position: refs/heads/master@{#461841}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 45196266f164836fca6d41e8f9cfad0eee0b91a6
2017-04-04 21:15:56 +00:00
sandv
577fdd2f4d
Added leanback support libraries as dependencies
...
Test: Rebuilt and deployed app to fugu
BUG=Internal b/31223668
Resubmit of https://codereview.chromium.org/2772253005 because I submitted from the wrong repo
Review-Url: https://codereview.chromium.org/2792173002
Cr-Original-Commit-Position: refs/heads/master@{#461800}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cd49590a296f0f2a28325672a03a9d512b03587b
2017-04-04 19:23:21 +00:00
twellington
7b2da500be
Remove BuildInfo#isGreaterThanN()
...
The NMR1 SDK has been published upstream, so BuildInfo#isGreaterThanN is
no longer needed. This patch also removes reflection for
UserManager#isDemoUser() and ShortcutManager#reportShortcutUsed(),
and updates AndroidManifest.xml to remove the conditional include
of launchershortcut.xml and network_security_config.xml.
BUG=707302
Review-Url: https://codereview.chromium.org/2785373004
Cr-Original-Commit-Position: refs/heads/master@{#461787}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df46c2242e4635dc77fce945bfc0ea0089efee31
2017-04-04 18:46:21 +00:00
kjellander
4f5e7234df
Don't use --gdb-index for Gold and LLVM linker
...
It appears --gdb-index is not supported for Gold or the LLVM linker.
This was discovered after https://codereview.chromium.org/2786603003
and affected builds configurations like Linux ARM64 Debug.
BUG=708104
Review-Url: https://codereview.chromium.org/2791403004
Cr-Original-Commit-Position: refs/heads/master@{#461781}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1c4b5eb17214fa0aedea5193628c74312f71a2d2
2017-04-04 18:36:33 +00:00
jbudorick
437fe490eb
[Android] Log gtest stdout regardless of result parsing mode.
...
Previously, we only logged gtest stdout as part of parsing the
stdout to determine the test results. When using XML parsing
(i.e., when a user passed --enable-xml-result-parsing), stdout
was not logged.
This CL ensures we log the stdout in both cases.
BUG=707373
Review-Url: https://codereview.chromium.org/2793133003
Cr-Original-Commit-Position: refs/heads/master@{#461705}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 00314619b481948fcaeed5cf5e607232a7e55d2d
2017-04-04 14:19:55 +00:00
Mike Case
58260eddc7
Update webview_public_framework_jar to N-MR1.
...
Adding frameworks jar build from the android-7.1.1_r28 tag
in AOSP.
Bug:707823
Change-Id: Ifbe2c91aa1b495b0959b5de026bc9fd690474b12
Reviewed-on: https://chromium-review.googlesource.com/466631
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Michael Case <mikecase@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#461605}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a2b501b65e0987b4f2a23561a4906eb02f955a40
2017-04-04 01:39:51 +00:00
michaeldo
d654a617b8
Use framework style includes in ios/web_view/public.
...
BUG=704946
Review-Url: https://codereview.chromium.org/2791323002
Cr-Original-Commit-Position: refs/heads/master@{#461494}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b48b353161948224246626099272017cb9fbbb4f
2017-04-03 18:56:38 +00:00
perezju
ae65e15a78
[tools/perf] Remove remaining references to indexeddb_perf benchmark
...
Benchmark does not exist any more.
BUG=669832
Review-Url: https://codereview.chromium.org/2788643003
Cr-Original-Commit-Position: refs/heads/master@{#461393}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b8d3e9460b771a757adfc985fa4d1d19bd2d55c
2017-04-03 09:33:49 +00:00
wychen
e00daf3d37
Use more accurate matching in fix_gn_headers.py
...
- Exclude "git grep" matches that already have header files.
- More accurate "git grep" pattern.
- Allow interactive picking which matches to handle.
BUG=661774
Review-Url: https://codereview.chromium.org/2790563003
Cr-Original-Commit-Position: refs/heads/master@{#461317}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eb936d60b77cbc82876bcd23e5ad7fc09a7646b1
2017-04-01 05:42:56 +00:00
hzl
6491c78616
(Reland) Upload the test results html file to google bucket.
...
Previously we print the test results html to stdout. In this cl, we
upload the test results html to google bucket and print the link to the
file instead.
Sample link would be
'https://storage.googleapis.com/chromium-result-details/html/test_name/builder_name_builder_number_2017_03_27_T15_22_47.html '.
BUG=
Review-Url: https://codereview.chromium.org/2777353002
Cr-Commit-Position: refs/heads/master@{#460827}
Committed: 0046d99e39
patch from issue 2777353002 at patchset 160001 (http://crrev.com/2777353002#ps160001 )
Review-Url: https://codereview.chromium.org/2783313003
Cr-Original-Commit-Position: refs/heads/master@{#461283}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92dd980ea051fc48a38368cfc74fb1dc7a716019
2017-04-01 00:14:06 +00:00
brucedawson
a7ee81bf6d
Clarify the implications of symbol_level = 1
...
It is obvious in hindsight that symbol_level = 1 means that functions
with internal linkage won't show up in back traces.
R=scottmg@chromium.org
BUG=706744
Review-Url: https://codereview.chromium.org/2785263003
Cr-Original-Commit-Position: refs/heads/master@{#461218}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de6de9d3f907de08bce627cb096586c65eabc89a
2017-03-31 20:49:58 +00:00
Nico Weber
362f572ab6
Reland of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2754973002/ )
...
Reason for revert:
pnacl should no longer complain about this switch.
Original issue's description:
> Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2756713002/ )
>
> Reason for revert:
> Still breaks pnacl-ld on Windows: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Win%2F16241%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
> pnacl-ld: "--build-id=sha1" affects translation. To allow, specify --pnacl-allow-native
>
>
> Original issue's description:
> > Reland of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2732023004/ )
> >
> > Reason for revert:
> > With https://bugs.chromium.org/p/nativeclient/issues/detail?id=4391#c1 fixed, this might now work.
> >
> > Original issue's description:
> > > Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #2 id:20001 of https://codereview.chromium.org/2732293002/ )
> > >
> > > Reason for revert:
> > > https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/30394/steps/compile/logs/stdio
> > >
> > > pnacl-ld: Unrecognized option: --build-id=sha1
> > >
> > > gn args:
> > > goma_dir = "/b/c/goma_client"
> > > is_chrome_branded = true
> > > is_debug = false
> > > is_official_build = true
> > > target_os = "chromeos"
> > > use_goma = true
> > >
> > > Original issue's description:
> > > > build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON
> > > >
> > > > BUG=622775
> > > >
> > > > Review-Url: https://codereview.chromium.org/2732293002
> > > > Cr-Commit-Position: refs/heads/master@{#455154}
> > > > Committed: 4e5c4a1545
> > >
> > > TBR=hans@chromium.org ,torne@chromium.org,mcgrathr@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=622775
> > >
> > > Review-Url: https://codereview.chromium.org/2732023004
> > > Cr-Commit-Position: refs/heads/master@{#455172}
> > > Committed: e806d46df5
> >
> > TBR=hans@chromium.org ,torne@chromium.org,mcgrathr@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=622775
> >
> > Review-Url: https://codereview.chromium.org/2756713002
> > Cr-Commit-Position: refs/heads/master@{#457493}
> > Committed: c3cb7d84db
>
> TBR=hans@chromium.org ,torne@chromium.org,mcgrathr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=622775
>
> Review-Url: https://codereview.chromium.org/2754973002
> Cr-Commit-Position: refs/heads/master@{#457523}
> Committed: c9650610e0
TBR=hans@chromium.org ,torne@chromium.org,mcgrathr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622775
Review-Url: https://codereview.chromium.org/2790473005 .
Cr-Original-Commit-Position: refs/heads/master@{#461188}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1bafcfdfcc6867b9be120e54c73b0ea526cd886e
2017-03-31 19:48:18 +00:00
thestig
778b337ee7
Update build/linux/unbundle/README
...
- Better explain what this component does.
- Add a detailed description for replace_gn_files.py.
- Format text to fit in 72 columns.
- Mention GN build files.
Review-Url: https://codereview.chromium.org/2783293002
Cr-Original-Commit-Position: refs/heads/master@{#461186}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5864d312aa006009fb4734c59320f04f2d6dceb2
2017-03-31 19:44:05 +00:00
jochen
199e673c90
Enable content shell crash integration test on Windows
...
BUG=688737,706744
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2782603002
Cr-Original-Commit-Position: refs/heads/master@{#461175}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2511b73c11a55d8bb8a4c730d0cb308fbc821780
2017-03-31 18:24:15 +00:00
thakis
27b4e10e80
Enable -Wdeprecated-register in CrOS builds.
...
This was blocked on the CrOS build not using the jessie sysroot,
but now it does.
BUG=705812
Review-Url: https://codereview.chromium.org/2794543002
Cr-Original-Commit-Position: refs/heads/master@{#461153}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e2aa9636a2086da87bba7d5ebca09fd831504d4a
2017-03-31 17:04:46 +00:00
thakis
1c890e6217
Enable warning on reserved user-defined literals for CrOS.
...
This was blocked on making CrOS use the jessie sysroot, which is now done.
BUG=263960
Review-Url: https://codereview.chromium.org/2786313004
Cr-Original-Commit-Position: refs/heads/master@{#461149}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b3fc618111c6c50e9e05a8afb72f6fb40fd3b585
2017-03-31 16:48:26 +00:00
thakis
383b3e6432
Enable -Wdeprecated-register (except on CrOS and 32-bit Linux).
...
No behavior change.
BUG=255186,705812
Review-Url: https://codereview.chromium.org/2780623003
Review-Url: https://codereview.chromium.org/2780623003
Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Original-Commit-Position: refs/heads/master@{#460879}
Committed: 76ad12fee7
Committed: a46872ca96
Cr-Original-Commit-Position: refs/heads/master@{#461102}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#459973}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 755d274e7b3e893719322489b07a5d929328caa0
2017-03-31 12:51:55 +00:00
thakis
2b76f608a8
Use new jessie sysroot for cros-desktop builds too.
...
BUG=706006,598033
Review-Url: https://codereview.chromium.org/2772403002
Cr-Original-Commit-Position: refs/heads/master@{#461095}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 17498ec3190acff0ae88d3083543a50da9d0af83
2017-03-31 11:09:13 +00:00
thakis
673a8f4c6b
Enable -Wshift-negative-value.
...
But not on chromeos, since it uses the old libjpeg were this isn't fixed yet.
BUG=507717
Review-Url: https://codereview.chromium.org/2774223005
Cr-Original-Commit-Position: refs/heads/master@{#460989}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e28bd95d56cc19730ccc89f3bd8d8db47b7ef502
2017-03-31 01:52:06 +00:00
rsesek
b436d9a09c
Delete several unused GYP scripts from build/mac and chrome/tools/build/mac.
...
This also adds rsesek@ as an OWNER of chrome/tools/build/mac.
BUG=615107
R=mark@chromium.org
TBR=thakis@chromium.org
Review-Url: https://codereview.chromium.org/2793433002
Cr-Original-Commit-Position: refs/heads/master@{#460981}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4a22fdb230ae32c544d870cb55fbf3643a82adb9
2017-03-31 01:34:48 +00:00
mikecase
ed0abc36a0
Roll Android SDK to N-MR1
...
BUG=688263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2760383003
Cr-Original-Commit-Position: refs/heads/master@{#460934}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c263053681fd4e5297e2f69268587604123e1c0
2017-03-30 23:46:11 +00:00
findit-for-me
ac1759b778
Revert of Enable -Wdeprecated-register (except on CrOS). (patchset #7 id:120001 of https://codereview.chromium.org/2780623003/ )
...
Reason for revert:
Findit identified CL at revision 460879 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E0Njg3MmNhOTZkODYyODE2Zjk5M2MxNmQ2YzI3MGFmMjYyOTAyNDcM
Original issue's description:
> Enable -Wdeprecated-register (except on CrOS).
>
> No behavior change.
>
> BUG=255186,705812
>
> Review-Url: https://codereview.chromium.org/2780623003
> Cr-Original-Commit-Position: refs/heads/master@{#459973}
> Committed: 76ad12fee7
> Review-Url: https://codereview.chromium.org/2780623003
> Cr-Commit-Position: refs/heads/master@{#460879}
> Committed: a46872ca96
TBR=dcheng@chromium.org ,rouslan@chromium.org,kbr@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=255186,705812
Review-Url: https://codereview.chromium.org/2786273002
Cr-Original-Commit-Position: refs/heads/master@{#460910}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0c64e3912571118d628f513ccc3a7eb6224099d8
2017-03-30 22:52:26 +00:00
mikecase
545007bcb1
Add support for robolectric play-services-shadows.
...
Adding support to use Robolectric's play-services shadow
classes. Removing a custom shadow class we had in Chromium
now that the same shadow is available in Robolectric.
BUG=693660
Review-Url: https://codereview.chromium.org/2760743002
Cr-Original-Commit-Position: refs/heads/master@{#460906}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 476fddc51fb5cf133f2ce351c6805e65f4cbc4dd
2017-03-30 22:20:11 +00:00
thakis
6b1f9eeba1
Enable -Wdeprecated-register (except on CrOS).
...
No behavior change.
BUG=255186,705812
Review-Url: https://codereview.chromium.org/2780623003
Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Commit-Position: refs/heads/master@{#460879}
Committed: 76ad12fee7
Cr-Original-Original-Commit-Position: refs/heads/master@{#459973}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a46872ca96d862816f993c16d6c270af26290247
2017-03-30 21:16:17 +00:00
agrieve
30113aa452
generate_gradle.py: Add --extra-target that appends to the default set
...
I find this is more often what I want (as opposed to replacing the
default list of targets).
BUG=620034
Review-Url: https://codereview.chromium.org/2784293002
Cr-Original-Commit-Position: refs/heads/master@{#460878}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f8d338ac684358b34a2cd77518d434fb6fa433a3
2017-03-30 21:14:36 +00:00
brucedawson
0ad304ccdc
Disable /analyze when building with clang
...
When doing x64 builds of Chrome with VC++ we compile some modules
(currently just libyuv) with clang, in order to get inline assembly
support. This causes problems on /analyze builds because clang-cl
doesn't understand the /analyze compiler switches. This change
disables /analyze for those files that are compiled with clang.
With this change I can do a /analyze build of libyuv without
hitting any errors, but warnings are emitted as appropriate.
R=brettw@chromium.org
BUG=427616
Review-Url: https://codereview.chromium.org/2786733005
Cr-Original-Commit-Position: refs/heads/master@{#460874}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb4bb0ebf2bfc2881100122e1513ee3f694744a0
2017-03-30 21:06:55 +00:00
jshin
d9d597d586
Drop noto-cjk fonts from the CrOS font list to install
...
BUG=697954
TEST=run-webkit-tests does not time out.
Review-Url: https://codereview.chromium.org/2784603004
Cr-Original-Commit-Position: refs/heads/master@{#460857}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9492ea7b7a2145a72e99178a81db98f0ac16b857
2017-03-30 19:54:22 +00:00
hzl
60430058d7
Revert of Upload the test results html file to google bucket. (patchset #9 id:160001 of https://codereview.chromium.org/2777353002/ )
...
Reason for revert:
Causing error in build bot
Original issue's description:
> Upload the test results html file to google bucket.
>
> Previously we print the test results html to stdout. In this cl, we
> upload the test results html to google bucket and print the link to the
> file instead.
>
> Sample link would be
> 'https://storage.googleapis.com/chromium-result-details/html/test_name/builder_name_builder_number_2017_03_27_T15_22_47.html '.
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2777353002
> Cr-Commit-Position: refs/heads/master@{#460827}
> Committed: 0046d99e39
TBR=mikecase@chromium.org ,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2786003003
Cr-Original-Commit-Position: refs/heads/master@{#460853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9c03a0c535466dd59dd578e1d180863dbe3f1fd9
2017-03-30 19:40:55 +00:00
agrieve
c209445cdd
Android: Make incremental install work for two <instrumentation>
...
This happens in the case of junit4
Review-Url: https://codereview.chromium.org/2790453003
Cr-Original-Commit-Position: refs/heads/master@{#460839}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4e5061771986fd0d506d21f33a0d8fdb065add92
2017-03-30 18:57:51 +00:00
hzl
f88d67ada7
Upload the test results html file to google bucket.
...
Previously we print the test results html to stdout. In this cl, we
upload the test results html to google bucket and print the link to the
file instead.
Sample link would be
'https://storage.googleapis.com/chromium-result-details/html/test_name/builder_name_builder_number_2017_03_27_T15_22_47.html '.
BUG=
Review-Url: https://codereview.chromium.org/2777353002
Cr-Original-Commit-Position: refs/heads/master@{#460827}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0046d99e3911d416d0b5cb6f6f0191317bf41711
2017-03-30 18:21:24 +00:00
thakis
edb8be2cdc
Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2780763002/ )
...
Reason for revert:
V8 bots are upgraded.
Original issue's description:
> Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #2 id:240001 of https://codereview.chromium.org/2776773002/ )
>
> Reason for revert:
> Breaks V8 perf testing:
> http://crbug.com/705870
>
> Original issue's description:
> > Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772113002/ )
> >
> > Reason for revert:
> > Relanding with fixed deps
> >
> > Original issue's description:
> > > Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772503005/ )
> > >
> > > Reason for revert:
> > > expected_deps_x64_jessie changes are causing a failure on the official builder
> > >
> > > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F16997%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
> > >
> > > Original issue's description:
> > > > Reland of "Update linux sysroot from Wheezy to Jessie"
> > > >
> > > > The last version of this change was:
> > > > https://codereview.chromium.org/2748183005
> > > >
> > > > Which was reverted in:
> > > > https://codereview.chromium.org/2776503002
> > > >
> > > > I've updated the expected package deps again, this
> > > > time being sure to use is_chrome_branded=true when
> > > > testing (which oddly seems to effect the deps).
> > > >
> > > > TBR=thestig (since this is effectively a reland)
> > > > BUG=701894
> > > >
> > > > Review-Url: https://codereview.chromium.org/2772503005
> > > > Cr-Commit-Position: refs/heads/master@{#459492}
> > > > Committed: 7f43e46a78
> > >
> > > TBR=thakis@chromium.org ,dpranke@chromium.org,thestig@chromium.org,sbc@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=701894
> > >
> > > Review-Url: https://codereview.chromium.org/2772113002
> > > Cr-Commit-Position: refs/heads/master@{#459553}
> > > Committed: f2296e4fca
> >
> > TBR=thakis@chromium.org ,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=701894
> >
> > Review-Url: https://codereview.chromium.org/2776773002
> > Cr-Commit-Position: refs/heads/master@{#459584}
> > Committed: b0d4ad8b38
>
> TBR=thakis@chromium.org ,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=701894
>
> Review-Url: https://codereview.chromium.org/2780763002
> Cr-Commit-Position: refs/heads/master@{#460070}
> Committed: 75a1434be0
TBR=dpranke@chromium.org ,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=701894
Review-Url: https://codereview.chromium.org/2783193002
Cr-Original-Commit-Position: refs/heads/master@{#460795}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2183884b24334db9eb57f544388c963dd2694f8e
2017-03-30 16:50:47 +00:00
Pawel Hajdan, Jr
850c04f334
Unbundle libdrm
...
BUG=551343
R=thestig@chromium.org
Review-Url: https://codereview.chromium.org/2782923002 .
Cr-Original-Commit-Position: refs/heads/master@{#460751}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9a50f192a882b65f021c0c13345762c3a4d7a499
2017-03-30 14:31:51 +00:00
kjellander
53b5a6a762
Fix case error in install-build-deps.sh
...
It appears the "*" path in the case statement is never
matched due to the double-quotes (tested with bash 4.3.11 on
Trusty 14.04). Removing the quoting aligns with other case
statements in the script, and solves the problem. This bug
made https://codereview.chromium.org/2650823010 not have any
effect, which was discovered when deploying ARM 64 bots for
WebRTC.
BUG=684356,webrtc:7024
Review-Url: https://codereview.chromium.org/2790453002
Cr-Original-Commit-Position: refs/heads/master@{#460733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95504aea9818ec4e593358d0373f9c41531a3b67
2017-03-30 12:30:31 +00:00
krasin
a634e44492
(Really) disable gdb-index for LTO.
...
This is a follow up to https://codereview.chromium.org/2782483002 ,
where only official LTO builds had got gdb-index disabled.
BUG=660216
Review-Url: https://codereview.chromium.org/2786603003
Cr-Original-Commit-Position: refs/heads/master@{#460421}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95e4983f85e5afb97b37df59b5666b2f3d2949a1
2017-03-29 16:37:40 +00:00
wychen
133db8fa95
Add script fix_gn_headers.py to fix GN missing headers
...
The script is based on CLs authored by thakis@chromium.org:
- https://codereview.chromium.org/2770693003/
- https://codereview.chromium.org/2771373003/
BUG=661774
Review-Url: https://codereview.chromium.org/2781603003
Cr-Original-Commit-Position: refs/heads/master@{#460256}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b663358c89e05334e8cfff0f1f855fe4c72c192a
2017-03-29 01:06:58 +00:00
brucedawson
bd82dfa88e
New VS 2017 toolchain with dbghelp.dll fixes
...
This updates the package used when building Chrome with VS 2017 based
on the changes in https://chromium-review.googlesource.com/461385 .
This packages versions of dbghelp.dll that can handle VS 2017's
/debug:fastlink binaries without hanging. This avoids hangs in windbg
and in base_unittests, and elsewhere.
See this bug for details:
https://developercommunity.visualstudio.com/content/problem/36255/chromes-base-unittests-fails-with-vs-2017-due-to-s.html
R=scottmg@chromium.org
BUG=683729
Review-Url: https://codereview.chromium.org/2778323002
Cr-Original-Commit-Position: refs/heads/master@{#460236}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a01e98bf1f7cd1b9418698808ae83fca54fb626
2017-03-28 23:28:26 +00:00
drott
2715439e5a
Allow FreeType compilation and linkage from third_party on Windows
...
Create an OWNERS file for this directory and add myself as well. This is
preparation for using a shared FreeType between Blink and PDFium, but
not actually used as a depedency to any Windows targets yet.
BUG=700926
Review-Url: https://codereview.chromium.org/2781773003
Cr-Original-Commit-Position: refs/heads/master@{#460211}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e15f5107bfba9080481fd78ed35c69c81fc41ac3
2017-03-28 20:42:41 +00:00
thomasanderson
ee47daef90
install-build-deps: Remove support for EOL distros
...
This CL
* Removes support for Precise, Utopic, Vivid, and Wily.
* Precise is not really EOL, but Chrome no longer supports it.
* Fixes install-build-deps.sh on Yakkety.
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2774743002
Cr-Original-Commit-Position: refs/heads/master@{#460187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 05c4029f2ac708568f984a5ce4d75eabca12a915
2017-03-28 19:28:45 +00:00
mikecase
f7ef9cb43e
Add logging for logdog link to logcat.
...
Currently, logcats are very difficult to find in bot logs. Adding
logging to log the logdog links.
In the future, these links will get moved out of the python logs
and into the result detail HTML page.
Review-Url: https://codereview.chromium.org/2777103004
Cr-Original-Commit-Position: refs/heads/master@{#460151}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2753f4dd3d49fddb16c538feddb125c92cc0fe23
2017-03-28 17:22:37 +00:00
krasin
c66ea07ede
Use llvm-ar when building with Clang.
...
llvm-ar is faster and is capable of handling
LLVM bitcode files without a need for a Gold plugin.
BUG=660216,607968
Review-Url: https://codereview.chromium.org/2766333002
Cr-Original-Commit-Position: refs/heads/master@{#460129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8968cd5170f4a22b1c508ffa3bc240b346c44b1b
2017-03-28 16:46:15 +00:00
sdefresne
947f28d085
[ios] Add framework_dir flag to all_dependent_configs (-F).
...
When building a custom framework, the framework and the framework_dir
flags need to be added to the command-line of every linkable target
the depends directly or indirectly on it. GN propagates properly the
framework as it knows about "libs", but the -F flag added to ldflags
need to be propagated using all_dependent_configs.
BUG=704946
Review-Url: https://codereview.chromium.org/2778813002
Cr-Original-Commit-Position: refs/heads/master@{#460071}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5376139411f2b362d24abc27425f3827697a46d4
2017-03-28 12:44:55 +00:00
machenbach
a58c37fd20
Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #2 id:240001 of https://codereview.chromium.org/2776773002/ )
...
Reason for revert:
Breaks V8 perf testing:
http://crbug.com/705870
Original issue's description:
> Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772113002/ )
>
> Reason for revert:
> Relanding with fixed deps
>
> Original issue's description:
> > Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772503005/ )
> >
> > Reason for revert:
> > expected_deps_x64_jessie changes are causing a failure on the official builder
> >
> > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F16997%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
> >
> > Original issue's description:
> > > Reland of "Update linux sysroot from Wheezy to Jessie"
> > >
> > > The last version of this change was:
> > > https://codereview.chromium.org/2748183005
> > >
> > > Which was reverted in:
> > > https://codereview.chromium.org/2776503002
> > >
> > > I've updated the expected package deps again, this
> > > time being sure to use is_chrome_branded=true when
> > > testing (which oddly seems to effect the deps).
> > >
> > > TBR=thestig (since this is effectively a reland)
> > > BUG=701894
> > >
> > > Review-Url: https://codereview.chromium.org/2772503005
> > > Cr-Commit-Position: refs/heads/master@{#459492}
> > > Committed: 7f43e46a78
> >
> > TBR=thakis@chromium.org ,dpranke@chromium.org,thestig@chromium.org,sbc@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=701894
> >
> > Review-Url: https://codereview.chromium.org/2772113002
> > Cr-Commit-Position: refs/heads/master@{#459553}
> > Committed: f2296e4fca
>
> TBR=thakis@chromium.org ,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=701894
>
> Review-Url: https://codereview.chromium.org/2776773002
> Cr-Commit-Position: refs/heads/master@{#459584}
> Committed: b0d4ad8b38
TBR=thakis@chromium.org ,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=701894
Review-Url: https://codereview.chromium.org/2780763002
Cr-Original-Commit-Position: refs/heads/master@{#460070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 75a1434be05f2ef09c307f7b70713385232a5b84
2017-03-28 12:43:32 +00:00
Michael Achenbach
c559cf2546
Whitespace change to trigger more bots
...
Bug: 705891
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=dsansome@chromium.org
Change-Id: I531807bd0760726f811b67802af7e87229605c77
Reviewed-on: https://chromium-review.googlesource.com/461179
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#460043}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 40677416942bd3f8e184e6c59b10261cea0054b9
2017-03-28 09:04:23 +00:00
Michael Achenbach
4f17d44eec
Whitespace change to trigger bots
...
Bug: 705891
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=dsansome@chromium.org
Change-Id: I8a1df29b9a3252f50ec504baa675c70aa388e6e3
Reviewed-on: https://chromium-review.googlesource.com/461820
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#460042}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f67cfef3e420d140d949d10b47ea6c1ed8398642
2017-03-28 08:56:39 +00:00
satorux
5dd7ff3b70
Revert of Enable -Wdeprecated-register. (patchset #5 id:80001 of https://codereview.chromium.org/2780623003/ )
...
Reason for revert:
Broke os="chromeos" build: crbug.com/705812
Original issue's description:
> Enable -Wdeprecated-register.
>
> No behavior change.
>
> BUG=255186
>
> Review-Url: https://codereview.chromium.org/2780623003
> Cr-Commit-Position: refs/heads/master@{#459973}
> Committed: 76ad12fee7
TBR=dcheng@chromium.org ,rouslan@chromium.org,kbr@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=255186
Review-Url: https://codereview.chromium.org/2778053003
Cr-Original-Commit-Position: refs/heads/master@{#459989}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9a94c24489a558b43f6938e86d6c4e69cc52afb
2017-03-28 02:29:37 +00:00
thakis
30d5728d7f
Enable -Wdeprecated-register.
...
No behavior change.
BUG=255186
Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Commit-Position: refs/heads/master@{#459973}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 76ad12fee73e4512dbb9c7a79ffb6cec33fae6f2
2017-03-28 01:35:35 +00:00
brucedawson
9f91eb223d
Remove VS 2013 from vs_toolchain.py
...
Chrome has not built with VS 2013 for a while now, so no need to carry
that baggage around as we add VS 2017 support.
Review-Url: https://codereview.chromium.org/2771333002
Cr-Original-Commit-Position: refs/heads/master@{#459876}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e7c0d998d5416b380ffefe1f6acd6126e35d11ed
2017-03-27 20:59:15 +00:00
Nico Weber
9a841b4a32
Disable -Wl,--gdb-index with LTO.
...
Follow-up to https://codereview.chromium.org/2770933009/
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F17053%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
[1695/31073] LINK ./tls_edit
FAILED: tls_edit tls_edit.map.gz
python "../../build/toolchain/gcc_link_wrapper.py" --output="./tls_edit" --map-file "./tls_edit.map.gz" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -Wl,--icf=all -flto -fwhole-program-vtables -Wl,-plugin-opt,O1 -Wl,-plugin-opt,-function-sections -m64 -pthread -Werror -Wl,-O1 -Wl,--gc-sections -Wl,--gdb-index --sysroot=../../build/linux/debian_jessie_amd64-sysroot -L/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/lib/x86_64-linux-gnu -L/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu -L/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -Wl,-rpath-link=/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -L/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib -Wl,-rpath-link=/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib -fsanitize=cfi-vcall -Wl,-rpath-link=. -Wl,--disable-new-dtags -o "./tls_edit" -Wl,--start-group @"./tls_edit.rsp" -Wl,--end-group -ldl -lrt
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info
BUG=none
TBR=krasin
Review-Url: https://codereview.chromium.org/2782483002 .
Cr-Original-Commit-Position: refs/heads/master@{#459866}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d9dbcf9e54cef6adb8f50288a6d907004cbfeb88
2017-03-27 20:23:00 +00:00