The iOS port no longer uses //content (hooray!). This CL starts the
unwinding of references to iOS in //content by removing most references
in gypfiles. Note that after this CL dependencies on the content_browser
or content_common target will cause a gyp_chromium failure on iOS. This "fail
fast" behavior is good since new dependencies on //content on iOS are wrong.
Review URL: https://codereview.chromium.org/1710043002
Cr-Original-Commit-Position: refs/heads/master@{#376494}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e5ecd0f07adc12ac233d15a608d6bd3af569b2e4
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1469383005
Cr-Original-Commit-Position: refs/heads/master@{#361854}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 06c2ba3165d8b02364bf818d5028a7cb4fe48ac0
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1458653002/TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1475513006
Cr-Original-Commit-Position: refs/heads/master@{#361741}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cbc1cd295bc85219ad89326457cd7f5cf003d41c
Reason for revert:
This seems to have broken webkit builders: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/94668
Original issue's description:
> New build flag system, convert Google Now flag
>
> This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
>
> Converts Google Now to use this and remove the global google now define and grit define.
>
> Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
>
> Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
>
> Committed: https://crrev.com/3118dde528359280fa0cb3c6fc5b6323e834c514
> Cr-Commit-Position: refs/heads/master@{#361527}
TBR=mark@chromium.org,spang@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1475883002
Cr-Original-Commit-Position: refs/heads/master@{#361541}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4496a9a4563bf34e624261f7dcc5f1180282ff86
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Review URL: https://codereview.chromium.org/1458653002
Cr-Original-Commit-Position: refs/heads/master@{#361527}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3118dde528359280fa0cb3c6fc5b6323e834c514
- This strips conditions inside a variables in addition to the toplevel conditions.
- Removes percent signs from the ends of variable names.
Both of these are required to import some of the Blink .gypis.
Make net forward the crypto config. This appears to be necessary to use net's public API.
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/305013009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274302 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a skeleton build file for content/common that lists the basic deps, and processes the sources. This can keep track of the deps that have been converted and allows easy testing of the .gypi reading.
Changes content_common.gypi to separate out the public and private sources. The .gypi combines them both into the 'sources' so current users of this file should not be affected. This allows the GN build to declare the public API.
Enhance the gypi-to-gn script to strip conditions and collapse variables to allow the content .gypis to be read in.
Adds some simple BUILD.gn files for dependencies of content/common
Fix typo in accessibility.gyp that I discovered when writing the GN build.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/287233002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271767 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds support for a new value type, a dictionary. To script it looks the same as a scope, but the existing scope didn't have the right memory management semantics for this.
Adds a new input conversion mode to interpret the result of a script as a GN block (basically an eval) and get the result in a dictionary. This allows returning named sets of things from a script. Updates the accessor and defined stuff to work with this new type.
Adds some features to the input file manager so that when we do dynamic reading from a script we keep the text of the read around which means we can give proper errors that refer to the script output, and don't have to do the weird recursive set origin thing to clear out the pointers that became invalid when the InputFile went out of scope.
This allows us to give better error messages when parsing input. The error handling in the input conversion code is changed accordingly.
Checks for unused variables both in code that instantiates a template, and in the template code itself.
Adds a shared python script for outputting values from Python to GN.
Adds a python script to read .gypi files and return the value as a GN scope.
BUG=
R=dpranke@chromium.org, scottmg@chromium.org
Review URL: https://codereview.chromium.org/223783005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262045 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
brettw
blundell
raymes
brettw@chromium.org