With the component build, we tell Dalvik to load each library separately by name. Some of our library names conflict with android shared libraries resulting our library not getting loaded. When building for components on Android, change the suffix of libraries to "cr.so" e.g. libnetcr.so to avoid colliding with Android's copies
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/13549002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@192258 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
For the component build, it is impractical/impossible to explicitly
list all library dependencies. This list is required (in dependency
order) for several of the apk-building steps.
For now, we will generate this list as follows:
Use readelf to find all transitive dependencies
Topologically sort those dependencies
Once we can expose this information from gyp
(http://crbug.com/2255588), it is straightforward to update this action
to use the gyp-exposed list of libraries.
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/13261024
git-svn-id: http://src.chromium.org/svn/trunk/src/build@192103 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a gyp variable "android_managed_install" which defaults to off/0.
When this variable is 1, building an apk target will install that
target.
This will allow us to do crazy things with the install like pushing
native libraries independent from the apk they belong to.
This currently just does an "adb install -r <(apk_path)". I.e. it only
works for (the typical) single device attached workflow. This could
be made configurable to handle other cases (or maybe just install to all
devices attached, or just to the first device).
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/13269002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191840 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
BUG=159240,92909
Committed: r186925
Reverted: r186939 due to build errors
Committed: r187340
Committed: r187427
Reverted: r187668 due to a failing check in Canary, which was fixed here: r187681
Committed: r189518
Reverted: r189682, due to regression in Kraken (see crbug.com/222741)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191420
Reverted: r191441, due to new failing PDFResource unit test.
Review URL: https://chromiumcodereview.appspot.com/12378050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191510 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> PPAPI: Remove threading options; it's always on
>
> This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
>
> BUG=159240,92909
>
>
> Committed: r186925
> Reverted: r186939 due to build errors
>
> Committed: r187340
>
> Committed: r187427
> Reverted: r187668 due to a failing check in Canary, which was fixed here: r187681
>
> Committed: r189518
> Reverted: r189682, due to regression in Kraken (see crbug.com/222741)
>
> Review URL: https://chromiumcodereview.appspot.com/12378050TBR=dmichael@chromium.org
Review URL: https://codereview.chromium.org/13328006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191441 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
BUG=159240,92909
Committed: r186925
Reverted: r186939 due to build errors
Committed: r187340
Committed: r187427
Reverted: r187668 due to a failing check in Canary, which was fixed here: r187681
Committed: r189518
Reverted: r189682, due to regression in Kraken (see crbug.com/222741)
Review URL: https://chromiumcodereview.appspot.com/12378050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191420 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This enables Android layouts and Java code to use strings from
generated_resources.grd directly. Strings tagged with
formatter_data="android_java" in generated_resources.grd are used to produce an
Android strings xml file.
BUG=176069
Review URL: https://chromiumcodereview.appspot.com/12529025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190573 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The action will copy the ASan dynamic runtime to the output dir and into every
bundled executable being built.
Unlike the previous change, this one does not touch build/all.gyp, since our target
doesn't need to be built when building 'All'.
BUG=170629
TBR=thakis,mark
Review URL: https://codereview.chromium.org/12685006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187566 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Rename the "android_build_type" gyp variable to "android_webview_build"
to better describe what it does. There are still references in WebKit
and V8 that need to be changed before the original variable can be
removed.
BUG=184431
Review URL: https://codereview.chromium.org/12730006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187556 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is needed to fix a linking error on Ubuntu Precise:
/usr/bin/ld: out/Debug/obj.target/sync/libsync.so: undefined reference to symbol 'SSL_ExportKeyingMaterial'
/usr/bin/ld: note: 'SSL_ExportKeyingMaterial' is defined in DSO out/Debug/obj.target/net/third_party/nss/libcrssl.so so try adding it to the linker command line
out/Debug/obj.target/net/third_party/nss/libcrssl.so: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make: *** [out/Debug/unit_tests] Error 1
TBR=thestig
BUG=170262
Review URL: https://codereview.chromium.org/12633012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187181 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Files.app's ui used to be unresponsive, when displaying large images. This was caused because of contex.drawImage() synchronous
call on the UI thread, which takes sometimes even 300 ms per one picture. In case of loading more images it causes ui freezes.
This patch solves this issue by introducing an image loader extension, which loads and resizes images asynchronously.
With this fix, we will be able to enable mosaic view on each volume, not only on Drive.
TEST=Check thumbnails in Files.app, including photo importer and gallery.
BUG=175697, 176237, 168035
Review URL: https://chromiumcodereview.appspot.com/12304013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184088 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Summary of try run with flag enabled as warning:
On linux_clang, there's false positives from a bunch of assert usage that does !"string" or "string" for a true or false value. It's only in third_party (Mesa, skia, libjingle, etc.) so it probably wouldn't be too hard to disable the warnings in those subtrees.
It diagnoses 4 useful locations:
1.
../../base/debug/trace_event_unittest.cc:70:41: warning: implicit conversion turns string literal into bool: 'const char [2]' to 'bool' [-Wstring-conversion]
TraceLog::GetInstance()->SetEnabled("*");
~~~~~~~~ ^~~
2.
../../sync/syncable/entry_kernel.cc:77:38: warning: implicit conversion turns string literal into bool: 'const char [5]' to 'bool' [-Wstring-conversion]
value->SetBoolean("encrypted", "true");
~~~~~ ^~~~~~
3.
../../chrome/browser/webdata/web_data_service.cc:334:17: warning: implicit conversion turns string literal into bool: 'const char [44]' to 'bool' [-Wstring-conversion]
DLOG_ASSERT("WebDataService dtor called without Shutdown");
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:595:43: note: expanded from macro 'DLOG_ASSERT'
4.
../../chrome/browser/renderer_host/web_cache_manager_unittest.cc:259:20: warning: implicit conversion turns string literal into bool: 'const char [29]' to 'bool' [-Wstring-conversion]
EXPECT_FALSE("Unexpected entry in strategy");
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Finding #1 is what made me look into this, #3 and #4 are not doing what they're supposed to, and #2 is kind of funny so not all is lost.
So, 3 bugs and 1 very-close-to-a-bug: seems worth enabling.
R=thakis@chromium.orgTBR=darin@chromium.org, dhollowa@chromium.org, brettw@chromium.org, zea@chromium.org
BUG=177306
Review URL: https://chromiumcodereview.appspot.com/12258039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183998 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Do not regenerate JNI files (and subsequently the .so file) if they have
not changed. This will happen if you edit a java file that has a native
counterpart, but the native signatures were not touched.
We do not enable this all the time as some build systems require that
when you modify an input, the output should also be modified. This
also will result in more command line output, so we'll keep it behind
a developer flag for now.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12314025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183936 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It turns out that r181918, which pinned the Clang revision on Mac ASan
bots worked a little too well, pinning the version on *all* Mac bots.
This reverts the Clang roll. We will then fix update.sh to get the Mac
ASan pinning correct, and then re-land the roll.
BUG=174873, 170629
Review URL: https://codereview.chromium.org/12256002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@182173 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
As of Clang r174490 instrumented binaries do not include the __asan_* symbols,
so the postbuild strip action fails.
This is a temporary measure, we may need to do something else (e.g. use different .saves files) when the dynamic runtime is adopted on OSX.
BUG=170629,174873
Review URL: https://codereview.chromium.org/12210114
git-svn-id: http://src.chromium.org/svn/trunk/src/build@181733 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The Chrome OS builds already use -fstack-protector-strong. Adding
additional -fstack-protector arguments means that the last one seen on the
commandline is used. This has caused a regression in the stack-protector
features, so avoid stack-protector on Chrome OS.
BUG=chromium-os:38354
TEST=link build
Review URL: https://chromiumcodereview.appspot.com/12095046
git-svn-id: http://src.chromium.org/svn/trunk/src/build@180088 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
After https://chromiumcodereview.appspot.com/10407058 we can compile
breakpad by default and still have it disabled for non-official builds.
Changes the Android build to allow compiling breakpad but not use
it by not creating the crash fd and not passing it to the renderer
process unless breakpad is enabled.
Changes linux and Android to use a switch for enabling breakpad
since that's a lot easier to test with on android then an environment
variable.
BUG=105778,170530
Review URL: https://chromiumcodereview.appspot.com/11969025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@178111 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This removes unneeded gyp defines from envsetup. I still left the environment variables because some scripts (e.g. findbugs) still depend on them. I'll remove those usages and the environment variables separately.
Review URL: https://codereview.chromium.org/11886053
git-svn-id: http://src.chromium.org/svn/trunk/src/build@177169 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This brings the Linux build into line with the Windows and Mac builds,
where Breakpad is compiled in by default. This allows us to test
Breakpad on the trybots and buildbots.
It's still possible to omit Breakpad support using a Gyp option.
As with Windows and Mac, we don't want to enable Breakpad in Chromium
at run time by default (since that would spam the crash server, which
doesn't have symbols for Chromium builds anyway), so we put this
behind a run time flag. We also don't compile in debug info (-g) by
default.
We extend NaCl's Breakpad tests to be able to locate crash dumps on
Linux.
We add some "#ifdef GOOGLE_CHROME_BUILD"s to prevent Breakpad from
being enabled accidentally without the run time flag, but this is just
in case because there should be no GUI option for enabling stats/crash
reporting inside non-Chrome Chromium builds.
BUG=105778
TEST=breakpad_browser_process_crash_test in nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10407058
git-svn-id: http://src.chromium.org/svn/trunk/src/build@176911 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This should not affect upstream build configuration. This should only
affect build when building as part of the Android System build.
Disabling since we do not yet merge the necessary third_party
repositories so it is breaking downstream build.
dcommitted after all the bots have passed compile
BUG=161417
TBR=wjia@chromium.org
Review URL: https://codereview.chromium.org/11884010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@176518 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Moves ui/app_list code specific to toolkit-views to ui/app_list/views.
Update gyp[i], include guards, #includes for moved files.
Seed chrome/browser/ui/cocoa/app_list and ui/app_list/cocoa with a
skeleton Cocoa UI.
BUG=138633
TEST=Mostly build changes. Functionality of AppLauncher on ChromeOS
and Windows should be unchanged.
On OSX, without chrome running, `Chromium.app/Contents/MacOS/Chromium --show-app-list`
should show a borderless gray window for 1 second (note: this is for
testing only -- OSX needs a different approach for IPC).
Review URL: https://chromiumcodereview.appspot.com/11784034
git-svn-id: http://src.chromium.org/svn/trunk/src/build@176042 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
By default, fake .dSYM files
will be generated for regular builds, and dsymutils will be used to create .dSYMs for ASan builds.
mac_want_real_dsym can be used to override this.
mac_real_dsym can't be set directly, because it's not a % variable.
According to https://codereview.chromium.org/113999, it can't be made a
% variable now, because of a bug in % handling in GYP that leads to
mac_real_dsym being unconditionally set to 1 for some targets.
BUG=148383
TBR=thakis
Review URL: https://codereview.chromium.org/11636014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@173896 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
will be generated for regular builds, and dsymutils will be used to create .dSYMs for ASan builds.
mac_want_real_dsym can be used to override this.
mac_real_dsym can't be set directly, because it's not a % variable.
According to https://codereview.chromium.org/113999, it can't be made a
% variable now, because of a bug in % handling in GYP that leads to
mac_real_dsym being unconditionally set to 1 for some targets.
BUG=148383
Review URL: https://chromiumcodereview.appspot.com/11587012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@173749 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Previously many custom GYP_DEFINES were needed to get a
chrome build for linux/arm. This adds these as sensible
defaults. This allows chrome for arm to be built with
with only target_arch=arm set in GYP_DEFINES.
In order to set a default sysroot based on target_arch
this change also defines target_arch one level deeper
in common.gypi.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11465030
git-svn-id: http://src.chromium.org/svn/trunk/src/build@172377 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Previous attempt; expanded since then:
https://chromiumcodereview.appspot.com/10332156/
* The search string has "sourceid=chrome-mobile" on Android devices.
* SearchTermsDataAndroid added to handle the data values that Android
needs to store for RLZ tracking.
* UiThreadSearchTermsData calls Android specific functions when being
asked for rlz= or client= strings.
* ENABLE_RLZ is moved around (or removed) in some cases to allow use of
the fields even when the RLZ library is not in use.
* The RLZ unit test is changed to account for the way Android sets the
RLZ string.
* A new SearchClient unit test is added to check that setting client
strings works.
BUG=145065
Review URL: https://chromiumcodereview.appspot.com/11448005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@171954 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
to catch memory problems early, easily, and cleanly.
This is disabled by default.
Because of gyp limitations, the flag is to force-disable the feature, but there is no flag to force-enable it.
BUG=30715
TEST=none
Review URL: https://codereview.chromium.org/11266019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@171063 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently if you set profiling=1 content_shell will load,
it will just load to a white screen (and attempts to sample
the binary with perf will not get proper stacks).
This adds -mapcs and -marm per the AndroidPerf wiki docs.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11316228
git-svn-id: http://src.chromium.org/svn/trunk/src/build@170249 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is used for normal builds to strip out lots of unneeded symbols and
minimize binary size. However, for shared library build, this causes
needed symbols to be excluded and subsequent so's to fail linking.
BUG=158821
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11413110
git-svn-id: http://src.chromium.org/svn/trunk/src/build@169060 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The new naming scheme simply appends .pdb to the target (e.g. foo.dll.pdb and
foo.exe.pdb). This is beneficial for a couple reasons:
* no more chrome_dll.pdb and chrome_exe.pdb silliness
* also avoids this issue if we end up with similarly named targets in the
future (target.dll and target.exe)
* ninja already does this, and, by extension, either ninja needs to be broken
to use the old scheme, or the we fix the broken in the existing system.
One less difference between msvs and ninja.
Fixes for chrome-internal stuff: https://chromereviews.googleplex.com/5681015
BUG=
Review URL: https://codereview.chromium.org/11384003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168341 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change decouples the logic that associates the app launcher and
settings app with windows-only builds, and consolidates the list of
app_list sources in chrome_browser_ui.gypi.
BUG=160839
TEST=on Windows: compiles with -Denable_app_list=0 (with no app launcher function), and
on Windows: compiles with -Denable_settings_app=0 (with app launcher but no settings app in it)
on ChromeOS: compiles (functional ChromeOS launcher)
Review URL: https://chromiumcodereview.appspot.com/11293267
git-svn-id: http://src.chromium.org/svn/trunk/src/build@167853 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Seems like a clobber might be enough to fix the issues caused by this CL.
Reverted because it is assumed to be the cause for multiple compile failures on mac and linux.
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020TBR=pastarmovj@google.com
Review URL: https://codereview.chromium.org/11377023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166405 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reverted because it is assumed to be the cause for multiple compile failures on mac and linux.
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166369 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166365 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is not yet used, but helps lay the groundwork for building chrome/
targets for iOS.
This uses exclude-all-and-include since Chrome for iOS uses only a subset
of chrome/browser/, so the include list will be much more manageable and
maintainable than an exclude list.
BUG=156699
Review URL: https://chromiumcodereview.appspot.com/11361056
git-svn-id: http://src.chromium.org/svn/trunk/src/build@165802 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This doesn't work yet without upstream protobuf changes,
but with this infrastructure in place it's going to be
easier to test further updates.
Google Chrome will of course use the bundled version,
there's no change here.
BUG=157155
TEST=none
Review URL: https://codereview.chromium.org/11231046
git-svn-id: http://src.chromium.org/svn/trunk/src/build@165257 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is not yet used, but helps lay the groundwork for building chrome/
targets for iOS.
This uses exclude-all-and-include since Chrome for iOS uses only a very
small portion of chrome/browser/ui/, so the include list will be much more
manageable and maintainable than an exclude list.
BUG=156699
Review URL: https://chromiumcodereview.appspot.com/11339010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@164908 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The intention is to allow to build iOS Chrome/tests with asan=1, which is only possible with a custom Clang at the moment.
The resulting binaries can't be shipped to users, but can be used to debug memory corruptions.
Review URL: https://codereview.chromium.org/11273012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@164619 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This centralizes this definition and removes it from the various places it is currently replicated. This also allows external projects that rely on Chromium base to compile successfully, as otherwise this (required) definition is missing.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11190060
git-svn-id: http://src.chromium.org/svn/trunk/src/build@163299 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
SDK to verify when an SDK path is set. The SDK path supersedes whatever
find_sdk is supposed to find.
Also: Reorganize the SDK and deployment target variables to be scoped more
appropriately. Add a mac_sdk_min variable to set the main argument to
find_sdk.
Review URL: https://chromiumcodereview.appspot.com/11068023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@160536 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The envsetup configuration for building WebView using the Android build
system has rotted. Rather than try to share the non_sdk_build_init code,
just repeat the (few) parts we need to avoid setting all the parts that
are inappropriate, and fix the parts that are wrong or outdated.
Also, upstream the common.gypi settings that are specific to the WebView
build.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11026038
git-svn-id: http://src.chromium.org/svn/trunk/src/build@160188 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It stores mapping between object's starting addresses and their
allocated types when a build option 'clang_type_profiler=1' is
specified. It enables information like
"an object at 0x37f3c88 is an instance of std::string."
Nothing is changed when the option is not specified.
It depends on a modified version of the LLVM/Clang compiler
introduced at deps/third_party/llvm-allocated-type.
BUG=123758
TEST=build with clang_type_profiler=1 and run type_profiler_unittests and type_profiler_map_unittests manually.
Review URL: https://chromiumcodereview.appspot.com/10411047
git-svn-id: http://src.chromium.org/svn/trunk/src/build@158752 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If the DoneCallback returns false, breakpad should reinstall the old
signal handlers. Specifically, it will reinstall the Android tombstone
handler. This change ensure that on Android we always return false from
these callbacks. When this happens, the minidump should still be
created/uploaded as normal.
Also, just prior to returning we log a Chrome build fingerprint. This
should appear in the log just above the tombstone.
Requires breakpad DEPS roll to >=1025
(http://breakpad.appspot.com/440002/) to work correctly, but fails
safely without it.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10908115
git-svn-id: http://src.chromium.org/svn/trunk/src/build@156063 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Restructures content_app.gypi, content_common.gypi, and content_tests.gypi
slightly to support building them for iOS.
One target, content_browsertests, is excluded entirely for iOS.
More files will be added to the iOS build later, once the content/ build
is working for iOS.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10917130
git-svn-id: http://src.chromium.org/svn/trunk/src/build@155759 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1474: Emacs mode for gyp: font-lock edition.
1475: Tidy up default toolset for msbuild-based builds.
1476: add -Gstandalone flag
1477: Enable pretty xml generation.
1478: msvs: Ensure trailing slash on IntermediateDir and OutputDir.
1479: mac ninja&make: Pass OTHER_LDFLAGS to libtool for static libraries.
Also don't pass -faddress-sanitizer to libtool.
BUG=113085
Review URL: https://chromiumcodereview.appspot.com/10876059
git-svn-id: http://src.chromium.org/svn/trunk/src/build@153250 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Is causing warnings for Official build in PDF code. Boo.
-----------------
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429TBR=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10872063
git-svn-id: http://src.chromium.org/svn/trunk/src/build@153223 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429
git-svn-id: http://src.chromium.org/svn/trunk/src/build@153092 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
without this CL
fastbuild=1 => no debug information
win_z7=1 => debug information available (with /Z7)
fastbuild=1 win_z7 => *.obj has debug info, but linker doesn't generate debug info in *.exe. it would be useless, and just makes build slower
This CL makes win_z7 wins against fastbuild.
R=scottmg,arthurhsu
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10866016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@152953 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The enable_themes and enable_extensions gyp variables were in a different
scope that prevented the grit_defines from having the correct value when
evaluating the condition. Moves the variable assignment into the same
scope as the variable declaration and now everything is happy.
TEST=touch chrome/browser/browser_resources.grd && \
make chrome_resources (check about_version does not have theme icon)
BUG=
Review URL: https://chromiumcodereview.appspot.com/10828396
git-svn-id: http://src.chromium.org/svn/trunk/src/build@152455 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
glider@chromium.org
mostynb@opera.com
cjhopman@chromium.org
csharp@chromium.org
maruel@chromium.org
rjkroege@chromium.org
yfriedman@chromium.org
phajdan.jr@chromium.org
dmichael@chromium.org
rlarocque@chromium.org
shouqun.liu@intel.com
thakis@chromium.org
ygorshenin@chromium.org
thestig@chromium.org
newt@chromium.org
rtoy@google.com
wjia@chromium.org
torne@chromium.org
jeanfrancoisg@google.com
sbc@chromium.org
rsesek@chromium.org
karen@chromium.org
benm@google.com
petarj@mips.com
aberent@google.com
jvoung@chromium.org
leozwang@chromium.org
bartfab@chromium.org
teravest@chromium.org
scottmg@chromium.org
eugenis@chromium.org
siggi@chromium.org
wfh@chromium.org
jschuh@chromium.org
mtomasz@chromium.org
aruslan@chromium.org
tedchoc@chromium.org
bengr@chromium.org
shashishekhar@chromium.org
miguelg@chromium.org
tfarina@chromium.org
isherman@chromium.org
hans@chromium.org
chrisha@chromium.org
jwd@chromium.org
sky@chromium.org
keescook@google.com
kjyoun@google.com
vadimt@chromium.org
mark@chromium.org
nona@chromium.org
jcivelli@chromium.org
wtc@chromium.org
dmikurube@chromium.org
iannucci@chromium.org
bauerb@chromium.org
mseaborn@chromium.org
apatrick@chromium.org
boliu@chromium.org
tapted@chromium.org
dewittj@chromium.org
kristianm@chromium.org
glider@google.com
qsr@chromium.org
benwells@chromium.org
ivankr@chromium.org
sebmarchand@chromium.org
fischman@chromium.org
dfalcantara@chromium.org
danakj@chromium.org
nileshagrawal@chromium.org
erikwright@chromium.org
felipeg@chromium.org
sgurun@chromium.org
eseidel@chromium.org
mirandac@chromium.org
scottmg@google.com
brettw@chromium.org
pastarmovj@google.com
ilevy@chromium.org
blundell@chromium.org
stuartmorgan@chromium.org
hbono@chromium.org
michaelbai@chromium.org
zhaoqin@google.com
alexeypa@chromium.org
jamesr@chromium.org
pkl@chromium.org
michaelbai@google.com
glotov@chromium.org
saintlou@chromium.org
msarda@chromium.org
mihaip@chromium.org
tony@chromium.org
joi@chromium.org
droger@chromium.org
xhwang@chromium.org
ukai@chromium.org
wangxianzhu@chromium.org